Re: [PHP-DEV] leaks related with virtual_file_ex()

2006-09-17 Thread Ilia Alshanetsky
On 17-Sep-06, at 8:03 AM, Nuno Lopes wrote: OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt There might be other issues with virtual_file_ex() that I haven't fully tested. Can you not simply add the free before

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Pierre
Hello, On 9/17/06, Ilia Alshanetsky <[EMAIL PROTECTED]> wrote: On 17-Sep-06, at 12:05 PM, Michael Wallner wrote: > Ilia Alshanetsky wrote: > >> These looks good. The only other suggestion is to explore the >> option of >> renaming filter_get_args() to filter_get_variable() so it is a bit >> mo

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Ilia Alshanetsky
On 17-Sep-06, at 12:05 PM, Michael Wallner wrote: Ilia Alshanetsky wrote: These looks good. The only other suggestion is to explore the option of renaming filter_get_args() to filter_get_variable() so it is a bit more consistent with filter_has_variable(). What about filter_get_var() an

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Michael Wallner
Ilia Alshanetsky wrote: > These looks good. The only other suggestion is to explore the option of > renaming filter_get_args() to filter_get_variable() so it is a bit more > consistent with filter_has_variable(). What about filter_get_var() and filter_has_var()? -- Michael -- PHP Internals -

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Ilia Alshanetsky
On 16-Sep-06, at 9:27 PM, Pierre wrote: Hello, On 9/17/06, Andi Gutmans <[EMAIL PROTECTED]> wrote: Yep I agree. I thought the idea was to go to filter_* which has been our standard for extensions. I'm sure we can find good names for the functions in this way. old name > new name: input_g

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Dan Scott
On 16/09/06, Pierre <[EMAIL PROTECTED]> wrote: Hello, On 9/17/06, Andi Gutmans <[EMAIL PROTECTED]> wrote: > Yep I agree. I thought the idea was to go to filter_* which has been our > standard for extensions. > I'm sure we can find good names for the functions in this way. old name > new name:

Re: [PHP-DEV] leaks related with virtual_file_ex()

2006-09-17 Thread Nuno Lopes
OK, first patch to fix the 'tests/lang/bug35176.phpt' specific problem: http://mega.ist.utl.pt/~ncpl/zend_include_memleak.txt There might be other issues with virtual_file_ex() that I haven't fully tested. Nuno - Original Message - From: "Nuno Lopes" <[EMAIL PROTECTED]> To: "PHPdev"

Re: [PHP-DEV] ext/filter, Final API proposal

2006-09-17 Thread Zeev Suraski
At 04:27 17/09/2006, Pierre wrote: Hello, On 9/17/06, Andi Gutmans <[EMAIL PROTECTED]> wrote: Yep I agree. I thought the idea was to go to filter_* which has been our standard for extensions. I'm sure we can find good names for the functions in this way. old name > new name: input_get