RE: [PHP-DEV] Inconsistency between FETCH_DIM_IS and FETCH_OBJ_IS

2006-07-05 Thread Andi Gutmans
Looks good to me. Thanks! > -Original Message- > From: Sara Golemon [mailto:[EMAIL PROTECTED] > Sent: Wednesday, July 05, 2006 2:00 PM > To: internals@lists.php.net > Subject: [PHP-DEV] Inconsistency between FETCH_DIM_IS and FETCH_OBJ_IS > > When executing ZEND_FETCH_OBJ_IS on a non-obj

Re: [PHP-DEV] Inconsistency between FETCH_DIM_IS and FETCH_OBJ_IS

2006-07-05 Thread Marcus Boerger
Hello Sara, nice catch, fix looks pretty correct to me best regards marcus Wednesday, July 5, 2006, 10:59:35 PM, you wrote: > When executing ZEND_FETCH_OBJ_IS on a non-object, the handler dispatches > to zend_fetch_property_address_read_helper with type==BP_VAR_IS and ends > up generating an

[PHP-DEV] Inconsistency between FETCH_DIM_IS and FETCH_OBJ_IS

2006-07-05 Thread Sara Golemon
When executing ZEND_FETCH_OBJ_IS on a non-object, the handler dispatches to zend_fetch_property_address_read_helper with type==BP_VAR_IS and ends up generating an error (isset() is supposed to be quiet) here: if (Z_TYPE_P(container) != IS_OBJECT || !Z_OBJ_HT_P(container)->read_property) {

[PHP-DEV] Re: Making changes to PG() (php_core_globals)

2006-07-05 Thread Gwynne
On Jul 5, 2006, at 11:17 AM, Sara Golemon wrote: Did you run `make clean` between making the change and running the build? Files containing PG(track_changes) aren't the only ones you need to change, every PG element past track_changes is now located at a different memory offset from the st

Re: [PHP-DEV] [PATCH] FILE UPLOAD HOOKs

2006-07-05 Thread Stefan Esser
Hey, > Are you going to adjust it for HEAD as well? Yes, but I first put it into 5.2 and test it. Stefan -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: Making changes to PG() (php_core_globals)

2006-07-05 Thread Sara Golemon
Did you run `make clean` between making the change and running the build? Files containing PG(track_changes) aren't the only ones you need to change, every PG element past track_changes is now located at a different memory offset from the start of the structure. And if you happen to be running

[PHP-DEV] Making changes to PG() (php_core_globals)

2006-07-05 Thread Gwynne
The subject line gives a pretty good idea what this question is about. Yes, I'm well aware of the dangers of making core changes, and I'm only doing it to give myself a better idea what's going on inside :). In any case, here's the problem... One of the changes I tried to make is changing t

Re: [PHP-DEV] Building three SAPIs in one go

2006-07-05 Thread Gwynne
On Jul 5, 2006, at 6:10 AM, Michael Wallner wrote: The patch basically adds CGI to the SAPIs that can be built in one go, so we can build CLI, CGI and the Apache SAPIs all in one go. Ilia et al, anything against integrating this into 5_2? I'm not Ilia or any of the others with control over th

Re: [PHP-DEV] Building three SAPIs in one go

2006-07-05 Thread Michael Wallner
Luca Longinotti wrote: Sebastian Bergmann wrote: Michael Wallner wrote: That's interesting. What happens on `make install`? Does it have separate install commands per SAPI? I will ask Luca, the maintainer of this patch. The patch basically adds CGI to the SAPIs that can be built in one

Re: [PHP-DEV] [PATCH] array_fill: Allow an array to specify keys

2006-07-05 Thread Matt W
Hi Marcus, Thanks for the info. I'm sending along the patch for 5.2 now, since I didn't know whether to wait until the MAIN patch was agreed to (that's what I got from your message), or if you wanted both first. :-) I didn't realize tests were needed for every function, change, etc. (being new a

[PHP-DEV] PHP 4.4.3RC2

2006-07-05 Thread Derick Rethans
Hello! I packed PHP 4.4.3RC2 today, which you can find here: http://downloads.php.net/derick/ Please test it carefully, and report any bugs in the bug system, but only if you have a short reproducable test case. If everything goes well, we can release it somewhere in the second half of this mo