Re: [PHP-DEV] Beta 2 Take Infinity

2005-06-22 Thread Andi Gutmans
Thanks. Will bump the copyright years in HEAD. At 01:02 AM 6/23/2005 -0400, Sean Coates wrote: Andi Gutmans wrote: Please check http://snaps.php.net/~andi/ Try not to find show stoppers unless they format your hard drive :) Will post public tomorrow... Andi Number of tests : 1912

Re: [PHP-DEV] Beta 2 Take Infinity

2005-06-22 Thread Sean Coates
Andi Gutmans wrote: Please check http://snaps.php.net/~andi/ Try not to find show stoppers unless they format your hard drive :) Will post public tomorrow... Andi Number of tests : 1912 1422 Tests skipped : 490 ( 25.6%) Tests warned:0 ( 0.0%) ( 0.0%) Tests fa

[PHP-DEV] Beta 2 Take Infinity

2005-06-22 Thread Andi Gutmans
Please check http://snaps.php.net/~andi/ Try not to find show stoppers unless they format your hard drive :) Will post public tomorrow... Andi -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

[PHP-DEV] Re: [PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

2005-06-22 Thread Andi Gutmans
I suggest to leave this out of Beta 2 and I'd like to hear feedback from others here as to this patch. Andi At 01:28 AM 6/23/2005 +0400, Antony Dovgal wrote: Hello all, hello Andi. Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983 It adds OnUp

Re: [PHP-DEV] httpOnly Cookies [tiny enhancement]

2005-06-22 Thread Jochen Hansper
Hello Marcus, patches for official php-4.3.11 release in attachment... (diff -Naur) Jochen [php_session.h.patch; session.c.patch] Am Donnerstag, den 23.06.2005, 02:15 +0200 schrieb Marcus Boerger: > Hello Jochen, > > please resend your patch as unified patch (cvs di -u). > > marcus > > T

Re: [PHP-DEV] httpOnly Cookies [tiny enhancement]

2005-06-22 Thread Matt W
Hi, I'm sorry, I didn't even see that this is for sessions! :-/ Nevermind... Matt - Original Message - From: "Matt W" <[EMAIL PROTECTED]> Sent: Wednesday, June 22, 2005 7:36 PM Subject: Re: [PHP-DEV] httpOnly Cookies [tiny enhancement] > Hi, > > Supporting the httpOnly thing is good

Re: [PHP-DEV] httpOnly Cookies [tiny enhancement]

2005-06-22 Thread Matt W
Hi, Supporting the httpOnly thing is good, but is a php.ini setting better than another setcookie() parameter? I thought that's how it would be implemented... Well, I guess we can use ini_set(). Matt - Original Message - From: "Jochen Hansper" <[EMAIL PROTECTED]> Sent: Wednesday, Jun

Re: [PHP-DEV] [PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

2005-06-22 Thread Ilia Alshanetsky
Tony, It looks like you are missing a check to determine if the headers have already been sent. Ilia -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] Problem with leak detection

2005-06-22 Thread Marcus Boerger
Hello Zeev, thanks for clarifying. Any chance we could change that for "normal/unproblemeatic" exit()s in the future with run-tests in mind? marcus Wednesday, June 22, 2005, 4:03:35 PM, you wrote: > When exit() is called, like any other case in which zend_bailout() is used, > there can be memo

Re: [PHP-DEV] httpOnly Cookies [tiny enhancement]

2005-06-22 Thread Marcus Boerger
Hello Jochen, please resend your patch as unified patch (cvs di -u). marcus Thursday, June 23, 2005, 2:03:24 AM, you wrote: > Hi, > Internet Explorer 6 SP1 supports the cookie attribute "httponly" which > prevents reading cookies from JavaScript or the like. This can help to > mitigate XSS s

[PHP-DEV] httpOnly Cookies [tiny enhancement]

2005-06-22 Thread Jochen Hansper
Hi, Internet Explorer 6 SP1 supports the cookie attribute "httponly" which prevents reading cookies from JavaScript or the like. This can help to mitigate XSS session hijacking. Browsers not supporting this cookie attribute are not disturbed if it is present. AFAIK PHP does not support httponly c

Re: [PHP-DEV] [PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

2005-06-22 Thread Antony Dovgal
On Thu, 23 Jun 2005 01:28:04 +0400 Antony Dovgal <[EMAIL PROTECTED]> wrote: > Hello all, hello Andi. > > Andi, I'd like to ask your permission to commit the patch for > http://bugs.php.net/bug.php?id=29983 > It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in > runtime) to sub

[PHP-DEV] [PATCH] bugfix for #29983 (unable to set default_charset using ini_set)

2005-06-22 Thread Antony Dovgal
Hello all, hello Andi. Andi, I'd like to ask your permission to commit the patch for http://bugs.php.net/bug.php?id=29983 It adds OnUpdateDefaultCharset, which calls sapi_header_op() (only in runtime) to substitute SAPI content-type/charset header. See the patch in attachment. -- Wbr, Antony

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli.c mysqli_warning.c php_mysqli.h

2005-06-22 Thread Andi Gutmans
I reviewed the patch and it looks OK. Go ahead and commit it. At 03:02 PM 6/22/2005 -0400, Rob Richards wrote: Is it too late to sneak in another change? http://www.ctindustries.net/patches/dom.diff.txt For http://bugs.php.net/bug.php?id=33431 and http://bugs.php.net/bug.php?id=33299 Have n

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli.c mysqli_warning.c php_mysqli.h

2005-06-22 Thread Rob Richards
Is it too late to sneak in another change? http://www.ctindustries.net/patches/dom.diff.txt For http://bugs.php.net/bug.php?id=33431 and http://bugs.php.net/bug.php?id=33299 Have no idea if it fixes the first bug, but know it fixes the latter. First one is probably more critical but cant repr

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli.c mysqli_warning.c php_mysqli.h

2005-06-22 Thread Andi Gutmans
Please try and get back to my previous email ASAP. It's holding up Beta 2 now! Andi At 09:12 AM 6/22/2005 +, Georg Richter wrote: georg Wed Jun 22 05:12:45 2005 EDT Modified files: /php-src/ext/mysqli mysqli_warning.c mysqli.c php_mysqli.h Log: changed/fixed mysqli_warn

[PHP-DEV] Re: [PHP-CVS] cvs: php-src /ext/mysqli mysqli.c mysqli_warning.c php_mysqli.h

2005-06-22 Thread Andi Gutmans
Guys, I want to reroll Beta 2 (due to the PDO build problem) and move forward ASAP. Is this an open issue? Should I roll back? Please commiters, don't commit such big changes while I'm in the middle of rolling betas. Andi At 09:33 AM 6/22/2005 -0400, Ilia Alshanetsky wrote: Hi Georg, After

[PHP-DEV] Re: [Spam] [PHP-DEV] PHP 5.1 Beta 2

2005-06-22 Thread Markus Lervik
On Tuesday 21 June 2005 05:30, Andi Gutmans wrote: > Hi, > > You can reach Beta 2 at http://snaps.php.net/~andi/ > If there are no surprise show stoppers I'll put it live tomorrow evening. ../configure --with-apxs=/usr/local/apache/bin/apxs --with-openssl --with-curl --with-zlib --with-bz2 --enabl

[PHP-DEV] CVS Account Request: acmurthy

2005-06-22 Thread Arun C Murthy
working on apc for php5, *rasmus* suggested that I should go ahead and request an account -- PHP Internals - PHP Runtime Development Mailing List To unsubscribe, visit: http://www.php.net/unsub.php

Re: [PHP-DEV] what happened to run-tests2.php

2005-06-22 Thread Nuno Lopes
It was renamed to 'server-tests.php'. Nuno - Original Message - Hi All, I used to see run-tests2.php in php source bundle. But I could not see it anymore. In http://cvs.php.net/php-src show deleted file shows run-tests2.php has been renamed by helly 3 months back. I want to what it ha

Re: [PHP-DEV] Problem with leak detection

2005-06-22 Thread Zeev Suraski
When exit() is called, like any other case in which zend_bailout() is used, there can be memory blocks which will not be 'properly' freed, and we have to rely on the memory manager to free it. So the fact leaks are not shown in case of exit() is intentional. Zeev At 05:19 20/06/2005, Marcus

Re: [PHP-DEV] PHP 5.1 Beta 2

2005-06-22 Thread Derick Rethans
On Tue, 21 Jun 2005, Nuno Lopes wrote: > There are also a couple of tests related with strtotime() (or date()) that > fail on Solaris: > http://mega.ist.utl.pt/~ncpl/php_test_results_20050621_2035.txt That is a broken date() implementation AFAICT. That's next on my todo list. Derick -- Derick

Re: [PHP-DEV] PHP 5.1 Beta 2

2005-06-22 Thread Magnus Määttä
Hi Andi, On Tuesday 21 June 2005 04.30, Andi Gutmans wrote: > Hi, > > You can reach Beta 2 at http://snaps.php.net/~andi/ > If there are no surprise show stoppers I'll put it live tomorrow > evening. Here are some test results from various systems: FreeBSD 5.4 alpha: Number of tests : 1907

[PHP-DEV] what happened to run-tests2.php

2005-06-22 Thread Kamesh Jayachandran
Hi All, I used to see run-tests2.php in php source bundle. But I could not see it anymore. In http://cvs.php.net/php-src show deleted file shows run-tests2.php has been renamed by helly 3 months back. I want to what it has been renamed to. With regards Kamesh Jayachandran -- http://www.fastmail.

Re: [PHP-DEV] PHP 5.1 Beta 2

2005-06-22 Thread Wez Furlong
It's a build related tweak, so it really does need to get in there; commited it this morning. --Wez. On 6/21/05, Andi Gutmans <[EMAIL PROTECTED]> wrote: > What config.m4 patch? Is it crucial for Beta 2? I don't want to keep Beta 2 > delayed indefinitely... It's only worth it if it's a critical bu