Re: [PHP-DEV] [PATCH] Fix for 32371 : php://input sometimes returns dupl data

2005-03-18 Thread D . Walsh
On Mar 18, 2005, at 20:46, Jozef Hatala wrote: I did not find a matching bug entry. Created #32371 for it. The exacly same code is also in php-4.3.10, I made a diff against that version (streams.c is in a different dir), too. Description and patches : http://thepathetic.com/jozef/php_input_stream_

[PHP-DEV] [PATCH] Fix for 32371 : php://input sometimes returns dupl data

2005-03-18 Thread Jozef Hatala
I did not find a matching bug entry. Created #32371 for it. The exacly same code is also in php-4.3.10, I made a diff against that version (streams.c is in a different dir), too. Description and patches : http://thepathetic.com/jozef/php_input_stream_patch.html http://thepathetic.com/jozef/php-5

Re: [PHP-DEV] [PATCH] Bug #32333 - Unable to perform command line build with Ingres extension

2005-03-18 Thread Jani Taskinen
Modified patch applied. No need to patch php_ii.h. --Jani On Wed, 16 Mar 2005, Croker, Grant wrote: Hi, Attached is a new file, config.w32, needed to build the Ingres extension with the command line build on Windows. Using this patch you should be able to use the following combination of flag

Re: [PHP-DEV] [PATCH] Fix for php://input returning duplicate data in some cases

2005-03-18 Thread Jani Taskinen
Are there any bug reports about this at bugs.php.net ? If not, enter one and put the patch online somewhere were we can download it as text file. (and the url to that into the bug report) Does this problem exist with PHP_4_3 branch? --Jani On Wed, 16 Mar 2005, Jozef Hatala w

Re: [PHP-DEV] Re: [PHP-CVS] cvs: php-src / NEWS /ext/pcre php_pcre.c php_pcre.h /main SAPI.c /win32 sendmail.c

2005-03-18 Thread Andrei Zmievski
I guess it's fine. I would make sure, though, that you can pass NULL for that parameter safely, in case we add another one in the future and you don't need to get the replacement count. On Tue, 15 Mar 2005, Andrey Hristov wrote: > Hi Andrei, > do you have anything against that change? > > Cheers

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Andi Gutmans
Just make sure that zval's which are isolated with convert_to_string_ex() are only used as read-only. At 09:41 PM 3/18/2005 +0300, Alexander Valyalkin wrote: I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt which imporves performance of implode() function in PHP4, but nobo

Re[2]: [PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread Andi Gutmans
Yeah it might make sense to move that to a function. But for some reason I already see that zend_execute_API.c contains this code in HEAD. Did someone apply and I missed the commit msg? Kamesh, can you please verify if it exists in your source tree? Good catch btw. Andi At 01:46 PM 3/18/2005 +02

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Moriyoshi Koizumi
On 2005/03/19, at 6:14, Derick Rethans wrote: On Sat, 19 Mar 2005, Moriyoshi Koizumi wrote: We already have an optimisation in the 5.x branches. I think it is appliable to the 4.3 branch. 4.3 is only for bugfixes! It didn't mean that the fix should be in the 4.3. What was it that excited you so mu

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Derick Rethans
On Sat, 19 Mar 2005, Moriyoshi Koizumi wrote: > $arrays = array(array(), array(), array()); > var_dump(implode('', $arrays)); > var_dump($arrays); > ?> > > We already have an optimisation in the 5.x branches. > I think it is appliable to the 4.3 branch. 4.3 is only for bugfixes! Derick -- De

Re: [PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Moriyoshi Koizumi
On 2005/03/19, at 3:41, Alexander Valyalkin wrote: I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt which imporves performance of implode() function in PHP4, but nobody doesn't commit it yet. Can anybody explain the reason? Because convert_to_string_ex() modifies the conte

[PHP-DEV] Re: implode() speedup in PHP4

2005-03-18 Thread Christian Stadler
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Alexander Valyalkin schrieb: > I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt > which imporves performance of implode() function in PHP4, but nobody > doesn't > commit it yet. Can anybody explain the reason? After applying t

[PHP-DEV] about mt_srand() function

2005-03-18 Thread Alexander Valyalkin
mt_srand() is used to seed initialisation vector (IV) for Mersenne Twister pseudorandom generator. But there is a "little" problem: the actual length of IV is 19968 bits, but mt_srand() accepts only 32-bit integers, which even reduced to 31 bit in function php_mt_srand() at /ext/standard/rand.c a

[PHP-DEV] implode() speedup in PHP4

2005-03-18 Thread Alexander Valyalkin
I've posted patch last summer http://www.zend.com/zend/week/pat/pat5.txt which imporves performance of implode() function in PHP4, but nobody doesn't commit it yet. Can anybody explain the reason? -- Using Opera's revolutionary e-mail client: http://www.opera.com/m2/ -- PHP Internals - PHP Runti

Re: [PHP-DEV] How to submit a new SAPI extension?

2005-03-18 Thread George Wang
No, there should not be any licensing issue. :-) The code that we will submit will be under PHP and BSD licenses. The SAPI works like the Fast CGI SAPI using different protocol, PHP runs out of our server process in its own process. Please let me know if there are more concerns. Best Regards, Geo

Re[2]: [PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread val khokhlov
Hello Kamesh, Friday, March 18, 2005, 1:15:53 PM, you wrote: KJ> Yes I got this fix from pass_two only. It duplicates pass_two especially KJ> the while loop. you see, i also use this part of pass_two() code in my ext. maybe, it'd be a good idea to find one place for this jump addr calculat

Re: [PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread Kamesh Jayachandran
Hi Val, Yes I got this fix from pass_two only. It duplicates pass_two especially the while loop. With regards Kamesh Jayachandran On Fri, 18 Mar 2005 13:05:46 +0200, "val khokhlov" <[EMAIL PROTECTED]> said: > Hello Kamesh, > > Friday, March 18, 2005, 12:46:44 PM, you wrote: > > KJ> This normall

Re: [PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread val khokhlov
Hello Kamesh, Friday, March 18, 2005, 12:46:44 PM, you wrote: KJ> This normally happens from pass_two. KJ> I am attaching the patch which does this jmp_addr evaluation. This patch KJ> is against php-5.0.4-dev-RC[2]. your code will duplicate some lines pass_two(), won't it? or execute_new

Re: [PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread Derick Rethans
On Fri, 18 Mar 2005, Kamesh Jayachandran wrote: > Hi, > In case of interactive mode the > for ZEND_JMP > op1.u.jmp_addr is not evaluated, it still has the relative diff from the > current opcode. > > for ZEND_JMP, ZEND_JMPNZ, ZEND_JMPZ_EX, ZEND_JMPNZ_EX > op2.u.jmp_addr is not evaluated, it stil

[PHP-DEV] Fix for 30818, 28839, 32229, 30513

2005-03-18 Thread Kamesh Jayachandran
Hi, In case of interactive mode the for ZEND_JMP op1.u.jmp_addr is not evaluated, it still has the relative diff from the current opcode. for ZEND_JMP, ZEND_JMPNZ, ZEND_JMPZ_EX, ZEND_JMPNZ_EX op2.u.jmp_addr is not evaluated, it still has the relative diff from the current opcode. This normally h