[PHP-DEV] [PATCH] Resubmitted for review

2004-10-11 Thread Robert Silva
This patch allows php extension authors to declare constants on internal objects. This pretty much just duplicates the zend_declare_property_* functions but for constants. Currently there is no way for C level class authors to declare constants on their objects since the engine has to allocate spac

[PHP-DEV] [PATCH] Bug #30230 exception handler not working with objects

2004-10-11 Thread Robert Silva
The problem is that set_exception_handler allows you to reset the handler by passing an empty string as argument. It did not check to make sure it was a string before checking strlen, therefore when passed an array, it assumed the user was resetting the handler. This patch only resets when an empty

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Sascha Schumann
On Mon, 11 Oct 2004, Andi Gutmans wrote: > I think you are right. The only problem I can see is that people added more > than one header with a header() call and it actually having worked under some > SAPIs. My guess is that this has happened quite often and it might break quite > a few apps.

[PHP-DEV] Fwd: New VM Architecture

2004-10-11 Thread Andi Gutmans
btw, in case it's not clear how to use it then do the following: a) untar the files into php5/Zend b) Apply zend_vm_gen.diff (this is a one time thingy which will be resolved if the patch is applied). c) Run php zend_vm_gen.php --help There'll be some files which can be deleted later on if we use

[PHP-DEV] New VM Architecture

2004-10-11 Thread Andi Gutmans
Due to popular demand, attached is an example of how the new VM architecture would be without the macro magic. Basically, the zend_vm_gen.php script auto-generates the chosen VM architecture (goto/call/switch) and the user can also select if he wants to specialize opcodes and/or wants the genera

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Wez Furlong
I'm fairly sure this topic came up on the list a little while back. Would you mind searching the archives to see what the outcome was? I think we ended up deciding to keep the current behaviour for BC reasons. ---Wez. On Tue, 12 Oct 2004 01:32:21 +0200, Christian Schneider <[EMAIL PROTECTED]> wro

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Christian Schneider
Andi Gutmans wrote: No I don't know of any application which uses it. You might be right. If you people think we should introduce it then I'd do it for 5.1.x and as you said, definitely have an RC before release. And as I mentioned to Andi in another email the change would also increase consisten

Fwd: Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Andi Gutmans
FYI. Forgot to cc: [EMAIL PROTECTED] Date: Mon, 11 Oct 2004 15:56:17 -0700 To: Christian Schneider <[EMAIL PROTECTED]> From: Andi Gutmans <[EMAIL PROTECTED]> Subject: Re: [PHP-DEV] HTTP Response Splitting At 12:46 AM 10/12/2004 +0200, Christian Schneider wrote: Andi Gutmans wrote: under some SAPIs.

Re: [PHP-DEV] [PATCH] Compiling bcompiler with PHP5

2004-10-11 Thread Andi Gutmans
It'd be smarter for bcompiler to set the correct destructor during unserializing then doing the comparisons it does during serialization. I encourage the author to fix this. There's no good reason to do it this way. Andi At 03:35 PM 10/11/2004 -0700, Frank M. Kromann wrote: Hi Andi, I was just tr

Re: [PHP-DEV] [PATCH] Compiling bcompiler with PHP5

2004-10-11 Thread Frank M. Kromann
Hi Andi, I was just trying to compile and use the latest version of pecl/becompiler on win32. When I compile as shared these needs to be exported. I would prefere to have this extension as shared as it's not used that often. I have not testet on Linux, but I would asume the same is the case there.

Re: [PHP-DEV] [PATCH] Compiling bcompiler with PHP5

2004-10-11 Thread Andi Gutmans
Are you sure it needs access to these functions? That seems kind of strange... They aren't really supposed to be exported. If there's a real reason I'll export them. Andi At 12:33 PM 10/11/2004 -0700, Frank M. Kromann wrote: Hello, Here is a small patch to Zend taht will allow the current version

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Andi Gutmans
I think you are right. The only problem I can see is that people added more than one header with a header() call and it actually having worked under some SAPIs. My guess is that this has happened quite often and it might break quite a few apps. Andi At 07:36 PM 10/11/2004 +0200, Sascha Schumann

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Christian Schneider
Sascha Schumann wrote: response header. There are also some SAPI modules which specifically expect exactly one header per call. As such, stripping off \n.* seems correct to me. The HTTP standard allows header field folding (CR/LF followed by at least one whitespace on the next line)

Re: [PHP-DEV] Bug: Can't inherit abstract function

2004-10-11 Thread Andi Gutmans
What do you expect to happen? BTW, I see an additional problem. You aren't supposed to be able to use access modifiers such as public/abstract in an interface definition. This is something we have to fix. It should be: interface Drawable { function draw(); } Andi At 03:26 PM 10/9/2004 +02

[PHP-DEV] [PATCH] Compiling bcompiler with PHP5

2004-10-11 Thread Frank M. Kromann
Hello, Here is a small patch to Zend taht will allow the current version of pecl/bcompiler to compile with PHP and ZendEngine2. http://kromann.info/Zend.patch Would it be possible for someone with karma to commit this ? - Frank -- PHP Internals - PHP Runtime Development Mailing List To unsubs

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Sascha Schumann
Considering the sapi code where each header() call lands, the code assumes that the buffer contains exactly one HTTP response header. There are also some SAPI modules which specifically expect exactly one header per call. As such, stripping off \n.* seems correct to me. -

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Christian Schneider
Derick Rethans wrote: This is the users' problem, not ours. Sounds too much like MS to me :-) I wrote a little patch for PHP4 which I'll deploy on our servers. In case anyone is interested, have a look at: http://cschneid.com/php/php4/http_reponse_splitting.patch - Chris -- PHP Internals - PHP Runt

Re: [PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Derick Rethans
On Mon, 11 Oct 2004, Christian Schneider wrote: > I looked through the bug database and the archive of this mailing list > but couldn't find any reference to HTTP Response Splitting. I apoligize > if this has been discussed before :-) > > Basically it means that web applications return unfiltered

[PHP-DEV] HTTP Response Splitting

2004-10-11 Thread Christian Schneider
I looked through the bug database and the archive of this mailing list but couldn't find any reference to HTTP Response Splitting. I apoligize if this has been discussed before :-) Basically it means that web applications return unfiltered user-supplied data in the HTTP header, most commonly wh

Re: [PHP-DEV] Static variable reflection

2004-10-11 Thread Marcus Boerger
Hello Benjamin, Monday, October 11, 2004, 1:36:25 AM, you wrote: > I sent this message to the php-general list and didn't get any > replies. This seems to be a potential bug so I thought it would be > appropriate to the php-dev list. Thank you for reading this message. > I have been using and

[PHP-DEV] PHP 5 Bug Summary Report

2004-10-11 Thread internals
PHP 5 Bug Database summary - http://bugs.php.net Num Status Summary (435 total including feature requests) ===[*Compile Issues]== 28103 Open During ./configure you get png error instead of iodbc 28297 Open (SNMP) make instal

[PHP-DEV] PHP 4 Bug Summary Report

2004-10-11 Thread internals
PHP 4 Bug Database summary - http://bugs.php.net Num Status Summary (823 total including feature requests) ===[*Configuration Issues] 29208 Open The variable name which ext_skel generates, and the variable name which configu