Re: [PHP-DEV] Reference equality between objects

2004-09-23 Thread Andi Gutmans
You also have to compare Z_OBJ_HT_P(objA) == Z_OBJ_HT_P(objB) in addition to Z_OBJ_HANDLE_P. After checking both of these your code will work. At 10:57 PM 9/23/2004 -0700, Robert Silva wrote: Just wondering if there is a better way to test for reference equality than what is listed below. zval *

[PHP-DEV] Reference equality between objects

2004-09-23 Thread Robert Silva
Just wondering if there is a better way to test for reference equality than what is listed below. zval *objA; zval *objB; if (zend_parse_parameters(ZEND_NUM_ARGS() TSRMLS_CC, "oo", &objA, &objB) == FAILURE) { return; } // Reference equality only if (Z_OBJ_HANDLE_P(objA) == Z_OBJ_HANDLE_

Re: [PHP-DEV] Re: cvs: ZendEngine2 / zend_compile.h zend_execute.c zend_execute.h zend_execute_API.c zend_opcode.c zend_vm.h

2004-09-23 Thread Andi Gutmans
Thanks. Will check it out. Andi At 06:12 AM 9/24/2004 +0200, Sebastian Bergmann wrote: Andi Gutmans wrote: > andi Thu Sep 23 17:43:32 2004 EDT > > Modified files: > /ZendEngine2 zend_compile.h zend_execute.c zend_execute.h > zend_execute_API.c zend_opcode.c

[PHP-DEV] Re: cvs: ZendEngine2 / zend_compile.h zend_execute.c zend_execute.h zend_execute_API.c zend_opcode.c zend_vm.h

2004-09-23 Thread Sebastian Bergmann
Andi Gutmans wrote: > andi Thu Sep 23 17:43:32 2004 EDT > > Modified files: > /ZendEngine2 zend_compile.h zend_execute.c zend_execute.h > zend_execute_API.c zend_opcode.c zend_vm.h > Log: > - Commit new VM architecture. This one allows

[PHP-DEV] Benchmark of new VM

2004-09-23 Thread Andi Gutmans
Hi, Take it at face value but I get the following results with the new VM vs. 5.0.x on the bench.php script I commited to php5/Zend/tests. PHP 5.0.xPHP 5.1.x 37.5secsvs 29secs You know I'm not a big believer in synthetic benchmarks but it's still quite nice. Andi -- PHP Internals

Re: [PHP-DEV] realpath() caching

2004-09-23 Thread Andi Gutmans
I don't know if I'd like to make a PHP user-land function for this, especially as it'll get slightly sticky due to this being a TSRM mechanism. Also, as mentioned by Elfyn, it's very unlikely to affect anyone. How about allowing ini_set("realpath_catch_size", ?); during execution. It would chang

Re: [PHP-DEV] interface method redeclaration

2004-09-23 Thread Andrey Hristov
George Schlossnagle wrote: Hi, Coogle brought this up, shouldn't this be ok? interface Bar { function foo(); } interface Baz { function foo(); } class A implements Bar, Baz { function foo() {} } Throws a redclaration error in 5.0.1. George Schlossnagle -- Prinicipal Consult

[PHP-DEV] interface method redeclaration

2004-09-23 Thread George Schlossnagle
Hi, Coogle brought this up, shouldn't this be ok? interface Bar { function foo(); } interface Baz { function foo(); } class A implements Bar, Baz { function foo() {} } Throws a redclaration error in 5.0.1. George Schlossnagle -- Prinicipal Consultant -- OmniTI Computer Cons

Re: [PHP-DEV] [PATCH] tests/classes/factory_and_singleton_009.phpt

2004-09-23 Thread Marcus Boerger
Hello Kamesh, doesn't work for me. And if you were right we would see those tests FAILing in all php 5 test reports. There must be another problem. regards marcus Thursday, September 23, 2004, 1:15:30 PM, you wrote: > Hi Helly, > I had the tests/classes/factory_and_singleton_009.phpt testcase

Re: [PHP-DEV] New VM architecture

2004-09-23 Thread Andi Gutmans
At 10:31 AM 9/23/2004 +0200, Thies C. Arntzen wrote: On 2004-09-22 20:09:47 +0200, Andi Gutmans <[EMAIL PROTECTED]> said: Guys, There's no feedback about the new VM architecture and it's hard to maintain the patches as changes are being made to the source base constantly. I will recommit the patch

[PHP-DEV] PHP 4.3.9 Released

2004-09-23 Thread Ilia Alshanetsky
Here is the proposed 4.3.9 release announcement. PHP Development Team is proud to announce the immediate release of PHP 4.3.9. This is a maintenance release that in addition to over 50 non-critical bug fixes, addresses a problem with GPC input processing. This release also re-introduces ability t

Re: [PHP-DEV] Weird engine problem

2004-09-23 Thread Sebastian Bergmann
Sebastian Bergmann wrote: > Sorry for these lengthy mails but this issue is important to me as it > hinders the development of PHPUnit2. Since I was finally able to write a small reproducing script I opened a bug report for this: http://bugs.php.net/bug.php?id=30209 -- Sebastian Bergmann

RE: [PHP-DEV] New VM architecture

2004-09-23 Thread Dmitry Stogov
The problem, that not all C compilers support direct threaded code (GOTO), so we cannot generate one code that will run with all compilers. And we will get a lot of troubles with support different executors. Now with this patch we use one executor's definition and can select different threading mo

[PHP-DEV] [PATCH] tests/classes/factory_and_singleton_009.phpt

2004-09-23 Thread Kamesh Jayachandran
Hi Helly, I had the tests/classes/factory_and_singleton_009.phpt testcase failing in Linux, NetWare, Windows ports of PHP. And found that this failure is due to one extra line. Attached the patch. Similar issue exists in tests/classes/factory_and_singleton_010.phpt Actually after ===DONE=== newl

Re: [PHP-DEV] New VM architecture

2004-09-23 Thread Thies C . Arntzen
On 2004-09-22 20:09:47 +0200, Andi Gutmans <[EMAIL PROTECTED]> said: Guys, There's no feedback about the new VM architecture and it's hard to maintain the patches as changes are being made to the source base constantly. I will recommit the patches on Monday unless someone has reasonable objectio