Re: [PHP-DEV] RC1

2004-02-08 Thread Jon Parise
On Sun, Feb 08, 2004 at 09:53:03PM +0100, Derick Rethans wrote: > > > > (b) Default inclusion of the SOAP extension > > > > > >That word 'default' kinda muddies the issue - are you suggesting that SOAP > > >is included in distributions, or are you suggesting that it should be > > >enabled by defau

Re: [PHP-DEV] Iterators and new destructors

2004-02-08 Thread Marcus Boerger
Hello Andi, without looking at the code i guessed iterators needed both, destruction and cleaning. But unfortunatley i fear i cannot look into it until wednesday. So i took a few mins right now and i'd say you should commit Rob's patch which seems correct. regards marcus Sunday, February 8, 2004

Re: [PHP-DEV] Session SID and strip tags

2004-02-08 Thread Rasmus Lerdorf
Read README.input_filter in the php5 tree. On Sun, 8 Feb 2004, Juan Alonso wrote: > Excuse my ignorance Rasmus but how do we turn on input filtering now? (I > will pretend I know what "input filtering" is) > > El dom, 08-02-2004 a las 20:26, Rasmus Lerdorf escribió: > > Perhaps the real answer h

Re: [PHP-DEV] Session SID and strip tags

2004-02-08 Thread Juan Alonso
Excuse my ignorance Rasmus but how do we turn on input filtering now? (I will pretend I know what "input filtering" is) El dom, 08-02-2004 a las 20:26, Rasmus Lerdorf escribió: > Perhaps the real answer here is to turn on input filtering by default so > we defeat XSS once and for all across the b

RE: [PHP-DEV] RC1

2004-02-08 Thread Derick Rethans
On Wed, 4 Feb 2004, Zeev Suraski wrote: > At 22:12 04/02/2004, Steph wrote: > > > > (b) Default inclusion of the SOAP extension > > > >That word 'default' kinda muddies the issue - are you suggesting that SOAP > >is included in distributions, or are you suggesting that it should be > >enabled by d

Re: [PHP-DEV] Session SID and strip tags

2004-02-08 Thread Rasmus Lerdorf
Perhaps the real answer here is to turn on input filtering by default so we defeat XSS once and for all across the board. On Sun, 8 Feb 2004, Derick Rethans wrote: > Hey, > > while reading the session documentation today > (en/reference/session/reference.xml) I noticed the following: > >

[PHP-DEV] Session SID and strip tags

2004-02-08 Thread Derick Rethans
Hey, while reading the session documentation today (en/reference/session/reference.xml) I noticed the following: To continue, click here The strip_tags() is used when printing the SID in order to prevent XSS related attacks. What's the point of having the SID sup

Re: [PHP-DEV] NetWare diff - 1.

2004-02-08 Thread Derick Rethans
On Thu, 5 Feb 2004, Andi Gutmans wrote: > Hi Ananth, > > I'm sorry but your patches are kind of messy. There are far too many #ifdef > NETWARE's in there. It should be possible to improve on this by creating > abstraction for things such as stat. > I don't feel very comfortable with commiting them

[PHP-DEV] zlib.output_compression on -> garbage

2004-02-08 Thread Sascha Schumann
Is "on" supposed to produce garbage (apparently Content-Encoding is simply missing), while 1 is the one true setting? I always thought they were equivalent in the context of a boolean flag. # works php_admin_value zlib.output_compression 1 # compression, but incomplet

Re: [PHP-DEV] Iterators and new destructors

2004-02-08 Thread Andi Gutmans
I submitted the patch for checking free_storage != NULL. Marcus, will have to look into SPL and see if dtor is more suitable than free_storage. Andi At 11:39 AM 2/8/2004 -0500, Rob Richards wrote: It appears that the zend iterators need to go back to using the dtor callback rather than free stor

[PHP-DEV] Iterators and new destructors

2004-02-08 Thread Rob Richards
It appears that the zend iterators need to go back to using the dtor callback rather than free storage. throwing an unhandled exception in any of the iterator foreach loops in SPL, SXE and DOM results in a segfault due to improper cleanup. To reproduce, put a throw new exception within one of the