Re: [Intel-wired-lan] [PATCH iwl-net] ice: health.c: fix compilation on gcc 7.5

2025-02-05 Thread Zhuo, Qiuxu
> From: Kitszel, Przemyslaw > [...] > Subject: [PATCH iwl-net] ice: health.c: fix compilation on gcc 7.5 > > GCC 7 is not as good as GCC 8+ in telling what is a compile-time const, and > thus could be used for static storage. So we could not use variables for that, > no matter how much "const" ke

[Intel-wired-lan] Build error on "drivers/net/ethernet/intel/ice/devlink/health.c:35:3: error: initializer element is not constant"

2025-02-05 Thread Zhuo, Qiuxu
Hi, I got theĀ build error messages as below: My GCC is: gcc (Ubuntu 7.5.0-3ubuntu1~18.04) 7.5.0. CC [M] drivers/net/ethernet/stmicro/stmmac/stmmac_mdio.o drivers/net/ethernet/intel/ice/devlink/health.c:35:3: error: initializer element is not constant ice_common_port_solutions, {ice_port_n

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: health.c: fix compilation on gcc 7.5

2025-02-06 Thread Zhuo, Qiuxu
> From: Kitszel, Przemyslaw > [...] > Subject: [PATCH iwl-net v2] ice: health.c: fix compilation on gcc 7.5 > > GCC 7 is not as good as GCC 8+ in telling what is a compile-time const, and > thus could be used for static storage. > Fortunately keeping strings as const arrays is enough to make old