Re: [Intel-wired-lan] [PATCH net-next v6 13/21] bitmap: make bitmap_{get, set}_value8() use bitmap_{read, write}()

2024-05-30 Thread Yury Norov
On Wed, May 29, 2024 at 04:12:25PM +0100, Robin Murphy wrote: > Hi Alexander, > > On 27/03/2024 3:23 pm, Alexander Lobakin wrote: > > Now that we have generic bitmap_read() and bitmap_write(), which are > > inline and try to take care of non-bound-crossing and aligned cases > > to keep them optimi

Re: [Intel-wired-lan] [PATCH iwl-next v4 0/7] Add PFCP filter support

2023-12-18 Thread Yury Norov
+ Alexander Potapenko On Mon, Dec 18, 2023 at 01:47:01PM +0100, Alexander Lobakin wrote: > From: Marcin Szycik > Date: Mon, 18 Dec 2023 11:04:01 +0100 > > > > > > > On 15.12.2023 17:49, Jakub Kicinski wrote: > >> On Fri, 15 Dec 2023 11:11:23 +0100 Alexander Lobakin wrote: > >>> Ping? :s > >>>

Re: [Intel-wired-lan] [PATCH net-next v5 01/21] lib/bitmap: add bitmap_{read, write}()

2024-02-28 Thread Yury Norov
other kernel headers), and I'm working on unloading it. I checked allyesconfig build time before and after this patch, and I found no difference for me. So if you're concerned about compilation time, this patch doesn't make things worse in this department. With all that, Alexander, can you please double-check that the functions get inlined, and if so: Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 02/21] lib/test_bitmap: add tests for bitmap_{read, write}()

2024-02-28 Thread Yury Norov
197][T1] test_bitmap: Time spent in test_bitmap_write_perf: > 916313 > > (numbers from a Intel(R) Xeon(R) Gold 6154 CPU @ 3.00GHz machine running > QEMU). > > Signed-off-by: Alexander Potapenko > Reviewed-by: Andy Shevchenko > Acked-by: Yury Norov > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 03/21] lib/test_bitmap: use pr_info() for non-error messages

2024-02-28 Thread Yury Norov
ggested-by: Alexander Lobakin > Signed-off-by: Alexander Potapenko > Acked-by: Yury Norov > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 04/21] bitops: add missing prototype check

2024-02-28 Thread Yury Norov
ernel.org # 6.0+ > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Acked-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 05/21] bitops: make BYTES_TO_BITS() treewide-available

2024-02-28 Thread Yury Norov
e perf code. > > Suggested-by: Andy Shevchenko > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Acked-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 06/21] bitops: let the compiler optimize {__, }assign_bit()

2024-02-28 Thread Yury Norov
a place for possible suboptimal codegen. Moreover, with certain > kernel configuration it actually gives some saves (x86): > > do_ip_setsockopt41544099 -55 > > Suggested-by: Yury Norov # assign_bit(), too > Cc: Andy Shevchenko > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Acked-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 07/21] linkmode: convert linkmode_{test, set, clear, mod}_bit() to macros

2024-02-28 Thread Yury Norov
piled by LLVM for x86_64) whatsoever, but that > doesn't necessarily means the change is meaningless. > > Reviewed-by: Przemek Kitszel > Acked-by: Jakub Kicinski > Signed-off-by: Alexander Lobakin Acked-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 09/21] fs/ntfs3: add prefix to bitmap_size() and use BITS_TO_U64()

2024-02-28 Thread Yury Norov
ough it uses ideologically right ALIGN() instead of division). > Add the prefix 'ntfs3_' used for that FS (not just 'ntfs_' to not mix > it with the legacy module) and use generic BITS_TO_U64() while at it. > > Suggested-by: Yury Norov # BITS_TO_U64() > Reviewed-

Re: [Intel-wired-lan] [PATCH net-next v5 10/21] btrfs: rename bitmap_set_bits() -> btrfs_bitmap_set_bits()

2024-02-28 Thread Yury Norov
Just add the prefix to exclude such possible conflict. > > Reviewed-by: Przemek Kitszel > Acked-by: David Sterba > Signed-off-by: Alexander Lobakin Reviewed-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 11/21] tools: move alignment-related macros to new

2024-02-28 Thread Yury Norov
nsistent with the kernel headers and allow > using those macros outside of the mentioned headers. Create > inside the tools/ folder and include it where needed. > > Signed-off-by: Alexander Lobakin Reviewed-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 11/21] tools: move alignment-related macros to new

2024-02-28 Thread Yury Norov
On Wed, Feb 28, 2024 at 08:28:31AM -0800, Yury Norov wrote: > On Thu, Feb 01, 2024 at 01:22:06PM +0100, Alexander Lobakin wrote: > > Currently, tools have *ALIGN*() macros scattered across the unrelated > > headers, as there are only 3 of them and they were added separately > &g

Re: [Intel-wired-lan] [PATCH net-next v5 12/21] bitmap: introduce generic optimized bitmap_size()

2024-02-28 Thread Yury Norov
/shrink: 9/133 up/down: 18/-538 (-520) > > Note that we can't expand DIV_ROUND_UP() by adding a check and using > this approach there, as it's used in array declarations where > expressions are not allowed. > Add this helper to tools/ as well. > > Reviewed-by: Przemek Kitszel > Acked-by: Yury Norov > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 13/21] bitmap: make bitmap_{get, set}_value8() use bitmap_{read, write}()

2024-02-28 Thread Yury Norov
lot. > > Suggested-by: Yury Norov > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 14/21] lib/bitmap: add compile-time test for __assign_bit() optimization

2024-02-28 Thread Yury Norov
mment mentioning the workaround removed recently > in favor of adding the whole file to GCov exceptions. > > Reviewed-by: Przemek Kitszel > Signed-off-by: Alexander Lobakin Signed-off-by: Yury Norov

Re: [Intel-wired-lan] [PATCH net-next v5 17/21] lib/bitmap: add tests for IP tunnel flags conversion helpers

2024-02-28 Thread Yury Norov
On Thu, Feb 01, 2024 at 01:22:12PM +0100, Alexander Lobakin wrote: > Now that there are helpers for converting IP tunnel flags between the > old __be16 format and the bitmap format, make sure they work as expected > by adding a couple of tests to the bitmap testing suite. The helpers are > all inli

Re: [Intel-wired-lan] [PATCH net-next v5 00/21] ice: add PFCP filter support

2024-02-28 Thread Yury Norov
On Mon, Feb 12, 2024 at 12:35:38PM +0100, Alexander Lobakin wrote: > From: Jakub Kicinski > Date: Wed, 7 Feb 2024 07:05:35 -0800 > > > On Tue, 6 Feb 2024 13:46:44 +0100 Alexander Lobakin wrote: > >>> Add support for creating PFCP filters in switchdev mode. Add pfcp module > >>> that allows to cre