[Intel-wired-lan] [PATCH] Revert "igb: Disable threaded IRQ for igb_msix_other"

This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f. Sebastian noticed the ISR indirectly acquires spin_locks, which are sleeping locks under PREEMPT_RT, which leads to kernel splats. Signed-off-by: Wander Lairson Costa Reported-by: Sebastian Andrzej Siewior --- drivers/net/ethernet

Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel wrote: > > On 9/21/24 14:52, Paul Menzel wrote: > > Dear Wander, > > > > > > Thank you for your patch. > > > > Am 20.09.24 um 20:59 schrieb Wander Lairson Costa: > >> tx_queue_lock and stats_loc

Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

On Mon, Sep 23, 2024 at 3:44 PM Tony Nguyen wrote: > > > > On 9/23/2024 9:46 AM, Wander Lairson Costa wrote: > > On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel > > wrote: > >> > >> On 9/21/24 14:52, Paul Menzel wrote: > >>> Dear Wander, >

[Intel-wired-lan] [PATCH 0/2] Fixes in igbvf driver

The first patch fixes a bug manifested manifested in the igbvf driver when interrupting handling for the igb driver delays. The second is just a cleanup for igbvf. Wander Lairson Costa (2): igb: Disable threaded IRQ for igb_msix_other igbvf: remove unused spinlock drivers/net/ethernet

[Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

tx_queue_lock and stats_lock are declared and initialized, but never used. Remove them. Signed-off-by: Wander Lairson Costa --- drivers/net/ethernet/intel/igbvf/igbvf.h | 3 --- drivers/net/ethernet/intel/igbvf/netdev.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/net

[Intel-wired-lan] [PATCH 1/2] igb: Disable threaded IRQ for igb_msix_other

ip link set $vf down done Signed-off-by: Wander Lairson Costa Reported-by: Yuying Ma --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/ethernet/int

[Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

an Andrzej Siewior Signed-off-by: Wander Lairson Costa --- Changelog: v2: Add the Fixes tag Signed-off-by: Wander Lairson Costa --- drivers/net/ethernet/intel/igb/igb_main.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/d

Re: [Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

On Fri, Nov 8, 2024 at 4:20 AM Sebastian Andrzej Siewior wrote: > > On 2024-11-06 08:14:26 [-0300], Wander Lairson Costa wrote: > > This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f. > > > > Sebastian noticed the ISR indirectly acquires spin_locks, which are

[Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

, Wander [1] https://lore.kernel.org/all/20240920185918.616302-2-wan...@redhat.com/ [2] https://lore.kernel.org/all/20241104124050.22290-1-wan...@redhat.com/ [3] https://lore.kernel.org/all/20241104110708.gfyxr...@linutronix.de/ Wander Lairson Costa (4): igb: narrow scope of vfs_lock in SR-IOV

[Intel-wired-lan] [PATCH iwl-net 3/4] igb: split igb_msg_task()

the igb_msix_other interrupt handler will be split into IRQ and threaded handlers, each invoking the appropriate part of the newly divided igb_msg_task(). Signed-off-by: Wander Lairson Costa --- drivers/net/ethernet/intel/igb/igb_main.c | 88 +-- 1 file changed, 81 insertions(+), 7 deleti

[Intel-wired-lan] [PATCH iwl-net 4/4] igb: fix igb_msix_other() handling for PREEMPT_RT

n done You can also reproduce it more reliably by setting nr_cpus=1 in the kernel command line. Fixes: 9d5c824399de ("igb: PCI-Express 82575 Gigabit Ethernet driver") Signed-off-by: Wander Lairson Costa Reported-by: Yuying Ma --- drivers/net/ethernet/intel/igb/igb_main.c | 35 +++

[Intel-wired-lan] [PATCH iwl-net 2/4] igb: introduce raw vfs_lock to igb_adapter

. By introducing this raw spinlock, we can safely acquire the lock in both contexts, paving the way for the necessary restructuring of igb_msg_task(). Signed-off-by: Wander Lairson Costa Suggested-by: Clark Williams --- drivers/net/ethernet/intel/igb/igb.h | 4 ++ drivers/net/ethernet/intel

[Intel-wired-lan] [PATCH iwl-net 1/4] igb: narrow scope of vfs_lock in SR-IOV cleanup

the vfs_lock scope, it becomes possible to safely convert vfs_lock to a raw_spin_lock. Signed-off-by: Wander Lairson Costa --- drivers/net/ethernet/intel/igb/igb_main.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/intel/igb/igb_main.c b/drivers/net/et

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

On Tue, Jan 07, 2025 at 02:51:06PM +0100, Sebastian Andrzej Siewior wrote: > On 2024-12-04 08:42:23 [-0300], Wander Lairson Costa wrote: > > This is the second attempt at fixing the behavior of igb_msix_other() > > for PREEMPT_RT. The previous attempt [1] was reverted [2] followi

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

On Wed, Dec 4, 2024 at 8:43 AM Wander Lairson Costa wrote: > > This is the second attempt at fixing the behavior of igb_msix_other() > for PREEMPT_RT. The previous attempt [1] was reverted [2] following > concerns raised by Sebastian [3]. > > The initial approach proposed conver

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

On Thu, Jan 09, 2025 at 06:45:12PM +0100, Sebastian Andrzej Siewior wrote: > On 2025-01-09 13:46:47 [-0300], Wander Lairson Costa wrote: > > > If the issue is indeed the use of threaded interrupts then the fix > > > should not be limited to be PREEMPT_RT only. > > > &

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

On Wed, Jan 8, 2025 at 7:25 AM Sebastian Andrzej Siewior wrote: > > On 2025-01-07 15:52:47 [-0300], Wander Lairson Costa wrote: > > On Tue, Jan 07, 2025 at 02:51:06PM +0100, Sebastian Andrzej Siewior wrote: > > > On 2024-12-04 08:42:23 [-0300], Wander Lairson Costa wrote