Re: [Intel-wired-lan] [PATCH iwl-next v4 05/12] ice: Log virtual channel messages in PF

2023-12-06 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Tuesday, November 21, 2023 10:51 AM > @@ -4037,6 +4045,17 @@ void ice_vc_process_vf_msg(struct ice_pf *pf, > struct ice_rq_event_info *event, > goto finish; > } > > + if (vf->migration_enabled) { > + if (ice_migration_log_vf_msg(vf, e

Re: [Intel-wired-lan] [PATCH iwl-next v4 06/12] ice: Add device state save/load function for migration

2023-12-06 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Tuesday, November 21, 2023 10:51 AM > + > + while (msg_slot->opcode != VIRTCHNL_OP_UNKNOWN) { > + struct ice_rq_event_info event; > + u64 slot_sz; > + > + slot_sz = struct_size(msg_slot, msg_buffer, msg_slot- > >msg_len); > +

Re: [Intel-wired-lan] [PATCH iwl-next v4 07/12] ice: Fix VSI id in virtual channel message for migration

2023-12-06 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Tuesday, November 21, 2023 10:51 AM > > + /* Read the beginning two bytes of message for VSI id */ > + u16 *vsi_id = (u16 *)msg; > + > + /* For VM runtime stage, vsi_id in the virtual channel > message > + * should be equa

Re: [Intel-wired-lan] [PATCH iwl-next v4 08/12] ice: Save and load RX Queue head

2023-12-06 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Tuesday, November 21, 2023 10:51 AM > > + > + /* Once RX Queue is enabled, network traffic may come in at > any > + * time. As a result, RX Queue head needs to be loaded > before > + * RX Queue is enabled. > + * For simp

Re: [Intel-wired-lan] [PATCH iwl-next v4 09/12] ice: Save and load TX Queue head

2023-12-07 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Tuesday, November 21, 2023 10:51 AM > > To advance TX Head queue, HW needs to touch memory by DMA. But > directly > touching VM's memory to advance TX Queue head does not follow vfio > migration protocol design, because vIOMMU state is not defined by the > protocol. Eve

Re: [Intel-wired-lan] [PATCH iwl-next v4 08/12] ice: Save and load RX Queue head

2023-12-07 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Thursday, December 7, 2023 10:46 PM > > On Thu, Dec 07, 2023 at 07:55:17AM +, Tian, Kevin wrote: > > > From: Cao, Yahui > > > Sent: Tuesday, November 21, 2023 10:51 AM > > > > > > + > > > + /*

Re: [Intel-wired-lan] [PATCH iwl-next v4 12/12] vfio/ice: Implement vfio_pci driver for E800 devices

2023-12-07 Thread Tian, Kevin
> From: Alex Williamson > Sent: Friday, December 8, 2023 6:43 AM > > + > > + if (cur == VFIO_DEVICE_STATE_RUNNING && > > + new == VFIO_DEVICE_STATE_RUNNING_P2P) { > > + ice_migration_suspend_dev(ice_vdev->pf, ice_vdev->vf_id); > > + return NULL; > > + } > > + > > +

Re: [Intel-wired-lan] [PATCH iwl-next v4 12/12] vfio/ice: Implement vfio_pci driver for E800 devices

2023-12-07 Thread Tian, Kevin
> From: Tian, Kevin > Sent: Friday, December 8, 2023 11:42 AM > > > From: Alex Williamson > > Sent: Friday, December 8, 2023 6:43 AM > > > + > > > + if (cur == VFIO_DEVICE_STATE_RUNNING && > > > + new == VFIO_DEVICE_STATE_RUNNING_P2P)

Re: [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices

2023-10-13 Thread Tian, Kevin
> From: Cao, Yahui > Sent: Monday, September 18, 2023 2:26 PM > > +static struct file * > +ice_vfio_pci_step_device_state_locked(struct ice_vfio_pci_core_device > *ice_vdev, > + u32 new, u32 final) > +{ > + u32 cur = ice_vdev->mig_state; > + int ret; > + >

Re: [Intel-wired-lan] [PATCH iwl-next v3 13/13] vfio/ice: Implement vfio_pci driver for E800 devices

2023-10-16 Thread Tian, Kevin
> From: Jason Gunthorpe > Sent: Friday, October 13, 2023 10:08 PM > > On Fri, Oct 13, 2023 at 08:52:07AM +, Tian, Kevin wrote: > > > From: Cao, Yahui > > > Sent: Monday, September 18, 2023 2:26 PM > > > > > > +static struct file * >