Re: [Intel-wired-lan] [PATCH iwl-next] igc: Get rid of spurious interrupts

2024-06-12 Thread Sebastian Andrzej Siewior
the Rx interrupts in case of real allocation > failures. Introduce a new flag for signaling that condition. > > [1] - > https://git.kernel.org/pub/scm/linux/kernel/git/tglx/history.git/commit/?id=3be507547e6177e5c808544bd6a2efa2c7f1d436 > > Signed-off-by: Kurt Kanzenbach Reviewed-by: Sebastian Andrzej Siewior Sebastian

Re: [Intel-wired-lan] [PATCH iwl-next] igc: Get rid of spurious interrupts

2024-06-12 Thread Sebastian Andrzej Siewior
On 2024-06-12 12:49:21 [-0700], Vinicius Costa Gomes wrote: > > diff --git a/drivers/net/ethernet/intel/igc/igc_main.c > > b/drivers/net/ethernet/intel/igc/igc_main.c > > index 305e05294a26..e666739dfac7 100644 > > --- a/drivers/net/ethernet/intel/igc/igc_main.c > > +++ b/drivers/net/ethernet/inte

Re: [Intel-wired-lan] [PATCH iwl-next v6 1/6] igb: Always call igb_xdp_ring_update_tail() under Tx lock

2024-08-16 Thread Sebastian Andrzej Siewior
On 2024-08-16 11:24:00 [+0200], Kurt Kanzenbach wrote: > index 11be39f435f3..4d5e5691c9bd 100644 > --- a/drivers/net/ethernet/intel/igb/igb_main.c > +++ b/drivers/net/ethernet/intel/igb/igb_main.c > @@ -2914,6 +2914,7 @@ static int igb_xdp(struct net_device *dev, struct > netdev_bpf *xdp) >

[Intel-wired-lan] [PATCH net-next 20/24] net: intel: Use nested-BH locking for XDP redirect.

2023-12-15 Thread Sebastian Andrzej Siewior
-...@lists.osuosl.org Signed-off-by: Sebastian Andrzej Siewior --- drivers/net/ethernet/intel/i40e/i40e_txrx.c | 1 + drivers/net/ethernet/intel/i40e/i40e_xsk.c| 22 + drivers/net/ethernet/intel/ice/ice_txrx.c | 1 + drivers/net/ethernet/intel/ice/ice_xsk.c | 21

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Remove stale comment about Tx timestamping

2024-03-14 Thread Sebastian Andrzej Siewior
On 2024-03-14 11:21:38 [+0100], Przemek Kitszel wrote: > On 3/13/24 14:03, Kurt Kanzenbach wrote: > > The initial igc Tx timestamping implementation used only one register for > > retrieving Tx timestamps. Commit 3ed247e78911 ("igc: Add support for > > multiple in-flight TX timestamps") added suppo

Re: [Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

2024-11-11 Thread Sebastian Andrzej Siewior
On 2024-11-08 15:00:48 [-0800], Jacob Keller wrote: > > > On 11/8/2024 4:28 AM, Sebastian Andrzej Siewior wrote: > > On 2024-11-08 13:20:28 [+0100], Przemek Kitszel wrote: > >> I don't like to slow things down, but it would be great to have a Link: > >> t

Re: [Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

2024-11-08 Thread Sebastian Andrzej Siewior
On 2024-11-08 13:20:28 [+0100], Przemek Kitszel wrote: > I don't like to slow things down, but it would be great to have a Link: > to the report, and the (minified) splat attached. I don't have a splat, I just reviewed the original patch. Please do delay this. Sebastian

Re: [Intel-wired-lan] [PATCH v2 1/4] Revert "igb: Disable threaded IRQ for igb_msix_other"

2024-11-07 Thread Sebastian Andrzej Siewior
38c4d3902feb ("igb: Disable threaded IRQ for igb_msix_other") > Reported-by: Sebastian Andrzej Siewior > Signed-off-by: Wander Lairson Costa Reviewed-by: Sebastian Andrzej Siewior This is the only patch. Sebastian

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

2025-01-07 Thread Sebastian Andrzej Siewior
On 2024-12-04 08:42:23 [-0300], Wander Lairson Costa wrote: > This is the second attempt at fixing the behavior of igb_msix_other() > for PREEMPT_RT. The previous attempt [1] was reverted [2] following > concerns raised by Sebastian [3]. > > The initial approach proposed converting vfs_lock to a r

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

2025-01-08 Thread Sebastian Andrzej Siewior
On 2025-01-07 15:52:47 [-0300], Wander Lairson Costa wrote: > On Tue, Jan 07, 2025 at 02:51:06PM +0100, Sebastian Andrzej Siewior wrote: > > On 2024-12-04 08:42:23 [-0300], Wander Lairson Costa wrote: > > > This is the second attempt at fixing the behavior of igb_msix_other() &g

Re: [Intel-wired-lan] [PATCH iwl-net 0/4] igb: fix igb_msix_other() handling for PREEMPT_RT

2025-01-09 Thread Sebastian Andrzej Siewior
On 2025-01-09 13:46:47 [-0300], Wander Lairson Costa wrote: > > If the issue is indeed the use of threaded interrupts then the fix > > should not be limited to be PREEMPT_RT only. > > > Although I was not aware of this scenario, the patch should work for it as > well, > as I am forcing it to run i