Re: [Intel-wired-lan] [BUG] e1000e, scheduling while atomic

2024-04-17 Thread Sasha Neftin
On 17/04/2024 21:46, Jérôme Carretero wrote: Hi, I opened https://bugzilla.kernel.org/show_bug.cgi?id=218740 because I'm not quite sure the culprit is e1000e or some timer stuff. Hello Jérôme, You hit on regression introduced by 6dbdd4de0362 (used the wrong timer during code running in atom

Re: [Intel-wired-lan] [BUG] e1000e, scheduling while atomic (stable)

2024-04-20 Thread Sasha Neftin
On 19/04/2024 19:20, Jérôme Carretero wrote: Hi Sasha, Thank you, sorry for the delay but I coudln't reboot. Adding Greg KH because I don't know if stable will receive my e-mail (not subscribed) but the regression was integrated in stable: commit 0a4e3c2d976aa4dd38951afd6267f74ef3fade0e so t

Re: [Intel-wired-lan] [BUG] e1000e, scheduling while atomic (stable)

2024-04-24 Thread Sasha Neftin
On 23/04/2024 19:23, Greg Kroah-Hartman wrote: On Fri, Apr 19, 2024 at 12:20:05PM -0400, Jérôme Carretero wrote: Hi Sasha, Thank you, sorry for the delay but I coudln't reboot. Adding Greg KH because I don't know if stable will receive my e-mail (not subscribed) but the regression was integra

Re: [Intel-wired-lan] [PATCH 1/1] net: e1000e & ixgbe: Remove PCI_HEADER_TYPE_MFD duplicates

2024-04-27 Thread Sasha Neftin
IXGBE_PCIDEVCTRL2_TIMEO_MASK 0xf Acked-by: Sasha Neftin

Re: [Intel-wired-lan] [PATCH v2 1/2] e1000e: let the sleep codes run every time

2024-05-06 Thread Sasha Neftin
On 03/05/2024 13:18, Ricky Wu wrote: Originally, the sleep codes being moved forward only ran if we met some conditions (e.g. BMSR_LSTATUS bit not set in phy_status). Moving these sleep codes forward makes the usec_interval take effect every time. Signed-off-by: Ricky Wu --- In v2: * Split the

Re: [Intel-wired-lan] [PATCH] e1000e: fix link fluctuations problem

2024-05-07 Thread Sasha Neftin
On 07/05/2024 15:10, Andrew Lunn wrote: On Tue, May 07, 2024 at 11:24:05AM +0200, En-Wei WU wrote: Why PHY is this? It's the Intel I219-LM, and I haven't found any other device having the same issue. There is no Linux PHY driver for this device, only the code buried in the e1000e MAC driver.

Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations problem

2024-05-07 Thread Sasha Neftin
On 07/05/2024 15:31, Andrew Lunn wrote: On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote: As described in https://bugzilla.kernel.org/show_bug.cgi?id=218642, Intel I219-LM reports link up -> link down -> link up after hot-plugging the Ethernet cable. Please could you quote some parts o

Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations problem

2024-05-10 Thread Sasha Neftin
On 09/05/2024 16:46, Andrew Lunn wrote: On Thu, May 09, 2024 at 12:13:27PM +0300, Ruinskiy, Dima wrote: On 08/05/2024 8:05, Sasha Neftin wrote: On 07/05/2024 15:31, Andrew Lunn wrote: On Fri, May 03, 2024 at 06:18:36PM +0800, Ricky Wu wrote: As described in https://bugzilla.kernel.org

Re: [Intel-wired-lan] [PATCH v2 2/2] e1000e: fix link fluctuations problem

2024-05-12 Thread Sasha Neftin
On 10/05/2024 15:32, Andrew Lunn wrote: It would be interesting to see what the link partner sees. What does it think the I219-LM is advertising? Is it advertising 1000BaseT_Half? i219 parts come with LSI PHY. 1000BASE-T half-duplex is not supported. 1000BASET half-duplex not advertised in IEEE

Re: [Intel-wired-lan] 6.10; regression; bisected - commit 86167183a17e cause info msg "trying to register non-static key"

2024-05-20 Thread Sasha Neftin
On 18/05/2024 0:05, Vinicius Costa Gomes wrote: Hi, + intel-wired-lan Mikhail Gavrilov writes: Hello Corinna, Any thought? Revert? Thanks, Sasha Hi, I am here to test unstable kernels. Yesterday at Fedora Rawhide arrived the new kernel 20240515git1b294a1f3561 and I spotter in kernel log

[Intel-wired-lan] [iwl-net v1 1/1] igc: Fix Energy Efficient Ethernet support declaration

2024-05-22 Thread Sasha Neftin
neg in EEE capabilities") Suggested-by: Dima Ruinskiy Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 9 +++-- drivers/net/ethernet/intel/igc/igc_main.c| 4 2 files changed, 11 insertions(+), 2 deletions(-) diff --git a/drivers/net/ethernet/int

[Intel-wired-lan] [iwl-net v1 1/1] Revert "igc: fix a log entry using uninitialized netdev"

2024-05-28 Thread Sasha Neftin
-485af9c0a61a@int el.com/ [1] Link: https://lore.kernel.org/all/87o78rmkhu@intel.com/ [2] Fixes: 86167183a17e ("igc: fix a log entry using uninitialized netdev") Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_main.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletion

[Intel-wired-lan] [iwl-next v1 1/1] igc: Remove the internal 'eee_advert' field

2024-06-08 Thread Sasha Neftin
Since kernels 'ethtool_keee' structure is in use, the internal 'eee_advert' a field becomes pointless and can be removed. This patch comes to clean up this redundant code. Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc.h | 1 - drivers/ne

Re: [Intel-wired-lan] [iwl-next v1 1/1] igc: Remove the internal 'eee_advert' field

2024-06-12 Thread Sasha Neftin
On 09/06/2024 11:43, Paul Menzel wrote: Dear Sasha, Thank you for your patch. Am 09.06.24 um 08:53 schrieb Sasha Neftin: Since kernels 'ethtool_keee' structure is in use, the internal 'eee_advert' a field becomes pointless and can be removed. Redundant *a*?

[Intel-wired-lan] [iwl-next v2 1/1] igc: Remove the internal 'eee_advert' field

2024-06-12 Thread Sasha Neftin
Since the kernel's 'ethtool_keee' structure is in use, the internal 'eee_advert' field becomes pointless and can be removed. This patch comes to clean up this redundant code. Signed-off-by: Sasha Neftin --- v2: Fixed grammar in the commit message --- drivers/net

[Intel-wired-lan] [iwl-next v1 1/1] igc: Add Energy Efficient Ethernet ability

2024-07-13 Thread Sasha Neftin
100baseT/Full 1000baseT/Full 2500baseT/Full Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_defines.h | 10 +++ drivers/net/ethernet/intel/igc/igc_ethtool.c | 73 +++- drivers/net/ethernet/intel

[Intel-wired-lan] [iwl-next v1 1/1] igc: Move the MULTI GBT AN Control Register to _regs file

2024-08-18 Thread Sasha Neftin
MULTI GBT AN Control Register is IEEE Standard Register 7.32 (not a mask). The right place should be in igc_reg.h file. In accordance with the registers naming convention added IGC_' prefix. Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_defines.h | 1 - drivers/net/eth

[Intel-wired-lan] [PATCH iwl-net v1 1/1] e1000e: Correct the maximum frequency adjustment

2023-12-09 Thread Sasha Neftin
ned-off-by: Sasha Neftin --- drivers/net/ethernet/intel/e1000e/ptp.c | 17 - 1 file changed, 12 insertions(+), 5 deletions(-) diff --git a/drivers/net/ethernet/intel/e1000e/ptp.c b/drivers/net/ethernet/intel/e1000e/ptp.c index 02d871bc112a..792dfe602ca0 100644 --- a/drivers/ne

Re: [Intel-wired-lan] [PATCH net v3] net: ethtool: do runtime PM outside RTNL

2023-12-25 Thread Sasha Neftin
On 25/12/2023 1:12, Heiner Kallweit wrote: On 24.12.2023 17:30, Marc MERLIN wrote: On Fri, Dec 15, 2023 at 09:46:34AM -0800, Marc MERLIN wrote: On Fri, Dec 15, 2023 at 02:42:01PM +0100, Heiner Kallweit wrote: Why don't you simply disable runtime pm for the affected device as a workaround? This

Re: [Intel-wired-lan] [PATCH] [iwl-net] igc: write to phy power management and management control registers to power up/power down the phy during interface up/down

2024-01-04 Thread Sasha Neftin
On 04/01/2024 3:01, Prasad Koya wrote: For I225/226 parts, when the interface is set down with "ip link set down", interface is down but the PHY (led) continues to be up. This patch makes the phy to be actually off/on during interface down/up events. Signed-off-by: Prasad Koya --- dr

[Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Remove temporary workaround

2024-01-23 Thread Sasha Neftin
PHY_CONTROL register works as defined in the IEEE 802.3 specification. (IEEE 802.3-2008 22.2.4.1). Tide up the temporary workaround. Fixes: 5586838fe9ce ("igc: Add code for PHY support") Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_phy.c | 6 +- 1 file

Re: [Intel-wired-lan] I225-V (rev 03) LOM + Linux kernel 6.7.0 power save issues

2024-01-27 Thread Sasha Neftin
On 26/01/2024 13:37, S. wrote: Hi, This was tested on a recently assembled Asus X670E-E ROG Gaming Wifi motherboard running a standard Arch linux install - "Linux r912 6.7.0-arch3-1 #1 SMP PREEMPT_DYNAMIC Sat, 13 Jan 2024 14:37:14 + x86_64 GNU/Linux." The NIC will only connect at 100 Mb

[Intel-wired-lan] [PATCH iwl-next v1 1/1] igc: Refactor runtime power management flow

2024-02-10 Thread Sasha Neftin
-pc1c0hjn.dhcp.thefacebook.com/t/ [2] Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_main.c | 32 +++ 1 file changed, 15 insertions(+), 17 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_main.c b/drivers/net/ethernet/intel/igc/igc_main.c index

[Intel-wired-lan] [PATCH iwl-net v1 1/1] intel: legacy: Partially revert of field get conversion

2024-02-17 Thread Sasha Neftin
ts Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/e1000e/ich8lan.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c b/drivers/net/ethernet/intel/e1000e/ich8lan.c index a2788fd5f8bb..bdf3344c 100644 --- a/drivers/ne

[Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Fix ambiguity in the ethtool advertising

2023-10-02 Thread Sasha Neftin
;igc: Add ethtool support") Suggested-by: Dima Ruinskiy Suggested-by: Vitaly Lifshits Signed-off-by: Sasha Neftin --- drivers/net/ethernet/intel/igc/igc_ethtool.c | 35 ++-- 1 file changed, 25 insertions(+), 10 deletions(-) diff --git a/drivers/net/ethernet/intel/igc/igc_ethtool.c