Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: Remove unnecessary argument from ice_fdir_comp_rules()

2023-12-06 Thread Plachno, Lukasz
On 12/5/2023 10:23 PM, Tony Nguyen wrote: On 11/29/2023 9:55 PM, Lukasz Plachno wrote: Passing v6 argument is unnecessary as flow_type is still analyzed inside the function. Reviewed-by: Przemek Kitszel Signed-off-by: Lukasz Plachno This doesn't build cleanly. > ../drivers/net/ethernet/in

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/2] ice: Implement 'flow-type ether' rules

2023-12-14 Thread Plachno, Lukasz
On 12/12/2023 11:29 AM, Simon Horman wrote: On Thu, Dec 07, 2023 at 01:48:40PM +0100, Lukasz Plachno wrote: From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Rules not containing masks are processed by the Flow Director, and support the following set of i

Re: [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules

2023-12-19 Thread Plachno, Lukasz
On 12/16/2023 11:03 AM, Simon Horman wrote: On Thu, Dec 14, 2023 at 05:34:49AM +0100, Lukasz Plachno wrote: ... @@ -1199,6 +1212,99 @@ ice_set_fdir_ip6_usr_seg(struct ice_flow_seg_info *seg, return 0; } +/** + * ice_fdir_vlan_valid - validate VLAN data for Flow Director rule + *

Re: [Intel-wired-lan] [PATCH iwl-next v3 2/2] ice: Implement 'flow-type ether' rules

2023-12-20 Thread Plachno, Lukasz
On 12/19/2023 6:35 PM, Brett Creeley wrote: On 12/13/2023 8:34 PM, Lukasz Plachno wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. From: Jakub Buchocki Add support for 'flow-type ether' Flow Direct

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/2] ice: Implement 'flow-type ether' rules

2024-01-31 Thread Plachno, Lukasz
On 1/25/2024 12:09 AM, Paul Menzel wrote: Dear Lukasz, dear Jakub, dear Mateusz, Thank you for your patch. Am 24.01.24 um 16:21 schrieb Lukasz Plachno: From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Can you please elaborate on the implementation?

Re: [Intel-wired-lan] [PATCH iwl-next v5 2/2] ice: Implement 'flow-type ether' rules

2024-02-08 Thread Plachno, Lukasz
On 2/7/2024 3:07 PM, Alexander Lobakin wrote: From: Lukasz Plachno Date: Tue, 6 Feb 2024 17:33:37 +0100 From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Create packet segment info for filter configuration based on ethtool command parameters. Reuse inf

Re: [Intel-wired-lan] [PATCH iwl-next v6 2/2] ice: Implement 'flow-type ether' rules

2024-02-12 Thread Plachno, Lukasz
On 2/9/2024 6:00 PM, Simon Horman wrote: On Fri, Feb 09, 2024 at 11:18:23AM +0100, Lukasz Plachno wrote: ... diff --git a/drivers/net/ethernet/intel/ice/ice_fdir.c b/drivers/net/ethernet/intel/ice/ice_fdir.c index 1f7b26f38818..ec8a84b80a73 100644 --- a/drivers/net/ethernet/intel/ice/ice_fdir

Re: [Intel-wired-lan] [PATCH iwl-next v7 2/2] ice: Implement 'flow-type ether' rules

2024-02-29 Thread Plachno, Lukasz
On 2/12/2024 12:03 PM, Lukasz Plachno wrote: From: Jakub Buchocki Add support for 'flow-type ether' Flow Director rules via ethtool. Create packet segment info for filter configuration based on ethtool command parameters. Reuse infrastructure already created for ipv4 and ipv6 flows to convert