Hi,
This is second patchset split from subfunction patchset [1].
Important changes from previous version:
* remove unnecessary checks for devlink port type
* link correct devlink port to subfunction netdev
Follow up patchset with subfunction port representor will be the last
patchset for subfun
subfunction.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_base.c| 5 +++-
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
drivers/net/ethernet/intel/ice/ice_lib.c
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h
Signed-off-by: Jacob Keller
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 3 +
.../ethernet/intel/ice/devlink/devlink_port.c | 454 ++
.../ethernet/intel/ice/devlink/devlink_port.h | 30 ++
drivers/net
port
creation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 47 ++---
.../net/ethernet/intel/ice/devlink/devlink.h | 1 +
.../ethernet/intel/ice/devlink/devlink_port.c | 51 +++
.../ethernet
From: Piotr Raczynski
Implement subfunction driver. It is probe when subfunction port is
activated.
VSI is already created. During the probe VSI is being configured.
MAC unicast and broadcast filter is added to allow traffic to pass.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice
From: Piotr Raczynski
Use previously implemented SF aux driver. It is probe during SF
activation and remove after deactivation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 7 ++
.../ethernet/intel/ice/devlink
On Fri, Apr 12, 2024 at 01:44:45PM +0200, Przemek Kitszel wrote:
> On 4/12/24 08:30, Michal Swiatkowski wrote:
> > From: Piotr Raczynski
> >
> > Implement subfunction driver. It is probe when subfunction port is
> > activated.
> >
> > VSI is already
; >
> >Reviewed-by: Wojciech Drewek
> >Co-developed-by: Jacob Keller
> >Signed-off-by: Jacob Keller
> >Signed-off-by: Piotr Raczynski
> >Signed-off-by: Michal Swiatkowski
> >---
> > .../net/ethernet/intel/ice/devlink/devlink.c | 3 +
> > .
unction for SF devlink port creation. It will be used in next
> >patch.
> >
> >Create header file for subfunction device. Define subfunction device
> >structure there as it is needed for devlink allocation and port
> >creation.
> >
> >Signed-off-by: Piotr Racz
On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote:
> Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri Pirko wrote:
> >> Fri, Apr 12, 2024 at 08:30:49AM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
On Tue, Apr 16, 2024 at 07:14:43AM +0200, Michal Swiatkowski wrote:
> On Mon, Apr 15, 2024 at 11:10:50AM +0200, Jiri Pirko wrote:
> > Mon, Apr 15, 2024 at 10:39:39AM CEST, michal.swiatkow...@linux.intel.com
> > wrote:
> > >On Fri, Apr 12, 2024 at 09:12:18AM +0200, Jiri
.339795-1-michal.swiatkow...@linux.intel.com/
Michal Swiatkowski (1):
ice: treat subfunction VSI the same as PF VSI
Piotr Raczynski (7):
ice: add new VSI type for subfunctions
ice: export ice ndo_ops functions
ice: add basic devlink subfunctions support
ice: allocate devlink for subfunction
subfunction.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_base.c| 5 +++-
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
drivers/net/ethernet/intel/ice/ice_lib.c
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h
When subfunction VSI is open the same code as for PF VSI should be
executed. Also when up is complete. Reflect that in code by adding
subfunction VSI to consideration.
In case of stopping, PF doesn't have additional tasks, so the same
is with subfunction VSI.
Signed-off-by: Michal Swiatk
Signed-off-by: Jacob Keller
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 3 +
.../ethernet/intel/ice/devlink/devlink_port.c | 347 ++
.../ethernet/intel/ice/devlink/devlink_port.h | 30 ++
drivers/net
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
drivers/net/ethernet/intel/ice/ice_main.c | 10 ++
drivers/net/ethernet/intel/ice/ice_sf_eth.c | 140
drivers/net/ethernet/intel/ice/ice_sf_eth.h | 9 ++
4 files changed, 160
port
creation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 47 ++---
.../net/ethernet/intel/ice/devlink/devlink.h | 1 +
.../ethernet/intel/ice/devlink/devlink_port.c | 50 +++
.../ethernet
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net
From: Piotr Raczynski
Use previously implemented SF aux driver. It is probe during SF
activation and remove after deactivation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 106 ++
.../ethernet/intel/ice
s,
> + fltr->extack))
> + return -EOPNOTSUPP;
> }
>
Thanks,
Reviewed-by: Michal Swiatkowski
> if (addr_type == FLOW_DISSECTOR_KEY_IPV4_ADDRS) {
> --
> 2.43.0
>
On Thu, Apr 18, 2024 at 11:12:47AM +0300, Shay Drori wrote:
> resend as plain test
>
> On 18/04/2024 10:53, Shay Drori wrote:
> > On 17/04/2024 17:20, Michal Swiatkowski wrote:
> > > +/**
> > > + * ice_devlink_port_fn_state_get - devlink handler for port stat
On Thu, Apr 18, 2024 at 02:04:21PM +0200, Jiri Pirko wrote:
> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >From: Piotr Raczynski
>
> [...]
>
> >+/**
> >+ * ice_allocate_sf - Allocate devlink and return SF structure pointer
> >+ * @dev: the device to alloc
On Thu, Apr 18, 2024 at 03:02:49PM +0200, Jiri Pirko wrote:
> Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, Apr 18, 2024 at 02:04:21PM +0200, Jiri Pirko wrote:
> >> Wed, Apr 17, 2024 at 04:20:25PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
On Thu, Apr 18, 2024 at 03:02:21PM +0200, Jiri Pirko wrote:
> Wed, Apr 17, 2024 at 04:20:26PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >From: Piotr Raczynski
>
> [...]
>
>
> >+static int ice_sf_dev_probe(struct auxiliary_device *adev,
> >+const struct auxilia
On Thu, Apr 18, 2024 at 10:57:17AM +0300, Shay Drori wrote:
>
> On 17/04/2024 17:20, Michal Swiatkowski wrote:
> > From: Piotr Raczynski
> >
> > Implement subfunction driver. It is probe when subfunction port is
> > activated.
> >
> > VSI is alre
On Thu, Apr 18, 2024 at 05:43:25PM +0200, Jiri Pirko wrote:
> Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, Apr 18, 2024 at 03:02:49PM +0200, Jiri Pirko wrote:
> >> Thu, Apr 18, 2024 at 02:48:53PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
etdev/20240213072724.77275-1-michal.swiatkow...@linux.intel.com/
Michal Swiatkowski (4):
ice: store representor ID in bridge port
ice: move devlink locking outside the port creation
ice: move VSI configuration outside repr setup
ice: update representor when VSI is ready
.../net/ethernet/intel/ice/de
It is used to get representor structure during cleaning.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_eswitch_br.c | 4 +++-
drivers/net/ethernet/intel/ice/ice_eswitch_br.h | 1 +
drivers/net/ethernet/intel/ice/ice_repr.c | 7
In case of subfunction lock will be taken for whole port creation. Do
the same in VF case.
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 --
drivers/net/ethernet/intel/ice/devlink/devlink_port.c | 4 ++--
drivers/net/ethernet/intel/ice
It is needed because subfunction port representor shouldn't configure
the source VSI during representor creation.
Move the code to separate function and call it only in case the VF port
representor is being created.
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/inte
-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_eswitch.c | 21 +---
drivers/net/ethernet/intel/ice/ice_eswitch.h | 4 ++--
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +-
3 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/
On Thu, Apr 18, 2024 at 07:25:35PM +0200, Jiri Pirko wrote:
> Thu, Apr 18, 2024 at 06:11:38PM CEST, michal.swiatkow...@linux.intel.com
> wrote:
> >On Thu, Apr 18, 2024 at 05:43:25PM +0200, Jiri Pirko wrote:
> >> Thu, Apr 18, 2024 at 04:46:23PM CEST, michal.swiatkow...@linux.intel.com
> >> wrote:
kdoc in ice_eswitch_cfg_vsi
[1]
https://lore.kernel.org/netdev/20240213072724.77275-1-michal.swiatkow...@linux.intel.com/
[2]
https://lore.kernel.org/netdev/20240419171336.11617-1-michal.swiatkow...@linux.intel.com/
Michal Swiatkowski (4):
ice: store representor ID in bridge port
ice: move devlink
It is used to get representor structure during cleaning.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_eswitch_br.c | 4 +++-
drivers/net/ethernet/intel/ice/ice_eswitch_br.h | 1 +
drivers/net/ethernet/intel/ice/ice_repr.c | 7
In case of subfunction lock will be taken for whole port creation. Do
the same in VF case.
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/devlink/devlink.c | 2 --
drivers/net/ethernet/intel/ice/devlink/devlink_port.c | 4 ++--
drivers/net/ethernet/intel/ice
It is needed because subfunction port representor shouldn't configure
the source VSI during representor creation.
Move the code to separate function and call it only in case the VF port
representor is being created.
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/inte
-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_eswitch.c | 21 +---
drivers/net/ethernet/intel/ice/ice_eswitch.h | 4 ++--
drivers/net/ethernet/intel/ice/ice_vf_lib.c | 2 +-
3 files changed, 17 insertions(+), 10 deletions(-)
diff --git a/drivers/net/ethernet/intel/
On Wed, Apr 24, 2024 at 02:08:11PM -0700, Tony Nguyen wrote:
>
>
> On 4/19/2024 10:13 AM, Michal Swiatkowski wrote:
>
> > +/**
> > + * ice_eswitch_cfg_vsi - configure VSI to work in slow-path
> > + * @vsi: VSI structure of representee
> > + * @mac: represent
the code.
Most recent previous patchset (not containing port representor for SF
support). [1]
[1]
https://lore.kernel.org/netdev/20240417142028.2171-1-michal.swiatkow...@linux.intel.com/
Michal Swiatkowski (7):
ice: treat subfunction VSI the same as PF VSI
ice: create port representor for SF
subfunction.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_base.c| 5 +++-
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
drivers/net/ethernet/intel/ice/ice_lib.c
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h
Signed-off-by: Jacob Keller
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 3 +
.../ethernet/intel/ice/devlink/devlink_port.c | 357 ++
.../ethernet/intel/ice/devlink/devlink_port.h | 33 ++
drivers/net
When subfunction VSI is open the same code as for PF VSI should be
executed. Also when up is complete. Reflect that in code by adding
subfunction VSI to consideration.
In case of stopping, PF doesn't have additional tasks, so the same
is with subfunction VSI.
Signed-off-by: Michal Swiatk
port
creation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 33
.../net/ethernet/intel/ice/devlink/devlink.h | 1 +
.../ethernet/intel/ice/devlink/devlink_port.c | 50 +++
.../ethernet/intel
for VF
pointer. Make union of subfunction and VF pointer as only one of them
can be set with one VSI.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
drivers/net/ethernet/intel/ice/ice.h| 7
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net
happens in case of SF port
representor. SF port representor is always added or removed with devlink
lock taken. Doing the same with VF port representor simplify logic.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 6
Add check for subfunction before setting target VSI. It is needed for PF
in switchdev mode but not for subfunction (even in switchdev mode).
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Now there is another type of port representor. Correct checking if
parent device is ready to reflect also new PR type.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++
drivers/net/ethernet/intel/ice/ice_repr.c| 12
Subfunction port representor needs the basic netdevice ops to work
correctly. Create them.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_repr.c | 57 +--
1 file changed, 43 insertions(+), 14 deletions(-)
diff --git a
as taken before to not do it twice.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/devlink/devlink.c | 12
.../net/ethernet/intel/ice/devlink/devlink_port.c| 3 ++-
drivers/net/ethernet/intel/ice/ic
Implement add / delete vlan for subfunction type VSI.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
.../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 +++
.../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h
From: Piotr Raczynski
Use previously implemented SF aux driver. It is probe during SF
activation and remove after deactivation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 108 ++
.../ethernet/intel/ice
e where a specific number is not
> >required. It may also be slightly faster to check that a number exists
> >since xarray lookup should be faster than a linear scan of the dyn_ports
> >xarray.
> >
> >Reviewed-by: Wojciech Drewek
> >Co-developed-by:
as only one of them
> >can be set with one VSI.
> >
> >Reviewed-by: Jiri Pirko
> >Signed-off-by: Piotr Raczynski
> >Signed-off-by: Michal Swiatkowski
>
> Perhaps it would make things clearer for reviewer to have all patches
> related to sf auxdev/devlink/netdev
links to previous ones. I didn't add changlog here as it is
new patchset (partialy the same as from [1], because of that I added a
link). I can add the changlog from [1] if you want, but for me it can be
missleading.
>
> >Michal Swiatkowski (7):
> > ice: treat subfunction VSI t
T, michal.swiatkow...@linux.intel.com
> wrote:
> >Subfunction port representor needs the basic netdevice ops to work
> >correctly. Create them.
> >
> >Reviewed-by: Wojciech Drewek
> >Signed-off-by: Michal Swiatkowski
> >---
> > drivers/net/ethernet/i
>representor. SF port representor is always added or removed with devlink
> >lock taken. Doing the same with VF port representor simplify logic.
> >
> >Reviewed-by: Wojciech Drewek
> >Signed-off-by: Michal Swiatkowski
> >---
> > .../ethernet/intel/ic
and remove after deactivation.
> >
> >Signed-off-by: Piotr Raczynski
> >Signed-off-by: Michal Swiatkowski
> >---
> > .../ethernet/intel/ice/devlink/devlink_port.c | 108 ++
> > .../ethernet/intel/ice/devlink/devlink_port.h | 6 +
> > drivers/net/e
s
> >> >will find the first free index and use that as the number. This reduces
> >> >burden on users in the simple case where a specific number is not
> >> >required. It may also be slightly faster to check that a number exists
> >> >since xarray lookup s
;> >representor. SF port representor is always added or removed with devlink
> >> >lock taken. Doing the same with VF port representor simplify logic.
> >> >
> >> >Reviewed-by: Wojciech Drewek
> >> >Signed-off-by: Michal Swiatkowski
> >> >
>> that came through multiple iterations alread. Changelog is missing
> >> completely :/
> >>
> >
> >What is wrong here? There is a link to previous patchset with whole
> >changlog and links to previous ones. I didn't add changlog here as it is
>
12063053.339795-1-michal.swiatkow...@linux.intel.com/
Michal Swiatkowski (8):
ice: treat subfunction VSI the same as PF VSI
ice: make reprresentor code generic
ice: create port representor for SF
ice: don't set target VSI for subfunction
ice: check if SF is ready in ethtool ops
ice: i
subfunction.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_base.c| 5 +++-
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
drivers/net/ethernet/intel/ice/ice_lib.c
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h
When subfunction VSI is open the same code as for PF VSI should be
executed. Also when up is complete. Reflect that in code by adding
subfunction VSI to consideration.
In case of stopping, PF doesn't have additional tasks, so the same
is with subfunction VSI.
Signed-off-by: Michal Swiatk
. It may also be slightly faster to check that a number exists
since xarray lookup should be faster than a linear scan of the dyn_ports
xarray.
Reviewed-by: Wojciech Drewek
Co-developed-by: Jacob Keller
Signed-off-by: Jacob Keller
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
port
creation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 33
.../net/ethernet/intel/ice/devlink/devlink.h | 1 +
.../ethernet/intel/ice/devlink/devlink_port.c | 50 +++
.../ethernet/intel
for VF
pointer. Make union of subfunction and VF pointer as only one of them
can be set with one VSI.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
drivers/net/ethernet/intel/ice/ice.h| 7
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net
saved in port representor structure.
Add devlink lock for whole port representor creation and destruction.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.h | 1 +
drivers/net/ethernet/intel/ice/ice_eswitch.c | 74
Implement attaching and detaching SF port representor. It is done in the
same way as the VF port representor.
SF port representor is always added or removed with devlink
lock taken.
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 6 +--
drivers/net
Add check for subfunction before setting target VSI. It is needed for PF
in switchdev mode but not for subfunction (even in switchdev mode).
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Now there is another type of port representor. Correct checking if
parent device is ready to reflect also new PR type.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++
drivers/net/ethernet/intel/ice/ice_repr.c| 12
Subfunction port representor needs the basic netdevice ops to work
correctly. Create them.
Reviewed-by: Wojciech Drewek
Reviewed-by: Jiri Pirko
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_repr.c | 57 +--
1 file changed, 43 insertions(+), 14
as taken before to not do it twice.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/devlink/devlink.c | 12
.../net/ethernet/intel/ice/devlink/devlink_port.c| 3 ++-
drivers/net/ethernet/intel/ice/ic
Implement add / delete vlan for subfunction type VSI.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
.../ethernet/intel/ice/ice_sf_vsi_vlan_ops.c | 21 +++
.../ethernet/intel/ice/ice_sf_vsi_vlan_ops.h
From: Piotr Raczynski
Use previously implemented SF aux driver. It is probe during SF
activation and remove after deactivation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 173 ++
.../ethernet/intel/ice
On Mon, May 13, 2024 at 02:55:48PM +0530, Kalesh Anakkur Purayil wrote:
> On Mon, May 13, 2024 at 2:03 PM Michal Swiatkowski
> wrote:
> >
> > From: Piotr Raczynski
> >
> > Make devlink allocation function generic to use it for PF and for SF.
> >
> > Add
On Mon, May 13, 2024 at 01:04:23PM +0200, Jiri Pirko wrote:
> Mon, May 13, 2024 at 10:37:23AM CEST, michal.swiatkow...@linux.intel.com
> wrote:
>
> [...]
>
>
>
> >+int ice_devlink_create_sf_port(struct ice_dynamic_port *dyn_port)
> >+{
> >+struct devlink_port_attrs attrs = {};
> >+stru
On Mon, May 13, 2024 at 05:05:51PM +0100, Simon Horman wrote:
> On Mon, May 13, 2024 at 10:37:23AM +0200, Michal Swiatkowski wrote:
>
> ...
>
> > diff --git a/drivers/net/ethernet/intel/ice/devlink/devlink_port.h
> > b/drivers/net/ethernet/intel/ice/devlink/devlink_port.
On Mon, May 13, 2024 at 05:09:47PM +0100, Simon Horman wrote:
> On Mon, May 13, 2024 at 10:37:28AM +0200, Michal Swiatkowski wrote:
> > Keep the same flow of port representor creation, but instead of general
> > attach function create helpers for specific representor type.
> >
On Wed, May 15, 2024 at 01:55:42PM +0200, Harald Welte wrote:
> Daer Alexander, Wojciech,
Hi Harald,
>
> forgive me for being late to the party, but I just saw the PFCP support
> hitting Linus'' git repo in 1b294a1f35616977caddaddf3e9d28e576a1adbc
> and was trying to figure out what it is all ab
On Thu, May 16, 2024 at 11:30:00PM +0200, Harald Welte wrote:
> Hi Michal,
>
> thanks for your response.
>
> On Thu, May 16, 2024 at 12:44:13PM +0200, Michal Swiatkowski wrote:
>
> > > I'm curious to understand why are *pfcp* packets hardware offloaded?
>
43-1-michal.swiatkow...@linux.intel.com/
[3]
https://lore.kernel.org/netdev/20240412063053.339795-1-michal.swiatkow...@linux.intel.com/
[4]
https://lore.kernel.org/netdev/20240408103049.19445-1-michal.swiatkow...@linux.intel.com/
[5]
https://lore.kernel.org/netdev/20240513083735.54791-1-michal.swiatkow...@linu
subfunction.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_base.c| 5 +++-
drivers/net/ethernet/intel/ice/ice_dcb_lib.c | 1 +
drivers/net/ethernet/intel/ice/ice_lib.c
From: Piotr Raczynski
Make some of the netdevice_ops functions visible from outside for
another VSI type created netdev.
Reviewed-by: Przemek Kitszel
Reviewed-by: Wojciech Drewek
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice.h
. It may also be slightly faster to check that a number exists
since xarray lookup should be faster than a linear scan of the dyn_ports
xarray.
Reviewed-by: Wojciech Drewek
Co-developed-by: Jacob Keller
Signed-off-by: Jacob Keller
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
When subfunction VSI is open the same code as for PF VSI should be
executed. Also when up is complete. Reflect that in code by adding
subfunction VSI to consideration.
In case of stopping, PF doesn't have additional tasks, so the same
is with subfunction VSI.
Signed-off-by: Michal Swiatk
port
creation.
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
.../net/ethernet/intel/ice/devlink/devlink.c | 33 +++
.../net/ethernet/intel/ice/devlink/devlink.h | 1 +
.../ethernet/intel/ice/devlink/devlink_port.c | 41 +++
.../ethernet/intel
for VF
pointer. Make union of subfunction and VF pointer as only one of them
can be set with one VSI.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/Makefile | 1 +
drivers/net/ethernet/intel/ice/ice.h| 7
From: Piotr Raczynski
Configure netdevice for subfunction usecase. Mostly it is reusing ops
from the PF netdevice.
SF netdev is linked to devlink port registered after SF activation.
Reviewed-by: Jiri Pirko
Signed-off-by: Piotr Raczynski
Signed-off-by: Michal Swiatkowski
---
drivers/net
saved in port representor structure.
Add devlink lock for whole port representor creation and destruction.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.h | 2 +
drivers/net/ethernet/intel/ice/ice_eswitch.c | 74
Implement attaching and detaching SF port representor. It is done in the
same way as the VF port representor.
SF port representor is always added or removed with devlink
lock taken.
Signed-off-by: Michal Swiatkowski
---
.../ethernet/intel/ice/devlink/devlink_port.c | 6 +--
drivers/net
Add check for subfunction before setting target VSI. It is needed for PF
in switchdev mode but not for subfunction (even in switchdev mode).
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_txrx.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a
Now there is another type of port representor. Correct checking if
parent device is ready to reflect also new PR type.
Reviewed-by: Wojciech Drewek
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_ethtool.c | 7 +++
drivers/net/ethernet/intel/ice/ice_repr.c| 12
Subfunction port representor needs the basic netdevice ops to work
correctly. Create them.
Reviewed-by: Wojciech Drewek
Reviewed-by: Jiri Pirko
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ice/ice_repr.c | 57 +--
1 file changed, 43 insertions(+), 14
1 - 100 of 430 matches
Mail list logo
