Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-04 Thread Lorenzo Bianconi
On Oct 04, Jesper Dangaard Brouer wrote: > > > On 04/10/2024 15.55, Arthur Fabre wrote: > > On Fri Oct 4, 2024 at 12:38 PM CEST, Jesper Dangaard Brouer wrote: > > > [...] > > > > > > There are two different use-cases for the metadata: > > > > > > > > > > > > * "Hardware" metadata (like the hash,

[Intel-wired-lan] [RFC bpf-next 1/4] net: xdp: Add xdp_rx_meta structure

2024-09-21 Thread Lorenzo Bianconi
been populated by the driver. This is a preliminary patch to preserve xdp rx hints running XDP_REDIRECT. Signed-off-by: Lorenzo Bianconi --- include/net/xdp.h | 31 +++ 1 file changed, 31 insertions(+) diff --git a/include/net/xdp.h b/include/net/xdp.h index

[Intel-wired-lan] [RFC bpf-next 4/4] net: xdp: Update rx timestamp of xdp_rx_meta struct running xmo_rx_timestamp callback

2024-09-21 Thread Lorenzo Bianconi
sk_buff. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 3 +++ drivers/net/ethernet/intel/igc/igc_main.c | 3 +++ drivers/net/ethernet/mellanox/mlx4/en_rx.c| 2 ++ .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 3 +++ .../net/ethernet/stmicro

[Intel-wired-lan] [RFC bpf-next 2/4] net: xdp: Update rx_hash of xdp_rx_meta struct running xmo_rx_hash callback

2024-09-21 Thread Lorenzo Bianconi
sk_buff. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/intel/ice/ice_txrx_lib.c | 3 +++ drivers/net/ethernet/intel/igc/igc_main.c | 2 ++ drivers/net/ethernet/mellanox/mlx4/en_rx.c| 1 + .../net/ethernet/mellanox/mlx5/core/en/xdp.c | 2 ++ drivers/net/veth.c

[Intel-wired-lan] [RFC bpf-next 3/4] net: xdp: Update rx_vlan of xdp_rx_meta struct running xmo_rx_vlan_tag callback

2024-09-21 Thread Lorenzo Bianconi
sk_buff. Signed-off-by: Lorenzo Bianconi --- drivers/net/ethernet/intel/ice/ice_txrx_lib.c| 3 +++ drivers/net/ethernet/mellanox/mlx5/core/en/xdp.c | 3 +++ drivers/net/veth.c | 3 +++ include/net/xdp.h| 14 ++ net/core

[Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-21 Thread Lorenzo Bianconi
to set the skb metadata converting the xdp_buff/xdp_frame to a skb. Update xdp_metadata_ops callbacks for the following drivers: - ice - igc - mlx5 - mlx4 - veth - virtio_net - stmmac Lorenzo Bianconi (4): net: xdp: Add xdp_rx_meta structure net: xdp: Update rx_hash of xdp_rx_meta struct

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-22 Thread Lorenzo Bianconi
> From: Lorenzo Bianconi > Date: Sat, 21 Sep 2024 18:52:56 +0200 > > > This series introduces the xdp_rx_meta struct in the xdp_buff/xdp_frame > > &xdp_buff is on the stack. > &xdp_frame consumes headroom. ack, right. > > IOW they're size-sensitiv

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-22 Thread Lorenzo Bianconi
> > > On 21/09/2024 22.17, Alexander Lobakin wrote: > > From: Lorenzo Bianconi > > Date: Sat, 21 Sep 2024 18:52:56 +0200 > > > > > This series introduces the xdp_rx_meta struct in the xdp_buff/xdp_frame > > > > &xdp_buff is on the stack. &g

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-22 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> > >> > >> On 21/09/2024 22.17, Alexander Lobakin wrote: > >> > From: Lorenzo Bianconi > >> > Date: Sat, 21 Sep 2024 18:52:56 +0200 > >> > > >> > > This series introduces

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-26 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> I'm hinting at some complications here (with the EFAULT return) that > >> needs to be resolved: there is no guarantee that a given packet will be > >> in sync with the current status of the registered metadata, so we

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-27 Thread Lorenzo Bianconi
On Sep 27, Arthur Fabre wrote: > On Fri Sep 27, 2024 at 12:24 PM CEST, Toke Høiland-Jørgensen wrote: > > "Arthur Fabre" writes: > > > > >> >> The nice thing about an API like this, though, is that it's > > >> >> extensible, > > >> >> and the kernel itself can be just another consumer of it for th

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-30 Thread Lorenzo Bianconi
> Lorenzo Bianconi writes: > > >> > We could combine such a registration API with your header format, so > >> > that the registration just becomes a way of allocating one of the keys > >> > from 0-63 (and the registry just becomes a global copy of the h

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-10-01 Thread Lorenzo Bianconi
> On Mon Sep 30, 2024 at 1:49 PM CEST, Lorenzo Bianconi wrote: > > > Lorenzo Bianconi writes: > > > > > > >> > We could combine such a registration API with your header format, so > > > >> > that the registration just becomes a way of al