Re: [Intel-wired-lan] [bug report] idpf: add core init and interrupt request

2024-07-19 Thread Linga, Pavan Kumar
On 7/19/2024 4:53 PM, Dan Carpenter wrote: Hello Pavan Kumar Linga, Commit 4930fbf419a7 ("idpf: add core init and interrupt request") from Aug 7, 2023 (linux-next), leads to the following Smatch static checker warning: drivers/net/ethernet/intel/idpf/idpf_lib.c:417 idpf_intr_req()

Re: [Intel-wired-lan] [[PATCH v2 iwl-next] v2 2/4] idpf: Acquire the lock before accessing the xn->salt

2024-08-29 Thread Linga, Pavan Kumar
On 8/26/2024 11:10 AM, Manoj Vishwanathan wrote: The transaction salt was being accessed before acquiring the idpf_vc_xn_lock when idpf has to forward the virtchnl reply. Fixes: 34c21fa894a1a (“idpf: implement virtchnl transaction manager”) Signed-off-by: Manoj Vishwanathan Reviewed-by: Pa

Re: [Intel-wired-lan] [[PATCH v2 iwl-next] v2 3/4] idpf: convert workqueues to unbound

2024-08-29 Thread Linga, Pavan Kumar
On 8/26/2024 11:10 AM, Manoj Vishwanathan wrote: From: Marco Leogrande When a workqueue is created with `WQ_UNBOUND`, its work items are served by special worker-pools, whose host workers are not bound to any specific CPU. In the default configuration (i.e. when `queue_delayed_work` and frie

Re: [Intel-wired-lan] [[PATCH v2 iwl-next] v2 4/4] idpf: add more info during virtchnl transaction time out

2024-08-29 Thread Linga, Pavan Kumar
On 8/26/2024 11:10 AM, Manoj Vishwanathan wrote: Add more information related to the transaction like cookie, vc_op, salt when transaction times out and include similar information when transaction salt does not match. Info output for transaction timeout: --- (op:5015 cookie:4

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: avoid compiler padding in virtchnl2_ptype struct

2023-12-28 Thread Linga, Pavan Kumar
On 12/27/2023 1:45 PM, Paul Menzel wrote: Dear Pavan, Thank you for yoru patch. Am 27.12.23 um 18:37 schrieb Pavan Kumar Linga: Config option in arm random config file Sorry, I do not understand this part of the sentence. What Kconfig option was selected exactly causing this behavior.

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: avoid compiler padding in virtchnl2_ptype struct

2024-01-04 Thread Linga, Pavan Kumar
On 12/28/2023 9:39 AM, Linga, Pavan Kumar wrote: On 12/27/2023 1:45 PM, Paul Menzel wrote: Dear Pavan, Thank you for yoru patch. Am 27.12.23 um 18:37 schrieb Pavan Kumar Linga: Config option in arm random config file Sorry, I do not understand this part of the sentence. What Kconfig

Re: [Intel-wired-lan] [PATCH iwl-next v1] idpf: cancel mailbox work in error path

2023-10-05 Thread Linga, Pavan Kumar
On 10/5/2023 10:25 AM, Tony Nguyen wrote: On 10/4/2023 3:06 PM, Pavan Kumar Linga wrote: In idpf_vc_core_init, the mailbox work is queued on a mailbox workqueue but it is not cancelled on error. This results in a call trace when idpf_mbx_task tries to access the freed mailbox queue pointer.

Re: [Intel-wired-lan] [PATCH iwl-net 2/2] idpf: fix idpf_vc_core_init error path

2024-10-25 Thread Linga, Pavan Kumar
On 10/24/2024 7:39 AM, Simon Horman wrote: On Tue, Oct 22, 2024 at 10:35:27AM -0700, Pavan Kumar Linga wrote: In an event where the platform running the device control plane is rebooted, reset is detected on the driver. It releases all the resources and waits for the reset to complete. Once t