Re: [Intel-wired-lan] [PATCH net-next v8 1/8] net: ethtool: pass a pointer to parameters to get/set_rxfh ethtool ops

2023-12-07 Thread Kiyanovski, Arthur
> The get/set_rxfh ethtool ops currently takes the rxfh (RSS) parameters > as direct function arguments. This will force us to change the API (and > all drivers' functions) every time some new parameters are added. > > This is part 1/2 of the fix, as suggested in [1]: > > - First simplify the c

Re: [Intel-wired-lan] [PATCH 2/3] treewide: Convert some ethtool_sprintf() to ethtool_puts()

2023-10-30 Thread Kiyanovski, Arthur
> -Original Message- > From: Przemek Kitszel > Sent: Thursday, October 26, 2023 12:24 PM > To: Justin Stitt ; David S. Miller > ; Eric Dumazet ; Jakub > Kicinski ; Paolo Abeni ; Agroskin, Shay > ; Kiyanovski, Arthur ; Arinzon, > David ; Dagan, Noam ; >

Re: [Intel-wired-lan] [PATCH net-next v4 3/3] net: Convert some ethtool_sprintf() to ethtool_puts()

2023-11-02 Thread Kiyanovski, Arthur
> -Original Message- > From: Justin Stitt > Sent: Thursday, November 2, 2023 8:56 PM > To: David S. Miller ; Eric Dumazet > ; Jakub Kicinski ; Paolo Abeni > ; Agroskin, Shay ; Kiyanovski, > Arthur ; Arinzon, David ; > Dagan, Noam ; Bshara, Saeed > ; Rasesh

Re: [Intel-wired-lan] [resend PATCH 2/2] dim: pass dim_sample to net_dim() by reference

2024-11-01 Thread Kiyanovski, Arthur
> -Original Message- > From: Caleb Sander Mateos > Sent: Wednesday, October 30, 2024 5:23 PM > > net_dim() is currently passed a struct dim_sample argument by value. > struct dim_sample is 24 bytes. Since this is greater 16 bytes, x86-64 passes > it > on the stack. All callers have alrea

Re: [Intel-wired-lan] [resend PATCH 1/2] dim: make dim_calc_stats() inputs const pointers

2024-11-01 Thread Kiyanovski, Arthur
On 10/30/24 17:23, Caleb Sander Mateos wrote: > Make the start and end arguments to dim_calc_stats() const pointers to > clarify that the function does not modify their values. > > Signed-off-by: Caleb Sander Mateos Reviewed-by: Arthur Kiyanovski Thanks, Arthur