On Mon, May 13, 2024 at 2:03 PM Michal Swiatkowski
wrote:
>
> From: Piotr Raczynski
>
> Make devlink allocation function generic to use it for PF and for SF.
>
> Add function for SF devlink port creation. It will be used in next
> patch.
>
> Create header file for subfunction device. Define subfu
On Mon, May 13, 2024 at 3:54 PM Michal Swiatkowski
wrote:
>
> On Mon, May 13, 2024 at 02:55:48PM +0530, Kalesh Anakkur Purayil wrote:
> > On Mon, May 13, 2024 at 2:03 PM Michal Swiatkowski
> > wrote:
> > >
> > > From: Piotr Raczynski
> > >
> >
Hi David,
One question in line.
On Mon, Aug 12, 2024 at 3:52 PM Dawid Osuchowski
wrote:
>
> Ethtool callbacks can be executed while reset is in progress and try to
> access deleted resources, e.g. getting coalesce settings can result in a
> NULL pointer dereference seen below.
>
> Once the drive
On Wed, Dec 6, 2023 at 6:32 AM Jesse Brandeburg
wrote:
> It was found while doing further testing of the previous commit
> fbf32a9bab91 ("ice: field get conversion") that one of the FIELD_GET
> conversions should really be a FIELD_PREP. The previous code was styled
> as a match to the FIELD_GET c
On Wed, Dec 13, 2023 at 11:57 PM Jesse Brandeburg <
jesse.brandeb...@intel.com> wrote:
> Please don't use HTML email, your reply was likely dropped by most lists
> that filter HTML.
>
Sure, I will check.
>
> On 12/12/2023 8:06 PM, Kalesh Anakkur Purayil wrote:
&
On Mon, Mar 18, 2024 at 8:01 PM Ivan Vecera wrote:
>
> The field is initialized always to zero and it is never read.
> Remove it.
>
> Signed-off-by: Ivan Vecera
> ---
LGTM
Reviewed-by: Kalesh AP
> drivers/net/ethernet/intel/i40e/i40e.h | 3 +--
> drivers/net/ethernet/intel/i40e/i40e_d
On Wed, Mar 27, 2024 at 1:28 PM Ivan Vecera wrote:
>
> Commit 07d44190a389 ("i40e/i40evf: Detect and recover hung queue
> scenario") changes i40e_detect_recover_hung() argument type from
> i40e_pf* to i40e_vsi* to be shareable by both i40e and i40evf.
> Because the i40evf does not exist anymore an
On Tue, Mar 26, 2024 at 6:07 AM Michal Schmidt wrote:
>
> This is a cleanup. It is unnecessary to have this function just to call
> another function.
>
> Reviewed-by: Przemek Kitszel
> Signed-off-by: Michal Schmidt
Reviewed-by: Kalesh AP
> ---
> drivers/net/ethernet/intel/ice/ice_ptp.c | 25 +
On Fri, Oct 4, 2024 at 12:25 PM Michal Swiatkowski
wrote:
>
> There is no support for SF in legacy mode. Reflect it in the code.
>
> Reviewed-by: Przemek Kitszel
> Fixes: eda69d654c7e ("ice: add basic devlink subfunctions support")
> Signed-off-by: Michal Swiatkowski
LGTM,
Reviewed-by: Kalesh A
On Thu, Oct 3, 2024 at 7:49 PM Piotr Kwapulinski
wrote:
>
> Add low level link management support for E610 device. Link management
> operations are handled via the Admin Command Interface. Add the following
> link management operations:
> - get link capabilities
> - set up link
> - get media type
On Thu, Oct 3, 2024 at 7:48 PM Piotr Kwapulinski
wrote:
>
> Add low level support for E610 device capabilities detection. The
> capabilities are discovered via the Admin Command Interface. Discover the
> following capabilities:
> - function caps: vmdq, dcb, rss, rx/tx qs, msix, nvm, orom, reset
>
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Split ice_init_hw() call out from ice_init_dev(). Such move enables
> pulling the former to be even earlier on call path, what would enable
> moving ice_adapter init to be between the two (in subsequent commit).
> Such move enables ice_adap
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Clean up goto labels after previous commit, to conform to single naming
> scheme in ice_probe() and ice_init_dev().
>
> Reviewed-by: Marcin Szycik
> Signed-off-by: Przemek Kitszel
LGTM,
Reviewed-by: Kalesh AP
--
Regards,
Kalesh A P
On Wed, Oct 2, 2024 at 5:23 PM Przemek Kitszel
wrote:
>
> Move ice_adapter initialization to be after HW init, so it could use HW
> capabilities, like number of PFs. This is needed for devlink-resource
> based RSS LUT size management for PF/VF (not in this series).
>
> Reviewed-by: Marcin Szycik
On Sun, Dec 22, 2024 at 12:13 AM wrote:
>
> From: "Dr. David Alan Gilbert"
>
> The last use of i40e_get_cur_guaranteed_fd_count() was removed in 2015 by
> commit 04294e38a451 ("i40e: FD filters flush policy changes")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert
LGTM,
Reviewed-by: Ka
On Sun, Dec 22, 2024 at 12:16 AM wrote:
>
> From: "Dr. David Alan Gilbert"
>
> i40e_blink_phy_link_led() was added in 2016 by
> commit fd077cd3399b ("i40e: Add functions to blink led on 10GBaseT PHY")
>
> but hasn't been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert
LGTM,
Revie
On Sun, Dec 22, 2024 at 12:15 AM wrote:
>
> From: "Dr. David Alan Gilbert"
>
> i40e_commit_partition_bw_setting() was added in 2017 by
> commit 4fc8c6763957 ("i40e: genericize the partition bandwidth control")
> but hasn't been used.
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert
LGTM
On Sun, Dec 22, 2024 at 12:15 AM wrote:
>
> From: "Dr. David Alan Gilbert"
>
> The last useof i40e_dcb_hw_get_num_tc() was removed in 2022 by
> commit fe20371578ef ("Revert "i40e: Fix reset bw limit when DCB enabled
> with 1 TC"")
>
> Remove it.
>
> Signed-off-by: Dr. David Alan Gilbert
LGTM,
R
On Sat, Jan 4, 2025 at 6:13 AM Ahmed Zaki wrote:
>
> Delete the driver CPU affinity info and use the core's napi config
> instead.
>
> Signed-off-by: Ahmed Zaki
> ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.c | 26 ---
> drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 --
>
On Fri, Feb 21, 2025 at 5:37 PM Jedrzej Jagielski
wrote:
>
> Prevent from proceeding if there's nothing to print.
>
> Suggested-by: Przemek Kitszel
> Reviewed-by: Jiri Pirko
> Signed-off-by: Jedrzej Jagielski
Reviewed-by: Kalesh AP
--
Regards,
Kalesh AP
smime.p7s
Description: S/MIME Crypt
20 matches
Mail list logo
