Re: [Intel-wired-lan] [PATCH iwl-next v1] idpf: refactor some missing field get/prep conversions

2023-12-01 Thread Julia Lawall
On Fri, 1 Dec 2023, Jesse Brandeburg wrote: > On 12/1/2023 6:32 AM, Alexander Lobakin wrote: > > From: Jesse Brandeburg > > >> --- a/drivers/net/ethernet/intel/idpf/idpf_txrx.c > >> +++ b/drivers/net/ethernet/intel/idpf/idpf_txrx.c > >> @@ -505,7 +505,7 @@ static void idpf_rx_post_buf_refill(s

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-20 Thread Julia Lawall
On Wed, 20 Mar 2024, Dan Carpenter wrote: > On Tue, Mar 19, 2024 at 12:43:17PM -0700, Jakub Kicinski wrote: > > On Sat, 16 Mar 2024 12:44:40 +0300 Dan Carpenter wrote: > > > - struct ice_aqc_get_phy_caps_data *pcaps __free(kfree); > > > - void *mac_buf __free(kfree); > > > + struct ice_aqc_get_

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-21 Thread Julia Lawall
Does one prefer an initialization of null at the top of the function or an initialization to a meaningful value in the middle of the function ? (Sorry for top posting) Sent from my iPhone > On 21 Mar 2024, at 14:14, Markus Elfring wrote: > >  >> >>> How do you think about to reduce the sco

Re: [Intel-wired-lan] [PATCH net] ice: Fix freeing uninitialized pointers

2024-03-22 Thread Julia Lawall
On Thu, 21 Mar 2024, Jakub Kicinski wrote: > On Thu, 21 Mar 2024 15:27:47 -0700 Jesse Brandeburg wrote: > > The gist of it is that we should instead be using inline declarations, > > which I also agree is a reasonable style for this. It more clearly shows > > the __free(kfree) and the allocation

Re: [Intel-wired-lan] [PATCH linux-next] ice: use string choice helpers

2024-10-30 Thread Julia Lawall
On Mon, 28 Oct 2024, Przemek Kitszel wrote: > On 10/27/24 15:19, R Sundar wrote: > > Use string choice helpers for better readability. > > > > Reported-by: kernel test robot > > Reported-by: Julia Lawall > > Closes: https://lore.kernel.org/r/202410121553.s

[Intel-wired-lan] [PATCH 00/35] Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
Reorganize kerneldoc parameter names to match the parameter order in the function header. The misordered cases were identified using the following Coccinelle semantic patch: // @initialize:ocaml@ @@ let parse_doc l = let pieces = List.map String.trim (String.split_on_char '*' l) in let l =

[Intel-wired-lan] [PATCH 33/35] drivers/net/ethernet/intel: Reorganize kerneldoc parameter names

2024-09-30 Thread Julia Lawall
Reorganize kerneldoc parameter names to match the parameter order in the function header. Problems identified using Coccinelle. Signed-off-by: Julia Lawall --- drivers/net/ethernet/intel/e1000/e1000_hw.c |2 +- drivers/net/ethernet/intel/i40e/i40e_common.c |7 +++ drivers