Re: [Intel-wired-lan] [PATCH iwl-next v2 1/2] ixgbe: Refactor overtemp event handling

2023-12-08 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Friday, December 8, 2023 12:17 AM >On 12/5/2023 3:28 AM, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events via internal >> IXGBE_ERR_OVERTEMP error code. >> >> Change the approach to use freshly introduced is_overtemp function >

Re: [Intel-wired-lan] [PATCH iwl-next v3 1/2] ixgbe: Refactor overtemp event handling

2023-12-11 Thread Jagielski, Jedrzej
From: Kitszel, Przemyslaw Sent: Friday, December 8, 2023 11:07 AM >On 12/8/23 10:00, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events >> via internal IXGBE_ERR_OVERTEMP error code. >> >> Change the approach to use freshly introduced is_overtemp >> function pa

Re: [Intel-wired-lan] [PATCH iwl-next v3 1/2] ixgbe: Refactor overtemp event handling

2023-12-12 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Monday, December 11, 2023 10:35 PM >On 12/11/2023 1:45 AM, Jagielski, Jedrzej wrote: >> From: Kitszel, Przemyslaw >> Sent: Friday, December 8, 2023 11:07 AM >> >>> On 12/8/23 10:00, Jedrzej Jagielski wrote: >>>> Current

Re: [Intel-wired-lan] [PATCH iwl-next v4 1/2] ixgbe: Refactor overtemp event handling

2023-12-14 Thread Jagielski, Jedrzej
From: Simon Horman Sent: Thursday, December 14, 2023 10:56 AM >On Tue, Dec 12, 2023 at 11:46:41AM +0100, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events >> via internal IXGBE_ERR_OVERTEMP error code. >> >> Change the approach for handle_lasi() to use freshly

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: Convert ret val type from s32 to int

2024-01-10 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Friday, January 5, 2024 10:50 PM >On 1/5/2024 2:31 AM, Jedrzej Jagielski wrote: >> Currently big amount of the functions returning standard error codes >> are of type s32. Convert them to regular ints as typdefs here are >> not necessary to return standard error cod

Re: [Intel-wired-lan] [PATCH iwl-next v1 2/2] i40e-linux: Add support for reading Trace Buffer

2024-01-15 Thread Jagielski, Jedrzej
From: Jiri Pirko Sent: Friday, January 12, 2024 1:49 PM >Fri, Jan 12, 2024 at 10:59:45AM CET, jedrzej.jagiel...@intel.com wrote: >>Currently after entering FW Recovery Mode we have no info in logs >>regarding current FW state. >> >>Add function reading content of the alternate RAM storing that i

Re: [Intel-wired-lan] [PATCH iwl-next v3 3/3] ixgbe: Cleanup after type convertion

2024-01-24 Thread Jagielski, Jedrzej
From: Kitszel, Przemyslaw Sent: Thursday, January 18, 2024 3:34 PM >On 1/18/24 14:43, Jedrzej Jagielski wrote: >> Clean up code where touched during type convertion by the patch >> 8035560dbfaf. Rearrange to fix reverse Christmas tree >I don't see this SHA in my copy, please fix it. I see this

Re: [Intel-wired-lan] [PATCH iwl-next v3 1/3] ixgbe: Convert ret val type from s32 to int

2024-01-25 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Monday, January 22, 2024 10:19 PM >On 1/18/2024 5:43 AM, Jedrzej Jagielski wrote: >> Currently big amount of the functions returning standard error codes >> are of type s32. Convert them to regular ints as typdefs here are not >> necessary to return standard error c

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/2] ixgbe: Refactor overtemp event handling

2023-11-20 Thread Jagielski, Jedrzej
From: Nguyen, Anthony L Sent: Friday, November 17, 2023 12:36 AM >On 11/14/2023 1:10 AM, Jedrzej Jagielski wrote: >> Currently ixgbe driver is notified of overheating events >> via internal IXGBE_ERR_OVERTEMP erorr code. >> >> Change the approach to use is_overhaet variable >> which set when su

Re: [Intel-wired-lan] [PATCH iwl-next v1 01/13] ixgbe: add initial devlink support

2025-02-10 Thread Jagielski, Jedrzej
From: Simon Horman Sent: Friday, February 7, 2025 11:47 AM >On Mon, Feb 03, 2025 at 04:03:16PM +0100, Jedrzej Jagielski wrote: >> Add an initial support for devlink interface to ixgbe driver. >> >> Similarly to i40e driver the implementation doesn't enable >> devlink to manage device-wide config

Re: [Intel-wired-lan] [PATCH iwl-next v1 02/13] ixgbe: add handler for devlink .info_get()

2025-02-10 Thread Jagielski, Jedrzej
From: Simon Horman Sent: Sunday, February 9, 2025 5:27 PM >On Mon, Feb 03, 2025 at 04:03:17PM +0100, Jedrzej Jagielski wrote: >> Provide devlink .info_get() callback implementation to allow the >> driver to report detailed version information. The following info >> is reported: >> >> "serial_nu

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-10 Thread Jagielski, Jedrzej
From: Paul Menzel Sent: Monday, February 10, 2025 12:40 PM >Dear Jedrzej, > > >Thank you for your patch. > >Am 10.02.25 um 11:40 schrieb Jedrzej Jagielski: >> E610 NICs unlike the previous devices utilising ixgbe driver >> are notified in the case of overheatning by the FW ACI event. > >overheati

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-10 Thread Jagielski, Jedrzej
From: Paul Menzel Sent: Monday, February 10, 2025 1:07 PM >Dear Jedrzej, > > >Thank you for the quick reply. > > >Am 10.02.25 um 12:59 schrieb Jagielski, Jedrzej: >> From: Paul Menzel >> Sent: Monday, February 10, 2025 12:40 PM > >>> Am 10.02.25

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-06 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Tuesday, February 4, 2025 2:09 PM >On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: >> E610 NICs unlike the previous devices utilising ixgbe driver >> are notified in the case of overheatning by the FW ACI event. >> >> In event of overheat when treshold

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-06 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Thursday, February 6, 2025 2:59 PM >On Thu, Feb 06, 2025 at 01:05:27PM +0000, Jagielski, Jedrzej wrote: >> From: Andrew Lunn >> Sent: Tuesday, February 4, 2025 2:09 PM >> >On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: &g

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-11 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Monday, February 10, 2025 2:37 PM >> > > > Then driver >> > > > logs appropriate message and closes the adapter instance. >> > > > The card remains in that state until the platform is rebooted. >> > > >> > > As a user I’d be interested what the threshold is, and what the

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jagielski, Jedrzej
From: Jiri Pirko Sent: Monday, February 10, 2025 5:26 PM >Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: > >[...] > >>+enum ixgbe_devlink_version_type { >>+ IXGBE_DL_VERSION_FIXED, >>+ IXGBE_DL_VERSION_RUNNING, >>+}; >>+ >>+static int ixgbe_devlink_info_put(stru

Re: [Intel-wired-lan] [PATCH iwl-next v3 02/14] ixgbe: add initial devlink support

2025-02-12 Thread Jagielski, Jedrzej
From: Jiri Pirko Sent: Wednesday, February 12, 2025 4:09 PM >Wed, Feb 12, 2025 at 02:14:01PM +0100, jedrzej.jagiel...@intel.com wrote: >>Add an initial support for devlink interface to ixgbe driver. >> >>Similarly to i40e driver the implementation doesn't enable >>devlink to manage device-wide co

Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: add support for thermal sensor event reception

2025-01-16 Thread Jagielski, Jedrzej
From: Paul Menzel Sent: Wednesday, January 15, 2025 2:40 PM >Dear Jedrzej, > >Thank you for the patch. > >Am 15.01.25 um 13:27 schrieb Jedrzej Jagielski: >> E610 NICs unlike the previous devices utilising ixgbe driver >> are notified in the case of overheat by the FW ACI event. > >overheat*ing* >

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-12 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Tuesday, February 11, 2025 3:17 PM >> Actually there is only one adapter across all portfolio of ixgbe adapters >> which supports this feature. That is 82599, none other supports it. >> Even next generations (x540, x550) didn't provide support for reading thermal >> data

Re: [Intel-wired-lan] [PATCH iwl-next v3 03/14] ixgbe: add handler for devlink .info_get()

2025-02-13 Thread Jagielski, Jedrzej
From: Jiri Pirko Sent: Wednesday, February 12, 2025 4:05 PM >Wed, Feb 12, 2025 at 02:14:02PM +0100, jedrzej.jagiel...@intel.com wrote: >>Provide devlink .info_get() callback implementation to allow the >>driver to report detailed version information. The following info >>is reported: >> >> "seri

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/4] ixgbe: create E610 specific ethtool_ops structure

2025-03-03 Thread Jagielski, Jedrzej
From: Paul Menzel Sent: Friday, February 28, 2025 11:17 AM >Dear Jedrzej, > > >Thank you for your patch. > >Am 28.02.25 um 09:37 schrieb Jedrzej Jagielski: >> E610's implementation of various ethtool ops is different than >> the ones corresponding to ixgbe legacy products. Therefore create >> se

Re: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixgbe: add support for devlink reload

2025-03-06 Thread Jagielski, Jedrzej
From: Simon Horman >Sent: Thursday, March 6, 2025 10:41 AM >To: Jagielski, Jedrzej >Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L >; net...@vger.kernel.org; j...@nvidia.com; >Polchlopek, Mateusz ; Mrozowicz, SlawomirX >; Kwapulinski, Piotr >; Wegrzyn, Stefan

Re: [Intel-wired-lan] [PATCH iwl-next v7 11/15] ixgbe: add device flash update via devlink

2025-03-13 Thread Jagielski, Jedrzej
From: Simon Horman Sent: Wednesday, March 12, 2025 3:56 PM >On Wed, Mar 12, 2025 at 01:58:39PM +0100, Jedrzej Jagielski wrote: > >... > >> diff --git a/Documentation/networking/devlink/ixgbe.rst >> b/Documentation/networking/devlink/ixgbe.rst >> index a41073a62776..41aedf4b8017 100644 >> --- a/