On 4/23/2024 6:14 AM, Jiri Pirko wrote:
> Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote:
>>
>>
>>> -Original Message-
>>> From: Jiri Pirko
>>> Sent: Tuesday, April 23, 2024 1:36 PM
>>> To: Temerkhanov, Sergey
>>> Cc: intel-wired-...@lists.osuosl.org; net...@v
On 4/24/2024 8:07 AM, Jiri Pirko wrote:
> Wed, Apr 24, 2024 at 12:03:25AM CEST, jacob.e.kel...@intel.com wrote:
>>
>>
>> On 4/23/2024 6:14 AM, Jiri Pirko wrote:
>>> Tue, Apr 23, 2024 at 01:56:55PM CEST, sergey.temerkha...@intel.com wrote:
> -Original Message-
> From: Ji
On 4/26/2024 6:43 AM, Jiri Pirko wrote:
> Fri, Apr 26, 2024 at 02:49:40PM CEST, przemyslaw.kits...@intel.com wrote:
>> On 4/26/24 13:19, Jiri Pirko wrote:
>>> Wed, Apr 24, 2024 at 06:56:37PM CEST, jacob.e.kel...@intel.com wrote:
On 4/24/2024 8:07 AM, Jiri Pirko wrote:
> Wed, A
v_u64, and future
patches could implement roundup64_u64 if they need to round by a multiple
that is greater than 32-bits.
Replace the logic in ice_ptp.c which does this equivalent with the newly
added roundup_u64.
Signed-off-by: Jacob Keller
---
Changes since v1:
* add DIV_U64_ROUND_UP and use it f
Hi,
I'm attempting to widen the audience a bit for a discussion about the
ice driver and its current (ab)use and future of using auxiliary bus to
manage cross-function inter-dependencies.
I've included the latest discussion with Jiri, but the full context can
be read from lore.kernel.org:
https:
On 2/15/2024 3:02 AM, kernel.org-fo5...@ycharbi.fr wrote:
> Hello,
>
> (Please note that I don't speak English, sorry if the traction is not
> faithful to your language)
>
Hi,
I haven't touched the ixgbe driver and hardware in many years, but I'll
try to see what I can do to help.
> Follow
On 5/4/2024 6:29 AM, kernel.org-fo5...@ycharbi.fr wrote:
> Hi,
>
> > I haven't touched the ixgbe driver and hardware in many years, but I'll
> try to see what I can do to help.
>
> Thank you very much for your reply. I'll answer you point by point.
> I upgraded the Qoton to Debian 13 (testing
Host Programs" (mind the meaning of the word
>> "host"!).
>>>
>>> Oh okay, I see. `-objs` is indeed only mentioned in the host
>> chapter.
>>
>> Reviewed-by: Alexander Lobakin
>>
>> Thanks,
>> Olek
>
> Reviewed-by: Aleksandr Loktionov
Yea, reading the makefiles.rst again, it does seem that -objs only is
intended for host programs. The fact that it works now is an accident.
Further use of -y is necessary as we also use module-$(CONFIG_SYMBOL) to
resolve cases where we only include the files if the configuration is set.
Makes sense to clean this up.
Reviewed-by: Jacob Keller
vsi->num_vlan in the case where we
actually added an entry, and not in the case where the entry already
existed.
Fixes: a1ffafb0b4a4 ("ice: Support configuring the device to Double VLAN Mode")
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_vsi_vlan_lib.c |
7a8 net: intel: Use *-y instead of *-objs in
> Makefile
> @@ Commit message
>
> Let's correct the old usages of *-objs in Makefiles.
>
> -Signed-off-by: Andy Shevchenko
> -Reviewed-by: Alexander Lobakin
> Reviewed-by: Aleksand
v_u64, and future
patches could implement roundup64_u64 if they need to round by a multiple
that is greater than 32-bits.
Replace the logic in ice_ptp.c which does this equivalent with the newly
added roundup_u64.
Signed-off-by: Jacob Keller
---
Changes since v1:
* add DIV_U64_ROUND_UP and use it f
On 5/14/2024 2:55 AM, Simon Horman wrote:
> On Mon, May 13, 2024 at 12:55:47PM -0500, Thinh Tran wrote:
>> The patch fixes an issue where repeated EEH reports with a single error
>> on the bus of Intel X710 4-port 10G Base-T adapter in the MSI domain
>> causes the device to be permanently disabl
declared before being used.
>
> Tested-by: Robert Thomas
> Signed-off-by: Thinh Tran
> ---
Reviewed-by: Jacob Keller
eplaced i40e_handle_reset_warning()
> with i40e_io_resume(). This change allows the system to resume I/O
> operations
>
> Fixes: a5f3d2c17b07 ("powerpc/pseries/pci: Add MSI domains")
> Tested-by: Robert Thomas
> Signed-off-by: Thinh Tran
> ---
Thanks for moving this info to the commit message.
Reviewed-by: Jacob Keller
On 5/16/2024 4:59 AM, Simon Horman wrote:
> On Thu, May 16, 2024 at 01:43:18PM +0200, Larysa Zaremba wrote:
>> On Thu, May 16, 2024 at 09:27:13AM +0100, Simon Horman wrote:
>>> On Wed, May 15, 2024 at 06:02:16PM +0200, Larysa Zaremba wrote:
ice_pf_dcb_recfg() re-maps queues to vectors with
On 5/8/2024 5:06 AM, Hui Wang wrote:
> The commit 861e8086029e ("e1000e: move force SMBUS from enable ulp
> function to avoid PHY loss issue") introduces a regression on
> CH_MTP_I219_LM18 (PCIID: 0x8086550A). Without the referred commit, the
> ethernet works well after suspend and resume, but a
ff-by: Paul Greenwalt
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_nvm.c | 8 ++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_nvm.c
b/drivers/net/ethernet/intel/ice/ice_nvm.c
index 84eab92dc03c..9e58d319355f 100644
rwise misinterpreting NVM values.
Co-developed-by: Paul Greenwalt
Signed-off-by: Paul Greenwalt
Signed-off-by: Jacob Keller
---
Changes in v2:
- Use check_add_overflow instead of increasing the variables to u32
- Upgrade log messages to dev_warn()
- Link to v1:
https://lore.kernel.org/r/20240516-iw
On 5/17/2024 4:08 PM, Jacob Keller wrote:
> The ice_get_pfa_module_tlv() function iterates over the TLVs in the
> Preserved Fields Area (PFA) of the NVM. This is used to access data such as
> the Part Board Assembly identifier.
>
> Some NVMs in the wild have been found wit
On 5/17/2024 4:08 PM, Jacob Keller wrote:
> - next_tlv = next_tlv + tlv_len + 2;
> + if (check_add_overflow(next_tlv, 2, &next_tlv) ||
> + check_add_overflow(next_tlv, tlv_len, &next_tlv))
> + dev_warn(ice_hw_to
rwise misinterpreting NVM values.
Fixes: e961b679fb0b ("ice: add board identifier info to devlink .info_get")
Co-developed-by: Paul Greenwalt
Signed-off-by: Paul Greenwalt
Signed-off-by: Jacob Keller
---
Changes in v3:
- Fix missing {
- Fix missing pfa_ptr variable to dev_warn()
- Add Fixe
evice
family.
Fixes: ba20ecb1d1bb ("ice: Hook up 4 E830 devices by adding their IDs")
Co-developed-by: Paul Greenwalt
Signed-off-by: Paul Greenwalt
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_nvm.c | 88 +
On 5/9/2024 6:26 AM, kernel.org-fo5...@ycharbi.fr wrote:
> Hi,
>
>> No link detected, but it does detect this is a 10GBaseT cable.
>> Interesting it doesn't report FEC or autonegotiation. Hmm.
>
> In fact, I personally find it strange that the "Supported link modes" is
> "1baseT/Full". A
On 5/20/2024 10:55 PM, Paul Menzel wrote:
> Dear Jacob, dear Paul,
>
>
> Thank you for the patch.
>
> Am 20.05.24 um 23:39 schrieb Jacob Keller:
>> The ice driver reads data from the Shadow RAM portion of the NVM during
>> initialization, including data used
On 5/20/2024 3:20 PM, Dave Ertman wrote:
> On module load, the ice driver checks for the lack of a specific PF
> capabilty to determine if it should reduce the number of devlink params
> to register. One situation when this test returns true is when the
> driver loads in safe mode. The same ch
On 5/21/2024 9:11 PM, Paul Menzel wrote:
> Dear Jacob,
>
>
> Am 21.05.24 um 21:27 schrieb Jacob Keller:
>
>> On 5/20/2024 10:55 PM, Paul Menzel wrote:
>
>>> Am 20.05.24 um 23:39 schrieb Jacob Keller:
>>>> The ice driver reads data
On 5/20/2024 1:33 AM, Przemek Kitszel wrote:
> On 5/18/24 01:22, Jacob Keller wrote:
>> The ice_get_pfa_module_tlv() function iterates over the TLVs in the
>> Preserved Fields Area (PFA) of the NVM. This is used to access data such as
>> the Part Board Assembly identifie
On 5/22/2024 3:38 AM, Przemek Kitszel wrote:
> On 5/21/24 23:26, Jacob Keller wrote:
>>
>>
>> On 5/20/2024 3:20 PM, Dave Ertman wrote:
>>> On module load, the ice driver checks for the lack of a specific PF
>>> capabilty to determine if it should red
ther system load.
> This ice change is similar to i40e commit d34c54d1739c ("i40e: Use
> irq_update_affinity_hint()").
>
> [1] https://github.com/Irqbalance/irqbalance/commit/dcc411e7bfdd
>
> Signed-off-by: Michal Schmidt
> ---
Makes sense.
Reviewed-by: Jacob Keller
On 5/23/2024 1:44 AM, Przemek Kitszel wrote:
> On 5/22/24 11:19, Vitaly Lifshits wrote:
>> Add support for ethtool.set_phys_id callback to initiate LED blinking
>> and stopping them by the ethtool interface.
>> This is done by storing the initial LEDCTL register value and restoring
>> it when LE
On 5/20/2024 3:20 AM, Karthik Sundaravel wrote:
> Changing the MAC address of the VFs is currently unsupported via devlink.
> Add the function handlers to set and get the HW address for the VFs.
>
> Signed-off-by: Karthik Sundaravel
> ---
> .../ethernet/intel/ice/devlink/devlink_port.c | 59 +
t; Fixes: 109eb2917284 ("ice: Add tx_scheduling_layers devlink param")
> CC: Lukasz Czapnik
> Reviewed-by: Przemek Kitszel
> Signed-off-by: Dave Ertman
>
> ---
> Changes in v2: break params into two list
> clean up variable usage
> ---
Thanks for cleaning this up!
Reviewed-by: Jacob Keller
On 5/9/2024 11:50 PM, Anil Samal wrote:
> Current driver implementation for Sideband Queue supports a
> fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from
> firmware, Sideband Queue command is used with a different flag.
>
> Extend API for Sideband Queue command to use 'flag' as input
On 5/22/2024 11:33 AM, Jacob Keller wrote:
>
>
> On 5/20/2024 1:33 AM, Przemek Kitszel wrote:
>> On 5/18/24 01:22, Jacob Keller wrote:
>>> The ice_get_pfa_module_tlv() function iterates over the TLVs in the
>>> Preserved Fields Area (PFA) of the NVM. Th
On 5/22/2024 4:12 PM, Michal Schmidt wrote:
> irq_set_affinity_hint() is deprecated. Use irq_update_affinity_hint()
> instead. This removes the side-effect of actually applying the affinity.
>
> The driver does not really need to worry about spreading its IRQs across
> CPUs. The core code alrea
On 5/24/2024 6:51 AM, Anil Samal wrote:
> Implementation to dump PHY configuration and FEC statistics to
> facilitate link level debugging of customer issues. Implementation has
> two parts
>
What commit is this based off of? I believe we have slightly conflicting
work already queued in IW
On 5/24/2024 1:43 PM, Paul Menzel wrote:
> Dear Anil,
>
>
> Thank you for your patch.
>
> Am 24.05.24 um 15:51 schrieb Anil Samal:
>> Current driver implementation for Sideband Queue supports a
>> fixed flag (ICE_AQ_FLAG_RD). To retrieve FEC statistics from
>> firmware, Sideban
On 5/24/2024 8:13 AM, Piotr Kwapulinski wrote:
> Add low level support for Admin Command Interface (ACI). ACI is the
> Firmware interface used by a driver to communicate with E610 adapter. Add
> the following ACI features:
> - data structures, macros, register definitions
> - commands handling
>
at the end of each loop iteration. This ensures that
the driver will not get stuck in an infinite loop when scanning the PFA.
Fixes: e961b679fb0b ("ice: add board identifier info to devlink .info_get")
Co-developed-by: Paul Greenwalt
Signed-off-by: Paul Greenwalt
Signed-off-by: Ja
On 5/28/2024 12:16 PM, Jakub Kicinski wrote:
> On Tue, 28 May 2024 13:01:32 +0200 Wojciech Drewek wrote:
>> Subject: [PATCH iwl-net v2] ice: Add support for devlink loopback param.
>
> iwl-next, presumably
>
> Param makes sense, although the name keeps giving me pause.
> I expect "loopback" wi
On 5/28/2024 3:43 AM, Paul Menzel wrote:
> Dear Vitaly,
>
>
> Thank you for the patch.
>
> Am 28.05.24 um 12:33 schrieb Vitaly Lifshits:
>> From: Dima Ruinskiy
>>
>> On vPro systems,the configuration of the I219-LM to achieve power
>
> s/,the /, the /
>
>> gating and S0ix residency is sp
On 5/28/2024 3:43 AM, Wojciech Drewek wrote:
>
>
> On 28.05.2024 12:03, Ricky Wu wrote:
>> A bug in https://bugzilla.kernel.org/show_bug.cgi?id=218906 describes
>> that irdma would break and report hardware initialization failed after
>> suspend/resume with Intel E810 NIC (tested on 6.9.0-rc5)
On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
>
> struct idpf_rx_queue_stats {
> diff --git a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> b/drivers/net/ethernet/intel/idpf/idpf_lib.c
> index 3e8b24430dd8..a8be09a89943 100644
> --- a/drivers/net/ethernet/intel/idpf/idpf_lib.c
> +++ b/driver
t we can more easily spot
regressions in the layout is a big benefit.
Thanks!
Although I'm not an expert on cache-line layout, I didn't see anything
wrong here:
Reviewed-by: Jacob Keller
> drivers/net/ethernet/intel/idpf/idpf_txrx.h | 443 +++-
> 1 file changed,
Lobakin
> ---
Makes sense.
Reviewed-by: Jacob Keller
On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
> Currently, all HW supporting idpf supports the singleq model, but none
> of it advertises it by default, as splitq is supported and preferred
> for multiple reasons. Still, this almost dead code often times adds
> hotpath branches and redundant ca
array of ptypes in &idpf_vport --
> allocate them dynamically. The pointer to it is anyway cached in
> &idpf_rx_queue.
>
Reviewed-by: Jacob Keller
>
Yep. No reason to expose these twice, and blocking the ability for
someone to disable these for optimization is annoying. Good cleanup.
Reviewed-by: Jacob Keller
> @@ -876,7 +870,6 @@ static void idpf_get_ethtool_stats(struct net_device
> *netdev,
> {
> struc
introducing even more latency into the cleaning
> path. Bump up the timeout value to account for these workloads.
>
> Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration")
> Reviewed-by: Sridhar Samudrala
> Signed-off-by: Joshua Hay
> ---
Reviewed-by: Jacob Keller
atkowski
> Reviewed-by: Michal Swiatkowski
> Reviewed-by: Przemek Kitszel
> Signed-off-by: Marcin Szycik
> ---
Reviewed-by: Jacob Keller
On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
> From: Jackie Jone
>
> To facilitate running PHY parametric tests, add support for the SIOCSMIIREG
> ioctl. This allows a userspace application to write to the PHY registers
> to enable the test modes.
>
> Signed-off-by: Jackie Jone
On 6/5/2024 2:10 PM, Chris Packham wrote:
>
> On 6/06/24 08:51, Jacob Keller wrote:
>>
>> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
>>> From: Jackie Jone
>>>
>>> To facilitate running PHY parametric tests, add support for the S
On 6/6/2024 8:41 AM, Andrew Lunn wrote:
> On Wed, Jun 05, 2024 at 01:51:24PM -0700, Jacob Keller wrote:
>>
>>
>> On 6/3/2024 8:10 PM, jackie.j...@alliedtelesis.co.nz wrote:
>>> From: Jackie Jone
>>>
>>> To facilitate running PHY parametric tests,
On 6/5/2024 5:48 PM, Jakub Kicinski wrote:
> On Tue, 4 Jun 2024 15:13:21 -0700 Jesse Brandeburg wrote:
>> - - `ETHTOOL_MSG_PAUSE_GET`
>>- `ETHTOOL_MSG_FEC_GET`
>> + - 'ETHTOOL_MSG_LINKSTATE_GET'
>>- `ETHTOOL_MSG_MM_GET`
>> + - `ETHTOOL_MSG_PAUSE_GET`
>> + - 'ETHTOOL_MSG_TSINFO_GET'
l too strong either way
regarding tainting the kernel. Adding support here I think will overall
be more helpful than harmful. I like the tainting idea as a way to help
reduce support burden and flag that something like this was done.
That being said, I don't think I personally have a problem with the
patch as-is given its intended use case so either way from me:
Acked-by: Jacob Keller
On 6/8/2024 5:55 AM, Simon Horman wrote:
> If you need to respin this for some reason, please consider updating
> the Kernel doc for the following to include a short description.
> Else, please consider doing so as a follow-up
>
> * struct virtchnl_ptp_caps
> * struct virtchnl_phc_time
>
> Lik
On 6/8/2024 11:14 AM, Samal, Anil wrote:
> Hi Jacob,
> Can you please help me with the branch name that I should rebase?
> Last time I rebased to "dev-queue" branch of "git clone
> git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git".
>
> Let me know, if I should use a different br
On 6/9/2024 1:15 AM, Richard chien wrote:
> This patch adds support for firmware update to the in-tree igb driver and it
> is actually a port from the out-of-tree igb driver.
> In-band firmware update is one of the essential system maintenance tasks. To
> simplify this task, the Intel online f
On 6/11/2024 12:55 AM, Chien, Richard (Options Engineering) wrote:
>> However, this implementation is wrong. It is exposing the
>> ETHTOOL_GEEPROM and ETHTOOL_SEEPROM interface and abusing it to
>> implement a non-standard interface that is custom to the out-of-tree Intel
>> drivers to support t
On 6/11/2024 4:47 AM, Alexander Lobakin wrote:
> From: Mateusz Polchlopek
> Date: Tue, 4 Jun 2024 09:13:57 -0400
>
>> From: Jacob Keller
>>
>> Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
>> negotiating to enable the advanced fl
On 6/12/2024 6:03 AM, Alexander Lobakin wrote:
> From: Jacob Keller
> Date: Tue, 28 May 2024 17:43:34 -0700
>
>>
>>
>> On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
>>> Now that the queue and queue vector structures are separated and laid
>>> o
On 6/12/2024 6:08 AM, Alexander Lobakin wrote:
> From: Alexander Lobakin
> Date: Wed, 12 Jun 2024 15:03:07 +0200
>
>> From: Jacob Keller
>> Date: Tue, 28 May 2024 17:43:34 -0700
>>
>>>
>>>
>>> On 5/28/2024 6:48 AM, Alexander Lobakin wrot
On 6/12/2024 6:15 AM, Alexander Lobakin wrote:
> From: Jacob Keller
> Date: Tue, 28 May 2024 17:47:32 -0700
>
>>
>>
>> On 5/28/2024 6:48 AM, Alexander Lobakin wrote:
>>> Currently, all HW supporting idpf supports the singleq model, but none
>>>
On 7/18/2024 3:52 AM, Sergey Temerkhanov wrote:
> Address E825C devices by PCI ID since dual IP core configurations
> need 1 ice_adapter for both devices.
>
> Signed-off-by: Sergey Temerkhanov
> ---
> drivers/net/ethernet/intel/ice/ice_adapter.c | 16 +---
> 1 file changed, 13 ins
+++---
> drivers/net/ethernet/intel/ice/ice_ptp.h | 5 +-
> drivers/net/ethernet/intel/ice/ice_ptp_hw.h | 5 +
> 5 files changed, 105 insertions(+), 43 deletions(-)
>
Reviewed-by: Jacob Keller
> diff --git a/drivers/net/ethernet/intel/ice/ice_ptp.c
> b/drivers/net/ethern
ntel/ice/ice_ptp.c | 252 ---
> drivers/net/ethernet/intel/ice/ice_ptp.h | 21 --
> 2 files changed, 273 deletions(-)
>
This patch probably could just be squashed into the other, but I'm ok
keeping it separate.
Reviewed-by: Jacob Keller
rame+0x76/0x7e
> [ +0.05] RIP: 0033:0x7f2033593154
>
> Fixes: 080b0c8d6d26 ("ice: Fix ASSERT_RTNL() warning during certain
> scenarios")
> Reviewed-by: Wojciech Drewek
> Signed-off-by: Larysa Zaremba
> ---
Much simpler method, good fix and cleanup!
Reviewed-by: Jacob Keller
configuration for us in a managed fashion.
>
> Therefore, add an additional VSI state flag ICE_VSI_REBUILD_PENDING to
> indicate that ice_xdp() can just hot-swap the program.
>
> Fixes: 2d4238f55697 ("ice: Add support for AF_XDP")
> Fixes: efc2214b6047 ("ice: Add support for XDP")
> Reviewed-by: Wojciech Drewek
> Signed-off-by: Larysa Zaremba
> ---
Reviewed-by: Jacob Keller
by: Wojciech Drewek
> Signed-off-by: Larysa Zaremba
> ---
Right. When operating on the rings, we should be checking xdp_rings. Ok.
Reviewed-by: Jacob Keller
initialize already_down? I guess its because the other
initialization happens inside the conditional which may not be executed
in every flow. Ok.
Reviewed-by: Jacob Keller
> set_bit(ICE_VSI_NEEDS_RESTART, vsi->state);
>
> @@ -2674,15 +2673,
set.
>
Yea, unfortunately a lot of places accidentally use the wrong flags. I
wonder if this is something sparse could help with identifying by having
the flags tagged in some way...
Reviewed-by: Jacob Keller
> Despite being useless, it still can deadlock the unfortunate functions that
> ha
n how it works:
>
> if (if_running)
> ret = ice_up(vsi);
>
> if (!ret && prog)
> ice_vsi_rx_napi_schedule(vsi);
>
> return (ret || xdp_ring_err) ? -ENOMEM : 0;
By changing if_running to include the VSI state flag, we ensure the call
to ice_up is correctly conditional.
Good fix. If I understand right, it depends on the other synchronization
fixes to work correctly so that the VSI state won't be changed on us.
Reviewed-by: Jacob Keller
On 7/25/2024 2:34 AM, Karol Kolacinski wrote:
> From: Jacob Keller
>
> The E830 and E82x devices use essentially the same logic for performing
> a crosstimestamp. The only difference is that E830 hardware has
> different offsets. Instead of having two implementations, combin
On 7/26/2024 6:37 AM, Alexander Lobakin wrote:
>> diff --git a/drivers/net/ethernet/intel/ice/ice_osdep.h
>> b/drivers/net/ethernet/intel/ice/ice_osdep.h
>> index a2562f04267f..c03ab0207e0a 100644
>> --- a/drivers/net/ethernet/intel/ice/ice_osdep.h
>> +++ b/drivers/net/ethernet/intel/ice/ice_os
On 7/31/2024 7:43 AM, Jakub Kicinski wrote:
> On Wed, 31 Jul 2024 07:40:11 + Song, Yoong Siang wrote:
>> Regarding your suggestion of implementing a "wildcard rule,"
>> are you suggesting the use of an ethtool command similar to the following?
>>
>> ethtool -U flow-type ether action
>>
>>
On 7/30/2024 6:58 AM, Jakub Kicinski wrote:
> On Tue, 30 Jul 2024 12:51:21 +0200 Wojciech Drewek wrote:
>> ETH_RESET_MAC - ICE_RESET_CORER
>
> Core doesn't really sound like MAC, what is it?
> And does PF reset reset mostly PCIe side or more?
> My knee jerk mapping would be to map Core to dedic
")
Signed-off-by: Jacob Keller
---
---
drivers/net/ethernet/intel/ice/ice_switch.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_switch.c
b/drivers/net/ethernet/intel/ice/ice_switch.c
index fe8847184cb1..0160f0bae8d6 100644
--- a/drive
d/expected NVM
version.
Signed-off-by: Jacob Keller
---
Bruce Allan (1):
ice: do not clutter debug logs with unused data
Jacob Keller (4):
ice: implement and use rd32_poll_timeout for ice_sq_done timeout
ice: improve debug print for control queue messages
ice: rewor
for its timeout
value, so update the CQ timeout macros used to be specified in microseconds
units as well instead of using HZ for jiffies.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_controlq.h | 2 +-
drivers/net/ethernet/intel/ice
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_controlq.c | 36 +++
1 file changed, 31 insertions(+), 5 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c
b/drivers/net/ethernet/intel/ice/ice_con
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_controlq.c | 14 ++
1 file changed, 10 insertions(+), 4 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c
b/drivers/net/ethernet/intel/ice/ice_controlq.c
index
t
specific to the Admin queue.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_controlq.c | 25 +
1 file changed, 13 insertions(+), 12 deletions(-)
diff --git a/drivers/net/ethernet/intel/ice/ice_controlq.c
b/drivers/ne
Signed-off-by: Przemek Kitszel
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_osdep.h| 24 ++--
drivers/net/ethernet/intel/ice/ice_controlq.c | 21 +++--
2 files changed, 25 insertions(+), 20 deletions(-)
diff --git a/drivers/net/ethernet
unused.
Since we do not plan to implement asynchronous completions, drop this
unnecessary memory and logic. This saves memory for each control queue, and
avoids the pointless copying and memset.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice
unnecessary assignment.
Signed-off-by: Bruce Allan
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_adminq_cmd.h | 4
drivers/net/ethernet/intel/ice/ice_controlq.c | 21 -
2 files changed, 16 insertions(+), 9 deletions
On 8/19/2024 12:17 AM, Michal Swiatkowski wrote:
> Use always the same pf id in devlink port number. When doing
> pass-through the PF to VM bus info func number can be any value.
>
Reviewed-by: Jacob Keller
> Fixes: 2ae0aa4758b0 ("ice: Move devlink port to PF/VF struc
rtner advertised EEE link modes: 100baseT/Full
> 1000baseT/Full
> 1baseT/Full
>
> Reviewed-by: Arkadiusz Kubalewski
> Signed-off-by: Aleksandr Loktionov
> ---
Reviewed-by: Jacob Keller
rs and OR-ing LB_EN.
>
> Reviewed-by: Przemek Kitszel
> Fixes: 73b483b79029 ("ice: Manage act flags for switchdev offloads")
> Signed-off-by: Michal Swiatkowski
Reviewed-by: Jacob Keller
h the style for the similar functions needed to enable
live migration in a future series.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
I opted to include the packing changes in this series to Intel Wired LAN,
because the changes are only required due to the new use with the ice
driv
ric packing operations")
Signed-off-by: Vladimir Oltean
Tested-by: Jacob Keller
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
lib/packing.c | 6 --
1 file changed, 4 insertions(+), 2 deletions(-)
diff --git a/lib/packing.c b/lib/packing.c
index 3f656167c17e..439125
that quirk during test implementation. This
quirk will be fixed and the tests will be included in a future change.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
lib/packing_test.c | 82 ++
1 file changed, 82 insertions(+)
diff
are left in the same order as the packed bit layout,
despite the gaps this causes.
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
drivers/net/ethernet/intel/ice/ice_lan_tx_rx.h | 32 --
1 file changed, 10 insertions(+), 22 deletions(-)
diff --git a/drivers
for generic packing operations")
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
lib/packing.c | 39 +
lib/packing_test.c | 72 ++
2 files changed, 83 insertions(+), 28 deletions(-)
diff --
simple selftest
functions. I adapted them to KUnit, refactoring them into a table driven
approach. This will aid in adding additional tests in the future.
Co-developed-by: Vladimir Oltean
Signed-off-by: Vladimir Oltean
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
lib
o completely eliminate packing(). But let's make alternatives
available for those who do not need that.
Link:
https://lore.kernel.org/netdev/20210223112003.2223332-1-geert+rene...@glider.be/
Signed-off-by: Vladimir Oltean
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
inclu
Signed-off-by: Jacob Keller
Reviewed-by: Przemek Kitszel
---
include/linux/packing.h | 26 --
1 file changed, 26 deletions(-)
diff --git a/include/linux/packing.h b/include/linux/packing.h
index 8d6571feb95d..69baefebcd02 100644
--- a/include/linux/packing.h
+++ b/include
c
style.
These changes align the existing write functions to current kernel
style, and will align with the style of the new functions added when we
implement live migration in a future series.
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_common.c | 42 --
ce_setup_rx_ctx().
Fixes: c31a5c25bb19 ("ice: Always set prefena when configuring an Rx queue")
Signed-off-by: Jacob Keller
---
drivers/net/ethernet/intel/ice/ice_base.c | 3 +++
drivers/net/ethernet/intel/ice/ice_common.c | 9 +++--
2 files changed, 6 insertions(+), 6 deletions(-)
From: Vladimir Oltean
Jacob Keller has a use case for packing() in the intel/ice networking
driver, but it cannot be used as-is.
Simply put, the API quirks for LSW32_IS_FIRST and LITTLE_ENDIAN are
naively implemented with the undocumented assumption that the buffer
length must be a multiple of
1 - 100 of 315 matches
Mail list logo
