PCI_HEADER_TYPE_MULTIFUNC is define by e1000e and ixgbe and both are
unused. There is already PCI_HEADER_TYPE_MFD in pci_regs.h anyway which
should be used instead so remove the duplicated defines of it.
Signed-off-by: Ilpo Järvinen
---
drivers/net/ethernet/intel/e1000e/defines.h | 2
check the error
handling conversion within the driver is correct.
Ilpo Järvinen (4):
PCI/AER: Cleanup register variable
PCI: Generalize TLP Header Log reading
PCI: Add TLP Prefix reading into pcie_read_tlp_log()
PCI: Create helper to print TLP Header and Prefix Log
drivers/firmware/e
Use u32 for PCIe Capability register variable and name it aercc
(Advanced Error Capabilities and Control register, PCIe r6.1 sec
7.8.4.7) instead of temp.
Signed-off-by: Ilpo Järvinen
---
drivers/pci/pcie/aer.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers
ally.
Generalize the struct name and members, and use it consistently where
TLP Header Log is being handled so that a pcie_read_tlp_log() helper
can be easily added.
Signed-off-by: Ilpo Järvinen
---
drivers/firmware/efi/cper.c | 4 +-
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c
ixes.
Signed-off-by: Ilpo Järvinen
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +-
drivers/pci/ats.c | 2 +-
drivers/pci/pci.c | 37 ---
drivers/pci/pcie/aer.c| 4 +-
drivers/pci/pcie/d
Add pcie_print_tlp_log() helper to print TLP Header and Prefix Log.
Print End-End Prefixes only if they are non-zero.
Consolidate the few places which currently print TLP using custom
formatting.
Signed-off-by: Ilpo Järvinen
---
drivers/net/ethernet/intel/ixgbe/ixgbe_main.c | 4 +--
drivers
Adding Cc Quigshun which I ended up forgotting despite thinking it at one
point.
--
i.
On Tue, 6 Feb 2024, Ilpo Järvinen wrote:
> This series consolidates AER & DPC TLP Log handling code. Helpers are
> added for reading and printing the TLP Log and the format is made to
>
On Fri, 8 Mar 2024, Bjorn Helgaas wrote:
> On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote:
> > This series consolidates AER & DPC TLP Log handling code. Helpers are
> > added for reading and printing the TLP Log and the format is made to
> > include E
On Mon, 11 Mar 2024, Ilpo Järvinen wrote:
> On Fri, 8 Mar 2024, Bjorn Helgaas wrote:
>
> > On Tue, Feb 06, 2024 at 03:57:13PM +0200, Ilpo Järvinen wrote:
> > > This series consolidates AER & DPC TLP Log handling code. Helpers are
> > > added for reading and prin
Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of
custom masking and shifting.
Signed-off-by: Ilpo Järvinen
Reviewed-by: Jonathan Cameron
---
drivers/net/ethernet/intel/igb/e1000_mac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net
e1000e has own copy of PCI Negotiated Link Width field defines. Use the
ones from include/uapi/linux/pci_regs.h instead of the custom ones and
remove the custom ones and convert to FIELD_GET().
Suggested-by: Jonathan Cameron
Signed-off-by: Ilpo Järvinen
Reviewed-by: Jonathan Cameron
it.
Signed-off-by: Ilpo Järvinen
---
drivers/net/ethernet/intel/e1000e/defines.h | 1 -
drivers/net/ethernet/intel/e1000e/mac.c | 11 ---
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/defines.h
b/drivers/net/ethernet/intel/e1000e
On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> On Mon, Sep 18, 2023 at 04:10:54PM +0300, Ilpo Järvinen wrote:
> > ASPM service driver does the same L0S / L1S / sub states allowed
> > calculation in __pci_disable_link_state() and
> > pci_set_default_link_state().
>
> I
On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote:
> > PCI core/ASPM service driver allows controlling ASPM state through
> > pci_disable_link_state() and pci_enable_link_state() API. It was
> > decided earlier (see th
On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote:
> > PCI core/ASPM service driver allows controlling ASPM state through
> > pci_disable_link_state() and pci_enable_link_state() API. It was
> > decided earlier (see th
On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote:
> > pci_disable_link_state() lacks a symmetric pair. Some drivers want to
> > disable ASPM during certain phases of their operation but then
> > re-e
On Fri, 13 Oct 2023, Bjorn Helgaas wrote:
> On Thu, Oct 12, 2023 at 03:53:39PM +0300, Ilpo Järvinen wrote:
> > On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> > > On Mon, Sep 18, 2023 at 04:10:55PM +0300, Ilpo Järvinen wrote:
> > > > pci_disable_link_state() lacks a sym
On Fri, 13 Oct 2023, Bjorn Helgaas wrote:
> On Thu, Oct 12, 2023 at 01:56:16PM +0300, Ilpo Järvinen wrote:
> > On Wed, 11 Oct 2023, Bjorn Helgaas wrote:
> > > On Mon, Sep 18, 2023 at 04:10:53PM +0300, Ilpo Järvinen wrote:
> > > > PCI core/ASPM service driver allows
Resending these PCI related cleanups for Intel Ethernet drivers. No
other changes except removing the accepted patches in v4.
These can go through the usual driver tree as there are no PCI tree
related dependencies.
v4:
- Removed accepted patches
Ilpo Järvinen (3):
igb: Use FIELD_GET() to
Use FIELD_GET() to extract PCIe Negotiated Link Width field instead of
custom masking and shifting.
Signed-off-by: Ilpo Järvinen
Reviewed-by: Jonathan Cameron
---
drivers/net/ethernet/intel/igb/e1000_mac.c | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/drivers/net
e1000e has own copy of PCI Negotiated Link Width field defines. Use the
ones from include/uapi/linux/pci_regs.h instead of the custom ones and
remove the custom ones and convert to FIELD_GET().
Suggested-by: Jonathan Cameron
Signed-off-by: Ilpo Järvinen
Reviewed-by: Jonathan Cameron
it.
Signed-off-by: Ilpo Järvinen
Reviewed-by: Jonathan Cameron
---
drivers/net/ethernet/intel/e1000e/defines.h | 1 -
drivers/net/ethernet/intel/e1000e/mac.c | 11 ---
2 files changed, 4 insertions(+), 8 deletions(-)
diff --git a/drivers/net/ethernet/intel/e1000e/defines.h
b
22 matches
Mail list logo
