Re: [Intel-wired-lan] [PATCH net-next v6 1/7] net: ethtool: pass ethtool_rxfh to get/set_rxfh ethtool ops

2024-06-05 Thread Gal Pressman
On 27/11/2023 16:14, Ahmed Zaki wrote: > > > On 2023-11-21 16:29, Jakub Kicinski wrote: >> On Mon, 20 Nov 2023 13:56:08 -0700 Ahmed Zaki wrote: >>>   u32    (*get_rxfh_key_size)(struct net_device *); >>>   u32    (*get_rxfh_indir_size)(struct net_device *); >>> -    int    (*get_rxfh)(str

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-29 Thread Gal Pressman
On 21/10/2023 3:00, Ahmed Zaki wrote: > > > On 2023-10-20 17:49, Jakub Kicinski wrote: >> On Fri, 20 Oct 2023 17:14:11 -0600 Ahmed Zaki wrote: >>> I replied to that here: >>> >>> https://lore.kernel.org/all/afb4a06f-cfba-47ba-adb3-09bea7cb5...@intel.com/ >>> >>> I am kind of confused now so pleas

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-29 Thread Gal Pressman
On 29/10/2023 14:42, Ahmed Zaki wrote: > > > On 2023-10-29 06:25, Gal Pressman wrote: >> On 21/10/2023 3:00, Ahmed Zaki wrote: >>> >>> >>> On 2023-10-20 17:49, Jakub Kicinski wrote: >>>> On Fri, 20 Oct 2023 17:14:11 -0600 Ahmed Zaki

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-31 Thread Gal Pressman
On 29/10/2023 18:59, Ahmed Zaki wrote: > > > On 2023-10-29 06:48, Gal Pressman wrote: >> On 29/10/2023 14:42, Ahmed Zaki wrote: >>> >>> >>> On 2023-10-29 06:25, Gal Pressman wrote: >>>> On 21/10/2023 3:00, Ahmed Zaki wrote: >>>>

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-31 Thread Gal Pressman
On 31/10/2023 16:40, Ahmed Zaki wrote: > > > On 2023-10-31 06:00, Gal Pressman wrote: >> On 29/10/2023 18:59, Ahmed Zaki wrote: >>> >>> >>> On 2023-10-29 06:48, Gal Pressman wrote: >>>> On 29/10/2023 14:42, Ahmed Zaki wrote: >>>>&

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-31 Thread Gal Pressman
On 31/10/2023 16:59, Alexander Duyck wrote: > On Tue, Oct 31, 2023 at 5:01 AM Gal Pressman wrote: >> >> On 29/10/2023 18:59, Ahmed Zaki wrote: >>> >>> >>> On 2023-10-29 06:48, Gal Pressman wrote: >>>> On 29/10/2023 14:42, Ahmed Zaki wrote: >

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-31 Thread Gal Pressman
On 31/10/2023 17:14, Ahmed Zaki wrote: > > > On 2023-10-31 08:45, Gal Pressman wrote: >> On 31/10/2023 16:40, Ahmed Zaki wrote: >>> >>> >>> On 2023-10-31 06:00, Gal Pressman wrote: >>>> On 29/10/2023 18:59, Ahmed Zaki wrote: >>>>&

Re: [Intel-wired-lan] [PATCH net-next v4 1/6] net: ethtool: allow symmetric-xor RSS hash for any flow type

2023-10-31 Thread Gal Pressman
On 31/10/2023 17:20, Jakub Kicinski wrote: > On Tue, 31 Oct 2023 09:14:58 -0600 Ahmed Zaki wrote: >> Do you mean add vendor-specific implementation details to common docs? >> Not sure if I have seen this before. Any examples? >> >> Or, we can add a note in ethtool doc that each vendor's implementa

Re: [Intel-wired-lan] [PATCH net-next v6 2/7] net: ethtool: add support for symmetric-xor RSS hash

2023-11-23 Thread Gal Pressman
On 22/11/2023 1:33, Jakub Kicinski wrote: > Last but not least please keep the field check you moved to the drivers > in the core. Nobody will remember to check that other drivers added the > check as well. The wording of this sentence is a bit confusing, so I might be repeating what you already s

Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

2025-07-29 Thread Gal Pressman
On 29/07/2025 13:23, Vadim Fedorenko wrote: > diff --git a/drivers/net/netdevsim/ethtool.c b/drivers/net/netdevsim/ethtool.c > index f631d90c428ac..7257de9ea2f44 100644 > --- a/drivers/net/netdevsim/ethtool.c > +++ b/drivers/net/netdevsim/ethtool.c > @@ -164,12 +164,25 @@ nsim_set_fecparam(struct n

Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

2025-07-30 Thread Gal Pressman
On 30/07/2025 14:32, Vadim Fedorenko wrote: > On 30/07/2025 11:42, Gal Pressman wrote: >> On 30/07/2025 12:29, Vadim Fedorenko wrote: >>> On 30/07/2025 06:54, Gal Pressman wrote: >>>> On 29/07/2025 13:23, Vadim Fedorenko wrote: >>>>> diff --git a/

Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

2025-07-30 Thread Gal Pressman
On 30/07/2025 15:59, Andrew Lunn wrote: > On Wed, Jul 30, 2025 at 08:39:25AM +0300, Gal Pressman wrote: >> On 30/07/2025 4:51, Jakub Kicinski wrote: >>> On Tue, 29 Jul 2025 19:07:59 +0100 Vadim Fedorenko wrote: >>>> On 29/07/2025 18:31, Andrew Lunn wrote: >>>

Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

2025-07-29 Thread Gal Pressman
On 30/07/2025 4:51, Jakub Kicinski wrote: > On Tue, 29 Jul 2025 19:07:59 +0100 Vadim Fedorenko wrote: >> On 29/07/2025 18:31, Andrew Lunn wrote: The only one bin will have negative value is the one to signal the end of the list of the bins, which is not actually put into netlink message.

Re: [Intel-wired-lan] [RFC PATCH] ethtool: add FEC bins histogramm report

2025-07-30 Thread Gal Pressman
On 30/07/2025 12:29, Vadim Fedorenko wrote: > On 30/07/2025 06:54, Gal Pressman wrote: >> On 29/07/2025 13:23, Vadim Fedorenko wrote: >>> diff --git a/drivers/net/netdevsim/ethtool.c b/drivers/net/netdevsim/ >>> ethtool.c >>> index f631d90c428ac..7257de