1536.
A typical trace looks like the following :
[ 377.548696] i40e :5d:00.0 eno5: Error changing mtu to 9000 which is
greater than the current mfs: 1536
Signed-off-by: Erwan Velu
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 9 -
1 file changed, 8 insertions(+), 1 deletion(-)
Le lun. 4 mars 2024 à 23:10, Tony Nguyen a écrit :
> > Signed-off-by: Erwan Velu
>
> The Author and Sign-off needs to be fixed; they don't match.
>
> WARNING: From:/Signed-off-by: email address mismatch: 'From: Erwan Velu
> ' != 'Signed-off-by: Erwan
1536.
A typical trace looks like the following :
[ 377.548696] i40e :5d:00.0 eno5: Error changing mtu to 9000 which is
greater than the current mfs: 1536
Signed-off-by: Erwan Velu
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +-
1 file changed, 9 insertions(+), 1 del
-off-by: Erwan Velu
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 10 +-
1 file changed, 9 insertions(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b/drivers/net/ethernet/intel/i40e/i40e_main.c
index 89a3401d20ab..225b2fd0449e 100644
--- a/drivers/net
> Am 12.03.24 um 10:42 schrieb Erwan Velu:
> > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is
> > setting the MFS to 0x600 = 1536.
>
> Please add a link, as most people do not have the iPXE archive checked
> out. Maybe also add the commit message
> On Tue, 2024-03-12 at 10:42 +0100, Erwan Velu wrote:
> > Commit 6871a7de705b6f6a4046f0d19da9bcd689c3bc8e from iPXE project is
>
> Please use the checkpatch-friendly commit reference: <12char hash>
> ("")
Done.
> This looks like a legit fix that should t
having an MTU set to 9000 on the
netdev with a firmware refusing packets larger than 1536.
A typical trace looks like:
[ 377.548696] i40e :5d:00.0 eno5: Error changing mtu to 9000, Max is 1500.
MFS is too small.
Signed-off-by: Erwan Velu
---
drivers/net/ethernet/intel/i40e/i40e_m
Le 14/03/2024 à 17:10, Brett Creeley a écrit :
[...]
If this is how the max_mtu is determined, does it make sense to set this
before registering the netdev, i.e. netdev->max_mtu in
i40e_config_netdev()?
The absolute max is properly set but I think that's only true if we
ensure the value of
Le 14/03/2024 à 18:55, Brett Creeley a écrit :
[...]
AFAIK there is no API for a user to change the max_mtu, so the only way
the device's MFS would need to change is if it's done during
initialization time, which should be done before netdev registration
anyway.
Sorry Brett, I was probably u
Le 14/03/2024 à 21:31, Tony Nguyen a écrit :
[..]
Setting the mfs size to max values during init and reset would better;
this is what the ice driver does. However, this would take
implementing new AdminQ calls. IMO this patch is ok to prevent the
issue being reported and allow for ease of ba
Le 18/03/2024 à 18:45, Simon Horman a écrit :
[...]
Hi Erwan, all,
As a fix, I think this patch warrants a fixes tag.
Perhaps this one is appropriate?
Fixes: 41c445ff0f48 ("i40e: main driver core")
Simon
Isn't that a bit too generic ?
[..]
I am fine with this patch, so please take what f
Le 19/03/2024 à 13:20, Simon Horman a écrit :
[...]
FWIIW, I think handling these questions in follow-up patches is fine.
I wonder if the previous patch must be merged first, so I can reference
it in the commit message, or if I should shoot it now.
Erwan,
or port 1 (1536) has been set below the default (9728)
Signed-off-by: Erwan Velu
---
drivers/net/ethernet/intel/i40e/i40e_main.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/ethernet/intel/i40e/i40e_main.c
b/drivers/net/ethernet/intel/i40e/i40e_main.c
ind
13 matches
Mail list logo
