[Intel-wired-lan] [PATCH iwl-net] idpf: add read memory barrier when checking descriptor done bit

2024-11-14 Thread Emil Tantilov
#2 is not executed until load has completed. Fixes: 8077c727561a ("idpf: add controlq init and reset checks") Reviewed-by: Przemek Kitszel Reviewed-by: Sridhar Samudrala Suggested-by: Lance Richardson Signed-off-by: Emil Tantilov --- drivers/net/ethernet/intel/idpf/idpf_contr

[Intel-wired-lan] [PATCH iwl-net] idpf: check error for register_netdev() on init

2025-02-10 Thread Emil Tantilov
check VPORT_REG_NETDEV flag prior to calling unregister and free on the netdev. Add local variables for idx, vport_config and netdev for readability. Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration") Reviewed-by: Madhu Chittim Suggested-by: Tony Nguyen Signed-of

[Intel-wired-lan] [PATCH iwl-net] idpf: fix transaction timeouts on reset

2024-12-17 Thread Emil Tantilov
t and vectors") Reviewed-by: Larysa Zaremba Signed-off-by: Emil Tantilov --- Testing hints: echo 1 > /sys/class/net//device/reset --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethern

[Intel-wired-lan] [PATCH iwl-net v2] idpf: fix transaction timeouts on reset

2024-12-19 Thread Emil Tantilov
t and vectors") Reviewed-by: Larysa Zaremba Signed-off-by: Emil Tantilov --- Changelog: v2: - Assigned the current state of REMOVE_IN_PROG flag to a boolean variable, to be checked instead of reading the flag twice. - Updated the description to clarify the reason for the timeouts on reset

[Intel-wired-lan] [PATCH iwl-net v2] idpf: add read memory barrier when checking descriptor done bit

2024-11-21 Thread Emil Tantilov
#2 is not executed until load #1 has completed. Fixes: 8077c727561a ("idpf: add controlq init and reset checks") Reviewed-by: Przemek Kitszel Reviewed-by: Sridhar Samudrala Suggested-by: Lance Richardson Signed-off-by: Emil Tantilov --- Changelog v2: - Rewrote comment to fit on a s

[Intel-wired-lan] [PATCH iwl-net v2] idpf: check error for register_netdev() on init

2025-02-14 Thread Emil Tantilov
check VPORT_REG_NETDEV flag prior to calling unregister and free on the netdev. Add local variables for idx, vport_config and netdev for readability. Fixes: 0fe45467a104 ("idpf: add create vport and netdev configuration") Suggested-by: Tony Nguyen Signed-off-by: Emil Tantilov --- Cha

[Intel-wired-lan] [PATCH iwl-net] idpf: fix adapter NULL pointer dereference on reboot

2025-03-06 Thread Emil Tantilov
ask, freeing IRQs, destroying the vports and freeing the mailbox. Reported-by: Yuying Ma Fixes: e850efed5e15 ("idpf: add module register and probe functionality") Reviewed-by: Madhu Chittim Signed-off-by: Emil Tantilov --- drivers/net/ethernet/intel/idpf/idpf_main.c | 6 +- 1 fi

[Intel-wired-lan] [PATCH iwl-net v2] idpf: fix adapter NULL pointer dereference on reboot

2025-03-17 Thread Emil Tantilov
tim Signed-off-by: Emil Tantilov --- Changelog: v2: - Updated the description to clarify the path leading up to the crash, and the difference in the logic between remove and shutdown as result of this change. v1: https://lore.kernel.org/intel-wired-lan/20250307003956.22018-1-emil.s.