On Thu, Apr 10, 2025 at 02:23:49PM +0300, Leon Romanovsky wrote:
> On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
> > On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
> > > On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote:
> > > > From: Phani R Burra
On 3/31/2025 11:36 PM, Jacek Kowalski wrote:
Hi,
Are you certain that the UEFI FW corrupts the checksum each time, or
is it just that the system left the factory with incorrect checksum?
I'm quite far from that device at the moment, but from what I remember:
- when I forced the NVM update
On 4/8/2025 11:31 PM, Jacob Keller wrote:
>On 4/8/2025 3:31 AM, Milena Olech wrote:
>> +/**
>> + * idpf_ptp_tstamp_extend_32b_to_64b - Convert a 32b nanoseconds Tx or Rx
>> + * timestamp value to 64b.
>> + * @cached_phc_time: recently cached copy of PHC time
>> + *
On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote:
> From: Leon Romanovsky
> Date: Thu, 10 Apr 2025 14:23:49 +0300
>
> > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
> >> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
> >>> On Tue, Apr 08, 2025
The descriptor structure is the same in ice, ixgbe and i40e. Move it to
common libie header to use it across different driver.
Leave device specific adminq commands in separate folders. This lead to
a change that need to be done in filling/getting descriptor:
- previous: struct specific_desc *cmd;
From: Leon Romanovsky
Date: Thu, 10 Apr 2025 16:44:43 +0300
> On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote:
>> From: Leon Romanovsky
>> Date: Thu, 10 Apr 2025 14:23:49 +0300
>>
>>> On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
On Thu, Apr 10, 2025 at 1
> -Original Message-
> From: Olech, Milena
> Sent: Thursday, April 10, 2025 7:12 AM
> To: Keller, Jacob E ;
> intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Nguyen, Anthony L ;
> Kitszel, Przemyslaw ; Lobakin, Aleksander
> ; Tantilov, Emil S ;
> Linga, Pavan Kumar ; Sali
On Tue, Apr 08, 2025 at 03:46:55PM +0200, Przemek Kitszel wrote:
> Use Device Serial Number instead of PCI bus/device/function for
> index of struct ice_adapter.
> Functions on the same physical device should point to the very same
> ice_adapter instance.
>
> This is not only simplification, but a
allnoconfiggcc-14.2.0
arc allyesconfiggcc-14.2.0
arc randconfig-001-20250410gcc-14.2.0
arc randconfig-002-20250410gcc-12.4.0
arm allmodconfiggcc-14.2.0
arm
On Thu, Apr 10, 2025 at 03:33:40PM +0200, Alexander Lobakin wrote:
> From: Leon Romanovsky
> Date: Thu, 10 Apr 2025 16:27:06 +0300
>
> > On Thu, Apr 10, 2025 at 02:58:28PM +0200, Larysa Zaremba wrote:
> >> On Thu, Apr 10, 2025 at 02:23:49PM +0300, Leon Romanovsky wrote:
> >>> On Thu, Apr 10, 2025
On Thu, Apr 10, 2025 at 04:44:43PM +0300, Leon Romanovsky wrote:
> On Thu, Apr 10, 2025 at 03:05:19PM +0200, Alexander Lobakin wrote:
> > From: Leon Romanovsky
> > Date: Thu, 10 Apr 2025 14:23:49 +0300
> >
> > > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
> > >> On Thu, Apr 10
On 4/9/2025 8:12 PM, Jacob Keller wrote:
>On 4/9/2025 4:51 AM, Olech, Milena wrote:
>> On 4/8/2025 11:12 PM, Jacob Keller wrote:
>>> On 4/8/2025 3:30 AM, Milena Olech wrote:
+/**
+ * struct virtchnl2_ptp_adj_dev_clk_fine: Associated with message
+ *
From: Leon Romanovsky
Date: Thu, 10 Apr 2025 16:58:43 +0300
> On Thu, Apr 10, 2025 at 03:33:40PM +0200, Alexander Lobakin wrote:
>> From: Leon Romanovsky
>> Date: Thu, 10 Apr 2025 16:27:06 +0300
>>
>>> On Thu, Apr 10, 2025 at 02:58:28PM +0200, Larysa Zaremba wrote:
On Thu, Apr 10, 2025 at 0
Am 10.04.25 um 16:30 schrieb Michal Kubiak:
> On Wed, Apr 09, 2025 at 05:17:49PM +0200, Marcus Wichelmann wrote:
>> Hi,
>>
>> in a setup where I use native XDP to redirect packets to a bonding interface
>> that's backed by two ixgbe slaves, I noticed that the ixgbe driver constantly
>> resets the N
On 4/9/2025 8:09 PM, Jacob Keller wrote:
>On 4/9/2025 7:04 AM, Olech, Milena wrote:
>> On 4/8/2025 11:23 PM, Jacob Keller wrote:
>>
>>> On 4/8/2025 3:31 AM, Milena Olech wrote:
+static void idpf_ptp_release_vport_tstamp(struct idpf_vport *vport)
+{
+ struct idpf_ptp_tx_tstamp *ptp
Use libie_aq_desc instead of i40e_aq_desc. Do needed changes to allow
clean build.
Get version descriptor is a little less detailed on i40e. To not mess up
with shifting or union inside libie desc use get version descriptor from
i40e.
Move additional caps for i40e to libie.
Fix RCT in declaratio
On Wed, Apr 09, 2025 at 05:17:49PM +0200, Marcus Wichelmann wrote:
> Hi,
>
> in a setup where I use native XDP to redirect packets to a bonding interface
> that's backed by two ixgbe slaves, I noticed that the ixgbe driver constantly
> resets the NIC with the following kernel output:
>
> ixgbe
On 08/04/2025 21:55, Jacob Keller wrote:
Both the PTP_EXTTS_REQUEST(2) and PTP_PEROUT_REQUEST(2) ioctls take flags
from userspace to modify their behavior. Drivers are supposed to check
these flags, rejecting requests for flags they do not support.
Many drivers today do not check these flags, de
Simple:
s/ice_aq_str/libie_aq_str
Add libie_aminq module in ice Kconfig.
Reviewed-by: Przemek Kitszel
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/Kconfig| 1 +
drivers/net/ethernet/intel/ice/ice.h | 1 -
.../net/ethernet/intel/ice/devlink/devlink.c
Use libie_aq_desc instead of iavf_aq_desc. Do needed changes to allow
clean build
Use libie_aq_raw() wherever it can be used.
Reviewed-by: Przemek Kitszel
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/iavf/iavf_adminq.h | 12 +-
.../net/eth
There is no need to store the err string in hw->err_str. Simplify it and
use common helper. hw->err_str is still used for other purpouse.
It should be marked that previously for unknown error the numeric value
was passed as a string. Now the "LIBIE_AQ_RC_UNKNOWN" is used for such
cases.
Add libie
Hi,
It is a prework to allow reusing some specific Intel code (eq. fwlog).
Move common *_aq_desc structure to libie header and changing
it in ice, ixgbe, i40e and iavf.
Only generic adminq commands can be easily moved to common header, as
rest is slightly different. Format remains the same. It w
On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
> On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote:
> > From: Phani R Burra
> >
> > Libeth will now support control queue setup and configuration APIs.
> > These are mainly used for mailbox communication between driver
On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
> > On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote:
> > > From: Phani R Burra
> > >
> > > Libeth will now support control queue setup and configuratio
On Wed, Apr 09, 2025 at 07:01:29PM -0700, Dan Williams wrote:
> diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
> index dd8874860cec..06a1ae3f3fd0 100644
> --- a/include/uapi/cxl/features.h
> +++ b/include/uapi/cxl/features.h
> @@ -14,7 +14,8 @@ typedef unsigned char __uapi_
On 02/04/2025 2:35, Jacob Keller wrote:
From: Christopher S M Hall
Make sure that the PTP module is cleaned up if the igc_probe() fails by
calling igc_ptp_stop() on exit.
Fixes: d89f88419f99 ("igc: Add skeletal frame for Intel(R) 2.5G Ethernet Controller
support")
Signed-off-by: Christopher S
On 02/04/2025 2:35, Jacob Keller wrote:
From: Christopher S M Hall
Add a mutex around the PTM transaction to prevent multiple transactors
Multiple processes try to initiate a PTM transaction, one or all may
fail. This can be reproduced by running two instances of the
following:
$ sudo phc2sys
On 02/04/2025 2:35, Jacob Keller wrote:
From: Christopher S M Hall
All functions in igc_ptp.c called from igc_main.c should check the
IGC_PTP_ENABLED flag. Adding check for this flag to stop and reset
functions.
Fixes: 5f2958052c58 ("igc: Add basic skeleton for PTP")
Signed-off-by: Christopher
There is no need to store the err string in hw->err_str. Simplify it and
use common helper. hw->err_str is still used for other purpouse.
It should be marked that previously for unknown error the numeric value
was passed as a string. Now the "LIBIE_AQ_RC_UNKNOWN" is used for such
cases.
Add libie
Before the referenced commit, the shutdown just called idpf_remove(),
this way IDPF_REMOVE_IN_PROG was protecting us from the serv_task
rescheduling reset. Without this flag set the shutdown process is
vulnerable to HW reset or any other triggering conditions (such as
default mailbox being destroye
On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote:
> From: Phani R Burra
>
> Libeth will now support control queue setup and configuration APIs.
> These are mainly used for mailbox communication between drivers and
> control plane.
>
> Make use of the page pool support for managing
On Mon, Apr 07, 2025 at 11:21:27AM +0200, Oleksandr Natalenko wrote:
> It's not a new warning, I've observe it for several recent major kernel
> releases already.
>
> I do not build with CONFIG_COMPILE_TEST.
>
> I've also realised I see this warning with -O3 only. I know this is
> unsupported, s
From: Leon Romanovsky
Date: Thu, 10 Apr 2025 14:23:49 +0300
> On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
>> On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
>>> On Tue, Apr 08, 2025 at 02:47:51PM +0200, Larysa Zaremba wrote:
From: Phani R Burra
Switch from unions with bitfield structs to definitions with bitfield
masks. This is necessary, because some registers have different
field definitions or even use a different register for the same fields
based on HW type.
Remove unused register fields.
Reviewed-by: Milena Olech
Signed-off-by: K
> -Original Message-
> From: Michal Swiatkowski
> Sent: Thursday, April 10, 2025 12:01 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: net...@vger.kernel.org; Lobakin, Aleksander
> ; Kitszel, Przemyslaw
> ; Kwapulinski, Piotr
> ; Loktionov, Aleksandr
> ; Jagielski, Jedrzej
> ; Zaremba,
> -Original Message-
> From: Kubalewski, Arkadiusz
> Sent: Wednesday, April 9, 2025 5:26 PM
> To: donald.hun...@gmail.com; k...@kernel.org; da...@davemloft.net;
> Dumazet, Eric ; pab...@redhat.com;
> ho...@kernel.org; vadim.fedore...@linux.dev; j...@resnulli.us; Nguyen,
> Anthony L ; Ki
On Tue, Apr 08, 2025 at 03:28:21PM +0200, Alexander Lobakin wrote:
> From: Maciej Fijalkowski
> Date: Tue, 11 Mar 2025 16:50:07 +0100
>
> > On Wed, Mar 05, 2025 at 05:21:30PM +0100, Alexander Lobakin wrote:
> >> Use libeth XDP infra to support running XDP program on Rx polling.
> >> This includes
From: Leon Romanovsky
Date: Thu, 10 Apr 2025 16:27:06 +0300
> On Thu, Apr 10, 2025 at 02:58:28PM +0200, Larysa Zaremba wrote:
>> On Thu, Apr 10, 2025 at 02:23:49PM +0300, Leon Romanovsky wrote:
>>> On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
On Thu, Apr 10, 2025 at 11:21:
On Thu, Apr 10, 2025 at 02:58:28PM +0200, Larysa Zaremba wrote:
> On Thu, Apr 10, 2025 at 02:23:49PM +0300, Leon Romanovsky wrote:
> > On Thu, Apr 10, 2025 at 12:44:33PM +0200, Larysa Zaremba wrote:
> > > On Thu, Apr 10, 2025 at 11:21:37AM +0300, Leon Romanovsky wrote:
> > > > On Tue, Apr 08, 2025
Jason Gunthorpe wrote:
> On Wed, Apr 09, 2025 at 07:01:29PM -0700, Dan Williams wrote:
>
> > diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
> > index dd8874860cec..06a1ae3f3fd0 100644
> > --- a/include/uapi/cxl/features.h
> > +++ b/include/uapi/cxl/features.h
> > @@ -14,7 +
On 4/9/2025 2:54 PM, Tony Nguyen wrote:
>
>
> On 4/7/2025 4:20 PM, Jesse Brandeburg wrote:
>
> iwl-next, not intel-next :)
>
>> From: Jesse Brandeburg
>>
>> The driver was being inconsistent when de-registering its PTP clock. Make
>> sure to NULL out the pointer once it is freed in all case
On Thu, Apr 10, 2025 at 10:48:00AM -0700, Dan Williams wrote:
> Jason Gunthorpe wrote:
> > On Wed, Apr 09, 2025 at 07:01:29PM -0700, Dan Williams wrote:
> >
> > > diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
> > > index dd8874860cec..06a1ae3f3fd0 100644
> > > --- a/includ
Jason Gunthorpe wrote:
> On Thu, Apr 10, 2025 at 10:48:00AM -0700, Dan Williams wrote:
> > Jason Gunthorpe wrote:
> > > On Wed, Apr 09, 2025 at 07:01:29PM -0700, Dan Williams wrote:
> > >
> > > > diff --git a/include/uapi/cxl/features.h b/include/uapi/cxl/features.h
> > > > index dd8874860cec..06a
Use libie_aq_desc instead of ixgbe_aci_desc. Do needed changes to allow
clean build.
Move additional caps used in ixgbe to libie.
Reviewed-by: Przemek Kitszel
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Michal Swiatkowski
---
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.h | 12 +-
.../eth
Add a new module for common handling of Admin Queue related logic.
Start by a helper for error to string conversion. This lives inside
libie/, but is a separate module what follows our logic of splitting
into topical modules, to avoid pulling in not needed stuff, and have
better organization in gen
list[i]);
- vf->num_mac++;
break;
}
---
base-commit: a9843689e2de1a3727d58b4225e4f8664937aefd
change-id: 20250410-jk-fix-v-num-mac-count-55acd188162b
Best regards,
--
Jacob Keller
Since workqueues are created per CPU, the works scheduled to this
workqueues are run on the CPU they were assigned. It may result in
overloaded CPU that is not able to handle virtchnl messages in
relatively short time. Allocating workqueue with WQ_UNBOUND and
WQ_HIGHPRI flags allows scheduler to qu
Hi Przemek,
kernel test robot noticed the following build warnings:
[auto build test WARNING on tnguy-net-queue/dev-queue]
url:
https://github.com/intel-lab-lkp/linux/commits/Przemek-Kitszel/ice-use-DSN-instead-of-PCI-BDF-for-ice_adapter-index/20250407-192849
base: https://git.kernel.org/p
From: Maciej Fijalkowski
Date: Tue, 11 Mar 2025 16:50:07 +0100
> On Wed, Mar 05, 2025 at 05:21:30PM +0100, Alexander Lobakin wrote:
>> Use libeth XDP infra to support running XDP program on Rx polling.
>> This includes all of the possible verdicts/actions.
>> XDP Tx queues are cleaned only in "la
On 4/7/2025 3:43 AM, Simon Horman wrote:
On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
In case of failing on rss_data->rss_key allocation the function is
freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
Move from freeing in error branch to goto scheme
Hi,
Jacob Keller writes:
> There have been sporadic reports of PTM timeouts using i225/i226 devices
>
> These timeouts have been root caused to:
>
> 1) Manipulating the PTM status register while PTM is enabled and triggered
> 2) The hardware retrying too quickly when an inappropriate response is
In the VF handling code, parts of the code for lag can be broken out into
helper functions to reduce code duplication. This is will be especially
helpful once the whole series is applied and A/A is implemented.
Break this code out into helper functions
Reviewed-by: Marcin Szycik
Signed-off-by:
On 4/8/2025 3:30 AM, Milena Olech wrote:
> When the access to read PTP clock is specified as mailbox, the driver
> needs to send virtchnl message to perform PTP actions. Message is sent
> using idpf_mbq_opc_send_msg_to_peer_drv mailbox opcode, with the parameters
> received during PTP capabiliti
On Mon, Apr 07, 2025 at 12:35:38PM +, Marek Pazdan wrote:
> Commit f3c1c896f5a8 ("ethtool: transceiver reset and presence pin control")
> adds ioctl API extension for get/set-phy-tunable so that transceiver
> reset and presence pin control is enabled.
As the name get/set-phy-tunable suggests,
From: Phani R Burra
Libeth will now support control queue setup and configuration APIs.
These are mainly used for mailbox communication between drivers and
control plane.
Make use of the page pool support for managing controlq buffers.
Reviewed-by: Maciej Fijalkowski
Signed-off-by: Phani R Bur
On 4/8/2025 3:30 AM, Milena Olech wrote:
> PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the
> capabilities recognition. Initial PTP support includes PTP initialization
> and registration of the clock.
>
> Reviewed-by: Alexander Lobakin
> Reviewed-by: Vadim Fedorenko
On Thu, Apr 10, 2025 at 03:04:16PM -0700, Tony Nguyen wrote:
> On 4/7/2025 3:43 AM, Simon Horman wrote:
> > On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
> > > In case of failing on rss_data->rss_key allocation the function is
> > > freeing vport without freeing earlier alloca
On Mon, Apr 07, 2025 at 11:43:50AM +0100, Simon Horman wrote:
> On Fri, Apr 04, 2025 at 12:54:21PM +0200, Michal Swiatkowski wrote:
> > In case of failing on rss_data->rss_key allocation the function is
> > freeing vport without freeing earlier allocated q_vector_idxs. Fix it.
> >
> > Move from fr
break;
> }
>
Right, thanks for fixing it.
Reviewed-by: Michal Swiatkowski
>
> ---
> base-commit: a9843689e2de1a3727d58b4225e4f8664937aefd
> change-id: 20250410-jk-fix-v-num-mac-count-55acd188162b
>
> Best regards,
> --
> Jacob Keller
Add helpers for checking TSPLL params, disabling sticky bits,
configuring TSPLL and getting default clock frequency to simplify
the code flows.
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_tspll.c | 156 ++---
1 file changed, 1
On Tue, Mar 25, 2025 at 10:01:49AM +0800, Xuanqiang Luo wrote:
> From: Xuanqiang Luo
>
> As mentioned in the commit baeb705fd6a7 ("ice: always check VF VSI
> pointer values"), we need to perform a null pointer check on the return
> value of ice_get_vf_vsi() before using it.
>
> v2: Add "iwl-net"
Both the PTP_EXTTS_REQUEST(2) and PTP_PEROUT_REQUEST(2) ioctls take flags
from userspace to modify their behavior. Drivers are supposed to check
these flags, rejecting requests for flags they do not support.
Many drivers today do not check these flags, despite many attempts to
squash individual dr
On Mon, Apr 07, 2025 at 11:41:54AM +0800, Wentao Liang wrote:
> The e1000_suspend_workarounds_ich8lan() calls e1e_rphy_locked to disable
> the SMB release, but does not check its return value. A proper
> implementation can be found in e1000_resume_workarounds_pchlan() from
> /source/drivers/net/eth
The PTP_PEROUT_REQUEST2 ioctl has gained support for flags specifying
specific output behavior including PTP_PEROUT_ONE_SHOT,
PTP_PEROUT_DUTY_CYCLE, PTP_PEROUT_PHASE.
Driver authors are notorious for not checking the flags of the request.
This results in misinterpreting the request, generating an
This is a 8 patch series to implement support for SRIOV VFs over an
active-active link aggregate
Patch 1 cleans up void pointer casts
Patch 2 utilizes bool over u8 when appropriate
Patch 3 adds a driver prefix to a LAG define
Patch 4 pre-move a function to reduce delta in implementation patch
Patc
The PTP_EXTTS_REQUEST(2) ioctl has a flags field which specifies how the
external timestamp request should behave. This includes which edge of the
signal to timestamp, as well as a specialized "offset" mode. It is expected
that more flags will be added in the future.
Driver authors routinely do no
In preparation for the new LAG functionality implementation, there are
a couple of existing LAG elements of the capabilities struct that should
be bool instead of u8. Since we are adding a new element to this struct
that should also be a bool, fix the existing LAG u8 in this patch and
eliminate !!
PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the
capabilities recognition. Initial PTP support includes PTP initialization
and registration of the clock.
Reviewed-by: Alexander Lobakin
Reviewed-by: Vadim Fedorenko
Reviewed-by: Willem de Bruijn
Signed-off-by: Milena Ole
On Wed, Apr 9, 2025 at 10:01 PM Jacob Keller wrote:
> On 4/9/2025 2:54 PM, Tony Nguyen wrote:
> > On 4/7/2025 4:20 PM, Jesse Brandeburg wrote:
> >
> > iwl-next, not intel-next :)
The brain rot on unused cells is severe it seems :-)
> >> -if (pf->ptp.clock)
> >> +if (pf->ptp.clock) {
> >>
69 matches
Mail list logo
