Add a helper function to print new/current TSPLL config. This helps
avoid unnecessary casts from u8 to enums.
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_tspll.c | 54 --
1 file changed, 30 inse
On 4/7/2025 4:20 PM, Jesse Brandeburg wrote:
iwl-next, not intel-next :)
From: Jesse Brandeburg
The driver was being inconsistent when de-registering its PTP clock. Make
sure to NULL out the pointer once it is freed in all cases. The driver was
mostly already doing so, but a couple spots w
On 4/8/2025 11:23 PM, Jacob Keller wrote:
>On 4/8/2025 3:31 AM, Milena Olech wrote:
>> +static void idpf_ptp_release_vport_tstamp(struct idpf_vport *vport)
>> +{
>> +struct idpf_ptp_tx_tstamp *ptp_tx_tstamp, *tmp;
>> +struct list_head *head;
>> +
>> +/* Remove list with free latches */
From: Sudheer Mogilappagari
Add opcodes and corresponding message structure to add and delete
flow steering rules. Flow steering enables configuration
of rules to take an action or subset of actions based on a match
criteria. Actions could be redirect to queue, redirect to queue
group, drop packe
Use the new virtchnl2 OP codes to communicate with the Control Plane to
add flow steering filters. We add the basic functionality for ADD/Delete
with TCP/UDP IPv4 only. Support for other OP codes and protocols will be
added later.
Standard 'ethtool -N|--config-ntuple' should be used, for example:
Add basic flow steering. For now, we support IPv4 and TCP/UDP only.
Patch 1 renames "enum virtchnl2_cap_rss" to a more generic "enum
virtchnl2_flow_types" that can be used with RSS and flow steering.
Patch 2 adds the required flow steering virtchnl2 OP codes and patch 3
adds the required flow st
On 4/9/2025 4:51 AM, Olech, Milena wrote:
> On 4/8/2025 11:12 PM, Jacob Keller wrote:
>> On 4/8/2025 3:30 AM, Milena Olech wrote:
>>> +/**
>>> + * struct virtchnl2_ptp_adj_dev_clk_fine: Associated with message
>>> + * VIRTCHNL2_OP_PTP_ADJ_DEV_CLK_FINE.
>>> + * @inc
On 4/9/2025 5:55 AM, Olech, Milena wrote:
> On 4/8/2025 11:15 PM, Jacob Keller wrote:
>
>> On 4/8/2025 3:30 AM, Milena Olech wrote:
>>> +static u64 idpf_ptp_read_src_clk_reg_direct(struct idpf_adapter *adapter,
>>> + struct ptp_system_timestamp *sts)
>>> +{
Implement new admin command and helper function to handle/obtain CGU
measurements for input pins, initialize PPS dpll capabilities using new
command.
Add callbacks to control dpll device feature:
all-inputs-phase-offset-monitor.
Allow enable/disable of all inputs monitoring for ice PPS dpll device.
On 4/9/2025 7:04 AM, Olech, Milena wrote:
> On 4/8/2025 11:23 PM, Jacob Keller wrote:
>
>> On 4/8/2025 3:31 AM, Milena Olech wrote:
>>> +static void idpf_ptp_release_vport_tstamp(struct idpf_vport *vport)
>>> +{
>>> + struct idpf_ptp_tx_tstamp *ptp_tx_tstamp, *tmp;
>>> + struct list_head *h
Add infrastructure for adding simple control over dpll device level
features.
Add define for new dpll device level feature:
DPLL_FEATURES_ALL_INPUTS_PHASE_OFFSET_MONITOR - control over monitoring of
all input pins phase offsets.
Reviewed-by: Aleksandr Loktionov
Reviewed-by: Milena Olech
Signed-o
Hi,
in a setup where I use native XDP to redirect packets to a bonding interface
that's backed by two ixgbe slaves, I noticed that the ixgbe driver constantly
resets the NIC with the following kernel output:
ixgbe :01:00.1 ixgbe-x520-2: Detected Tx Unit Hang (XDP)
Tx Queue <
Add simple dpll device level feature and capabilities infrastructure over
netlink dpll interface.
Using new infrastructure add new feature: ALL_INPUTS_PHASE_OFFSET_MONITOR.
Allow users control with two new attributes:
- DPLL_A_CAPABILITIES - for checking if dpll device is capable,
- DPLL_A_FEATURES
Introduce a new ethtool statistic to ice driver, `link_down_events`,
to track the number of times the link transitions from up to down.
This counter can help diagnose issues related to link stability,
such as port flapping or unexpected link drops.
The counter increments when a link-down event occ
On 4/8/2025 11:17 PM, Jacob Keller wrote:
>On 4/8/2025 3:30 AM, Milena Olech wrote:
>> +static int idpf_ptp_read_src_clk_reg_mailbox(struct idpf_adapter *adapter,
>> + struct ptp_system_timestamp *sts,
>> + u64 *src_cl
On Fri, Mar 21, 2025 at 04:13:57PM +0100, Michal Kubiak wrote:
> The "ice" driver implementation uses the control VSI to handle
> the flow director configuration for PFs and VFs.
>
> Unfortunately, although a separate VSI type was created to handle flow
> director queues, the Rx queue handler was
[add Jason, linux-cxl]
Heads up for a new __uapi_uuid_t patch.
kernel test robot wrote:
> tree: https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git
> dev-queue
> head: 41ab790c342f99d9eb891807b2ff00caa56804b9
> commit: a4bf8e3b34147889963e4c46d1e7916f7157b784 [2/12] fwctl/cxl
The "enum virtchnl2_cap_rss" will be used for negotiating flow
steering capabilities. Instead of adding a new enum, rename
virtchnl2_cap_rss to virtchnl2_flow_types. Also rename the enum's
constants.
Flow steering will use this enum in the next patches.
Reviewed-by: Sridhar Samudrala
Signed-off-
Rename TSPLL and CGU functions, definitions etc. to match the file name
and have consistent naming scheme.
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_common.c | 32 +-
drivers/net/ethernet/intel/ice/ice_common.
Collect TSPLL related functions and definitions and move them to
a separate file to have all TSPLL functionality in one place.
Move CGU related functions and definitions to ice_common.*
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethern
Instead of multiple comments, use designated initializers for TSPLL
consts.
Adjust ice_tspll_params_e82x fields sizes.
Remove ice_tspll_params_e825 definitions as according to EDS (Electrical
Design Specification) doc, E825 devices support only 156.25 MHz TSPLL
frequency for both TCXO and TIME_RE
On 4/8/2025 11:15 PM, Jacob Keller wrote:
>On 4/8/2025 3:30 AM, Milena Olech wrote:
>> +static u64 idpf_ptp_read_src_clk_reg_direct(struct idpf_adapter *adapter,
>> +struct ptp_system_timestamp *sts)
>> +{
>> +struct idpf_ptp *ptp = adapter->ptp;
>> +
On Wed, Apr 09, 2025 at 01:36:23PM +0200, Martyna Szapar-Mudlaw wrote:
> Introduce a new ethtool statistic to ice driver, `link_down_events`,
> to track the number of times the link transitions from up to down.
> This counter can help diagnose issues related to link stability,
> such as port flappi
Add new argument on dpll device register, a capabilities bitmask of
features supported by the dpll device.
Provide capability value on dpll device dump.
Reviewed-by: Milena Olech
Signed-off-by: Arkadiusz Kubalewski
---
drivers/dpll/dpll_core.c | 5 -
drivers/dpll/dpll_
Add new callback ops for a dpll device.
- features_get(..) - to obtain currently configured features from dpll
device,
- feature_set(..) - to allow dpll device features configuration.
Provide features attribute and allow control over it to the users if
device driver implements callbacks.
Reviewe
Separate TSPLL related functions and definitions from all PTP-related
files and clean up the code by implementing multiple helpers.
Adjust TSPLL wait times and fall back to TCXO on lock failure to ensure
proper init flow of TSPLL.
Karol Kolacinski (10):
ice: move TSPLL functions to a separate f
Add ICE_READ_CGU_REG_OR_DIE() and ICE_WRITE_CGU_REG_OR_DIE() helpers to
avoid multiple error checks after calling read/write functions.
Suggested-by: Przemek Kitszel
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_com
To ensure proper operation, wait for 10 to 20 microseconds before
enabling TSPLL.
Adjust wait time after enabling TSPLL from 1-5 ms to 1-2 ms.
Those values are empirical and tested on multiple HW configurations.
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/etherne
TSPLL can fail when trying to lock to TIME_REF as a clock source, e.g.
when the external clock source is not stable or connected to the board.
To continue operation after failure, try to lock again to internal TCXO
and inform user about this.
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacin
On Tue, Apr 08, 2025 at 02:04:21PM +0200, Kurt Kanzenbach wrote:
> On Mon Apr 07 2025, Simon Horman wrote:
> > On Fri, Mar 21, 2025 at 02:52:38PM +0100, Kurt Kanzenbach wrote:
> >> Limit netdev_tc calls to MQPRIO. Currently these calls are made in
> >> igc_tsn_enable_offload() and igc_tsn_disable_o
Initialize TSPLL after initializing PHC in ice_ptp.c instead of calling
for each product in PHC init in ice_ptp_hw.c.
Reviewed-by: Michal Kubiak
Reviewed-by: Milena Olech
Signed-off-by: Karol Kolacinski
---
drivers/net/ethernet/intel/ice/ice_ptp.c| 11 +++
drivers/net/ethernet/inte
Dear Martyna,
Thank you for your patch.
Am 09.04.25 um 13:36 schrieb Martyna Szapar-Mudlaw:
Introduce a new ethtool statistic to ice driver, `link_down_events`,
to track the number of times the link transitions from up to down.
This counter can help diagnose issues related to link stability,
s
On 4/7/2025 6:30 AM, Przemek Kitszel wrote:
On 4/7/25 13:42, Michal Kubiak wrote:
On Mon, Apr 07, 2025 at 01:20:05PM +0200, Przemek Kitszel wrote:
Use Device Serial Number instead of PCI bus/device/function for
index of struct ice_adapter.
Functions on the same physical device should point t
Introduce a new ethtool statistic to ixgbe driver, `link_down_events`,
to track the number of times the link transitions from up to down.
This counter can help diagnose issues related to link stability,
such as port flapping or unexpected link drops.
The counter increments when a link-down event o
From: Pavan Kumar Linga
Support to initialize and configure controlq, Xn manager,
MMIO and reset APIs was introduced in libeth. As part of it,
most of the existing controlq structures are renamed and
modified. Use those APIs in idpf and make all the necessary changes.
Previously for the send and
This series introduces a new ethtool statistic, link_down_events,
to both the ixgbe and ice drivers. The purpose of this counter is
to track the number of times the network link transitions from up to
down.
This statistic can help diagnose issues related to link stability,
such as port flapping or
On 4/8/2025 11:12 PM, Jacob Keller wrote:
>On 4/8/2025 3:30 AM, Milena Olech wrote:
>> PTP capabilities are negotiated using virtchnl commands. There are two
>> available modes of the PTP support: direct and mailbox. When the direct
>> access to PTP resources is negotiated, virtchnl messages retur
37 matches
Mail list logo
