Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Andrew Lunn
> From a technical perspective, your patch looks correct. However, if the > checksum validation is skipped, there is no way to distinguish between the > simple checksum error described above, and actual NVM corruption, which may > result in loss of functionality and undefined behavior. This means,

Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix adapter NULL pointer dereference on reboot

2025-03-31 Thread Salin, Samuel
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, March 20, 2025 10:48 AM > To: Tantilov, Emil S > Cc: will...@google.com; pab...@redhat.com; net...@vger.kernel.org; > y...@redhat.com; Loktionov, Aleksandr ; > Dumazet, Eric ; Chittim, Madhu > ;

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Jacek Kowalski
From a technical perspective, your patch looks correct. However, if the checksum validation is skipped, there is no way to distinguish between the simple checksum error described above, and actual NVM corruption, which may result in loss of functionality and undefined behavior. This means, that if

Re: [Intel-wired-lan] [PATCH] e1000e: add option not to verify NVM checksum

2025-03-31 Thread Jacek Kowalski
Hi, Are you certain that the UEFI FW corrupts the checksum each time, or is it just that the system left the factory with incorrect checksum? I'm quite far from that device at the moment, but from what I remember: - when I forced the NVM update path in the driver, the device would work, - aft