Re: [Intel-wired-lan] [PATCH iwl-next v10 12/14] igc: block setting preemptible traffic class in taprio

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Since preemptible tc implementation is not ready yet, block it from being set in taprio. The existing code already blocks it in mqprio. Reviewed-by: Vladimir Oltean Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_main.c | 4 1

Re: [Intel-wired-lan] [PATCH iwl-next v10 07/14] igc: optimize TX packet buffer utilization for TSN mode

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: In preparation for upcoming frame preemption patches, optimize the TX packet buffer size. The total packet buffer size (RX + TX) is 64KB, with a maximum of 34KB for either RX or TX. Split the buffer evenly, allocating 32KB to each. For TX, assign 7KB to ea

Re: [Intel-wired-lan] [PATCH iwl-next v10 11/14] igc: add support to set tx-min-frag-size

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Add support for setting tx-min-frag-size via the set_mm callback in igc. If the requested value is unsupported, round it up to the smallest supported i226 size (64, 128, 192, 256) and send a netlink message to inform the user. Co-developed-by: Vinicius Cos

Re: [Intel-wired-lan] [PATCH net-next] igc: Fix TX drops in XDP ZC

2025-03-27 Thread Mor Bar-Gabay
On 19/03/2025 16:18, Zdenek Bouska wrote: Fixes TX frame drops in AF_XDP zero copy mode when budget < 4. xsk_tx_peek_desc() consumed TX frame and it was ignored because of low budget. Not even AF_XDP completion was done for dropped frames. It can be reproduced on i226 by sending 10x 60 B fra

Re: [Intel-wired-lan] [PATCH iwl-next v10 04/14] igc: rename xdp_get_tx_ring() for non-xdp usage

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Renamed xdp_get_tx_ring() function to a more generic name for use in upcoming frame preemption patches. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 9 - 2 files

Re: [Intel-wired-lan] [PATCH iwl-next v10 06/14] igc: use FIELD_PREP and GENMASK for existing TX packet buffer size

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: In preparation for an upcoming patch that will modify the TX buffer size in TSN mode, replace IGC_TXPBSIZE_TSN and IGC_TXPBSIZE_DEFAULT implementation with new macros that utilizes FIELD_PREP and GENMASK for clarity. The newly introduced macros follow the

Re: [Intel-wired-lan] [PATCH iwl-next v10 08/14] igc: use FIELD_PREP and GENMASK for existing RX packet buffer size

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Prepare for an upcoming patch that modifies the RX buffer size in TSN mode. Refactor IGC_RXPBSIZE_EXP_BMC_DEFAULT and IGC_RXPBS_CFG_TS_EN using FIELD_PREP and GENMASK to improve clarity and maintainability. Refactor both macros for consistency, even though

Re: [Intel-wired-lan] [PATCH iwl-next] igc: enable HW vlan tag insertion/stripping by default

2025-03-27 Thread Mor Bar-Gabay
On 13/03/2025 11:35, Rui Salvaterra wrote: This is enabled by default in other Intel drivers I've checked (e1000, e1000e, iavf, igb and ice). Fixes an out-of-the-box performance issue when running OpenWrt on typical mini-PCs with igc-supported Ethernet controllers and 802.1Q VLAN configurations,

Re: [Intel-wired-lan] [PATCH iwl-next v10 09/14] igc: set the RX packet buffer size for TSN mode

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: In preparation for supporting frame preemption, when entering TSN mode, set the receive packet buffer to 15KB for the Express MAC, 15KB for the Preemptible MAC and 2KB for the BMC. References: I225/I226 SW User Manual, Section 4.7.9, Section 7.1.3.2, Secti

Re: [Intel-wired-lan] [PATCH iwl-next v10 10/14] igc: add support for frame preemption verification

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: This patch implements the "ethtool --set-mm" callback to trigger the frame preemption verification handshake. Uses the MAC Merge Software Verification (mmsv) mechanism in ethtool to perform the verification handshake for igc. The structure fpe.mmsv is set

Re: [Intel-wired-lan] [PATCH iwl-next v10 14/14] igc: add support to get frame preemption statistics via ethtool

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Implemented "ethtool --include-statistics --show-mm" callback for IGC. Tested preemption scenario to check preemption statistics: 1) Trigger verification handshake on both boards: $ sudo ethtool --set-mm enp1s0 pmac-enabled on $ sudo ethtool --se

Re: [Intel-wired-lan] [PATCH iwl-net v2] ice: Check VF VSI Pointer Value in ice_vc_add_fdir_fltr()

2025-03-27 Thread Przemek Kitszel
On 3/25/25 03:01, Xuanqiang Luo wrote: From: Xuanqiang Luo As mentioned in the commit baeb705fd6a7 ("ice: always check VF VSI pointer values"), we need to perform a null pointer check on the return value of ice_get_vf_vsi() before using it. v2: Add "iwl-net" to the subject and modify the name

Re: [Intel-wired-lan] [PATCH iwl-next v10 13/14] igc: add support to get MAC Merge data via ethtool

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Implement "ethtool --show-mm" callback for IGC. Tested with command: $ ethtool --show-mm enp1s0. MAC Merge layer state for enp1s0: pMAC enabled: on TX enabled: on TX active: on TX minimum fragment size: 64 RX minimum fragment size: 60

Re: [Intel-wired-lan] [PATCH iwl-next v10 05/14] igc: rename I225_RXPBSIZE_DEFAULT and I225_TXPBSIZE_DEFAULT

2025-03-27 Thread Mor Bar-Gabay
On 18/03/2025 5:07, Faizal Rahim wrote: Rename RX and TX packet buffer size macros in preparation for an upcoming patch that will refactor buffer size handling using FIELD_PREP and GENMASK. Changes: - Rename I225_RXPBSIZE_DEFAULT to IGC_RXPBSIZE_EXP_BMC_DEFAULT. The EXP_BMC suffix explicitly