Re: [Intel-wired-lan] [PATCH iwl-next v2 3/3] ice: enable timesync operation on 2xNAC E825 devices

2025-03-17 Thread Simon Horman
On Mon, Mar 10, 2025 at 01:24:39PM +0100, Grzegorz Nitka wrote: > From: Karol Kolacinski > > According to the E825C specification, SBQ address for ports on a single > complex is device 2 for PHY 0 and device 13 for PHY1. > For accessing ports on a dual complex E825C (so called 2xNAC mode), > the

Re: [Intel-wired-lan] [PATCH iwl-next v1 1/3] ice: remove SW side band access workaround for E825

2025-03-17 Thread Simon Horman
On Mon, Mar 10, 2025 at 12:36:31PM +, Nitka, Grzegorz wrote: > > -Original Message- > > From: Intel-wired-lan On Behalf Of > > Nitka, Grzegorz > > Sent: Tuesday, March 4, 2025 2:04 PM > > To: Paul Menzel ; Kolacinski, Karol > > > > Cc: intel-wired-...@lists.osuosl.org; net...@vger.ker

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/3] ice: remove SW side band access workaround for E825

2025-03-17 Thread Simon Horman
On Mon, Mar 10, 2025 at 01:24:37PM +0100, Grzegorz Nitka wrote: > From: Karol Kolacinski > > Due to the bug in FW/NVM autoload mechanism (wrong default > SB_REM_DEV_CTL register settings), the access to peer PHY and CGU > clients was disabled by default. > > As the workaround solution, the regis

Re: [Intel-wired-lan] [iwl-net v3 2/5] ice: stop truncating queue ids when checking

2025-03-17 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Martyna Szapar-Mudlaw > Sent: Tuesday, March 4, 2025 12:09 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Glaza, Jan ; Loktionov, > Aleksandr ; Jagielski, Jedrzej > ; Simon Horman ; Martyna > Szapar-Mudlaw

Re: [Intel-wired-lan] [PATCH net-next 11/16] idpf: prepare structures to support XDP

2025-03-17 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Fri, 7 Mar 2025 14:27:13 +0100 > On Wed, Mar 05, 2025 at 05:21:27PM +0100, Alexander Lobakin wrote: >> From: Michal Kubiak >> >> Extend basic structures of the driver (e.g. 'idpf_vport', 'idpf_*_queue', >> 'idpf_vport_user_config_data') by adding members necessary

Re: [Intel-wired-lan] [iwl-net v3 5/5] ice: fix using untrusted value of pkt_len in ice_vc_fdir_parse_raw()

2025-03-17 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Martyna Szapar-Mudlaw > Sent: Tuesday, March 4, 2025 12:09 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Polchlopek, Mateusz > ; Kitszel, Przemyslaw > ; Martyna Szapar-Mudlaw mud...@linux.intel.com> > Su

[Intel-wired-lan] [PATCH][next][V2] ice: make const read-only array dflt_rules static

2025-03-17 Thread Colin Ian King
Don't populate the const read-only array dflt_rules on the stack at run time, instead make it static. Signed-off-by: Colin Ian King --- V2: Remove additional changes not related to this commit. --- drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +- 1 file changed, 1 insertion(+), 1 delet

[Intel-wired-lan] [PATCH][next] ice: make const read-only array dflt_rules static

2025-03-17 Thread Colin Ian King
Don't populate the const read-only array dflt_rules on the stack at run time, instead make it static. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/intel_memory_region.c| 2 +- drivers/net/ethernet/intel/ice/ice_ethtool_fdir.c | 2 +- 2 files changed, 2 insertions(+), 2 deletion

Re: [Intel-wired-lan] [PATCH][next] ice: make const read-only array dflt_rules static

2025-03-17 Thread Colin King (gmail)
Ignore, managed to mangle two commits into one. On 17/03/2025 14:46, Colin Ian King wrote: Don't populate the const read-only array dflt_rules on the stack at run time, instead make it static. Signed-off-by: Colin Ian King --- drivers/gpu/drm/i915/intel_memory_region.c| 2 +- driv

Re: [Intel-wired-lan] [iwl-net v3 1/5] virtchnl: make proto and filter action count unsigned

2025-03-17 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Szapar-Mudlaw, Martyna > Sent: Tuesday, March 4, 2025 2:12 PM > To: Paul Menzel ; Glaza, Jan > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Jagielski, > Jedrzej > ; Simon Horman ; Lobakin, > Aleksander > Subjec

Re: [Intel-wired-lan] [PATCH net-next 03/16] libeth: add a couple of XDP helpers (libeth_xdp)

2025-03-17 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Tue, 11 Mar 2025 15:05:38 +0100 > On Wed, Mar 05, 2025 at 05:21:19PM +0100, Alexander Lobakin wrote: >> "Couple" is a bit humbly... Add the following functionality to libeth: >> >> * XDP shared queues managing >> * XDP_TX bulk sending infra >> * .ndo_xdp_xmit() infr

[Intel-wired-lan] [PATCH iwl-next v10 00/14] igc: Add support for Frame Preemption feature in IGC

2025-03-17 Thread Faizal Rahim
Introduces support for the FPE feature in the IGC driver. The patches aligns with the upstream FPE API: https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/ https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.73054-1-vladimir.olt...

[Intel-wired-lan] [PATCH iwl-next v10 04/14] igc: rename xdp_get_tx_ring() for non-xdp usage

2025-03-17 Thread Faizal Rahim
Renamed xdp_get_tx_ring() function to a more generic name for use in upcoming frame preemption patches. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 9 - 2 files changed, 5 insertions(+), 6 deletions(-) dif

[Intel-wired-lan] [PATCH iwl-net v2] idpf: fix adapter NULL pointer dereference on reboot

2025-03-17 Thread Emil Tantilov
With SRIOV enabled, idpf ends up calling into idpf_remove() twice. First via idpf_shutdown() and then again when idpf_remove() calls into sriov_disable(), because the VF devices use the idpf driver, hence the same remove routine. When that happens, it is possible for the adapter to be NULL from the

[Intel-wired-lan] [PATCH iwl-next v10 12/14] igc: block setting preemptible traffic class in taprio

2025-03-17 Thread Faizal Rahim
Since preemptible tc implementation is not ready yet, block it from being set in taprio. The existing code already blocks it in mqprio. Reviewed-by: Vladimir Oltean Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_main.c | 4 1 file changed, 4 insertions(+) diff --git a/

[Intel-wired-lan] [PATCH iwl-next v10 05/14] igc: rename I225_RXPBSIZE_DEFAULT and I225_TXPBSIZE_DEFAULT

2025-03-17 Thread Faizal Rahim
Rename RX and TX packet buffer size macros in preparation for an upcoming patch that will refactor buffer size handling using FIELD_PREP and GENMASK. Changes: - Rename I225_RXPBSIZE_DEFAULT to IGC_RXPBSIZE_EXP_BMC_DEFAULT. The EXP_BMC suffix explicitly indicates Express and BMC buffer default

[Intel-wired-lan] [PATCH iwl-next v10 08/14] igc: use FIELD_PREP and GENMASK for existing RX packet buffer size

2025-03-17 Thread Faizal Rahim
Prepare for an upcoming patch that modifies the RX buffer size in TSN mode. Refactor IGC_RXPBSIZE_EXP_BMC_DEFAULT and IGC_RXPBS_CFG_TS_EN using FIELD_PREP and GENMASK to improve clarity and maintainability. Refactor both macros for consistency, even though the upcoming patch only use IGC_RXPBSIZE_E

[Intel-wired-lan] [PATCH iwl-next v10 11/14] igc: add support to set tx-min-frag-size

2025-03-17 Thread Faizal Rahim
Add support for setting tx-min-frag-size via the set_mm callback in igc. If the requested value is unsupported, round it up to the smallest supported i226 size (64, 128, 192, 256) and send a netlink message to inform the user. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Go

[Intel-wired-lan] [PATCH iwl-next v10 14/14] igc: add support to get frame preemption statistics via ethtool

2025-03-17 Thread Faizal Rahim
Implemented "ethtool --include-statistics --show-mm" callback for IGC. Tested preemption scenario to check preemption statistics: 1) Trigger verification handshake on both boards: $ sudo ethtool --set-mm enp1s0 pmac-enabled on $ sudo ethtool --set-mm enp1s0 tx-enabled on $ sudo ethtool

[Intel-wired-lan] [PATCH iwl-next v10 01/14] net: stmmac: move frag_size handling out of spin_lock

2025-03-17 Thread Faizal Rahim
The upcoming patch will extract verification logic into a new module, MMSV (MAC Merge Software Verification). MMSV will handle most FPE fields, except frag_size. It introduces its own lock (mmsv->lock), replacing fpe_cfg->lock. Since frag_size handling remains in the driver, the existing rtnl_lock

[Intel-wired-lan] [PATCH iwl-next v10 03/14] net: ethtool: mm: reset verification status when link is down

2025-03-17 Thread Faizal Rahim
When the link partner goes down, "ethtool --show-mm" still displays "Verification status: SUCCEEDED," reflecting a previous state that is no longer valid. Reset the verification status to ensure it reflects the current state. Reviewed-by: Furong Xu <0x1...@gmail.com> Reviewed-by: Vladimir Oltean

[Intel-wired-lan] [PATCH iwl-next v10 06/14] igc: use FIELD_PREP and GENMASK for existing TX packet buffer size

2025-03-17 Thread Faizal Rahim
In preparation for an upcoming patch that will modify the TX buffer size in TSN mode, replace IGC_TXPBSIZE_TSN and IGC_TXPBSIZE_DEFAULT implementation with new macros that utilizes FIELD_PREP and GENMASK for clarity. The newly introduced macros follow the naming from the i226 SW User Manual for e

[Intel-wired-lan] [PATCH iwl-next v10 13/14] igc: add support to get MAC Merge data via ethtool

2025-03-17 Thread Faizal Rahim
Implement "ethtool --show-mm" callback for IGC. Tested with command: $ ethtool --show-mm enp1s0. MAC Merge layer state for enp1s0: pMAC enabled: on TX enabled: on TX active: on TX minimum fragment size: 64 RX minimum fragment size: 60 Verify enabled: on Verify time: 128 Max verif

Re: [Intel-wired-lan] [PATCH iwl-net v3] ixgbe: fix media type detection for E610 device

2025-03-17 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Piotr Kwapulinski > Sent: Friday, February 21, 2025 9:19 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; pmen...@molgen.mpg.de; and...@lunn.ch; > Kwapulinski, Piotr ; Kitszel, Przemyslaw > > Subject: [Inte

Re: [Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of resources for RDMA when disabled

2025-03-17 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Jesse > Brandeburg > Sent: 06 March 2025 23:27 > To: intel-wired-...@lists.osuosl.org > Cc: Brandeburg, Jesse ; net...@vger.kernel.org; > kernel-t...@cloudflare.com; jbran...@kernel.org; l...@kernel.org; Kitszel, > Przemyslaw ; E

Re: [Intel-wired-lan] [iwl-next v4 1/1] iidc/ice/irdma: Update IDC to support multiple consumers

2025-03-17 Thread Leon Romanovsky
On Fri, Mar 14, 2025 at 06:18:00PM -0700, Samudrala, Sridhar wrote: > > > On 3/14/2025 11:12 AM, Leon Romanovsky wrote: > > On Thu, Mar 13, 2025 at 04:38:39PM -0700, Samudrala, Sridhar wrote: > > > > > > > > > On 3/2/2025 12:26 AM, Leon Romanovsky wrote: > > > > On Wed, Feb 26, 2025 at 11:01:52

Re: [Intel-wired-lan] [PATCH net-next 12/16] idpf: implement XDP_SETUP_PROG in ndo_bpf for splitq

2025-03-17 Thread Alexander Lobakin
From: Maciej Fijalkowski Date: Fri, 7 Mar 2025 15:16:48 +0100 > On Wed, Mar 05, 2025 at 05:21:28PM +0100, Alexander Lobakin wrote: >> From: Michal Kubiak >> >> Implement loading/removing XDP program using .ndo_bpf callback >> in the split queue mode. Reconfigure and restart the queues if needed

Re: [Intel-wired-lan] [iwl-net v3 3/5] ice: validate queue quanta parameters to prevent OOB access

2025-03-17 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Martyna Szapar-Mudlaw > Sent: Tuesday, March 4, 2025 12:09 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Glaza, Jan ; Jagielski, > Jedrzej > ; Simon Horman ; Martyna > Szapar-Mudlaw > Subject: [Intel-wi

Re: [Intel-wired-lan] [iwl-net v3 4/5] ice: fix input validation for virtchnl BW

2025-03-17 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Martyna Szapar-Mudlaw > Sent: Tuesday, March 4, 2025 12:09 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Czapnik, Lukasz ; > Jagielski, Jedrzej ; Simon Horman > ; Martyna Szapar-Mudlaw mud...@linux.intel