Re: [Intel-wired-lan] [PATCH iwl-next v4 6/6] ice: enable LLDP TX for VFs through tc

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:59 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH net-next v11 0/4] fix the DMA API misuse problem for page_pool

2025-03-11 Thread Paolo Abeni
On 3/8/25 3:40 PM, Toke Høiland-Jørgensen wrote: > Yunsheng Lin writes: >> I only took a glance at git code above, it seems reusing the >> _pp_mapping_pad for pp_dma_index seems like a wrong direction >> as mentioned in discussion with Ilias above as the field might >> be used when a page is mmap'

Re: [Intel-wired-lan] [PATCH net-next 14/16] idpf: add support for XDP on Rx

2025-03-11 Thread Maciej Fijalkowski
On Wed, Mar 05, 2025 at 05:21:30PM +0100, Alexander Lobakin wrote: > Use libeth XDP infra to support running XDP program on Rx polling. > This includes all of the possible verdicts/actions. > XDP Tx queues are cleaned only in "lazy" mode when there are less than > 1/4 free descriptors left on the r

Re: [Intel-wired-lan] [PATCH net-next 15/16] idpf: add support for .ndo_xdp_xmit()

2025-03-11 Thread Maciej Fijalkowski
On Wed, Mar 05, 2025 at 05:21:31PM +0100, Alexander Lobakin wrote: > Use libeth XDP infra to implement .ndo_xdp_xmit() in idpf. > The Tx callbacks are reused from XDP_TX code. XDP redirect target > feature is set/cleared depending on the XDP prog presence, as for now > we still don't allocate XDP T

Re: [Intel-wired-lan] [PATCH net-next 03/16] libeth: add a couple of XDP helpers (libeth_xdp)

2025-03-11 Thread Maciej Fijalkowski
On Wed, Mar 05, 2025 at 05:21:19PM +0100, Alexander Lobakin wrote: > "Couple" is a bit humbly... Add the following functionality to libeth: > > * XDP shared queues managing > * XDP_TX bulk sending infra > * .ndo_xdp_xmit() infra > * adding buffers to &xdp_buff > * running XDP prog and managing its

Re: [Intel-wired-lan] [PATCH iwl-next v4 3/6] ice: receive LLDP on trusted VFs

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:58 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH iwl-next v6 02/15] ixgbe: wrap netdev_priv() usage

2025-03-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Friday, March 7, 2025 7:54 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; > net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Kitszel, > Przemyslaw ; Jagielski, Jedrzej > >

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: fix MMIO write access to an invalid page in i40e_clear_hw

2025-03-11 Thread Przemek Kitszel
On 3/11/25 06:16, Kyungwook Boo wrote: When the device sends a specific input, an integer underflow can occur, leading to MMIO write access to an invalid page. Prevent the integer underflow by changing the type of related variables. Signed-off-by: Kyungwook Boo Link: https://lore.kernel.org/l

Re: [Intel-wired-lan] [PATCH iwl-next v3] igc: Change Tx mode for MQPRIO offloading

2025-03-11 Thread Abdul Rahim, Faizal
On 7/3/2025 11:02 pm, Vladimir Oltean wrote: On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote: diff --git a/drivers/net/ethernet/intel/igc/igc.h b/drivers/net/ethernet/intel/igc/igc.h index cd1d7b6c1782352094f6867a31b6958c929bbbf4..16d85bdf55a7e9c412c47acf727bca6bc7154c61 10

Re: [Intel-wired-lan] [PATCH iwl-next v4 4/6] ice: remove headers argument from ice_tc_count_lkups

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:58 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH iwl-next v4 2/6] ice: do not add LLDP-specific filter if not necessary

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:57 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH iwl-next v2] i40e: fix MMIO write access to an invalid page in i40e_clear_hw

2025-03-11 Thread Simon Horman
On Tue, Mar 11, 2025 at 02:16:02PM +0900, Kyungwook Boo wrote: > When the device sends a specific input, an integer underflow can occur, > leading > to MMIO write access to an invalid page. > > Prevent the integer underflow by changing the type of related variables. > > Signed-off-by: Kyungwook

Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-11 Thread Przemek Kitszel
On 3/10/25 13:23, Jiri Pirko wrote: Mon, Mar 10, 2025 at 09:40:16AM +0100, przemyslaw.kits...@intel.com wrote: Subject: Re: [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index regarding -net vs -next, no one have complained that this bug hurts Wait, so we are now waiting

Re: [Intel-wired-lan] [PATCH net-next 06/16] idpf: a use saner limit for default number of queues to allocate

2025-03-11 Thread Maciej Fijalkowski
On Wed, Mar 05, 2025 at 05:21:22PM +0100, Alexander Lobakin wrote: > Currently, the maximum number of queues available for one vport is 16. > This is hardcoded, but then the function calculating the optimal number > of queues takes min(16, num_online_cpus()). > On order to be able to allocate more

Re: [Intel-wired-lan] [PATCH net-next 00/16] idpf: add XDP support

2025-03-11 Thread Alexander Lobakin
From: Alexander Lobakin Date: Wed, 5 Mar 2025 17:21:16 +0100 > Add XDP support (w/o XSk yet) to the idpf driver using the libeth_xdp > sublib, which will be then reused in at least iavf and ice. Ok, today I'm back at work. First of all, sorry for the confusion, the subject prefix must've been "

[Intel-wired-lan] ixgbe: Firmware error and NIC went away.

2025-03-11 Thread Ben Greear
Hello, We had the ixgbe radios in one of our systems on an overnight test. To my knowledge, we have never seen this particular issue before. Please let me know if you have any ideas on what caused it or how we can get better logs to debug it. We plan to replace the NIC and re-run in case it

Re: [Intel-wired-lan] [PATCH net-next v11 1/4] page_pool: introduce page_pool_get_pp() API

2025-03-11 Thread Harshitha Ramamurthy
On Fri, Mar 7, 2025 at 1:31 AM Yunsheng Lin wrote: > Introduce page_pool_get_pp() API to avoid caller accessing > page->pp directly, in order to make the following patch more > reviewable as the following patch will change page->pp to > page->pp_item to fix the DMA API misuse problem. > > Signed-

Re: [Intel-wired-lan] [PATCH net-next 01/16] libeth: convert to netmem

2025-03-11 Thread Mina Almasry
On Tue, Mar 11, 2025 at 10:23 AM Alexander Lobakin wrote: > > From: Mina Almasry > Date: Wed, 5 Mar 2025 16:13:32 -0800 > > > On Wed, Mar 5, 2025 at 8:23 AM Alexander Lobakin > > wrote: > >> > >> Back when the libeth Rx core was initially written, devmem was a draft > >> and netmem_ref didn't ex

Re: [Intel-wired-lan] [PATCH iwl-next v4 5/6] ice: support egress drop rules on PF

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:59 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH net-next 01/16] libeth: convert to netmem

2025-03-11 Thread Alexander Lobakin
From: Mina Almasry Date: Wed, 5 Mar 2025 16:13:32 -0800 > On Wed, Mar 5, 2025 at 8:23 AM Alexander Lobakin > wrote: >> >> Back when the libeth Rx core was initially written, devmem was a draft >> and netmem_ref didn't exist in the mainline. Now that it's here, make >> libeth MP-agnostic before i

[Intel-wired-lan] [PATCH iwl-next 06/10] ice: use bitfields instead of unions for CGU regs

2025-03-11 Thread Karol Kolacinski
Switch from unions with bitfield structs to definitions with bitfield masks. This is necessary, because some registers have different field definitions or even use a different register for the same fields based on HW type. Remove unused register fields. Reviewed-by: Milena Olech Signed-off-by: K

[Intel-wired-lan] [PATCH net 2/5] renesas: reject PTP_STRICT_FLAGS as unsupported

2025-03-11 Thread Jacob Keller
The ravb_ptp_extts() function checks the flags coming from the PTP_EXTTS_REQUEST ioctl, to ensure that future flags are not accepted on accident. This was updated to 'honor' the PTP_STRICT_FLAGS in commit 6138e687c7b6 ("ptp: Introduce strict checking of external time stamp options."). However, the

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/4] igb: Link queues to NAPI instances

2025-03-11 Thread Joe Damato
On Fri, Mar 07, 2025 at 02:03:44PM -0800, Tony Nguyen wrote: > On 2/17/2025 3:31 AM, Kurt Kanzenbach wrote: > > ... > > > diff --git a/drivers/net/ethernet/intel/igb/igb_xsk.c > > b/drivers/net/ethernet/intel/igb/igb_xsk.c > > index > > 157d43787fa0b55a74714f69e9e7903b695fcf0a..a5ad090dfe94b6af

Re: [Intel-wired-lan] [PATCH iwl-next v3 4/4] ixgbe: add E610 .set_phys_id() callback implementation

2025-03-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Monday, March 3, 2025 5:37 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; > net...@vger.kernel.org; and...@lunn.ch; pmen...@molgen.mpg.de; > Jagielski, Jedrzej ; Loktionov, Aleksandr

Re: [Intel-wired-lan] [PATCH iwl-next v4 1/6] ice: fix check for existing switch rule

2025-03-11 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, February 20, 2025 3:56 PM > To: Zaremba, Larysa > Cc: Nguyen, Anthony L ; intel-wired- > l...@lists.osuosl.org; Kitszel, Przemyslaw ; > Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub > Kicin

Re: [Intel-wired-lan] [PATCH iwl-next v6] ice: Add E830 checksum offload support

2025-03-11 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Paul > Greenwalt > Sent: 18 December 2024 14:42 > To: intel-wired-...@lists.osuosl.org > Cc: k...@kernel.org; net...@vger.kernel.org; Greenwalt, Paul > ; Alice Michael ; Eric > Joyner > Subject: [Intel-wired-lan] [PATCH iwl-next

[Intel-wired-lan] [PATCH 1/2] net: intel: Remove unnecessary static variable initialization

2025-03-11 Thread Joao Bonifacio
Static variables in C are implicitly initialized to zero, so there is no need to explicitly set and to 0. This change removes the redundant initialization Signed-off-by: Joao Bonifacio --- drivers/net/ethernet/intel/e100.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/

[Intel-wired-lan] [PATCH iwl-next 00/10] ice: Separate TSPLL from PTP and clean up

2025-03-11 Thread Karol Kolacinski
Separate TSPLL related functions and definitions from all PTP-related files and clean up the code by implementing multiple helpers. Adjust TSPLL wait times and fall back to TCXO on lock failure to ensure proper init flow of TSPLL. Karol Kolacinski (10): ice: move TSPLL functions to a separate f

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: add E830 Earliest TxTime First Offload support

2025-03-11 Thread kernel test robot
Hi Paul, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] url: https://github.com/intel-lab-lkp/linux/commits/Paul-Greenwalt/ice-add-E830-Earliest-TxTime-First-Offload-support/20250312-051400 base: https://git.kernel.org/pub/sc

Re: [Intel-wired-lan] [PATCH net 1/5] igb: reject invalid external timestamp requests for 82580-based HW

2025-03-11 Thread Keller, Jacob E
> -Original Message- > From: Michal Swiatkowski > Sent: Monday, March 10, 2025 11:04 PM > To: Keller, Jacob E > Cc: Nguyen, Anthony L ; Kitszel, Przemyslaw > ; Andrew Lunn ; David > S. Miller ; Eric Dumazet ; > Jakub Kicinski ; Paolo Abeni ; Richard > Cochran ; Ruud Bos ; Paul > Barker

[Intel-wired-lan] [iwl-next v1 8/8] i40e: use libie_aq_str

2025-03-11 Thread Michal Swiatkowski
There is no need to store the err string in hw->err_str. Simplify it and use common helper. hw->err_str is still used for other purpouse. It should be marked that previously for unknown error the numeric value was passed as a string. Now the "LIBIE_AQ_RC_UNKNOWN" is used for such cases. Add libie

[Intel-wired-lan] [iwl-next v1 5/8] libie: add adminq helper for converting err to str

2025-03-11 Thread Michal Swiatkowski
Add a new module for common handling of Admin Queue related logic. Start by a helper for error to string conversion. This lives inside libie/, but is a separate module what follows our logic of splitting into topical modules, to avoid pulling in not needed stuff, and have better organization in gen

[Intel-wired-lan] [iwl-next v1 4/8] iavf: use libie adminq descriptors

2025-03-11 Thread Michal Swiatkowski
Use libie_aq_desc instead of iavf_aq_desc. Do needed changes to allow clean build Use libie_aq_raw() wherever it can be used. Reviewed-by: Przemek Kitszel Reviewed-by: Aleksandr Loktionov Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/iavf/iavf_adminq.h | 12 +- .../net/eth

[Intel-wired-lan] [iwl-next v1 0/8] libie: commonize adminq structure

2025-03-11 Thread Michal Swiatkowski
Hi, It is a prework to allow reusing some specific Intel code (eq. fwlog). Move common *_aq_desc structure to libie header and changing it in ice, ixgbe, i40e and iavf. Only generic adminq commands can be easily moved to common header, as rest is slightly different. Format remains the same. It w

[Intel-wired-lan] [iwl-next v1 6/8] ice: use libie_aq_str

2025-03-11 Thread Michal Swiatkowski
Simple: s/ice_aq_str/libie_aq_str Add libie_aminq module in ice Kconfig. Reviewed-by: Przemek Kitszel Signed-off-by: Michal Swiatkowski --- drivers/net/ethernet/intel/Kconfig| 1 + drivers/net/ethernet/intel/ice/ice.h | 1 - .../net/ethernet/intel/ice/devlink/devlink.c

Re: [Intel-wired-lan] [PATCH iwl-next v6 04/15] ixgbe: add handler for devlink .info_get()

2025-03-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Friday, March 7, 2025 7:54 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; > net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej > ; Polchlopek, Mateusz > >

Re: [Intel-wired-lan] [PATCH iwl-next v6 08/15] ixgbe: add .info_get extension specific for E610 devices

2025-03-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Friday, March 7, 2025 7:54 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; > net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej > ; Polchlopek, Mateusz > ; M

Re: [Intel-wired-lan] [PATCH iwl-next v6 10/15] ixgbe: extend .info_get with stored versions

2025-03-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jedrzej Jagielski > Sent: Friday, March 7, 2025 7:54 PM > To: intel-wired-...@lists.osuosl.org > Cc: Nguyen, Anthony L ; > net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej > ; Polchlopek, Mateusz > ; K

[Intel-wired-lan] [PATCH iwl-next v2] ice: add E830 Earliest TxTime First Offload support

2025-03-11 Thread Paul Greenwalt
E830 supports Earliest TxTime First (ETF) hardware offload, which is configured via the ETF Qdisc (see tc-etf(8)). ETF introduces a new Tx flow mechanism that utilizes a timestamp ring (tstamp_ring) alongside the standard Tx ring. This timestamp ring is used to indicate when hardware will transmit

Re: [Intel-wired-lan] [PATCH iwl-next v2] ice: add E830 Earliest TxTime First Offload support

2025-03-11 Thread kernel test robot
Hi Paul, kernel test robot noticed the following build errors: [auto build test ERROR on tnguy-next-queue/dev-queue] url: https://github.com/intel-lab-lkp/linux/commits/Paul-Greenwalt/ice-add-E830-Earliest-TxTime-First-Offload-support/20250312-051400 base: https://git.kernel.org/pub/scm/li

Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-11 Thread Przemek Kitszel
-void ice_adapter_put(const struct pci_dev *pdev) +void ice_adapter_put(struct pci_dev *pdev) { A bit of a shame that this needs to be non const now.. Could pci_get_dsn() be made const? Or does it do something which might modify the device somehow? Would make sense to me to make it const.

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS 4f262e9f14eb198ecef69562d87b02a766b772a0

2025-03-11 Thread kernel test robot
allnoconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250311gcc-13.2.0 arc randconfig-002-20250311gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm