Re: [Intel-wired-lan] [PATCH iwl-next] ice: use DSN instead of PCI BDF for ice_adapter index

2025-03-06 Thread Jacob Keller
On 3/6/2025 1:11 PM, Przemek Kitszel wrote: > Use Device Serial Number instead of PCI bus/device/function for > index of struct ice_adapter. > Functions on the same physical device should point to the very same > ice_adapter instance. > > This is not only simplification, but also fixes things u

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 15f8b9eed0baa7b18679e888d21099704d0cb662

2025-03-06 Thread kernel test robot
. More configs may be tested in the coming days. tested configs: alpha allnoconfiggcc-14.2.0 arc allnoconfiggcc-13.2.0 arcnsim_700_defconfiggcc-13.2.0 arc randconfig-001-20250306gcc

[Intel-wired-lan] [PATCH iwl-net] idpf: fix adapter NULL pointer dereference on reboot

2025-03-06 Thread Emil Tantilov
Driver calls idpf_remove() from idpf_shutdown(), which can end up calling idpf_remove() again when disabling SRIOV. echo 1 > /sys/class/net//device/sriov_numvfs reboot BUG: kernel NULL pointer dereference, address: 0020 ... RIP: 0010:idpf_remove+0x22/0x1f0 [idpf] ... ? idpf_remove+0x2

Re: [Intel-wired-lan] [PATCH] i40e: fix MMIO write access to an invalid page in i40e_clear_hw

2025-03-06 Thread Kyungwook Boo
On 25. 3. 6. 20:13, Loktionov, Aleksandr wrote: > > >> -Original Message- >> From: Kyungwook Boo >> Sent: Thursday, March 6, 2025 6:26 AM >> To: Loktionov, Aleksandr ; Kitszel, >> Przemyslaw ; Nguyen, Anthony L >> >> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org >> Subjec

Re: [Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of resources for RDMA when disabled

2025-03-06 Thread Loktionov, Aleksandr
> -Original Message- > From: Intel-wired-lan On Behalf Of > Jesse Brandeburg > Sent: Thursday, March 6, 2025 6:57 PM > To: intel-wired-...@lists.osuosl.org > Cc: Brandeburg, Jesse ; > net...@vger.kernel.org; kernel-t...@cloudflare.com; jbran...@kernel.org; > l...@kernel.org; Kitszel, Pr

Re: [Intel-wired-lan] [PATCH net-next 11/16] idpf: prepare structures to support XDP

2025-03-06 Thread Jakub Kicinski
On Wed, 5 Mar 2025 17:21:27 +0100 Alexander Lobakin wrote: > +/** > + * idpf_xdp_is_prog_ena - check if there is an XDP program on adapter > + * @vport: vport to check > + */ > +static inline bool idpf_xdp_is_prog_ena(const struct idpf_vport *vport) > +{ > + return vport->adapter && vport->xdp

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: fix adapter NULL pointer dereference on reboot

2025-03-06 Thread Michal Swiatkowski
On Thu, Mar 06, 2025 at 04:39:56PM -0800, Emil Tantilov wrote: > Driver calls idpf_remove() from idpf_shutdown(), which can end up > calling idpf_remove() again when disabling SRIOV. > The same is done in other drivers (ice, iavf). Why here it is a problem? I am asking because heaving one functio

Re: [Intel-wired-lan] [PATCH iwl-next v8 11/11] igc: add support to get frame preemption statistics via ethtool

2025-03-06 Thread Abdul Rahim, Faizal
On 6/3/2025 8:48 am, Vladimir Oltean wrote: On Wed, Mar 05, 2025 at 08:00:26AM -0500, Faizal Rahim wrote: +/* Received out of order packets with SMD-C */ +#define IGC_PRMEXCPRCNT_OOO_SMDC 0x00FF +/* Received out of order packets with SMD-C and wrong Frame CNT */ +#de

Re: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixgbe: add support for devlink reload

2025-03-06 Thread Simon Horman
On Fri, Feb 21, 2025 at 12:51:13PM +0100, Jedrzej Jagielski wrote: > The E610 adapters contain an embedded chip with firmware which can be > updated using devlink flash. The firmware which runs on this chip is > referred to as the Embedded Management Processor firmware (EMP > firmware). > > Activa

Re: [Intel-wired-lan] [PATCH] i40e: Disable i40e PCIe AER on system reboot

2025-03-06 Thread Yue Zhao
Hi Tony, I am resending as I realized I sent in Rich Text instead of Plain Text. I am sorry if any of you got this duplicate email. Our DELL servers are all out of warranty, so I cannot provide more useful information from the communication with the vendor side. Is there any possible fix via upgr

Re: [Intel-wired-lan] [PATCH] i40e: fix MMIO write access to an invalid page in i40e_clear_hw

2025-03-06 Thread Przemek Kitszel
On 3/6/25 06:25, Kyungwook Boo wrote: In i40e_clear_hw(), when the device sends a specific input(e.g., 0), an integer underflow in the num_{pf,vf}_int variables can occur, leading to MMIO write access to an invalid page. To fix this, we change the type of the unsigned integer variables num_{pf,v

Re: [Intel-wired-lan] [PATCH] i40e: fix MMIO write access to an invalid page in i40e_clear_hw

2025-03-06 Thread Loktionov, Aleksandr
> -Original Message- > From: Kyungwook Boo > Sent: Thursday, March 6, 2025 6:26 AM > To: Loktionov, Aleksandr ; Kitszel, > Przemyslaw ; Nguyen, Anthony L > > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org > Subject: [PATCH] i40e: fix MMIO write access to an invalid page in

Re: [Intel-wired-lan] [PATCH iwl-next v5 12/15] ixgbe: add support for devlink reload

2025-03-06 Thread Jagielski, Jedrzej
From: Simon Horman >Sent: Thursday, March 6, 2025 10:41 AM >To: Jagielski, Jedrzej >Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L >; net...@vger.kernel.org; j...@nvidia.com; >Polchlopek, Mateusz ; Mrozowicz, SlawomirX >; Kwapulinski, Piotr >; Wegrzyn, Stefan >Subject: Re: [PATCH i

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix XSK queue NAPI ID mapping

2025-03-06 Thread florian
Hi Joe, On 2025-03-05 19:09, Joe Damato wrote: In commit b65969856d4f ("igc: Link queues to NAPI instances"), the XSK queues were incorrectly unmapped from their NAPI instances. After discussion on the mailing list and the introduction of a test to codify the expected behavior, we can see that t

[Intel-wired-lan] [tnguy-next-queue:for-next-fixes] BUILD SUCCESS f798c4bce163411673e49b7d07587aff7896ded4

2025-03-06 Thread kernel test robot
ilt successfully. More configs may be tested in the coming days. tested configs: alpha allnoconfiggcc-14.2.0 arc allnoconfiggcc-14.2.0 arc randconfig-001-20250306gcc-13.2.0 arc randconfig-

[Intel-wired-lan] [tnguy-net-queue:100GbE] BUILD SUCCESS 2a3e89a14864090ee4804fcec655ffc15fabf45c

2025-03-06 Thread kernel test robot
-20250306gcc-13.2.0 arc randconfig-002-20250306gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm allyesconfiggcc-14.2.0 arm randconfig-001-20250306gcc-14.2.0 arm randconfig-002

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix XSK queue NAPI ID mapping

2025-03-06 Thread Joe Damato
On Thu, Mar 06, 2025 at 05:27:38PM +0100, flor...@bezdeka.de wrote: > Hi Joe, > > On 2025-03-05 19:09, Joe Damato wrote: > > In commit b65969856d4f ("igc: Link queues to NAPI instances"), the XSK > > queues were incorrectly unmapped from their NAPI instances. After > > discussion on the mailing li

[Intel-wired-lan] [PATCH intel-net v2] ice: fix reservation of resources for RDMA when disabled

2025-03-06 Thread Jesse Brandeburg
From: Jesse Brandeburg If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a built-in, then don't let the driver reserve resources for RDMA. The result of this change is a large savings in resources for older kernels, and a cleaner driver configuration for the IRDMA=n case for old

Re: [Intel-wired-lan] [PATCH iwl-net] igc: Fix XSK queue NAPI ID mapping

2025-03-06 Thread Tony Nguyen
On 3/6/2025 8:45 AM, Joe Damato wrote: On Thu, Mar 06, 2025 at 05:27:38PM +0100, flor...@bezdeka.de wrote: ... Btw: I got this patch via stable. It doesn't make sense to send it to stable where this patch does not apply. Maybe I made a mistake, but as far as I can tell the commit under f