On 3/3/25 21:47, joaomboni wrote:
Signed-off-by: Joao Bonifacio
it will be good to use imperative mood in the Subject,
and add one more paragraph, like:
Subject: e1000: mark global variables const where possible
Next paragraph:
Mark global variables const, so unintended modification would no
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej
> ; Polchlopek, Mateusz
>
On 3/4/2025 12:15 PM, Paul Menzel wrote:
Dear Jan, dear Martina,
Thank you for the patch.
Am 04.03.25 um 12:08 schrieb Martyna Szapar-Mudlaw:
From: Jan Glaza
The count field in virtchnl_proto_hdrs and virtchnl_filter_action_set
should never be negative while still being valid. Changing i
Dear Martyna,
Thank you for your quick reply.
Am 04.03.25 um 12:45 schrieb Szapar-Mudlaw, Martyna:
On 3/4/2025 12:15 PM, Paul Menzel wrote:
Am 04.03.25 um 12:08 schrieb Martyna Szapar-Mudlaw:
From: Jan Glaza
The count field in virtchnl_proto_hdrs and virtchnl_filter_action_set
should ne
On Mon, Mar 03, 2025 at 05:26:54AM -0500, Faizal Rahim wrote:
> +static inline bool igc_fpe_is_verify_or_response(union igc_adv_rx_desc
> *rx_desc,
> + unsigned int size)
> +{
> + u32 status_error = le32_to_cpu(rx_desc->wb.upper.status_error);
> +
On 3/3/2025 10:54 AM, Simon Horman wrote:
On Wed, Feb 26, 2025 at 12:33:56PM +0100, Mateusz Polchlopek wrote:
Embed ice_get_tx_topo_user_sel() inside the only caller:
ice_devlink_tx_sched_layers_get().
Instead of jump from the wrapper to the function that does "get" operation
it does "get" it
On 3/4/2025 12:51 PM, Paul Menzel wrote:
Dear Martyna,
Thank you for your quick reply.
Am 04.03.25 um 12:45 schrieb Szapar-Mudlaw, Martyna:
On 3/4/2025 12:15 PM, Paul Menzel wrote:
Am 04.03.25 um 12:08 schrieb Martyna Szapar-Mudlaw:
From: Jan Glaza
The count field in virtchnl_proto_
> > > However, that does not really help explain how this helps prevent an
> > > interrupt. I assume playing with EEE settings was also played
> > > with. Not that is register appears to have anything to do with EEE!
> > >
> > I don't think we did tried those - it was never suggested that I can re
> -Original Message-
> From: Paul Menzel
> Sent: Friday, February 21, 2025 10:16 PM
> To: Nitka, Grzegorz ; Kolacinski, Karol
>
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Kitszel,
> Przemyslaw ; Michal Swiatkowski
>
> Subject: Re: [Intel-wired-lan] [PATCH iwl-next v1
[RE-SEND] I just realized I sent this only to iwl, sorry for spamming.
On 2025-03-03 10:11 a.m., Arinzon, David wrote:
Use the core's rmap notifiers and delete our own.
Acked-by: David Arinzon
Signed-off-by: Ahmed Zaki
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 43 +
Thanks Vitaly,
On Tue, Mar 4, 2025, at 5:48 AM, Lifshits, Vitaly wrote:
> On 3/3/2025 5:34 AM, Mark Pearson wrote:
>> Hi Andrew,
>>
>> On Sun, Mar 2, 2025, at 11:13 AM, Andrew Lunn wrote:
>>> On Sun, Mar 02, 2025 at 03:09:35PM +0200, Lifshits, Vitaly wrote:
Hi Mark,
> Hi A
On Mon, Mar 03, 2025 at 10:16:33AM +0100, Kurt Kanzenbach wrote:
> The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
> this mode the hardware uses four packet buffers and considers queue
> priorities.
>
> In order to harmonize the TAPRIO implementation with MQPRIO, switch t
> [RE-SEND] I just realized I sent this only to iwl, sorry for spamming.
>
>
> On 2025-03-03 10:11 a.m., Arinzon, David wrote:
> >> Use the core's rmap notifiers and delete our own.
> >>
> >> Acked-by: David Arinzon
> >> Signed-off-by: Ahmed Zaki
> >> ---
> >> drivers/net/ethernet/amazon/ena/
On 3/3/2025 5:34 AM, Mark Pearson wrote:
Hi Andrew,
On Sun, Mar 2, 2025, at 11:13 AM, Andrew Lunn wrote:
On Sun, Mar 02, 2025 at 03:09:35PM +0200, Lifshits, Vitaly wrote:
Hi Mark,
Hi Andrew
On Thu, Feb 27, 2025, at 11:07 AM, Andrew Lunn wrote:
+ e1e_rphy(hw, PHY_
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Przemek Kitszel
> Sent: Tuesday, March 4, 2025 9:28 AM
> To: joaomboni
> Cc: Nguyen, Anthony L ;
> andrew+net...@lunn.ch; da...@davemloft.net; eduma...@google.com;
> k...@kernel.org; pab...@redhat.com; intel-wired-...@lists.osu
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> joaomboni
> Sent: Monday, March 3, 2025 9:48 PM
> To: Nguyen, Anthony L ; Kitszel, Przemyslaw
> ; andrew+net...@lunn.ch;
> da...@davemloft.net; eduma...@google.com; k...@kernel.org;
> pab...@redhat.com
> Cc: intel-wired-...@lis
From: Jan Glaza
Queue IDs can be up to 4096, fix invalid check to stop
truncating IDs to 8 bits.
Fixes: bf93bf791cec8 ("ice: introduce ice_virtchnl.c and ice_virtchnl.h")
Reviewed-by: Aleksandr Loktionov
Reviewed-by: Jedrzej Jagielski
Reviewed-by: Simon Horman
Signed-off-by: Jan Glaza
Signed
From: Jan Glaza
Add queue wraparound prevention in quanta configuration.
Ensure end_qid does not overflow by validating start_qid and num_queues.
Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta size
configuration")
Reviewed-by: Jedrzej Jagielski
Reviewed-by: Simon Horman
Sig
From: Jan Glaza
The count field in virtchnl_proto_hdrs and virtchnl_filter_action_set
should never be negative while still being valid. Changing it from
int to u32 ensures proper handling of values in virtchnl messages in
driverrs and prevents unintended behavior.
In its current signed form, a ne
This patch series addresses validation issues in the virtchnl interface
of the ice driver. These fixes correct improper value checking,
ensuring that the driver can properly handle and reject invalid inputs
from potentially malicious VFs. By fixing validation mechanisms,
these patches strictly enfo
From: Lukasz Czapnik
Add missing validation of tc and queue id values sent by a VF in
ice_vc_cfg_q_bw().
Additionally fixed logged value in the warning message,
where max_tx_rate was incorrectly referenced instead of min_tx_rate.
Also correct error handling in this function by properly exiting
wh
Dear Jan, dear Martina,
Thank you for the patch.
Am 04.03.25 um 12:08 schrieb Martyna Szapar-Mudlaw:
From: Jan Glaza
The count field in virtchnl_proto_hdrs and virtchnl_filter_action_set
should never be negative while still being valid. Changing it from
int to u32 ensures proper handling of
From: Mateusz Polchlopek
Fix using the untrusted value of proto->raw.pkt_len in function
ice_vc_fdir_parse_raw() by verifying if it does not exceed the
VIRTCHNL_MAX_SIZE_RAW_PACKET value.
Fixes: 99f419df8a5c ("ice: enable FDIR filters from raw binary patterns for
VFs")
Reviewed-by: Przemek Kits
On 3/3/2025 5:30 PM, Paul Menzel wrote:
Dear Linux folks,
On a Dell OptiPlex 7000/0F1HC1, BIOS 1.8.2 12/08/2022 with
00:1f.6 Ethernet controller [0200]: Intel Corporation Ethernet
Connection (17) I219-LM [8086:1a1c] (rev 11)
and Dell OptiPlex 7071/097YXY, BIOS 1.1.2 08/29/2019 with
On Mon, Mar 03, 2025 at 05:26:50AM -0500, Faizal Rahim wrote:
> +/**
> + * ethtool_mmsv_link_state_handle() - Inform MAC Merge Software Verification
> + * of link state changes
> + * @mmsv: MAC Merge Software Verification state
> + * @up: True if device carrier is up
> > I suggest to try replacing the register read for a short delay or
> > reading the PHY STATUS register instead.
> >
>
> Ack - we'll try that, and collect some other debug registers in the process.
> Will update with findings - this may take a while :)
Please be careful with which register you
> -Original Message-
> From: Simon Horman
> Sent: Tuesday, February 25, 2025 4:05 PM
> To: Nitka, Grzegorz
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Kolacinski,
> Karol ; Kitszel, Przemyslaw
>
> Subject: Re: [PATCH iwl-next v1 3/3] ice: enable timesync operation on
27 matches
Mail list logo
