On Fri, Feb 21, 2025 at 5:37 PM Jedrzej Jagielski
wrote:
>
> Prevent from proceeding if there's nothing to print.
>
> Suggested-by: Przemek Kitszel
> Reviewed-by: Jiri Pirko
> Signed-off-by: Jedrzej Jagielski
Reviewed-by: Kalesh AP
--
Regards,
Kalesh AP
smime.p7s
Description: S/MIME Crypt
On 2/28/2025 6:09 PM, Simon Horman wrote:
On Tue, Feb 25, 2025 at 10:08:49AM +0100, Martyna Szapar-Mudlaw wrote:
From: Mateusz Polchlopek
Fix using the untrusted value of proto->raw.pkt_len in function
ice_vc_fdir_parse_raw() by verifying if it does not exceed the
VIRTCHNL_MAX_SIZE_RAW_PACK
On 3/3/2025 11:00 AM, Przemek Kitszel wrote:
On 2/28/25 18:17, Simon Horman wrote:
On Tue, Feb 25, 2025 at 10:08:49AM +0100, Martyna Szapar-Mudlaw wrote:
From: Mateusz Polchlopek
Fix using the untrusted value of proto->raw.pkt_len in function
ice_vc_fdir_parse_raw() by verifying if it does
This patch implements the "ethtool --set-mm" callback to trigger the
frame preemption verification handshake.
Uses the MAC Merge Software Verification (mmsv) mechanism in ethtool
to perform the verification handshake for igc.
The structure fpe.mmsv is set by mmsv in ethtool and should remain
read-
Signed-off-by: joaomboni
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 3f089c3d47b2..96bc85f09aaf 100644
--- a/drivers/net/e
The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
this mode the hardware uses four packet buffers and considers queue
priorities.
In order to harmonize the TAPRIO implementation with MQPRIO, switch to the
regular TSN Tx mode. This mode also uses four packet buffers and cons
Renamed xdp_get_tx_ring() function to a more generic name for use in
upcoming frame preemption patches.
Signed-off-by: Faizal Rahim
---
drivers/net/ethernet/intel/igc/igc.h | 2 +-
drivers/net/ethernet/intel/igc/igc_main.c | 9 -
2 files changed, 5 insertions(+), 6 deletions(-)
dif
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Mrozowicz,
> SlawomirX ; Polchlopek, Mateusz
On 3/3/2025 5:16 pm, Kurt Kanzenbach wrote:
The current MQPRIO offload implementation uses the legacy TSN Tx mode. In
this mode the hardware uses four packet buffers and considers queue
priorities.
In order to harmonize the TAPRIO implementation with MQPRIO, switch to the
regular TSN Tx mode.
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej
> ; Polchlopek, Mateusz
>
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej
> ; Keller, Jacob E ;
> M
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej
> ; Polchlopek, Mateusz
>
On Wed, Feb 26, 2025 at 12:33:56PM +0100, Mateusz Polchlopek wrote:
> Embed ice_get_tx_topo_user_sel() inside the only caller:
> ice_devlink_tx_sched_layers_get().
> Instead of jump from the wrapper to the function that does "get" operation
> it does "get" itself.
>
> Remove unnecessary comment an
On 2/28/25 18:17, Simon Horman wrote:
On Tue, Feb 25, 2025 at 10:08:49AM +0100, Martyna Szapar-Mudlaw wrote:
From: Mateusz Polchlopek
Fix using the untrusted value of proto->raw.pkt_len in function
ice_vc_fdir_parse_raw() by verifying if it does not exceed the
VIRTCHNL_MAX_SIZE_RAW_PACKET valu
Introduces support for the FPE feature in the IGC driver.
The patches aligns with the upstream FPE API:
https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/
https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.73054-1-vladimir.olt...
Packet buffers (RX + TX) total 64KB. Neither RX or TX buffers can be
larger than 34KB. So divide the buffer equally, 32KB for each.
Co-developed-by: Vinicius Costa Gomes
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Faizal Rahim
---
drivers/net/ethernet/intel/igc/igc_defines.h | 3 ++-
1
Add support to set tx-min-frag-size via set_mm callback in igc.
Increase the max limit of tx-ming-frag-size in ethtool from 252 to 256
since i225/6 value range is 64, 128, 192 and 256.
Co-developed-by: Vinicius Costa Gomes
Signed-off-by: Vinicius Costa Gomes
Signed-off-by: Faizal Rahim
---
dri
Implement "ethtool --show-mm" callback for IGC.
Tested with command:
$ ethtool --show-mm enp1s0.
MAC Merge layer state for enp1s0:
pMAC enabled: on
TX enabled: on
TX active: on
TX minimum fragment size: 64
RX minimum fragment size: 60
Verify enabled: on
Verify time: 128
Max verif
In preparation for supporting frame preemption, when entering TSN mode
set the receive packet buffer to 16KB for the Express MAC, 16KB for
the Preemptible MAC and 2KB for the BMC, according to the datasheet
section 7.1.3.2.
Co-developed-by: Vinicius Costa Gomes
Signed-off-by: Vinicius Costa Gomes
Implemented "ethtool --include-statistics --show-mm" callback for IGC.
Tested preemption scenario to check preemption statistics:
1) Trigger verification handshake on both boards:
$ sudo ethtool --set-mm enp1s0 pmac-enabled on
$ sudo ethtool --set-mm enp1s0 tx-enabled on
$ sudo ethtool
Since preemptible tc implementation is not ready yet, block it from being
set in taprio. The existing code already blocks it in mqprio.
Signed-off-by: Faizal Rahim
---
drivers/net/ethernet/intel/igc/igc_main.c | 4
1 file changed, 4 insertions(+)
diff --git a/drivers/net/ethernet/intel/igc
From: Vladimir Oltean
It appears that stmmac is not the only hardware which requires a
software-driven verification state machine for the MAC Merge layer.
While on the one hand it's good to encourage hardware implementations,
on the other hand it's quite difficult to tolerate multiple drivers
im
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Jagielski, Jedrzej
> ; Kitszel, Przemyslaw
>
> -Original Message-
> From: Intel-wired-lan On Behalf Of
> Jedrzej Jagielski
> Sent: Friday, February 21, 2025 5:21 PM
> To: intel-wired-...@lists.osuosl.org
> Cc: Nguyen, Anthony L ;
> net...@vger.kernel.org; ho...@kernel.org; j...@nvidia.com; Mrozowicz,
> SlawomirX ; Kitszel, Przemyslaw
From: Paul Menzel
Sent: Friday, February 28, 2025 11:17 AM
>Dear Jedrzej,
>
>
>Thank you for your patch.
>
>Am 28.02.25 um 09:37 schrieb Jedrzej Jagielski:
>> E610's implementation of various ethtool ops is different than
>> the ones corresponding to ixgbe legacy products. Therefore create
>> se
E610's implementation of various ethtool ops is different than
the ones corresponding to ixgbe legacy products. Therefore create
separate E610 ethtool_ops struct which will be filled out in the
forthcoming patches.
Add adequate ops struct basing on MAC type. This step requires
changing a bit the f
Legacy implementation of .set_phys_id() ethtool callback is not
applicable for E610 device.
Add new implementation which uses 0x06E9 command by calling
ixgbe_aci_set_port_id_led().
Reviewed-by: Aleksandr Loktionov
Reviewed-by: Michal Swiatkowski
Signed-off-by: Jedrzej Jagielski
---
v3: move th
As E610 adapter introduces different approach to communicate with FW than
the previous adapters using the ixgbe driver, there is a need to adjust
some of the ethtool callbacks implementations to the new pattern. Some of
the features are now set using Admin Command Interface (eg. controlling
LEDs) w
Currently only APM (Advanced Power Management) is supported by
the ixgbe driver. It works for magic packets only, as for different
sources of wake-up E610 adapter utilizes different feature.
Add E610 specific implementation of ixgbe_set_wol() callback. When
any of broadcast/multicast/unicast wake-
On Mon, Mar 03, 2025 at 10:11:55AM -0300, joaomboni wrote:
> Signed-off-by: joaomboni
Sorry, but the Subject: line needs to be in English.
And the name in Signed-off-by: needs to be a real name.
The code change itself looks sensible.
Andrew
---
pw-bot: cr
E610 device doesn't support disabling FC autonegotiation.
Create dedicated E610 .set_pauseparam() implementation and assign
it to ixgbe_ethtool_ops_e610.
Reviewed-by: Aleksandr Loktionov
Signed-off-by: Jedrzej Jagielski
---
.../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 57 ---
Signed-off-by: Joao Bonifacio
---
drivers/net/ethernet/intel/e1000/e1000_main.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/drivers/net/ethernet/intel/e1000/e1000_main.c
b/drivers/net/ethernet/intel/e1000/e1000_main.c
index 3f089c3d47b2..96bc85f09aaf 100644
--- a/drivers/
Hello,
It seems that there are invalid page MMIO write access in i40e_clear_hw()
due to an integer underflow from num_pf_int(also num_vf_int seems possible).
The following is a sample code in i40e_clear_hw():
val = rd32(hw, I40E_GLPCI_CNF2); // (1)
num_pf_int = FIELD_GET(I40E_GLPCI_CNF2_MSI_X_PF
On 2025-03-03 10:11 a.m., Arinzon, David wrote:
Use the core's rmap notifiers and delete our own.
Acked-by: David Arinzon
Signed-off-by: Ahmed Zaki
---
drivers/net/ethernet/amazon/ena/ena_netdev.c | 43 +---
1 file changed, 1 insertion(+), 42 deletions(-)
diff --git a/dr
On Mon, 3 Mar 2025 14:48:46 +0100 Andrew Lunn wrote:
> Sorry, but the Subject: line needs to be in English.
>
> And the name in Signed-off-by: needs to be a real name.
>
> The code change itself looks sensible.
If only we were also LLMs, not just humans, we could read commits
in any language!
> Use the core's rmap notifiers and delete our own.
>
> Acked-by: David Arinzon
> Signed-off-by: Ahmed Zaki
> ---
> drivers/net/ethernet/amazon/ena/ena_netdev.c | 43 +---
> 1 file changed, 1 insertion(+), 42 deletions(-)
>
> diff --git a/drivers/net/ethernet/amazon/ena/ena_net
36 matches
Mail list logo
