Re: [Intel-wired-lan] [PATCH v8 iwl-next 09/10] idpf: add support for Rx timestamping

2025-02-28 Thread YiFei Zhu
> Add Rx timestamp function when the Rx timestamp value is read directly > from the Rx descriptor. In order to extend the Rx timestamp value to 64 > bit in hot path, the PHC time is cached in the receive groups. > Add supported Rx timestamp modes. > > Signed-off-by: Milena Olech > --- > v7 -> v8:

[Intel-wired-lan] [tnguy-net-queue:200GbE] BUILD SUCCESS bcfc46cf644e2a44fa73edd20b94b18ec088315d

2025-02-28 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alpha allyesconfiggcc-14.2.0 arc randconfig-001-20250228gcc-13.2.0 arc randconfig-002-20250228gcc-13.2.0 arm randconfig-001-20250228clang

[Intel-wired-lan] [PATCH iwl-next v2 0/4] ixgbe: add ethtool support for E610

2025-02-28 Thread Jedrzej Jagielski
As E610 adapter introduce different approach to communicate with FW than the previous adapters using the ixgbe driver, there is a need to adjust some of them to the new pattern. Some of the features are now set using Admin Command Interface (eg. controlling LEDs) which among the ixgbe supported dev

[Intel-wired-lan] [PATCH iwl-next v2 2/4] ixgbe: add support for ACPI WOL for E610

2025-02-28 Thread Jedrzej Jagielski
Currently only APM (Advanced Power Management) is supported by the ixgbe driver. It works for magic packets only, as for different sources of wake-up E610 adapter utilizes different feature. Add E610 specific implementation of ixgbe_set_wol() callback. When any of broadcast/multicast/unicast wake-

[Intel-wired-lan] [PATCH iwl-next v2 1/4] ixgbe: create E610 specific ethtool_ops structure

2025-02-28 Thread Jedrzej Jagielski
E610's implementation of various ethtool ops is different than the ones corresponding to ixgbe legacy products. Therefore create separate E610 ethtool_ops struct which will be filled out in the forthcoming patches. Assing adequate ops struct basing on mac type. This step requires changing a bit th

[Intel-wired-lan] [PATCH iwl-next v2 4/4] ixgbe: apply different rules for setting FC on E610

2025-02-28 Thread Jedrzej Jagielski
E610 device doesn't support disabling FC autonegotiation. Create dedicated E610 .set_pauseparam() implementation and assign it to ixgbe_ethtool_ops_e610. Reviewed-by: Aleksandr Loktionov Signed-off-by: Jedrzej Jagielski --- .../net/ethernet/intel/ixgbe/ixgbe_ethtool.c | 57 ---

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow-path in LAG

2025-02-28 Thread Buvaneswaran, Sujai
> -Original Message- > From: Intel-wired-lan On Behalf Of > Marcin Szycik > Sent: Friday, January 3, 2025 12:38 AM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; Marcin Szycik ; > Michal Swiatkowski > Subject: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/4] igb: Link IRQs to NAPI instances

2025-02-28 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Kurt > Kanzenbach > Sent: 17 February 2025 17:01 > To: Nguyen, Anthony L ; Kitszel, Przemyslaw > > Cc: Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub Kicinski > ; Paolo Abeni ; Sebastian Andrzej Siewior > ; Damato, Joe

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/4] igb: Link queues to NAPI instances

2025-02-28 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Kurt > Kanzenbach > Sent: 17 February 2025 17:01 > To: Nguyen, Anthony L ; Kitszel, Przemyslaw > > Cc: Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub Kicinski > ; Paolo Abeni ; Sebastian Andrzej Siewior > ; Damato, Joe

Re: [Intel-wired-lan] [PATCH iwl-next v2 3/4] igb: Add support for persistent NAPI config

2025-02-28 Thread Rinitha, SX
> -Original Message- > From: Intel-wired-lan On Behalf Of Kurt > Kanzenbach > Sent: 17 February 2025 17:01 > To: Nguyen, Anthony L ; Kitszel, Przemyslaw > > Cc: Andrew Lunn ; David S. Miller > ; Eric Dumazet ; Jakub Kicinski > ; Paolo Abeni ; Sebastian Andrzej Siewior > ; Damato, Joe

[Intel-wired-lan] [PATCH iwl-next v2 3/4] ixgbe: add E610 .set_phys_id() callback implementation

2025-02-28 Thread Jedrzej Jagielski
Legacy implementation of .set_phys_id() ethtool callback is not applicable for E610 device. Add new implementation which uses 0x06E9 command by calling ixgbe_aci_set_port_id_led(). Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Swiatkowski Signed-off-by: Jedrzej Jagielski --- drivers/ne

Re: [Intel-wired-lan] [PATCH iwl-next v2 1/4] ixgbe: create E610 specific ethtool_ops structure

2025-02-28 Thread Paul Menzel
Dear Jedrzej, Thank you for your patch. Am 28.02.25 um 09:37 schrieb Jedrzej Jagielski: E610's implementation of various ethtool ops is different than the ones corresponding to ixgbe legacy products. Therefore create separate E610 ethtool_ops struct which will be filled out in the forthcoming

Re: [Intel-wired-lan] [PATCH iwl-next v6 5/9] igc: Add support for frame preemption verification

2025-02-28 Thread Przemek Kitszel
On 2/27/25 15:01, Faizal Rahim wrote: This patch implements the "ethtool --set-mm" callback to trigger the frame preemption verification handshake. Uses the MAC Merge Software Verification (mmsv) mechanism in ethtool to perform the verification handshake for igc. The structure fpe.mmsv is set by

Re: [Intel-wired-lan] [PATCH] e1000e: Link flap workaround option for false IRP events

2025-02-28 Thread Mark Pearson
Hi Andrew On Thu, Feb 27, 2025, at 11:07 AM, Andrew Lunn wrote: >> >> + e1e_rphy(hw, PHY_REG(772, 26), &phy_data); >> > >> > Please add some #define for these magic numbers, so we have some idea >> > what PHY register you are actually reading. That in itself might help >> > explain

Re: [Intel-wired-lan] [PATCH] e1000e: Link flap workaround option for false IRP events

2025-02-28 Thread Andrew Lunn
> For the PHY - do you know a way of determining this easily? Add printk()s to e1000e_get_phy_type_from_id(). Andrew

[Intel-wired-lan] [tnguy-net-queue:main] BUILD SUCCESS 54e1b4becf5e220be03db4e1be773c1310e8cbbd

2025-02-28 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alpha allyesconfiggcc-14.2.0 arc allmodconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250228

Re: [Intel-wired-lan] [PATCH v8 iwl-next 03/10] idpf: move virtchnl structures to the header file

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:17 AM Milena Olech wrote: > > Move virtchnl structures to the header file to expose them for the PTP > virtchnl file. > > Reviewed-by: Alexander Lobakin > Reviewed-by: Willem de Bruijn > Signed-off-by: Milena Olech Tested-by: Mina Almasry -- Thanks, Mina

Re: [Intel-wired-lan] [PATCH v8 iwl-next 02/10] virtchnl: add PTP virtchnl definitions

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:16 AM Milena Olech wrote: > > PTP capabilities are negotiated using virtchnl commands. There are two > available modes of the PTP support: direct and mailbox. When the direct > access to PTP resources is negotiated, virtchnl messages returns a set > of registers that allo

Re: [Intel-wired-lan] [PATCH v8 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:18 AM Milena Olech wrote: > > PTP capabilities are negotiated using virtchnl command. Add get > capabilities function, direct access to read the PTP clock time and > direct access to read the cross timestamp - system time and PTP clock > time. Set initial PTP capabilities

Re: [Intel-wired-lan] [PATCH v8 iwl-next 06/10] idpf: add PTP clock configuration

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:18 AM Milena Olech wrote: > > PTP clock configuration operations - set time, adjust time and adjust > frequency are required to control the clock and maintain synchronization > process. > > Extend get PTP capabilities function to request for the clock adjustments > and ad

Re: [Intel-wired-lan] [PATCH v8 iwl-next 09/10] idpf: add support for Rx timestamping

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:19 AM Milena Olech wrote: > > Add Rx timestamp function when the Rx timestamp value is read directly > from the Rx descriptor. In order to extend the Rx timestamp value to 64 > bit in hot path, the PHC time is cached in the receive groups. > Add supported Rx timestamp mod

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 8bca5ffb21dc600ad8c04b3c851936ceecac2c28

2025-02-28 Thread kernel test robot
successfully. More configs may be tested in the coming days. tested configs: alphaallyesconfiggcc-14.2.0 arc randconfig-001-20250228gcc-13.2.0 arc randconfig-002-20250228gcc-13.2.0 arm randconfig-001-20250228

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS 2b2933374bc2d099370221f5909aa4458b98aaa1

2025-02-28 Thread kernel test robot
allnoconfiggcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250228gcc-13.2.0 arc randconfig-002-20250228gcc-13.2.0 arm allnoconfigclang-17 arm

Re: [Intel-wired-lan] [iwl-net v2 1/5] virtchnl: make proto and filter action count unsigned

2025-02-28 Thread Simon Horman
On Tue, Feb 25, 2025 at 10:08:45AM +0100, Martyna Szapar-Mudlaw wrote: > From: Jan Glaza > > The count field in virtchnl_proto_hdrs and virtchnl_filter_action_set > should never be negative while still being valid. Changing it from > int to u32 ensures proper handling of values in virtchnl messag

Re: [Intel-wired-lan] [iwl-net v2 4/5] ice: fix input validation for virtchnl BW

2025-02-28 Thread Simon Horman
On Tue, Feb 25, 2025 at 10:08:48AM +0100, Martyna Szapar-Mudlaw wrote: > From: Lukasz Czapnik > > Add missing validation of tc and queue id values sent by a VF in > ice_vc_cfg_q_bw(). > Additionally fixed logged value in the warning message, > where max_tx_rate was incorrectly referenced instead

Re: [Intel-wired-lan] [iwl-net v2 5/5] ice: fix using untrusted value of pkt_len in ice_vc_fdir_parse_raw()

2025-02-28 Thread Simon Horman
On Tue, Feb 25, 2025 at 10:08:49AM +0100, Martyna Szapar-Mudlaw wrote: > From: Mateusz Polchlopek > > Fix using the untrusted value of proto->raw.pkt_len in function > ice_vc_fdir_parse_raw() by verifying if it does not exceed the > VIRTCHNL_MAX_SIZE_RAW_PACKET value. > > Fixes: 99f419df8a5c ("i

Re: [Intel-wired-lan] [iwl-net v2 3/5] ice: validate queue quanta parameters to prevent OOB access

2025-02-28 Thread Simon Horman
On Tue, Feb 25, 2025 at 10:08:47AM +0100, Martyna Szapar-Mudlaw wrote: > From: Jan Glaza > > Add queue wraparound prevention in quanta configuration. > Ensure end_qid does not overflow by validating start_qid and num_queues. > > Fixes: 015307754a19 ("ice: Support VF queue rate limit and quanta s

Re: [Intel-wired-lan] [iwl-net v2 5/5] ice: fix using untrusted value of pkt_len in ice_vc_fdir_parse_raw()

2025-02-28 Thread Simon Horman
On Tue, Feb 25, 2025 at 10:08:49AM +0100, Martyna Szapar-Mudlaw wrote: > From: Mateusz Polchlopek > > Fix using the untrusted value of proto->raw.pkt_len in function > ice_vc_fdir_parse_raw() by verifying if it does not exceed the > VIRTCHNL_MAX_SIZE_RAW_PACKET value. > > Fixes: 99f419df8a5c ("i

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 7fe0353606d77a32c4c7f2814833dd1c043ebdd2

2025-02-28 Thread kernel test robot
randconfig-001-20250228gcc-13.2.0 arc randconfig-002-20250228gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm allyesconfiggcc-14.2.0 arm orion5x_defconfigclang-21 arm

Re: [Intel-wired-lan] [PATCH v8 iwl-next 01/10] idpf: add initial PTP support

2025-02-28 Thread Mina Almasry
On Thu, Feb 27, 2025 at 5:16 AM Milena Olech wrote: > > PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the > capabilities recognition. Initial PTP support includes PTP initialization > and registration of the clock. > > Reviewed-by: Alexander Lobakin > Reviewed-by: Vadim F

Re: [Intel-wired-lan] [PATCH iwl-next v6 2/9] igc: Rename xdp_get_tx_ring() for non-xdp usage

2025-02-28 Thread Przemek Kitszel
On 2/27/25 15:01, Faizal Rahim wrote: Renamed xdp_get_tx_ring() function to a more generic name for use in upcoming frame preemption patches. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 10 +- 2 files

Re: [Intel-wired-lan] [PATCH iwl-next v2 3/4] ixgbe: add E610 .set_phys_id() callback implementation

2025-02-28 Thread Przemek Kitszel
On 2/28/25 09:37, Jedrzej Jagielski wrote: Legacy implementation of .set_phys_id() ethtool callback is not applicable for E610 device. Add new implementation which uses 0x06E9 command by calling ixgbe_aci_set_port_id_led(). Reviewed-by: Aleksandr Loktionov Reviewed-by: Michal Swiatkowski Sign