Re: [Intel-wired-lan] [PATCH iwl-next v4 5/9] igc: Add support for frame preemption verification

2025-02-18 Thread Abdul Rahim, Faizal
On 17/2/2025 7:31 pm, Simon Horman wrote: On Mon, Feb 10, 2025 at 02:02:03AM -0500, Faizal Rahim wrote: ... diff --git a/drivers/net/ethernet/intel/igc/igc_tsn.c b/drivers/net/ethernet/intel/igc/igc_tsn.c ... +bool igc_fpe_transmitted_smd_v(union igc_adv_tx_desc *tx_desc) +{ + u8

[Intel-wired-lan] [PATCH iwl-net] ice: fix Get Tx Topology AQ command error on E830

2025-02-18 Thread Jacob Keller
hw->mac_type != ICE_MAC_E830) + desc.flags |= cpu_to_le16(ICE_AQ_FLAG_RD); + } status = ice_aq_send_cmd(hw, &desc, buf, buf_size, cd); if (status) --- base-commit: f5da7c45188eea71394bf445655cae2df88a7788 change-id: 20250218-jk-e830-ddp-loading-fi

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

2025-02-18 Thread Kurt Kanzenbach
On Tue Feb 18 2025, Joe Damato wrote: > On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: >> This is a follow up for the igb XDP/ZC implementation. The first two >> patches link the IRQs and queues to NAPI instances. This is required to >> bring back the XDP/ZC busy polling support

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/4] igb: Link queues to NAPI instances

2025-02-18 Thread Kurt Kanzenbach
On Tue Feb 18 2025, Joe Damato wrote: > On Mon, Feb 17, 2025 at 12:31:22PM +0100, Kurt Kanzenbach wrote: >> Link queues to NAPI instances via netdev-genl API. This is required to use >> XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling >> support") for details. >> >> This

[Intel-wired-lan] [PATCH v7 iwl-next 02/10] virtchnl: add PTP virtchnl definitions

2025-02-18 Thread Milena Olech
PTP capabilities are negotiated using virtchnl commands. There are two available modes of the PTP support: direct and mailbox. When the direct access to PTP resources is negotiated, virtchnl messages returns a set of registers that allow read/write directly. When the mailbox access to PTP resources

[Intel-wired-lan] [PATCH v7 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock

2025-02-18 Thread Milena Olech
PTP capabilities are negotiated using virtchnl command. Add get capabilities function, direct access to read the PTP clock time and direct access to read the cross timestamp - system time and PTP clock time. Set initial PTP capabilities exposed to the stack. Reviewed-by: Alexander Lobakin Reviewe

[Intel-wired-lan] [PATCH v7 iwl-next 03/10] idpf: move virtchnl structures to the header file

2025-02-18 Thread Milena Olech
Move virtchnl structures to the header file to expose them for the PTP virtchnl file. Reviewed-by: Alexander Lobakin Reviewed-by: Willem de Bruijn Signed-off-by: Milena Olech --- v1 -> v2: fix commit message title .../net/ethernet/intel/idpf/idpf_virtchnl.c | 86 +-- .../net

[Intel-wired-lan] [PATCH v7 iwl-next 06/10] idpf: add PTP clock configuration

2025-02-18 Thread Milena Olech
PTP clock configuration operations - set time, adjust time and adjust frequency are required to control the clock and maintain synchronization process. Extend get PTP capabilities function to request for the clock adjustments and add functions to enable these actions using dedicated virtchnl messa

[Intel-wired-lan] [PATCH v7 iwl-next 05/10] idpf: add mailbox access to read PTP clock time

2025-02-18 Thread Milena Olech
When the access to read PTP clock is specified as mailbox, the driver needs to send virtchnl message to perform PTP actions. Message is sent using idpf_mbq_opc_send_msg_to_peer_drv mailbox opcode, with the parameters received during PTP capabilities negotiation. Add functions to recognize PTP mess

[Intel-wired-lan] [PATCH v7 iwl-next 08/10] idpf: add Tx timestamp flows

2025-02-18 Thread Milena Olech
Add functions to request Tx timestamp for the PTP packets, read the Tx timestamp when the completion tag for that packet is being received, extend the Tx timestamp value and set the supported timestamping modes. Tx timestamp is requested for the PTP packets by setting a TSYN bit and index value in

[Intel-wired-lan] [PATCH v7 iwl-next 09/10] idpf: add support for Rx timestamping

2025-02-18 Thread Milena Olech
Add Rx timestamp function when the Rx timestamp value is read directly from the Rx descriptor. In order to extend the Rx timestamp value to 64 bit in hot path, the PHC time is cached in the receive groups. Add supported Rx timestamp modes. Signed-off-by: Milena Olech --- v5 -> v6: add Rx filter v

[Intel-wired-lan] [PATCH v7 iwl-next 07/10] idpf: add Tx timestamp capabilities negotiation

2025-02-18 Thread Milena Olech
Tx timestamp capabilities are negotiated for the uplink Vport. Driver receives information about the number of available Tx timestamp latches, the size of Tx timestamp value and the set of indexes used for Tx timestamping. Add function to get the Tx timestamp capabilities and parse the uplink vpor

[Intel-wired-lan] [PATCH v7 iwl-next 01/10] idpf: add initial PTP support

2025-02-18 Thread Milena Olech
PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the capabilities recognition. Initial PTP support includes PTP initialization and registration of the clock. Reviewed-by: Alexander Lobakin Reviewed-by: Vadim Fedorenko Reviewed-by: Willem de Bruijn Signed-off-by: Milena Ole

[Intel-wired-lan] [PATCH v7 iwl-next 00/10] idpf: add initial PTP support

2025-02-18 Thread Milena Olech
This patch series introduces support for Precision Time Protocol (PTP) to Intel(R) Infrastructure Data Path Function (IDPF) driver. PTP feature is supported when the PTP capability is negotiated with the Control Plane (CP). IDPF creates a PTP clock and sets a set of supported functions. During the

[Intel-wired-lan] [PATCH v7 iwl-next 10/10] idpf: change the method for mailbox workqueue allocation

2025-02-18 Thread Milena Olech
Since workqueues are created per CPU, the works scheduled to this workqueues are run on the CPU they were assigned. It may result in overloaded CPU that is not able to handle virtchnl messages in relatively short time. Allocating workqueue with WQ_UNBOUND and WQ_HIGHPRI flags allows scheduler to qu

Re: [Intel-wired-lan] [iwl-next v3 2/4] ixgbe: check for MDD events

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:34AM +0100, Michal Swiatkowski wrote: > From: Don Skidmore > > When an event is detected it is logged and, for the time being, the > queue is immediately re-enabled. This is due to the lack of an API > to the hypervisor so it could deal with it as it chooses. > > R

[Intel-wired-lan] [PATCH iwl-net] ixgbe: fix media type detection for E610 device

2025-02-18 Thread Piotr Kwapulinski
The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") introduced incorrect media type detection for E610 device. It reproduces when advertised speed is modified after driver reload. Clear the previous outdated PHY type. Fixes: 23c0e5a16bcc ("ixgbe: Add link management supp

[Intel-wired-lan] e1000e: How to set parameters using sysfs?

2025-02-18 Thread Paul Menzel
Dear Linux folks, The driver e1000e has several parameters [1]: $ modinfo e1000e filename: /lib/modules/6.6.35.mx64.477/kernel/drivers/net/ethernet/intel/e1000e/e1000e.ko […] alias: pci:v8086d105Esv*sd*bc*sc*i* depends: retpoline: Y intree:

Re: [Intel-wired-lan] [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-18 Thread Lifshits, Vitaly
On 2/18/2025 2:59 PM, Simon Horman wrote: On Sun, Feb 16, 2025 at 04:57:28PM +0100, Piotr Wejman wrote: Update the driver to use the new hardware timestamping API added in commit 66f7223039c0 ("net: add NDOs for configuring hardware timestamping"). Use Netlink extack for error reporting in e1

Re: [Intel-wired-lan] [PATCH iwl-next v3] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-18 Thread Simon Horman
On Sun, Feb 16, 2025 at 04:57:28PM +0100, Piotr Wejman wrote: > Update the driver to use the new hardware timestamping API added in commit > 66f7223039c0 ("net: add NDOs for configuring hardware timestamping"). > Use Netlink extack for error reporting in e1000e_config_hwtstamp. > Align the indentat

Re: [Intel-wired-lan] [PATCH ipsec-next 3/5] xfrm: rely on XFRM offload

2025-02-18 Thread Zhu Yanjun
在 2025/2/5 19:20, Leon Romanovsky 写道: From: Leon Romanovsky After change of initialization of x->type_offload pointer to be valid only for offloaded SAs. There is no need to rely both on x->type_offload

Re: [Intel-wired-lan] [PATCH iwl-next v2 2/4] igb: Link queues to NAPI instances

2025-02-18 Thread Joe Damato
On Mon, Feb 17, 2025 at 12:31:22PM +0100, Kurt Kanzenbach wrote: > Link queues to NAPI instances via netdev-genl API. This is required to use > XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling > support") for details. > > This also allows users to query the info with net

Re: [Intel-wired-lan] [PATCH iwl-next v2 3/4] igb: Add support for persistent NAPI config

2025-02-18 Thread Joe Damato
On Mon, Feb 17, 2025 at 12:31:23PM +0100, Kurt Kanzenbach wrote: > Use netif_napi_add_config() to assign persistent per-NAPI config. > > This is useful for preserving NAPI settings when changing queue counts or > for user space programs using SO_INCOMING_NAPI_ID. > > Signed-off-by: Kurt Kanzenbac

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

2025-02-18 Thread Joe Damato
On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: > This is a follow up for the igb XDP/ZC implementation. The first two > patches link the IRQs and queues to NAPI instances. This is required to > bring back the XDP/ZC busy polling support. The last patch removes > undesired IRQs

Re: [Intel-wired-lan] [iwl-next v3 4/4] ixgbe: turn off MDD while modifying SRRCTL

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:36AM +0100, Michal Swiatkowski wrote: > From: Radoslaw Tyl > > Modifying SRRCTL register can generate MDD event. > > Turn MDD off during SRRCTL register write to prevent generating MDD. > > Fix RCT in ixgbe_set_rx_drop_en(). > > Reviewed-by: Marcin Szycik > Revie

Re: [Intel-wired-lan] [iwl-next v3 3/4] ixgbe: add Tx hang detection unhandled MDD

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:35AM +0100, Michal Swiatkowski wrote: > From: Slawomir Mrozowicz > > Add Tx Hang detection due to an unhandled MDD Event. > > Previously, a malicious VF could disable the entire port causing > TX to hang on the E610 card. > Those events that caused PF to freeze were

Re: [Intel-wired-lan] [iwl-next v3 1/4] ixgbe: add MDD support

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 10:06:33AM +0100, Michal Swiatkowski wrote: > From: Paul Greenwalt > > Add malicious driver detection to ixgbe driver. The supported devices > are E610 and X550. > > Handling MDD events is enabled while VFs are created and turned off > when they are disabled. here is no r

Re: [Intel-wired-lan] [iwl-net 0/4] ice: improve validation of virtchnl parameters

2025-02-18 Thread Simon Horman
On Mon, Feb 17, 2025 at 11:27:41AM +0100, Martyna Szapar-Mudlaw wrote: > This patch series introduces improvements to the `ice` driver and `virtchnl` > interface by adding stricter validation checks and preventing potential > out-of-bounds scenarios. Hi Martyna, The above talks about this patchse

Re: [Intel-wired-lan] [PATCH iwl-net] ixgbe: fix media type detection for E610 device

2025-02-18 Thread Paul Menzel
Dear Piotr, Thank you for your patch. Am 18.02.25 um 17:17 schrieb Piotr Kwapulinski: The commit 23c0e5a16bcc ("ixgbe: Add link management support for E610 device") introduced incorrect media type detection for E610 device. It reproduces when advertised speed is modified after driver reload.

Re: [Intel-wired-lan] [PATCH iwl-next v2 0/4] igb: XDP/ZC follow up

2025-02-18 Thread Joe Damato
On Tue, Feb 18, 2025 at 04:18:19PM -0500, Joe Damato wrote: > On Mon, Feb 17, 2025 at 12:31:20PM +0100, Kurt Kanzenbach wrote: > > This is a follow up for the igb XDP/ZC implementation. The first two > > patches link the IRQs and queues to NAPI instances. This is required to > > bring back the XD

[Intel-wired-lan] [PATCH v6 iwl-next 01/10] idpf: add initial PTP support

2025-02-18 Thread Milena Olech
PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the capabilities recognition. Initial PTP support includes PTP initialization and registration of the clock. Reviewed-by: Alexander Lobakin Reviewed-by: Vadim Fedorenko Reviewed-by: Willem de Bruijn Signed-off-by: Milena Ole

[Intel-wired-lan] [PATCH v6 iwl-next 02/10] virtchnl: add PTP virtchnl definitions

2025-02-18 Thread Milena Olech
PTP capabilities are negotiated using virtchnl commands. There are two available modes of the PTP support: direct and mailbox. When the direct access to PTP resources is negotiated, virtchnl messages returns a set of registers that allow read/write directly. When the mailbox access to PTP resources

[Intel-wired-lan] [PATCH v6 iwl-next 03/10] idpf: move virtchnl structures to the header file

2025-02-18 Thread Milena Olech
Move virtchnl structures to the header file to expose them for the PTP virtchnl file. Reviewed-by: Alexander Lobakin Reviewed-by: Willem de Bruijn Signed-off-by: Milena Olech --- v1 -> v2: fix commit message title .../net/ethernet/intel/idpf/idpf_virtchnl.c | 86 +-- .../net

[Intel-wired-lan] [PATCH v6 iwl-next 00/10] idpf: add initial PTP support

2025-02-18 Thread Milena Olech
This patch series introduces support for Precision Time Protocol (PTP) to Intel(R) Infrastructure Data Path Function (IDPF) driver. PTP feature is supported when the PTP capability is negotiated with the Control Plane (CP). IDPF creates a PTP clock and sets a set of supported functions. During the

[Intel-wired-lan] [PATCH v6 iwl-next 04/10] idpf: negotiate PTP capabilities and get PTP clock

2025-02-18 Thread Milena Olech
PTP capabilities are negotiated using virtchnl command. Add get capabilities function, direct access to read the PTP clock time and direct access to read the cross timestamp - system time and PTP clock time. Set initial PTP capabilities exposed to the stack. Reviewed-by: Alexander Lobakin Reviewe

[Intel-wired-lan] [PATCH v6 iwl-next 06/10] idpf: add PTP clock configuration

2025-02-18 Thread Milena Olech
PTP clock configuration operations - set time, adjust time and adjust frequency are required to control the clock and maintain synchronization process. Extend get PTP capabilities function to request for the clock adjustments and add functions to enable these actions using dedicated virtchnl messa

[Intel-wired-lan] [PATCH v6 iwl-next 05/10] idpf: add mailbox access to read PTP clock time

2025-02-18 Thread Milena Olech
When the access to read PTP clock is specified as mailbox, the driver needs to send virtchnl message to perform PTP actions. Message is sent using idpf_mbq_opc_send_msg_to_peer_drv mailbox opcode, with the parameters received during PTP capabilities negotiation. Add functions to recognize PTP mess

[Intel-wired-lan] [PATCH v6 iwl-next 08/10] idpf: add Tx timestamp flows

2025-02-18 Thread Milena Olech
Add functions to request Tx timestamp for the PTP packets, read the Tx timestamp when the completion tag for that packet is being received, extend the Tx timestamp value and set the supported timestamping modes. Tx timestamp is requested for the PTP packets by setting a TSYN bit and index value in

[Intel-wired-lan] [PATCH v6 iwl-next 07/10] idpf: add Tx timestamp capabilities negotiation

2025-02-18 Thread Milena Olech
Tx timestamp capabilities are negotiated for the uplink Vport. Driver receives information about the number of available Tx timestamp latches, the size of Tx timestamp value and the set of indexes used for Tx timestamping. Add function to get the Tx timestamp capabilities and parse the uplink vpor

[Intel-wired-lan] [PATCH v6 iwl-next 09/10] idpf: add support for Rx timestamping

2025-02-18 Thread Milena Olech
Add Rx timestamp function when the Rx timestamp value is read directly from the Rx descriptor. In order to extend the Rx timestamp value to 64 bit in hot path, the PHC time is cached in the receive groups. Add supported Rx timestamp modes. Signed-off-by: Milena Olech --- v5 -> v6: add Rx filter v

[Intel-wired-lan] [PATCH v6 iwl-next 10/10] idpf: change the method for mailbox workqueue allocation

2025-02-18 Thread Milena Olech
Since workqueues are created per CPU, the works scheduled to this workqueues are run on the CPU they were assigned. It may result in overloaded CPU that is not able to handle virtchnl messages in relatively short time. Allocating workqueue with WQ_UNBOUND and WQ_HIGHPRI flags allows scheduler to qu