[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 39f54262ba499d862420a97719d2f0eea0cbd394

2025-02-11 Thread kernel test robot
14.2.0 arc allmodconfiggcc-13.2.0 arc allnoconfiggcc-14.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250211gcc-13.2.0 arc randconfig-002-20250211gcc-

Re: [Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame

2025-02-11 Thread Mor Bar-Gabay
On 05/02/2025 4:36, Song Yoong Siang wrote: Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the igc_init_empty_frame function. This ensures that the buffer type is correctly identified and handled during Tx ring cleanup. Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using

Re: [Intel-wired-lan] [PATCH iwl-next v4] ixgbe: Fix possible skb NULL pointer dereference

2025-02-11 Thread Sanigani, SarithaX
> -Original Message- > From: Intel-wired-lan On Behalf Of > Kwapulinski, Piotr > Sent: 31 January 2025 17:45 > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; dan.carpen...@linaro.org; > yuehaib...@huawei.com; Fijalkowski, Maciej ; > Kitszel, Przemyslaw ; Kwapulinski, Pi

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Przemek Kitszel
On 2/11/25 13:52, Jiri Pirko wrote: Tue, Feb 11, 2025 at 01:12:12PM +0100, jedrzej.jagiel...@intel.com wrote: From: Jiri Pirko Sent: Monday, February 10, 2025 5:26 PM Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: [...] +enum ixgbe_devlink_version_type { + I

[Intel-wired-lan] [tnguy-next-queue:dev-queue] BUILD SUCCESS a7d6eadeafcf15b9aee1a00fddbbfb56edd06aec

2025-02-11 Thread kernel test robot
-13.2.0 arc allyesconfiggcc-13.2.0 arc axs103_defconfiggcc-13.2.0 arc randconfig-001-20250211gcc-13.2.0 arc randconfig-002-20250211gcc-13.2.0 arm allmodconfiggcc

Re: [Intel-wired-lan] [PATCH 0/3] igb: XDP/ZC follow up

2025-02-11 Thread Kurt Kanzenbach
On Mon Feb 10 2025, Joe Damato wrote: > On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote: >> This is a follow up for the igb XDP/ZC implementation. The first two >> patches link the IRQs and queues to NAPI instances. This is required to >> bring back the XDP/ZC busy polling support

[Intel-wired-lan] [PATCH net-next v8 3/6] net: napi: add CPU affinity to napi_config

2025-02-11 Thread Ahmed Zaki
A common task for most drivers is to remember the user-set CPU affinity to its IRQs. On each netdev reset, the driver should re-assign the user's settings to the IRQs. Add CPU affinity mask to napi_config. To delegate the CPU affinity management to the core, drivers must: 1 - set the new netdev f

[Intel-wired-lan] [PATCH net-next v8 0/6] net: napi: add CPU affinity to napi->config

2025-02-11 Thread Ahmed Zaki
Drivers usually need to re-apply the user-set IRQ affinity to their IRQs after reset. However, since there can be only one IRQ affinity notifier for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap management in the core (which also registers separate IRQ affinity notifiers). Mo

[Intel-wired-lan] [PATCH net-next v8 1/6] ice: clear NAPI's IRQ numbers in ice_vsi_clear_napi_queues()

2025-02-11 Thread Ahmed Zaki
We set the NAPI's IRQ number in ice_vsi_set_napi_queues(). Clear the NAPI's IRQ in ice_vsi_clear_napi_queues(). Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice_lib.c | 9 - 1 file changed, 8 insertions(+), 1 deletion(-) diff --git a/drivers/net/ethernet/intel/ice/ice_li

[Intel-wired-lan] [PATCH net-next v8 2/6] net: move ARFS rmap management to core

2025-02-11 Thread Ahmed Zaki
Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should set the flag via netif_enable_cpu_rmap() and core will allocate and manage the ARFS rmap. Freeing the rmap is also done by core when the netdev is freed. For better IRQ affinity management, move the IRQ rmap notifier inside t

[Intel-wired-lan] [PATCH net-next v8 4/6] bnxt: use napi's irq affinity

2025-02-11 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 -- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/dri

[Intel-wired-lan] [PATCH net-next v8 6/6] idpf: use napi's irq affinity

2025-02-11 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/idpf/idpf_lib.c | 1 + drivers/net/ethernet/intel/idpf/idpf_txrx.c | 22 +++-- drivers/net/ethernet/intel/idpf/idpf_txrx.h | 6 ++ 3 files c

[Intel-wired-lan] [PATCH net-next v8 5/6] ice: use napi's irq affinity

2025-02-11 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice.h | 3 -- drivers/net/ethernet/intel/ice/ice_base.c | 7 +--- drivers/net/ethernet/intel/ice/ice_lib.c | 6 --- drivers/net/ethernet/intel/ice/ice

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-11 Thread Jagielski, Jedrzej
From: Andrew Lunn Sent: Monday, February 10, 2025 2:37 PM >> > > > Then driver >> > > > logs appropriate message and closes the adapter instance. >> > > > The card remains in that state until the platform is rebooted. >> > > >> > > As a user I’d be interested what the threshold is, and what the

Re: [Intel-wired-lan] [iwl-next v1 3/4] ixgbe: add Tx hang detection unhandled MDD

2025-02-11 Thread Simon Horman
On Mon, Feb 10, 2025 at 06:50:37AM +0100, Michal Swiatkowski wrote: > On Fri, Feb 07, 2025 at 02:57:10PM +, Simon Horman wrote: > > On Fri, Feb 07, 2025 at 11:43:42AM +0100, Michal Swiatkowski wrote: ... > > > +/** > > > + * ixgbe_handle_mdd_event - handle mdd event > > > + * @adapter: struct

[Intel-wired-lan] [PATCH iwl-net 2/2] ice: Avoid setting default Rx VSI twice in switchdev setup

2025-02-11 Thread Marcin Szycik
As part of switchdev environment setup, uplink VSI is configured as default for both Tx and Rx. Default Rx VSI is also used by promiscuous mode. If promisc mode is enabled and an attempt to enter switchdev mode is made, the setup will fail because Rx VSI is already configured as default (rule exist

[Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix deinitializing VF in error path

2025-02-11 Thread Marcin Szycik
If ice_ena_vfs() fails after calling ice_create_vf_entries(), it frees all VFs without removing them from snapshot PF-VF mailbox list, leading to list corruption. Reproducer: devlink dev eswitch set $PF1_PCI mode switchdev ip l s $PF1 up ip l s $PF1 promisc on sleep 1 echo 1 > /sys/class

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jagielski, Jedrzej
From: Jiri Pirko Sent: Monday, February 10, 2025 5:26 PM >Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: > >[...] > >>+enum ixgbe_devlink_version_type { >>+ IXGBE_DL_VERSION_FIXED, >>+ IXGBE_DL_VERSION_RUNNING, >>+}; >>+ >>+static int ixgbe_devlink_info_put(stru

Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: add PTP support for E610 device

2025-02-11 Thread R, Bharath
> -Original Message- > From: Intel-wired-lan On Behalf Of > Piotr Kwapulinski > Sent: Tuesday, February 4, 2025 12:43 PM > To: intel-wired-...@lists.osuosl.org > Cc: net...@vger.kernel.org; richardcoch...@gmail.com; Kwapulinski, Piotr > ; Olech, Milena ; > Kitszel, Przemyslaw > Subject: [

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jiri Pirko
Tue, Feb 11, 2025 at 01:12:12PM +0100, jedrzej.jagiel...@intel.com wrote: >From: Jiri Pirko >Sent: Monday, February 10, 2025 5:26 PM >>Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote: >> >>[...] >> >>>+enum ixgbe_devlink_version_type { >>>+IXGBE_DL_VERSION_FIXED, >>>+

Re: [Intel-wired-lan] [PATCH iwl-next v3] ixgbe: add support for thermal sensor event reception

2025-02-11 Thread Andrew Lunn
> Actually there is only one adapter across all portfolio of ixgbe adapters > which supports this feature. That is 82599, none other supports it. > Even next generations (x540, x550) didn't provide support for reading thermal > data sensor. > As E610 is some type of extending x550 it also follows t

Re: [Intel-wired-lan] [PATCH iwl-next v2 02/13] ixgbe: add handler for devlink .info_get()

2025-02-11 Thread Jiri Pirko
Tue, Feb 11, 2025 at 03:38:25PM +0100, przemyslaw.kits...@intel.com wrote: >On 2/11/25 13:52, Jiri Pirko wrote: >> Tue, Feb 11, 2025 at 01:12:12PM +0100, jedrzej.jagiel...@intel.com wrote: >> > From: Jiri Pirko >> > Sent: Monday, February 10, 2025 5:26 PM >> > > Mon, Feb 10, 2025 at 02:56:28PM +01

[Intel-wired-lan] [tnguy-next-queue:100GbE] BUILD SUCCESS 13e22972471d1639c16081e95b1caed9351ed3be

2025-02-11 Thread kernel test robot
clang-18 arc allmodconfiggcc-13.2.0 arc allnoconfiggcc-14.2.0 arc allyesconfigclang-18 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250211clang

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-11 Thread Lifshits, Vitaly
On 2/6/2025 10:09 PM, Stephen Hemminger wrote: On Thu, 6 Feb 2025 15:17:00 +0200 "Lifshits, Vitaly" wrote: On 2/6/2025 6:13 AM, Stephen Hemminger wrote: On Wed, 5 Feb 2025 12:36:31 +0200 "Lifshits, Vitaly" wrote: On 1/31/2025 3:21 AM, Stephen Hemminger wrote: On Thu, 30 Jan 2025 21:

[Intel-wired-lan] [linus:master] [treewide] b04e317b52: INFO:task_blocked_for_more_than#seconds

2025-02-11 Thread kernel test robot
Hello, we noticed the issue happens with a low rate on this commit, but keeps clean on parent when we even run the tests up to 999 times. just FYI. 41f70d8e16349c65 b04e317b522630b46f78ee62ecb --- fail:runs %reproductionfail:runs

[Intel-wired-lan] [tnguy-net-queue:dev-queue] BUILD SUCCESS 05a7449aaaac86c85f6de8db0eae8d9ab76c8b70

2025-02-11 Thread kernel test robot
gcc-13.2.0 arc allyesconfiggcc-13.2.0 arc randconfig-001-20250211gcc-13.2.0 arc randconfig-002-20250211gcc-13.2.0 arm allmodconfiggcc-14.2.0 arm allnoconfig

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 20:20:03 +0200 "Lifshits, Vitaly" wrote: > On 2/6/2025 10:09 PM, Stephen Hemminger wrote: > > On Thu, 6 Feb 2025 15:17:00 +0200 > > "Lifshits, Vitaly" wrote: > > > >> On 2/6/2025 6:13 AM, Stephen Hemminger wrote: > >>> On Wed, 5 Feb 2025 12:36:31 +0200 > >>> "Lifshits, V

Re: [Intel-wired-lan] suspend/resume broken of igc driver broken on 6.12

2025-02-11 Thread Stephen Hemminger
On Tue, 11 Feb 2025 20:20:03 +0200 "Lifshits, Vitaly" wrote: > > > On 2/6/2025 10:09 PM, Stephen Hemminger wrote: > > On Thu, 6 Feb 2025 15:17:00 +0200 > > "Lifshits, Vitaly" wrote: > > > >> On 2/6/2025 6:13 AM, Stephen Hemminger wrote: > >>> On Wed, 5 Feb 2025 12:36:31 +0200 > >>> "Lifshits,

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: synchronize pending IRQs after disable

2025-02-11 Thread Salin, Samuel
> -Original Message- > From: Intel-wired-lan On Behalf Of > Simon Horman > Sent: Thursday, January 16, 2025 10:30 AM > To: Zaki, Ahmed > Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Chittim, Madhu > ; Sudheer Mogilappagari > > Subject: Re: [Intel-wired-lan] [PATCH iwl

[Intel-wired-lan] [iwl-next v2 2/4] ixgbe: check for MDD events

2025-02-11 Thread Michal Swiatkowski
From: Don Skidmore When an event is detected it is logged and, for the time being, the queue is immediately re-enabled. This is due to the lack of an API to the hypervisor so it could deal with it as it chooses. Reviewed-by: Przemek Kitszel Reviewed-by: Jedrzej Jagielski Reviewed-by: Marcin S

[Intel-wired-lan] [iwl-next v2 1/4] ixgbe: add MDD support

2025-02-11 Thread Michal Swiatkowski
From: Paul Greenwalt Add malicious driver detection. Support enabling MDD, disabling MDD, handling a MDD event, and restoring a MDD VF. Reviewed-by: Przemek Kitszel Reviewed-by: Jedrzej Jagielski Reviewed-by: Marcin Szycik Signed-off-by: Paul Greenwalt Signed-off-by: Michal Swiatkowski ---

[Intel-wired-lan] [iwl-next v2 0/4] ixgbe: support MDD events

2025-02-11 Thread Michal Swiatkowski
Hi, This patchset is adding support for MDD (malicious driver detection) for ixgbe driver. It can catch the error on VF side and reset malicious VF. An MDD event can be triggered for example by sending from VF a TSO packet with segment number set to 0. Add checking for Tx hang in case of MDD is

[Intel-wired-lan] [iwl-next v2 3/4] ixgbe: add Tx hang detection unhandled MDD

2025-02-11 Thread Michal Swiatkowski
From: Slawomir Mrozowicz Add Tx Hang detection due to an unhandled MDD Event. Previously, a malicious VF could disable the entire port causing TX to hang on the E610 card. Those events that caused PF to freeze were not detected as an MDD event and usually required a Tx Hang watchdog timer to cat

[Intel-wired-lan] [iwl-next v2 4/4] ixgbe: turn off MDD while modifying SRRCTL

2025-02-11 Thread Michal Swiatkowski
From: Radoslaw Tyl Modifying SRRCTL register can generate MDD event. Turn MDD off during SRRCTL register write to prevent generating MDD. Fix RCT in ixgbe_set_rx_drop_en(). Reviewed-by: Marcin Szycik Reviewed-by: Przemek Kitszel Signed-off-by: Radoslaw Tyl Signed-off-by: Michal Swiatkowski