When running the igc with XDP/ZC in busy polling mode with deferral of hard
interrupts, interrupts still happen from time to time. That is caused by
the igc task watchdog which triggers Rx interrupts periodically.
That mechanism has been introduced to overcome skb/memory allocation
failures [1]. S
This is a follow up for the igb XDP/ZC implementation. The first two
patches link the IRQs and queues to NAPI instances. This is required to
bring back the XDP/ZC busy polling support. The last patch removes
undesired IRQs (injected via igb watchdog) while busy polling with
napi_defer_hard_irqs
Link IRQs to NAPI instances via netdev-genl API. This allows users to query
that information via netlink:
|$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/netdev.yaml \
| --dump napi-get --json='{"ifindex": 2}'
|[{'defer-hard-irqs': 0,
| 'gro-flush-
Link queues to NAPI instances via netdev-genl API. This is required to use
XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling
support") for details.
This also allows users to query the info with netlink:
|$ ./tools/net/ynl/pyynl/cli.py --spec Documentation/netlink/specs/n
On 08/02/2025 15:43, Piotr Wejman wrote:
Update the driver to use the new hardware timestamping API added in commit
66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
Use Netlink extack for error reporting in e1000e_hwtstamp_set.
Align the indentation of net_device_ops.
Signed
On 2/7/25 20:49, Tatyana Nikolova wrote:
This patch series is based on 6.14-rc1 and includes both netdev and RDMA
patches for ease of review. It can also be viewed here [1]. A shared pull
request will be sent for patches 1-7 following review.
[...]
TLDR of my mail: could be take 1st patch prio
E610 NICs unlike the previous devices utilising ixgbe driver
are notified in the case of overheatning by the FW ACI event.
In event of overheat when threshold is exceeded, FW suspends all
traffic and sends overtemp event to the driver. Then driver
logs appropriate message and closes the adapter in
> -Original Message-
> From: Simon Horman
> Sent: Friday, February 7, 2025 11:04 AM
> To: Nitka, Grzegorz
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Nguyen,
> Anthony L ; Kitszel, Przemyslaw
> ; Kolacinski, Karol
>
> Subject: Re: [PATCH iwl-next v1 1/3] ice: Add sync
> -Original Message-
> From: Simon Horman
> Sent: Friday, February 7, 2025 11:06 AM
> To: Nitka, Grzegorz
> Cc: intel-wired-...@lists.osuosl.org; net...@vger.kernel.org; Nguyen,
> Anthony L ; Kitszel, Przemyslaw
> ; Kolacinski, Karol
>
> Subject: Re: [PATCH iwl-next v1 2/3] ice: Refactor
From: Simon Horman
Sent: Friday, February 7, 2025 11:47 AM
>On Mon, Feb 03, 2025 at 04:03:16PM +0100, Jedrzej Jagielski wrote:
>> Add an initial support for devlink interface to ixgbe driver.
>>
>> Similarly to i40e driver the implementation doesn't enable
>> devlink to manage device-wide config
From: Simon Horman
Sent: Sunday, February 9, 2025 5:27 PM
>On Mon, Feb 03, 2025 at 04:03:17PM +0100, Jedrzej Jagielski wrote:
>> Provide devlink .info_get() callback implementation to allow the
>> driver to report detailed version information. The following info
>> is reported:
>>
>> "serial_nu
On Mon, Feb 10, 2025 at 11:41:31AM +0100, Przemek Kitszel wrote:
> On 2/7/25 20:49, Tatyana Nikolova wrote:
> > This patch series is based on 6.14-rc1 and includes both netdev and RDMA
> > patches for ease of review. It can also be viewed here [1]. A shared pull
> > request will be sent for patches
On Sun, Feb 09, 2025 at 11:47:24PM -0500, Ethan Carter Edwards wrote:
> Variable self assignment does not have any effect.
Hi Ethan
As a general rule, it would be good to explain in the comment message
what research you did to find out why there is a self assignment, and
why just deleting it is t
On 2025-02-06 7:29 p.m., Jakub Kicinski wrote:
Speaking of which, why do the auto-removal in napi_disable()
rather than netif_napi_del() ? We don't reinstall on napi_enable()
and doing a disable() + enable() is fairly common during driver
reconfig.
The patch does not re-install the notifie
Dear Jedrzej,
Thank you for the quick reply.
Am 10.02.25 um 12:59 schrieb Jagielski, Jedrzej:
From: Paul Menzel
Sent: Monday, February 10, 2025 12:40 PM
Am 10.02.25 um 11:40 schrieb Jedrzej Jagielski:
E610 NICs unlike the previous devices utilising ixgbe driver
are notified in the case o
From: Slawomir Mrozowicz
Read NVM related info from the flash.
Add several helper functions used to access the flash data,
find memory banks, calculate offsets, calculate the flash size.
Reviewed-by: Przemek Kitszel
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-develop
Add functions reading inactive versions from the inactive flash
banks.
Print stored NVM, OROM and netlist versions by devlink when there
is an ongoing update for E610 devices.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Co-developed-by: Slawomir Mrozowicz
Signed-off-by: Slawom
Variable self assignment does not have any effect.
Addresses-Coverity-ID: 1641823 ("Self assignment")
Fixes: 46761fd52a886 ("ixgbe: Add support for E610 FW Admin Command Interface")
Signed-off-by: Ethan Carter Edwards
---
drivers/net/ethernet/intel/ixgbe/ixgbe_e610.c | 1 -
1 file changed, 1 del
Update the driver to use the new hardware timestamping API added in commit
66f7223039c0 ("net: add NDOs for configuring hardware timestamping").
Use Netlink extack for error reporting in e1000e_hwtstamp_set.
Align the indentation of net_device_ops.
Signed-off-by: Piotr Wejman
---
Changes in v2:
Mon, Feb 10, 2025 at 02:56:28PM +0100, jedrzej.jagiel...@intel.com wrote:
[...]
>+enum ixgbe_devlink_version_type {
>+ IXGBE_DL_VERSION_FIXED,
>+ IXGBE_DL_VERSION_RUNNING,
>+};
>+
>+static int ixgbe_devlink_info_put(struct devlink_info_req *req,
>+enum ix
Dear Jedrzej,
Thank you for your patch.
Am 10.02.25 um 11:40 schrieb Jedrzej Jagielski:
E610 NICs unlike the previous devices utilising ixgbe driver
are notified in the case of overheatning by the FW ACI event.
overheating (without n)
In event of overheat when threshold is exceeded, FW sus
From: Paul Menzel
Sent: Monday, February 10, 2025 12:40 PM
>Dear Jedrzej,
>
>
>Thank you for your patch.
>
>Am 10.02.25 um 11:40 schrieb Jedrzej Jagielski:
>> E610 NICs unlike the previous devices utilising ixgbe driver
>> are notified in the case of overheatning by the FW ACI event.
>
>overheati
From: Paul Menzel
Sent: Monday, February 10, 2025 1:07 PM
>Dear Jedrzej,
>
>
>Thank you for the quick reply.
>
>
>Am 10.02.25 um 12:59 schrieb Jagielski, Jedrzej:
>> From: Paul Menzel
>> Sent: Monday, February 10, 2025 12:40 PM
>
>>> Am 10.02.25 um 11:40 schrieb Jedrzej Jagielski:
E610 NICs
Add E610 specific function checking whether the FW API version
is compatible with the driver expectations.
The major API version should be less than or equal to the expected
API version. If not the driver won't be fully operational.
Check the minor version, and if it is more than two versions les
The E610 adapters contain an embedded chip with firmware which can be
updated using devlink flash. The firmware which runs on this chip is
referred to as the Embedded Management Processor firmware (EMP
firmware).
Activating the new firmware image currently requires that the system be
rebooted. Thi
Introduce 2 E610 specific callbacks implementations:
-ixgbe_start_hw_e610() which expands the regular .start_hw callback with
getting FW version information
-ixgbe_read_pba_string_e610() which gets Product Board Assembly string
Extend EEPROM ops with new .read_pba_string in order to distinguish
ge
Use the pldmfw library to implement device flash update for
the Intel ixgbe networking device driver specifically for E610 devices.
This support uses the devlink flash update interface.
Using the pldmfw library, the provided firmware file will be scanned for
the three major components, "fw.undi" f
Add E610 implementation of fw_recovery_mode MAC operation.
In case of E610 information about recovery mode is obtained
from FW_MODES field in IXGBE_GL_MNG_FWSM register (0x000B6134).
Introduce recovery specific probing flow and init only
vital features.
User should be able to perform NVM update
E610 devices give possibility to show more detailed info than the previous
boards.
Extend reporting NVM info with following pieces:
fw.mgmt.api -> version number of the API
fw.mgmt.build -> identifier of the source for the FW
fw.psid.api -> version defining the format of the flash contents
fw.n
From: Slawomir Mrozowicz
Add functions reading the OROM version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Reviewed-by: Przemek Kitszel
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
S
Add an initial support for devlink interface to ixgbe driver.
Similarly to i40e driver the implementation doesn't enable
devlink to manage device-wide configuration. Devlink instance
is created for each physical function of PCIe device.
Create separate directory for devlink related ixgbe files
an
From: Andrii Staikov
The driver should detect whether the device entered FW rollback
mode and then notify user with the dedicated message including
FW and NVM versions.
Even if the driver detected rollback mode, this should not result
in an probe error and the normal flow proceeds.
FW tries to
Provide devlink .info_get() callback implementation to allow the
driver to report detailed version information. The following info
is reported:
"serial_number" -> The PCI DSN of the adapter
"fw.bundle_id" -> Unique identifier for the combined flash image
"fw.undi" -> Version of the Option ROM c
From: Slawomir Mrozowicz
Add functions reading the netlist version info and use them
as a part of the setting NVM info procedure.
Reviewed-by: Mateusz Polchlopek
Signed-off-by: Slawomir Mrozowicz
Co-developed-by: Piotr Kwapulinski
Signed-off-by: Piotr Kwapulinski
Signed-off-by: Jedrzej Jagie
Create devlink specific directory for more convenient future feature
development.
Flashing and reloading are supported only by E610 devices.
Introduce basic FW/NVM validation since devlink reload introduces
possibility of runtime NVM update. Check FW API version, FW recovery mode
and FW rollback
From: Karol Kolacinski
Refactor the code by changing ice_ptp_init_phc_eth56g function
name to ice_ptp_init_phc_e825, to be consistent with the naming pattern
for other devices.
Signed-off-by: Karol Kolacinski
Signed-off-by: Grzegorz Nitka
---
drivers/net/ethernet/intel/ice/ice_ptp_hw.c | 13 +
This patch series simplifies PTP code related to E825C products by
simplifying PHY register info definition.
Cleanup the code by removing unused register definitions.
v1->v2:
* remove sync delay adding from the series (patch 1/3). To be submitted as
separate patch.
* fix kdoc (patch 2/3) in ice_
From: Karol Kolacinski
Simplify ice_phy_reg_info_eth56g struct definition to include base
address for the very first quad. Use base address info and 'step'
value to determine address for specific PHY quad.
Reviewed-by: Przemek Kitszel
Signed-off-by: Karol Kolacinski
Signed-off-by: Grzegorz Nit
From: Karol Kolacinski
Minor PTP register refactor, including logical grouping E825C 1-step
timestamping registers. Remove unused register definitions
(PHY_REG_GPCS_BITSLIP, PHY_REG_REVISION).
Also, apply preferred GENMASK macro (instead of ICE_M) for register
fields definition affected by this p
> > > > Then driver
> > > > logs appropriate message and closes the adapter instance.
> > > > The card remains in that state until the platform is rebooted.
> > >
> > > As a user I’d be interested what the threshold is, and what the measured
> > > temperature is. Currently, the log seems to be jus
On Sat, 8 Feb 2025 16:43:49 +0100 Piotr Wejman wrote:
> - if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP))
> + if (!(adapter->flags & FLAG_HAS_HW_TIMESTAMP)) {
> + NL_SET_ERR_MSG(extack, "No HW timestamp support\n");
No new lines at the end of extack messages, please.
User space
From: Joshua Hay
Date: Tue, 4 Feb 2025 18:08:11 -0800
> On initial driver load, alloc_etherdev_mqs is called with whatever max
> queue values are provided by the control plane. However, if the driver
> is loaded on a system where num_online_cpus() returns less than the max
> queues, the netdev w
On Mon, Feb 10, 2025 at 10:19:35AM +0100, Kurt Kanzenbach wrote:
> Link IRQs to NAPI instances via netdev-genl API. This allows users to query
> that information via netlink:
>
> |$ ./tools/net/ynl/pyynl/cli.py --spec
> Documentation/netlink/specs/netdev.yaml \
> | -
On Mon, Feb 10, 2025 at 10:19:36AM +0100, Kurt Kanzenbach wrote:
> Link queues to NAPI instances via netdev-genl API. This is required to use
> XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling
> support") for details.
>
> This also allows users to query the info with net
Current init logic ignores the error code from register_netdev(),
which will cause WARN_ON() on attempt to unregister it, if there was one,
and there is no info for the user that the creation of the netdev failed.
WARNING: CPU: 89 PID: 6902 at net/core/dev.c:11512
unregister_netdevice_many_notify
On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote:
> This is a follow up for the igb XDP/ZC implementation. The first two
> patches link the IRQs and queues to NAPI instances. This is required to
> bring back the XDP/ZC busy polling support. The last patch removes
> undesired IRQs
On Mon, Feb 10, 2025 at 10:19:37AM +0100, Kurt Kanzenbach wrote:
> When running the igc with XDP/ZC in busy polling mode with deferral of hard
> interrupts, interrupts still happen from time to time. That is caused by
> the igc task watchdog which triggers Rx interrupts periodically.
>
> That mech
On 10.02.25 10:19, Kurt Kanzenbach wrote:
When running the igc with XDP/ZC in busy polling mode with deferral of hard
interrupts, interrupts still happen from time to time. That is caused by
the igc task watchdog which triggers Rx interrupts periodically.
igc or igb?
On Mon, 10 Feb 2025 08:04:43 -0700 Ahmed Zaki wrote:
> On 2025-02-06 7:29 p.m., Jakub Kicinski wrote:
>
> > Speaking of which, why do the auto-removal in napi_disable()
> > rather than netif_napi_del() ? We don't reinstall on napi_enable()
> > and doing a disable() + enable() is fairly common duri
On Mon, Feb 10, 2025 at 10:25:47AM -0800, Joe Damato wrote:
> On Mon, Feb 10, 2025 at 10:19:35AM +0100, Kurt Kanzenbach wrote:
> > Link IRQs to NAPI instances via netdev-genl API. This allows users to query
> > that information via netlink:
> >
> > |$ ./tools/net/ynl/pyynl/cli.py --spec
> > Docum
On Mon, Feb 10, 2025 at 10:19:34AM +0100, Kurt Kanzenbach wrote:
> This is a follow up for the igb XDP/ZC implementation. The first two
> patches link the IRQs and queues to NAPI instances. This is required to
> bring back the XDP/ZC busy polling support. The last patch removes
> undesired IRQs
On Mon Feb 10 2025, Gerhard Engleder wrote:
> On 10.02.25 10:19, Kurt Kanzenbach wrote:
>> When running the igc with XDP/ZC in busy polling mode with deferral of hard
>> interrupts, interrupts still happen from time to time. That is caused by
>> the igc task watchdog which triggers Rx interrupts pe
On Mon Feb 10 2025, Joe Damato wrote:
> On Mon, Feb 10, 2025 at 10:19:36AM +0100, Kurt Kanzenbach wrote:
>> Link queues to NAPI instances via netdev-genl API. This is required to use
>> XDP/ZC busy polling. See commit 5ef44b3cb43b ("xsk: Bring back busy polling
>> support") for details.
>>
>> This
> -Original Message-
> From: Lobakin, Aleksander
> Sent: Monday, February 10, 2025 7:02 AM
> To: Hay, Joshua A
> Cc: intel-wired-...@lists.osuosl.org; Samudrala, Sridhar
> ; Chittim, Madhu
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: call
> set_real_num_queues in idpf_open
>
54 matches
Mail list logo
