[Intel-wired-lan] [PATCH iwl-next v4 1/9] net: ethtool: mm: extract stmmac verification logic into common library

2025-02-09 Thread Faizal Rahim
From: Vladimir Oltean It appears that stmmac is not the only hardware which requires a software-driven verification state machine for the MAC Merge layer. While on the one hand it's good to encourage hardware implementations, on the other hand it's quite difficult to tolerate multiple drivers im

[Intel-wired-lan] [PATCH iwl-next v4 0/9] igc: Add support for Frame Preemption feature in IGC

2025-02-09 Thread Faizal Rahim
Introduces support for the FPE feature in the IGC driver. The patches aligns with the upstream FPE API: https://patchwork.kernel.org/project/netdevbpf/cover/20230220122343.1156614-1-vladimir.olt...@nxp.com/ https://patchwork.kernel.org/project/netdevbpf/cover/20230119122705.73054-1-vladimir.olt...

[Intel-wired-lan] [PATCH iwl-next v4 5/9] igc: Add support for frame preemption verification

2025-02-09 Thread Faizal Rahim
This patch implements the "ethtool --set-mm" callback to trigger the frame preemption verification handshake. Uses the MAC Merge Software Verification (mmsv) mechanism in ethtool to perform the verification handshake for igc. The structure fpe.mmsv is set by mmsv in ethtool and should remain read-

[Intel-wired-lan] [PATCH iwl-next v4 8/9] igc: Add support to get MAC Merge data via ethtool

2025-02-09 Thread Faizal Rahim
Implement "ethtool --show-mm" callback for IGC. Tested with command: $ ethtool --show-mm enp1s0. MAC Merge layer state for enp1s0: pMAC enabled: on TX enabled: on TX active: on TX minimum fragment size: 64 RX minimum fragment size: 60 Verify enabled: on Verify time: 128 Max verif

[Intel-wired-lan] [PATCH iwl-next v4 9/9] igc: Add support to get frame preemption statistics via ethtool

2025-02-09 Thread Faizal Rahim
Implemented "ethtool --include-statistics --show-mm" callback for IGC. Tested preemption scenario to check preemption statistics: 1) Trigger verification handshake on both boards: $ sudo ethtool --set-mm enp1s0 pmac-enabled on $ sudo ethtool --set-mm enp1s0 tx-enabled on $ sudo ethtool

[Intel-wired-lan] [PATCH iwl-next v4 6/9] igc: Add support to set tx-min-frag-size

2025-02-09 Thread Faizal Rahim
Add support to set tx-min-frag-size via set_mm callback in igc. Increase the max limit of tx-ming-frag-size in ethtool from 252 to 256 since i225/6 value range is 64, 128, 192 and 256. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes Signed-off-by: Faizal Rahim --- dri

[Intel-wired-lan] [PATCH iwl-next v4 7/9] igc: Add support for preemptible traffic class in taprio

2025-02-09 Thread Faizal Rahim
Set queue as preemptible or express via taprio. This will eventually set queue-specific preemptible field in TXQCTL register. Implement configure_tx(), a callback triggered by mmsv, to set tx_enabled and update preemptible queue settings. tx_enabled is a new field that serves as a condition in igc

[Intel-wired-lan] [PATCH iwl-next v4 4/9] igc: Set the RX packet buffer size for TSN mode

2025-02-09 Thread Faizal Rahim
In preparation for supporting frame preemption, when entering TSN mode set the receive packet buffer to 16KB for the Express MAC, 16KB for the Preemptible MAC and 2KB for the BMC, according to the datasheet section 7.1.3.2. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes

[Intel-wired-lan] [PATCH iwl-next v4 2/9] igc: Rename xdp_get_tx_ring() for non-xdp usage

2025-02-09 Thread Faizal Rahim
Renamed xdp_get_tx_ring() function to a more generic name for use in upcoming frame preemption patches. Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc.h | 2 +- drivers/net/ethernet/intel/igc/igc_main.c | 10 +- 2 files changed, 6 insertions(+), 6 deletions(-)

[Intel-wired-lan] [PATCH iwl-next v4 3/9] igc: Optimize the TX packet buffer utilization

2025-02-09 Thread Faizal Rahim
Packet buffers (RX + TX) total 64KB. Neither RX or TX buffers can be larger than 34KB. So divide the buffer equally, 32KB for each. Co-developed-by: Vinicius Costa Gomes Signed-off-by: Vinicius Costa Gomes Signed-off-by: Faizal Rahim --- drivers/net/ethernet/intel/igc/igc_defines.h | 3 ++- 1

Re: [Intel-wired-lan] [PATCH] ixgbe: remove self assignment

2025-02-09 Thread Michal Swiatkowski
patch. This change is already in progress [1] (I hope, waiting for v3). [1] https://lore.kernel.org/netdev/20250115034117.172999-1-dheeraj.linux...@gmail.com/ Thanks, Michal > > --- > base-commit: a64dcfb451e254085a7daee5fe51bf22959d52d3 > change-id: 20250209-e610-self-85eac1f0e338 > > Best regards, > -- > Ethan Carter Edwards

Re: [Intel-wired-lan] [iwl-next v1 1/4] ixgbe: add MDD support

2025-02-09 Thread Michal Swiatkowski
On Fri, Feb 07, 2025 at 03:07:49PM +, Simon Horman wrote: > On Fri, Feb 07, 2025 at 11:43:40AM +0100, Michal Swiatkowski wrote: > > From: Paul Greenwalt > > > > Add malicious driver detection. Support enabling MDD, disabling MDD, > > handling a MDD event, and restoring a MDD VF. > > > > Revi

Re: [Intel-wired-lan] [iwl-next v1 3/4] ixgbe: add Tx hang detection unhandled MDD

2025-02-09 Thread Michal Swiatkowski
On Fri, Feb 07, 2025 at 02:57:10PM +, Simon Horman wrote: > On Fri, Feb 07, 2025 at 11:43:42AM +0100, Michal Swiatkowski wrote: > > From: Slawomir Mrozowicz > > > > Add Tx Hang detection due to an unhandled MDD Event. > > > > Previously, a malicious VF could disable the entire port causing >

Re: [Intel-wired-lan] [PATCH iwl-next v1 01/13] ixgbe: add initial devlink support

2025-02-09 Thread Simon Horman
On Mon, Feb 03, 2025 at 04:03:16PM +0100, Jedrzej Jagielski wrote: > Add an initial support for devlink interface to ixgbe driver. > > Similarly to i40e driver the implementation doesn't enable > devlink to manage device-wide configuration. Devlink instance > is created for each physical function

Re: [Intel-wired-lan] [PATCH iwl-next v1 02/13] ixgbe: add handler for devlink .info_get()

2025-02-09 Thread Simon Horman
On Mon, Feb 03, 2025 at 04:03:17PM +0100, Jedrzej Jagielski wrote: > Provide devlink .info_get() callback implementation to allow the > driver to report detailed version information. The following info > is reported: > > "serial_number" -> The PCI DSN of the adapter > "fw.bundle_id" -> Unique id