Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 10:04 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 02:14:00PM +0100, Song, Yoong Siang wrote: >> On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, >> Maciej wrote: >> >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: >> > >> >> Enable Lau

Re: [Intel-wired-lan] [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 12:07:21PM +0100, Song, Yoong Siang wrote: > On Tuesday, February 4, 2025 5:50 PM, Fijalkowski, Maciej > wrote: > >On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote: > >> Refactor the code for inserting an empty packet into a new function > >> igc_insert_emp

[Intel-wired-lan] [PATCH iwl-net v2] idpf: call set_real_num_queues in idpf_open

2025-02-04 Thread Joshua Hay
On initial driver load, alloc_etherdev_mqs is called with whatever max queue values are provided by the control plane. However, if the driver is loaded on a system where num_online_cpus() returns less than the max queues, the netdev will think there are more queues than are actually available. Only

[Intel-wired-lan] [PATCH iwl-net v1 1/1] igc: Set buffer type for empty frames in igc_init_empty_frame

2025-02-04 Thread Song Yoong Siang
Set the buffer type to IGC_TX_BUFFER_TYPE_SKB for empty frame in the igc_init_empty_frame function. This ensures that the buffer type is correctly identified and handled during Tx ring cleanup. Fixes: db0b124f02ba ("igc: Enhance Qbv scheduling by using first flag bit") Cc: sta...@vger.kernel.org #

[Intel-wired-lan] [PATCH bpf-next v8 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song Yoong Siang
Refactor the code for inserting an empty packet into a new function igc_insert_empty_packet(). This change extracts the logic for inserting an empty packet from igc_xmit_frame_ring() into a separate function, allowing it to be reused in future implementations, such as the XDP zero copy transmit fun

[Intel-wired-lan] [PATCH bpf-next v8 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song Yoong Siang
Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel I225-LM Ethernet controller. Below are the test steps and result. Test 1: Send a single packet with the launch time set to

[Intel-wired-lan] [PATCH bpf-next v8 1/5] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-02-04 Thread Song Yoong Siang
Extend the XDP Tx metadata framework so that user can requests launch time hardware offload, where the Ethernet device will schedule the packet for transmission at a pre-determined time called launch time. The value of launch time is communicated from user space to Ethernet driver via launch_time f

[Intel-wired-lan] [PATCH bpf-next v8 2/5] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-02-04 Thread Song Yoong Siang
Add launch time hardware offload request to xdp_hw_metadata. Users can configure the delta of launch time relative to HW RX-time using the "-l" argument. By default, the delta is set to 0 ns, which means the launch time is disabled. By setting the delta to a non-zero value, the launch time hardware

[Intel-wired-lan] [PATCH bpf-next v8 0/5] xsk: TX metadata Launch Time support

2025-02-04 Thread Song Yoong Siang
This series expands the XDP TX metadata framework to allow user applications to pass per packet 64-bit launch time directly to the kernel driver, requesting launch time hardware offload support. The XDP TX metadata framework will not perform any clock conversion or packet reordering. Please note t

[Intel-wired-lan] [PATCH bpf-next v8 3/5] net: stmmac: Add launch time support to XDP ZC

2025-02-04 Thread Song Yoong Siang
Enable launch time (Time-Based Scheduling) support for XDP zero copy via the XDP Tx metadata framework. This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test 1: Send a single packet with the launch time

Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: add PTP support for E610 device

2025-02-04 Thread Vadim Fedorenko
On 04/02/2025 07:12, Piotr Kwapulinski wrote: Add PTP support for E610 adapter. The E610 is based on X550 and adds firmware managed link, enhanced security capabilities and support for updated server manageability. It does not introduce any new PTP features compared to X550. Reviewed-by: Milena

Re: [Intel-wired-lan] [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 8:36 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 12:07:21PM +0100, Song, Yoong Siang wrote: [...] >> >> "insert an empty packet" is a launch time trick to send a packet in >> next Qbv cycle. The design is, the driver will still sending the >> packet, eve

Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 02:14:00PM +0100, Song, Yoong Siang wrote: > On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, Maciej > wrote: > >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: > > > >> Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx > >> metadata

Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-04 Thread Lifshits, Vitaly
On 2/2/2025 7:08 PM, Piotr Wejman wrote: Update the driver to the new hw timestamping API. > Signed-off-by: Piotr Wejman --- drivers/net/ethernet/intel/e1000e/e1000.h | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 52 -- 2 files changed, 20 insertions(+), 34 de

Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 03:49:32PM +0100, Song, Yoong Siang wrote: > On Tuesday, February 4, 2025 10:04 PM, Fijalkowski, Maciej > wrote: > >On Tue, Feb 04, 2025 at 02:14:00PM +0100, Song, Yoong Siang wrote: > >> On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, > >> Maciej wrote: > >> >On Tue,

Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 11:18 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 03:49:32PM +0100, Song, Yoong Siang wrote: [...] >> With above, IMHO, we no need to clear igc_tx_buffer::type, >> Are you agree? > >Yes, the contract should be that every routine that produces descriptors

Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-04 Thread Vadim Fedorenko
On 02/02/2025 17:08, Piotr Wejman wrote: Update the driver to the new hw timestamping API. Signed-off-by: Piotr Wejman --- drivers/net/ethernet/intel/e1000e/e1000.h | 2 +- drivers/net/ethernet/intel/e1000e/netdev.c | 52 -- 2 files changed, 20 insertions(+), 34 deleti

Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 6:10 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: > >> Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx >> metadata framework. >> >> This patch has been tested with tools/testing/selftests/bpf/x

[Intel-wired-lan] [PATCH iwl-next v2 4/6] ice: remove headers argument from ice_tc_count_lkups

2025-02-04 Thread Larysa Zaremba
Remove the headers argument from the ice_tc_count_lkups() function, because it is not used anywhere. Reviewed-by: Michal Swiatkowski Signed-off-by: Larysa Zaremba --- drivers/net/ethernet/intel/ice/ice_tc_lib.c | 11 +++ 1 file changed, 3 insertions(+), 8 deletions(-) diff --git a/driv

[Intel-wired-lan] [PATCH iwl-next v2 5/6] ice: support egress drop rules on PF

2025-02-04 Thread Larysa Zaremba
tc clsact qdisc allows us to add offloaded egress rules with commands such as the following one: tc filter add dev egress protocol lldp flower skip_sw action drop Support the egress rule drop action when added to PF, with a few caveats: * in switchdev mode, all PF traffic has to go uplink with a

[Intel-wired-lan] [PATCH iwl-next v2 1/6] ice: fix check for existing switch rule

2025-02-04 Thread Larysa Zaremba
From: Mateusz Pacuszka In case the rule already exists and another VSI wants to subscribe to it new VSI list is being created and both VSIs are moved to it. Currently, the check for already existing VSI with the same rule is done based on fdw_id.hw_vsi_id, which applies only to LOOKUP_RX flag. Ch

[Intel-wired-lan] [PATCH iwl-next v2 2/6] ice: do not add LLDP-specific filter if not necessary

2025-02-04 Thread Larysa Zaremba
Commit 34295a3696fb ("ice: implement new LLDP filter command") introduced the ability to use LLDP-specific filter that directs all LLDP traffic to a single VSI. However, current goal is for all trusted VFs to be able to see LLDP neighbors, which is impossible to do with the special filter. Make us

[Intel-wired-lan] [PATCH iwl-next v2 0/6] ice: LLDP support for VFs

2025-02-04 Thread Larysa Zaremba
Allow to: * receive LLDP packets on a VF in legacy mode * receive LLDP packets on a VF in switchdev mode * transmit LLDP from a VF in switchdev mode Many VSIs can receive LLDP packets, but only one VSI per port can transmit LLDP, therefore LLDP TX from VF requires adding an egress drop rule to the

[Intel-wired-lan] [PATCH iwl-next v2 3/6] ice: receive LLDP on trusted VFs

2025-02-04 Thread Larysa Zaremba
From: Mateusz Pacuszka When a trusted VF tries to configure an LLDP multicast address, configure a rule that would mirror the traffic to this VF, untrusted VFs are not allowed to receive LLDP at all, so the request to add LLDP MAC address will always fail for them. Add a forwarding LLDP filter t

[Intel-wired-lan] [PATCH iwl-next v2 6/6] ice: enable LLDP TX for VFs through tc

2025-02-04 Thread Larysa Zaremba
Only a single VSI can be in charge of sending LLDP frames, sometimes it is beneficial to assign this function to a VF, that is possible to do with tc capabilities in the switchdev mode. It requires first blocking the PF from sending the LLDP frames with a following command: tc filter add dev egre

Re: [Intel-wired-lan] [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote: > Refactor the code for inserting an empty packet into a new function > igc_insert_empty_packet(). This change extracts the logic for inserting > an empty packet from igc_xmit_frame_ring() into a separate function, > allowing it to b

Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: add PTP support for E610 device

2025-02-04 Thread Simon Horman
On Tue, Feb 04, 2025 at 08:12:59AM +0100, Piotr Kwapulinski wrote: > Add PTP support for E610 adapter. The E610 is based on X550 and adds > firmware managed link, enhanced security capabilities and support for > updated server manageability. It does not introduce any new PTP features > compared to

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-04 Thread Andrew Lunn
On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: > E610 NICs unlike the previous devices utilising ixgbe driver > are notified in the case of overheatning by the FW ACI event. > > In event of overheat when treshold is exceeded, FW suspends all > traffic and sends overtemp event t

[Intel-wired-lan] [PATCH net-next v7 0/5] net: napi: add CPU affinity to napi->config

2025-02-04 Thread Ahmed Zaki
Drivers usually need to re-apply the user-set IRQ affinity to their IRQs after reset. However, since there can be only one IRQ affinity notifier for each IRQ, registering IRQ notifiers conflicts with the ARFS rmap management in the core (which also registers separate IRQ affinity notifiers). Mo

[Intel-wired-lan] [PATCH net-next v7 1/5] net: move ARFS rmap management to core

2025-02-04 Thread Ahmed Zaki
Add a new netdev flag "rx_cpu_rmap_auto". Drivers supporting ARFS should set the flag via netif_enable_cpu_rmap() and core will allocate and manage the ARFS rmap. Freeing the rmap is also done by core when the netdev is freed. For better IRQ affinity management, move the IRQ rmap notifier inside t

[Intel-wired-lan] [PATCH net-next v7 5/5] idpf: use napi's irq affinity

2025-02-04 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/idpf/idpf_lib.c | 1 + drivers/net/ethernet/intel/idpf/idpf_txrx.c | 22 +++-- drivers/net/ethernet/intel/idpf/idpf_txrx.h | 6 ++ 3 files c

[Intel-wired-lan] [PATCH net-next v7 2/5] net: napi: add CPU affinity to napi_config

2025-02-04 Thread Ahmed Zaki
A common task for most drivers is to remember the user-set CPU affinity to its IRQs. On each netdev reset, the driver should re-assign the user's settings to the IRQs. Add CPU affinity mask to napi_config. To delegate the CPU affinity management to the core, drivers must: 1 - set the new netdev f

[Intel-wired-lan] [PATCH net-next v7 3/5] bnxt: use napi's irq affinity

2025-02-04 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/broadcom/bnxt/bnxt.c | 25 +++ drivers/net/ethernet/broadcom/bnxt/bnxt.h | 2 -- 2 files changed, 3 insertions(+), 24 deletions(-) diff --git a/dri

[Intel-wired-lan] [PATCH net-next v7 4/5] ice: use napi's irq affinity

2025-02-04 Thread Ahmed Zaki
Delete the driver CPU affinity info and use the core's napi config instead. Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/ice/ice.h | 3 -- drivers/net/ethernet/intel/ice/ice_base.c | 7 +--- drivers/net/ethernet/intel/ice/ice_lib.c | 6 --- drivers/net/ethernet/intel/ice/ice

Re: [Intel-wired-lan] [PATCH net-next v7 2/5] net: napi: add CPU affinity to napi_config

2025-02-04 Thread Joe Damato
On Tue, Feb 04, 2025 at 03:06:19PM -0700, Ahmed Zaki wrote: > A common task for most drivers is to remember the user-set CPU affinity > to its IRQs. On each netdev reset, the driver should re-assign the > user's settings to the IRQs. > > Add CPU affinity mask to napi_config. To delegate the CPU af

Re: [Intel-wired-lan] [PATCH iwl-next v2 6/6] ice: enable LLDP TX for VFs through tc

2025-02-04 Thread kernel test robot
Hi Larysa, kernel test robot noticed the following build warnings: [auto build test WARNING on tnguy-next-queue/dev-queue] url: https://github.com/intel-lab-lkp/linux/commits/Larysa-Zaremba/ice-fix-check-for-existing-switch-rule/20250204-200839 base: https://git.kernel.org/pub/scm/linux

Re: [Intel-wired-lan] [PATCH iwl-next v4] e1000e: Fix real-time violations on link up

2025-02-04 Thread Tony Nguyen
On 2/4/2025 12:18 PM, Gerhard Engleder wrote: Is there anything left from my side to get this change over iwl-next into net-next? Hi Gerhard, Nothing at the moment. I have it on my list to send but I'm working through the backlogged patches. Thanks, Tony Gerhard

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-04 Thread Simon Horman
On Tue, Feb 04, 2025 at 08:17:00AM +0100, Jedrzej Jagielski wrote: > E610 NICs unlike the previous devices utilising ixgbe driver > are notified in the case of overheatning by the FW ACI event. > > In event of overheat when treshold is exceeded, FW suspends all A nit flagged by checkpatch.pl --co

Re: [Intel-wired-lan] [PATCH iwl-next v4] e1000e: Fix real-time violations on link up

2025-02-04 Thread Gerhard Engleder
On 06.01.25 12:17, Simon Horman wrote: On Thu, Dec 19, 2024 at 08:27:43PM +0100, Gerhard Engleder wrote: From: Gerhard Engleder Link down and up triggers update of MTA table. This update executes many PCIe writes and a final flush. Thus, PCIe will be blocked until all writes are flushed. As a

Re: [Intel-wired-lan] [PATCH bpf-next v7 4/5] igc: Refactor empty packet insertion into a reusable function

2025-02-04 Thread Song, Yoong Siang
On Tuesday, February 4, 2025 5:50 PM, Fijalkowski, Maciej wrote: >On Tue, Feb 04, 2025 at 08:49:06AM +0800, Song Yoong Siang wrote: >> Refactor the code for inserting an empty packet into a new function >> igc_insert_empty_packet(). This change extracts the logic for inserting >> an empty packet

Re: [Intel-wired-lan] [PATCH iwl-next v2] ixgbe: add support for thermal sensor event reception

2025-02-04 Thread Mateusz Polchlopek
On 2/4/2025 8:17 AM, Jedrzej Jagielski wrote: E610 NICs unlike the previous devices utilising ixgbe driver are notified in the case of overheatning by the FW ACI event. In event of overheat when treshold is exceeded, FW suspends all traffic and sends overtemp event to the driver. Then driver

Re: [Intel-wired-lan] [xdp-hints] [PATCH bpf-next v7 5/5] igc: Add launch time support to XDP ZC

2025-02-04 Thread Maciej Fijalkowski
On Tue, Feb 04, 2025 at 08:49:07AM +0800, Song Yoong Siang wrote: > Enable Launch Time Control (LTC) support for XDP zero copy via XDP Tx > metadata framework. > > This patch has been tested with tools/testing/selftests/bpf/xdp_hw_metadata > on Intel I225-LM Ethernet controller. Below are the tes

Re: [Intel-wired-lan] [PATCH] net: e1000e: convert to ndo_hwtstamp_get() and ndo_hwtstamp_set()

2025-02-04 Thread Vadim Fedorenko
On 03/02/2025 16:41, Paul Menzel wrote: Dear Piotr, Thank you for your patch. Am 02.02.25 um 18:08 schrieb Piotr Wejman: Update the driver to the new hw timestamping API. Could you please elaborate. Maybe a pointer to the new API, and what commit added it, and what tests were done, and/or