Re: [Intel-wired-lan] [PATCH iwl-next v1] ixgbe: add support for thermal sensor event reception

2025-01-16 Thread Jagielski, Jedrzej
From: Paul Menzel Sent: Wednesday, January 15, 2025 2:40 PM >Dear Jedrzej, > >Thank you for the patch. > >Am 15.01.25 um 13:27 schrieb Jedrzej Jagielski: >> E610 NICs unlike the previous devices utilising ixgbe driver >> are notified in the case of overheat by the FW ACI event. > >overheat*ing* >

[Intel-wired-lan] [PATCH iwl-net] idpf: synchronize pending IRQs after disable

2025-01-16 Thread Ahmed Zaki
Wait for pending IRQ handler after it is disabled. This will ensure the IRQ is cleanly freed afterwards. Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") Reviewed-by: Madhu Chittim Suggested-by: Sudheer Mogilappagari Signed-off-by: Ahmed Zaki --- drivers/net/ethernet/intel/

[Intel-wired-lan] [PATCH bpf-next v6 2/4] selftests/bpf: Add launch time request to xdp_hw_metadata

2025-01-16 Thread Song Yoong Siang
Add launch time hardware offload request to xdp_hw_metadata. Users can configure the delta of launch time relative to HW RX-time using the "-l" argument. By default, the delta is set to 0 ns, which means the launch time is disabled. By setting the delta to a non-zero value, the launch time hardware

[Intel-wired-lan] [PATCH bpf-next v6 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-16 Thread Song Yoong Siang
Enable launch time (Time-Based Scheduling) support to XDP zero copy via XDP Tx metadata framework. This patch is tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test Steps: 1. At DUT, start xdp_hw_metadata selftest applica

[Intel-wired-lan] [PATCH bpf-next v6 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-16 Thread Song Yoong Siang
Extend the XDP Tx metadata framework so that user can requests launch time hardware offload, where the Ethernet device will schedule the packet for transmission at a pre-determined time called launch time. The value of launch time is communicated from user space to Ethernet driver via launch_time f

[Intel-wired-lan] [PATCH bpf-next v6 0/4] xsk: TX metadata Launch Time support

2025-01-16 Thread Song Yoong Siang
This series expands the XDP TX metadata framework to allow user applications to pass per packet 64-bit launch time directly to the kernel driver, requesting launch time hardware offload support. The XDP TX metadata framework will not perform any clock conversion or packet reordering. Please note t

[Intel-wired-lan] [PATCH bpf-next v6 4/4] igc: Add launch time support to XDP ZC

2025-01-16 Thread Song Yoong Siang
Enable Launch Time Control (LTC) support to XDP zero copy via XDP Tx metadata framework. This patch is tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel I225-LM Ethernet controller. Below are the test steps and result. Test Steps: 1. At DUT, start xdp_hw_metadata selftest applicati

Re: [Intel-wired-lan] [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic

2025-01-16 Thread Przemek Kitszel
On 1/16/25 16:39, Maciej Fijalkowski wrote: Hello in 2025, this patchset fixes a pretty nasty issue that was reported by RedHat folks which occured after ~30 minutes (this value varied, just trying here to state that it was not observed immediately but rather after a considerable longer amount o

Re: [Intel-wired-lan] [PATCH iwl-next] ixgbe: Fix possible skb NULL pointer dereference

2025-01-16 Thread Maciej Fijalkowski
On Wed, Jan 15, 2025 at 03:59:04PM +0100, Piotr Kwapulinski wrote: > Check both skb NULL pointer dereference and error in ixgbe_put_rx_buffer(). Hi Piotr, is this only theoretical or have you encountered any system panic? If so please include the splat so that reviewers will be able to understand

Re: [Intel-wired-lan] [PATCH v2 net-next] ixgbe: Fix endian handling for ACI descriptor registers

2025-01-16 Thread Simon Horman
On Wed, Jan 15, 2025 at 09:11:17AM +0530, Dheeraj Reddy Jonnalagadda wrote: > The ixgbe driver was missing proper endian conversion for ACI descriptor > register operations. Add the necessary conversions when reading and > writing to the registers. > > Fixes: 46761fd52a88 ("ixgbe: Add support for

Re: [Intel-wired-lan] [PATCH intel-net 1/3] ice: put Rx buffers after being done with current frame

2025-01-16 Thread Petr Oros
On 16. 01. 25 16:39, Maciej Fijalkowski wrote: Introduce a new helper ice_put_rx_mbuf() that will go through gathered frags from current frame and will call ice_put_rx_buf() on them. Current logic that was supposed to simplify and optimize the driver where we go through a batch of all buffers p

[Intel-wired-lan] [tnguy-next-queue:10GbE] BUILD SUCCESS 7a1723d3b230765dc025401db8308937e4c4fb13

2025-01-16 Thread kernel test robot
ang-18 arc allyesconfiggcc-13.2.0 arc defconfiggcc-14.2.0 arc randconfig-001-20250116gcc-13.2.0 arc randconfig-002-20250116gcc-13.2.0 arm allmodconfigcl

Re: [Intel-wired-lan] [PATCH net-next v7 0/8] fix two bugs related to page_pool

2025-01-16 Thread Jesper Dangaard Brouer
On 16/01/2025 13.52, Yunsheng Lin wrote: On 2025/1/16 1:40, Jesper Dangaard Brouer wrote: On 15/01/2025 12.33, Yunsheng Lin wrote: On 2025/1/14 22:31, Jesper Dangaard Brouer wrote: On 10/01/2025 14.06, Yunsheng Lin wrote: This patchset fix a possible time window problem for page_pool a

Re: [Intel-wired-lan] [PATCH intel-net 1/3] ice: put Rx buffers after being done with current frame

2025-01-16 Thread Maciej Fijalkowski
On Thu, Jan 16, 2025 at 06:10:38PM +0100, Petr Oros wrote: > > On 16. 01. 25 16:39, Maciej Fijalkowski wrote: > > Introduce a new helper ice_put_rx_mbuf() that will go through gathered > > frags from current frame and will call ice_put_rx_buf() on them. Current > > logic that was supposed to simpl

Re: [Intel-wired-lan] [PATCH iwl-net] idpf: synchronize pending IRQs after disable

2025-01-16 Thread Simon Horman
On Thu, Jan 16, 2025 at 06:42:57AM -0700, Ahmed Zaki wrote: > Wait for pending IRQ handler after it is disabled. This will ensure the IRQ > is cleanly freed afterwards. > > Fixes: d4d558718266 ("idpf: initialize interrupts and enable vport") > Reviewed-by: Madhu Chittim > Suggested-by: Sudheer Mo

Re: [Intel-wired-lan] [PATCH net-next v7 0/8] fix two bugs related to page_pool

2025-01-16 Thread Yunsheng Lin
On 2025/1/16 1:40, Jesper Dangaard Brouer wrote: > > > On 15/01/2025 12.33, Yunsheng Lin wrote: >> On 2025/1/14 22:31, Jesper Dangaard Brouer wrote: >>> >>> >>> On 10/01/2025 14.06, Yunsheng Lin wrote: This patchset fix a possible time window problem for page_pool and the dma API misuse

[Intel-wired-lan] [PATCH iwl-next] idpf: modify vport_cfg_lock to be per-vport

2025-01-16 Thread Ahmed Zaki
The vport config lock protects the vports queues and config data. These mainly change in soft reset path. Since there is no dependency across vports, there is no need for this lock to be global. Move the lock to be per-vport and allow one vport to reset without locking the rest of the vports. Rev

[Intel-wired-lan] [PATCH intel-net 3/3] ice: stop storing XDP verdict within ice_rx_buf

2025-01-16 Thread Maciej Fijalkowski
Idea behind having ice_rx_buf::act was to simplify and speed up the Rx data path by walking through buffers that were representing cleaned HW Rx descriptors. Since it caused us a major headache recently and we rolled back to old approach that 'puts' Rx buffers right after running XDP prog/creating

[Intel-wired-lan] [PATCH intel-net 1/3] ice: put Rx buffers after being done with current frame

2025-01-16 Thread Maciej Fijalkowski
Introduce a new helper ice_put_rx_mbuf() that will go through gathered frags from current frame and will call ice_put_rx_buf() on them. Current logic that was supposed to simplify and optimize the driver where we go through a batch of all buffers processed in current NAPI instance turned out to be

[Intel-wired-lan] [PATCH intel-net 0/3] ice: fix Rx data path for heavy 9k MTU traffic

2025-01-16 Thread Maciej Fijalkowski
Hello in 2025, this patchset fixes a pretty nasty issue that was reported by RedHat folks which occured after ~30 minutes (this value varied, just trying here to state that it was not observed immediately but rather after a considerable longer amount of time) when ice driver was tortured with jumb

[Intel-wired-lan] [PATCH intel-net 2/3] ice: gather page_count()'s of each frag right before XDP prog call

2025-01-16 Thread Maciej Fijalkowski
Intel networking drivers have a page recycling scheme that is nicely explained by Bjorn Topel in commit 75aab4e10ae6 ("i40e: avoid premature Rx buffer reuse"). Please refer to it for better understanding what is described below. If we store the page count on a bunch of fragments while being in the