Re: [Intel-wired-lan] [PATCH net-next v6 0/8] fix two bugs related to page_pool

2025-01-06 Thread Jakub Kicinski
On Mon, 6 Jan 2025 21:01:08 +0800 Yunsheng Lin wrote: > This patchset fix a possible time window problem for page_pool and > the dma API misuse problem as mentioned in [1], and try to avoid the > overhead of the fixing using some optimization. > > From the below performance data, the overhead is n

Re: [Intel-wired-lan] [PATCH net-next 0/9] i40e deadcoding

2025-01-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 2 Jan 2025 17:37:08 + you wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This is a bunch of deadcoding of functions that > are entirely uncalled in the i40e driver. > > Build tested only. > >

Re: [Intel-wired-lan] [PATCH net-next 0/3] igc deadcoding

2025-01-06 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Thu, 2 Jan 2025 17:41:39 + you wrote: > From: "Dr. David Alan Gilbert" > > Hi, > This set removes some functions that are entirely unused > and have been since ~2018. > > Build tested. > > [...] Here i

Re: [Intel-wired-lan] [PATCH net-next v3 3/6] net: napi: add CPU affinity to napi_config

2025-01-06 Thread Dan Carpenter
Hi Ahmed, kernel test robot noticed the following build warnings: url: https://github.com/intel-lab-lkp/linux/commits/Ahmed-Zaki/net-move-ARFS-rmap-management-to-core/20250104-084501 base: net-next/main patch link: https://lore.kernel.org/r/20250104004314.208259-4-ahmed.zaki%40intel.com

Re: [Intel-wired-lan] [RFC net-next 1/9] i40e: Deadcode i40e_aq_*

2025-01-06 Thread Simon Horman
On Sat, Dec 21, 2024 at 06:42:39PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > i40e_aq_add_mirrorrule(), i40e_aq_delete_mirrorrule() and > i40e_aq_set_vsi_vlan_promisc() were added in 2016 by > commit 7bd6875bef70 ("i40e: APIs to Add/remove port mirroring rules") > but ha

Re: [Intel-wired-lan] [RFC net-next 4/9] i40e: Deadcode profile code

2025-01-06 Thread Simon Horman
On Sat, Dec 21, 2024 at 06:42:42PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > i40e_add_pinfo_to_list() was added in 2017 by > commit 1d5c960c5ef5 ("i40e: new AQ commands") > > i40e_find_section_in_profile() was added in 2019 by > commit cdc594e00370 ("i40e: Implement DD

Re: [Intel-wired-lan] [RFC net-next 3/9] i40e: Remove unused i40e_(read|write)_phy_register

2025-01-06 Thread Simon Horman
On Sat, Dec 21, 2024 at 06:42:41PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > i40e_read_phy_register() and i40e_write_phy_register() were added in > 2016 by > commit f62ba91458b5 ("i40e: Add functions which apply correct PHY access > method for read and write operation")

Re: [Intel-wired-lan] [RFC net-next 8/9] i40e: Remove unused i40e_asq_send_command_v2

2025-01-06 Thread Simon Horman
On Sat, Dec 21, 2024 at 06:42:46PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > i40e_asq_send_command_v2() was added in 2022 by > commit 74073848b0d7 ("i40e: Add new versions of send ASQ command > functions") > but hasn't been used. > > Remove it. > > (The _atomic_v2 ver

Re: [Intel-wired-lan] [RFC net-next 6/9] i40e: Remove unused i40e_del_filter

2025-01-06 Thread Simon Horman
On Sat, Dec 21, 2024 at 06:42:44PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The last use of i40e_del_filter() was removed in 2016 by > commit 9569a9a4547d ("i40e: when adding or removing MAC filters, correctly > handle VLANs") > > Remove it. > > Fix up a comment that

Re: [Intel-wired-lan] [PATCH iwl-next v6] ice: Add E830 checksum offload support

2025-01-06 Thread Simon Horman
On Wed, Dec 18, 2024 at 04:11:45AM -0500, Paul Greenwalt wrote: > E830 supports raw receive and generic transmit checksum offloads. > > Raw receive checksum support is provided by hardware calculating the > checksum over the whole packet, regardless of type. The calculated > checksum is provided t

Re: [Intel-wired-lan] [PATCH net-next 0/9] i40e deadcoding

2025-01-06 Thread Tony Nguyen
On 1/4/2025 8:16 AM, Jakub Kicinski wrote: On Thu, 2 Jan 2025 17:37:08 + li...@treblig.org wrote: This is a bunch of deadcoding of functions that are entirely uncalled in the i40e driver. Build tested only. Intel folks, is it okay if we take this (and the igc series) in directly

Re: [Intel-wired-lan] [PATCH net-next 0/3] igc deadcoding

2025-01-06 Thread Tony Nguyen
On 1/2/2025 9:41 AM, li...@treblig.org wrote: From: "Dr. David Alan Gilbert" Hi, This set removes some functions that are entirely unused and have been since ~2018. Build tested. Signed-off-by: Dr. David Alan Gilbert (Repost now netdev is open) Reviewed-by: Tony Nguyen Dr. David A

Re: [Intel-wired-lan] [PATCH iwl-net v3] ice: fix ice_parser_rt::bst_key array size

2025-01-06 Thread Simon Horman
On Thu, Dec 19, 2024 at 12:55:16PM +0100, Przemek Kitszel wrote: > Fix &ice_parser_rt::bst_key size. It was wrongly set to 10 instead of 20 > in the initial impl commit (see Fixes tag). All usage code assumed it was > of size 20. That was also the initial size present up to v2 of the intro > series

[Intel-wired-lan] [PATCH bpf-next v4 0/4] xsk: TX metadata Launch Time support

2025-01-06 Thread Song Yoong Siang
This series expands the XDP TX metadata framework to allow user applications to pass per packet 64-bit launch time directly to the kernel driver, requesting launch time hardware offload support. The XDP TX metadata framework will not perform any clock conversion or packet reordering. Please note t

Re: [Intel-wired-lan] [PATCH iwl-net] ice: Fix switchdev slow-path in LAG

2025-01-06 Thread Simon Horman
On Thu, Jan 02, 2025 at 08:07:52PM +0100, Marcin Szycik wrote: > Ever since removing switchdev control VSI and using PF for port > representor Tx/Rx, switchdev slow-path has been working improperly after > failover in SR-IOV LAG. LAG assumes that the first uplink to be added to > the aggregate will

[Intel-wired-lan] [PATCH bpf-next v4 2/4] selftests/bpf: Add Launch Time request to xdp_hw_metadata

2025-01-06 Thread Song Yoong Siang
Add Launch Time hw offload request to xdp_hw_metadata. User can configure the delta of launch time to HW RX-time by using "-l" argument. The default delta is 100,000,000 nanosecond. Signed-off-by: Song Yoong Siang --- tools/testing/selftests/bpf/xdp_hw_metadata.c | 30 +-- 1 file

[Intel-wired-lan] [PATCH bpf-next v4 4/4] igc: Add launch time support to XDP ZC

2025-01-06 Thread Song Yoong Siang
Enable Launch Time Control (LTC) support to XDP zero copy via XDP Tx metadata framework. This patch is tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test Steps: 1. Add mqprio qdisc: $ sudo tc qdisc add dev enp2s0 hand

[Intel-wired-lan] [PATCH bpf-next v4 3/4] net: stmmac: Add launch time support to XDP ZC

2025-01-06 Thread Song Yoong Siang
Enable launch time (Time-Based Scheduling) support to XDP zero copy via XDP Tx metadata framework. This patch is tested with tools/testing/selftests/bpf/xdp_hw_metadata on Intel Tiger Lake platform. Below are the test steps and result. Test Steps: 1. Add mqprio qdisc: $ sudo tc qdisc add dev e

[Intel-wired-lan] [PATCH bpf-next v4 1/4] xsk: Add launch time hardware offload support to XDP Tx metadata

2025-01-06 Thread Song Yoong Siang
Extend the XDP Tx metadata framework so that user can requests launch time hardware offload, where the Ethernet device will schedule the packet for transmission at a pre-determined time called launch time. The value of launch time is communicated from user space to Ethernet driver via launch_time f

Re: [Intel-wired-lan] [PATCH v2 RESEND net-next] e1000e: makes e1000_watchdog_task use queue_delayed_work

2025-01-06 Thread Lifshits, Vitaly
On 1/5/2025 1:38 PM, Dmitrii Ermakov wrote: Replaces watchdog timer with delayed_work as advised in the driver's TODO comment. Signed-off-by: Dmitrii Ermakov --- V1 -> V2: Removed redundant line wraps, renamed e1000_watchdog to e1000_watchdog_work drivers/net/ethernet/intel/e1000e/e1000.

Re: [Intel-wired-lan] [PATCH iwl-net v2] idpf: fix transaction timeouts on reset

2025-01-06 Thread Simon Horman
On Thu, Dec 19, 2024 at 06:09:32PM -0800, Emil Tantilov wrote: > Restore the call to idpf_vc_xn_shutdown() at the beginning of > idpf_vc_core_deinit() provided the function is not called on remove. > In the reset path the mailbox is destroyed, leading to all transactions > timing out. > > Fixes: 0

Re: [Intel-wired-lan] [PATCH iwl-next v4] e1000e: Fix real-time violations on link up

2025-01-06 Thread Simon Horman
On Thu, Dec 19, 2024 at 08:27:43PM +0100, Gerhard Engleder wrote: > From: Gerhard Engleder > > Link down and up triggers update of MTA table. This update executes many > PCIe writes and a final flush. Thus, PCIe will be blocked until all > writes are flushed. As a result, DMA transfers of other t

[Intel-wired-lan] [PATCH net-next v6 0/8] fix two bugs related to page_pool

2025-01-06 Thread Yunsheng Lin
This patchset fix a possible time window problem for page_pool and the dma API misuse problem as mentioned in [1], and try to avoid the overhead of the fixing using some optimization. >From the below performance data, the overhead is not so obvious due to performance variations for time_bench_page

[Intel-wired-lan] [PATCH net-next v6 1/8] page_pool: introduce page_pool_get_pp() API

2025-01-06 Thread Yunsheng Lin
introduce page_pool_get_pp() API to avoid caller accessing page->pp directly. Signed-off-by: Yunsheng Lin --- drivers/net/ethernet/freescale/fec_main.c | 8 +--- .../net/ethernet/google/gve/gve_buffer_mgmt_dqo.c | 2 +- drivers/net/ethernet/intel/iavf/iavf_txrx.c| 6

Re: [Intel-wired-lan] [RFC net-next] ixgbevf: Remove unused ixgbevf_hv_mbx_ops

2025-01-06 Thread Simon Horman
On Thu, Dec 26, 2024 at 02:09:23PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The const struct ixgbevf_hv_mbx_ops was added in 2016 as part of > commit c6d45171d706 ("ixgbevf: Support Windows hosts (Hyper-V)") > > but has remained unused. > > The functions it reference

Re: [Intel-wired-lan] [RFC net-next 1/3] igc: Remove unused igc_acquire/release_nvm

2025-01-06 Thread Simon Horman
On Thu, Dec 26, 2024 at 04:52:13PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > igc_acquire_nvm() and igc_release_nvm() were added in 2018 as part of > commit ab4056126813 ("igc: Add NVM support") > > but never used. > > Remove them. > > The igc_1225.c has it's own spec

Re: [Intel-wired-lan] [RFC net-next 2/3] igc: Remove unused igc_read/write_pci_cfg wrappers

2025-01-06 Thread Simon Horman
On Thu, Dec 26, 2024 at 04:52:14PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > igc_read_pci_cfg() and igc_write_pci_cfg were added in 2018 as part of > commit 146740f9abc4 ("igc: Add support for PF") > but have remained unused. > > Remove them. > > Signed-off-by: Dr. Da

Re: [Intel-wired-lan] [RFC net-next 3/3] igc: Remove unused igc_read/write_pcie_cap_reg

2025-01-06 Thread Simon Horman
On Thu, Dec 26, 2024 at 04:52:15PM +, li...@treblig.org wrote: > From: "Dr. David Alan Gilbert" > > The last uses of igc_read_pcie_cap_reg() and igc_write_pcie_cap_reg() > were removed in 2019 by > commit 16ecd8d9af26 ("igc: Remove the obsolete workaround") > > Remove them. > > Signed-off-b