Re: [Intel-wired-lan] [PATCH net v1] ice: do not reserve resources for RDMA when disabled

2024-11-15 Thread Przemek Kitszel
On 11/14/24 01:00, jbran...@kernel.org wrote: From: Jesse Brandeburg If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a built-in, then don't let the driver reserve resources for RDMA. Do this by avoiding enabling the capability when scanning hardware capabilities. Fixes: d2

[Intel-wired-lan] [PATCH iwl-net v2] ice: fix PHY timestamp extraction for ETH56G

2024-11-15 Thread Przemyslaw Korba
Fix incorrect PHY timestamp extraction for ETH56G. It's better to use FIELD_PREP() than manual shift. Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products") Reviewed-by: Przemek Kitszel Reviewed-by: Simon Horman Signed-off-by: Przemyslaw Korba --- Changelog v2: remove legal

Re: [Intel-wired-lan] [PATCH net v1] ice: do not reserve resources for RDMA when disabled

2024-11-15 Thread Jesse Brandeburg
On Fri, Nov 15, 2024 at 12:51 AM Przemek Kitszel wrote: > > On 11/14/24 01:00, jbran...@kernel.org wrote: > > From: Jesse Brandeburg > > > > If the CONFIG_INFINIBAND_IRDMA symbol is not enabled as a module or a > > built-in, then don't let the driver reserve resources for RDMA. > > > > Do this by

Re: [Intel-wired-lan] [PATCH net v1] ice: do not reserve resources for RDMA when disabled

2024-11-15 Thread Jesse Brandeburg
On 11/14/24 10:06 AM, Ertman, David M wrote: case ICE_AQC_CAPS_RDMA: - caps->rdma = (number == 1); + if (IS_ENABLED(CONFIG_INFINIBAND_IRDMA)) + caps->rdma = (number == 1); ice_debug(hw, ICE_DBG_INIT, "%s: rdma = %d\n", pref

Re: [Intel-wired-lan] [PATCH iwl-net 04/10] idpf: negotiate PTP capabilies and get PTP clock

2024-11-15 Thread Simon Horman
On Wed, Nov 13, 2024 at 04:46:14PM +0100, Milena Olech wrote: > PTP capabilities are negotiated using virtchnl command. Add get > capabilities function, direct access to read the PTP clock time and > direct access to read the cross timestamp - system time and PTP clock > time. Set initial PTP capab

Re: [Intel-wired-lan] [PATCH iwl-net 01/10] idpf: initial PTP support

2024-11-15 Thread Paul Menzel
Dear Milena, Thank you for your patch. It’d be great if you used a statement for the summary/title by adding a verb (in imperative mood): idpf: Add initial PTP support Am 13.11.24 um 16:46 schrieb Milena Olech: PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the capab

Re: [Intel-wired-lan] [PATCH iwl-net 07/10] idpf: add Tx timestamp capabilities negotiation

2024-11-15 Thread Simon Horman
On Wed, Nov 13, 2024 at 04:46:19PM +0100, Milena Olech wrote: > Tx timestamp capabilities are negotiated for the uplink Vport. > Driver receives information about the number of available Tx timestamp > latches, the size of Tx timestamp value and the set of indexes used > for Tx timestamping. > > A

[Intel-wired-lan] [PATCH v3 1/1] ixgbe: Correct BASE-BX10 compliance code

2024-11-15 Thread Tore Amundsen
SFF-8472 (section 5.4 Transceiver Compliance Codes) defines bit 6 as BASE-BX10. Bit 6 means a value of 0x40 (decimal 64). The current value in the source code is 0x64, which appears to be a mix-up of hex and decimal values. A value of 0x64 (binary 01100100) incorrectly sets bit 2 (1000BASE-CX) and

Re: [Intel-wired-lan] [PATCH iwl-net 01/10] idpf: initial PTP support

2024-11-15 Thread Simon Horman
On Wed, Nov 13, 2024 at 04:46:09PM +0100, Milena Olech wrote: > PTP feature is supported if the VIRTCHNL2_CAP_PTP is negotiated during the > capabilities recognition. Initial PTP support includes PTP initialization > and registration of the clock. > > Reviewed-by: Alexander Lobakin > Signed-off-b

Re: [Intel-wired-lan] [PATCH iwl-net 02/10] virtchnl: add PTP virtchnl definitions

2024-11-15 Thread Simon Horman
On Wed, Nov 13, 2024 at 04:46:11PM +0100, Milena Olech wrote: > PTP capabilities are negotiated using virtchnl commands. There are two > available modes of the PTP support: direct and mailbox. When the direct > access to PTP resources is negotiated, virtchnl messages returns a set > of registers th

Re: [Intel-wired-lan] [PATCH iwl-net 07/10] idpf: add Tx timestamp capabilities negotiation

2024-11-15 Thread Simon Horman
On Thu, Nov 14, 2024 at 03:49:27PM -0500, Willem de Bruijn wrote: > Milena Olech wrote: > > Tx timestamp capabilities are negotiated for the uplink Vport. > > Driver receives information about the number of available Tx timestamp > > latches, the size of Tx timestamp value and the set of indexes us

Re: [Intel-wired-lan] [PATCH iwl-net 01/10] idpf: initial PTP support

2024-11-15 Thread Olech, Milena
On 11/15/2024 2:44 PM, Paul Menzel wrote: > Dear Milena, > > >Thank you for your patch. It’d be great if you used a statement for the >summary/title by adding a verb (in imperative mood): > >idpf: Add initial PTP support > >Am 13.11.24 um 16:46 schrieb Milena Olech: >> PTP feature is supported if

Re: [Intel-wired-lan] [PATCH v2 1/1] ixgbe: Correct BASE-BX10 compliance code

2024-11-15 Thread Erny
On Thu, 2024-11-14 at 19:50 +, Tore Amundsen wrote: > The current value in the source code is 0x64, which appears to be a > mix-up of hex and decimal values. A value of 0x64 (binary 01100100) > incorrectly sets bit 2 (1000BASE-CX) and bit 5 (100BASE-FX) as well. > --- >  drivers/net/ethernet/in

Re: [Intel-wired-lan] [PATCH iwl-next v4444] i40e: add ability to reset VF for Tx and Rx MDD events

2024-11-15 Thread Loktionov, Aleksandr
> -Original Message- > From: Michal Schmidt > Sent: Monday, November 4, 2024 4:41 PM > To: Loktionov, Aleksandr > Cc: intel-wired-...@lists.osuosl.org; Nguyen, Anthony L > ; net...@vger.kernel.org; Sokolowski, > Jan ; Connolly, Padraig J > ; Fijalkowski, Maciej > ; Kitszel, Przemyslaw >

Re: [Intel-wired-lan] [PATCH iwl-net 04/10] idpf: negotiate PTP capabilies and get PTP clock

2024-11-15 Thread Olech, Milena
On 11/14/2024 9:57 PM, Willem de Bruijn wrote: > Vadim Fedorenko wrote: > > > > +/** > > > + * idpf_ptp_read_src_clk_reg_direct - Read directly the main timer value > > > + * @adapter: Driver specific private structure > > > + * @sts: Optional parameter for holding a pair of system timestamps fro

[Intel-wired-lan] [PATCH iwl-next v5] i40e: add ability to reset VF for Tx and Rx MDD events

2024-11-15 Thread Aleksandr Loktionov
Implement "mdd-auto-reset-vf" priv-flag to handle Tx and Rx MDD events for VFs. This flag is also used in other network adapters like ICE. Usage: - "on" - The problematic VF will be automatically reset if a malformed descriptor is detected. - "off" - The problematic VF will be disabled.