Dear Christopher,
Thank you for the patch.
I’d use the more specific summary/title below:
igc: Lengthen hardware retry time to 4 μs to prevent timeouts
Am 06.11.24 um 19:47 schrieb Christopher S M Hall:
Lengthen the hardware retry timer to four microseconds.
The i225/i226 hardware retries i
Hi Paul,
> From: Paul Menzel
> Sent: Wednesday, November 06, 2024 3:14 PM
> Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 2/6] igc: Lengthen the
> hardware retry time to prevent timeouts
>
> Dear Christopher,
>
>
> Thank you for the patch.
>
> I’d use the more specific summary/title belo
From: Jacob Keller
Add a new extended capabilities negotiation to exchange information from
the PF about what PTP capabilities are supported by this VF. This
requires sending a VIRTCHNL_OP_1588_PTP_GET_CAPS message, and waiting
for the response from the PF. Handle this early on during the VF
init
-20241106gcc-14.2.0
arc randconfig-002-20241106gcc-14.2.0
arm allmodconfigclang-20
arm allnoconfiggcc-14.2.0
arm allyesconfigclang-20
arm
On Thu, Oct 31, 2024 at 07:00:07AM +0100, Michal Swiatkowski wrote:
> Implement get and set for the maximum IO event queues for SF.
> It is used to derive the maximum number of Rx/Tx queues on subfunction
> device.
>
> If the value isn't set when activating set it to the low default value.
>
> Re
From: Jacob Keller
Add the iavf_ptp.c file and fill it in with a skeleton framework to
allow registering the PTP clock device.
Add implementation of helper functions to check if a PTP capability
is supported and handle change in PTP capabilities.
Enabling virtual clock would be possible, though i
14.2.0
arcnsim_700_defconfiggcc-14.2.0
arc randconfig-001-20241106gcc-13.2.0
arc randconfig-001-20241106gcc-14.2.0
arc randconfig-002-20241106gcc-13.2.0
arc randconfig-002-20241106gcc-
On 26/10/2024 7:12, Yue Haibing wrote:
igc_xdp_run_prog() converts customed xdp action to a negative error code
with the sk_buff pointer type which be checked with IS_ERR in
igc_clean_rx_irq(). Remove this error pointer handing instead use plain
int return value to fix this smatch warnings:
d
lyesconfigclang-20
arc allyesconfiggcc-13.2.0
arc axs101_defconfiggcc-14.2.0
arc defconfiggcc-14.2.0
archsdk_defconfiggcc-14.1.0
arc randconfig-00
From: Jacob Keller
Support for allowing VF to negotiate the descriptor format requires that
the VF specify which descriptor format to use when requesting Rx queues.
The VF is supposed to request the set of supported formats via the new
VIRTCHNL_OP_GET_SUPPORTED_RXDIDS, and then set one of the sup
From: Jacob Keller
Add support for receive timestamps to the Rx hotpath. This support only
works when using the flexible descriptor format, so make sure that we
request this format by default if we have receive timestamp support
available in the PTP capabilities.
In order to report the timestamp
Initially, during VF creation it registers the PTP clock in
the system and negotiates with PF it's capabilities. In the
meantime the PF enables the Flexible Descriptor for VF.
Only this type of descriptor allows to receive Rx timestamps.
Enabling virtual clock would be possible, though it would pr
From: Jacob Keller
The Rx timestamps reported by hardware may only have 32 bits of storage
for nanosecond time. These timestamps cannot be directly reported to the
Linux stack, as it expects 64bits of time.
To handle this, the timestamps must be extended using an algorithm that
calculates the co
From: Jacob Keller
Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF
driver the ability to determine what Rx descriptor formats are
available. This requires sending an additional message during
initialization and reset, the VIRTCHNL_OP_GET_SUPPORTED_RXDIDS. This
operation requ
On Mon, Nov 04, 2024 at 01:56:20PM +0100, Mateusz Polchlopek wrote:
>
>
> On 11/2/2024 3:38 PM, Simon Horman wrote:
> > On Mon, Oct 28, 2024 at 12:59:22PM -0400, Mateusz Polchlopek wrote:
> > > Fix Flow Director not allowing to re-map traffic to 0th queue when action
> > > is configured to drop (
From: Jacob Keller
Add handlers for the .ndo_hwtstamp_get and .ndo_hwtstamp_set ops which
allow userspace to request timestamp enablement for the device. This
support allows standard Linux applications to request the timestamping
desired.
As with other devices that support timestamping all packe
This patch enables to update a selected component from PLDM image
containing multiple components.
Example usage:
struct pldmfw;
data.mode = PLDMFW_UPDATE_MODE_SINGLE_COMPONENT;
data.compontent_identifier = DRIVER_FW_MGMT_COMPONENT_ID;
Reviewed-by: Jacob Keller
Reviewed-by: Marcin Szycik
Review
Recovery Mode is intended to recover from a fatal failure scenario in
which the device is not accessible to the host, meaning the firmware is
non-responsive.
The purpose of the Firmware Recovery Mode is to enable software tools to
update firmware and/or device configuration so the fatal error can
Add devl guard for scoped_guard().
Example usage:
scoped_guard(devl, priv_to_devlink(pf)) {
err = init_devlink(pf);
if (err)
return err;
}
Co-developed-by: Przemek Kitszel
Signed-off-by: Przemek Kitszel
Signed-off-by: Konrad Knitter
Tested-by: Pucha Himasekhar
Enable update of card in FW Recovery Mode
v2: Update pldmfw commit description
Konrad Knitter (3):
pldmfw: enable selected component update
devlink: add devl guard
ice: support FW Recovery Mode
.../net/ethernet/intel/ice/devlink/devlink.c | 8 ++-
.../net/ethernet/intel/ice/ice_adminq_c
clang-20
arc allnoconfiggcc-14.2.0
arc allyesconfigclang-20
arc axs101_defconfiggcc-14.2.0
arc defconfiggcc-14.2.0
arc randconfig-001-20241106gcc
From: Simei Su
To support Rx timestamp offload, VIRTCHNL_OP_1588_PTP_CAPS is sent by
the VF to request PTP capability and responded by the PF what capability
is enabled for that VF.
Hardware captures timestamps which contain only 32 bits of nominal
nanoseconds, as opposed to the 64bit timestamps
From: Jacob Keller
Using VIRTCHNL_VF_OFFLOAD_FLEX_DESC, the iAVF driver is capable of
negotiating to enable the advanced flexible descriptor layout. Add the
flexible NIC layout (RXDID=2) as a member of the Rx descriptor union.
Also add bit position definitions for the status and error indication
From: Jacob Keller
Implement support for reading the PHC time indirectly via the
VIRTCHNL_OP_1588_PTP_GET_TIME operation.
Based on some simple tests with ftrace, the latency of the indirect
clock access appears to be about ~110 microseconds. This is due to the
cost of preparing a message to send
The union iavf_32byte_rx_desc consists of two unnamed structs defined
inside. One of them represents legacy 32 byte descriptor and second the
16 byte descriptor (extended to 32 byte). Each of them consists of
bunch of unions, structs and __le fields that represent specific fields
in descriptor.
Th
Rx timestamping introduced in PF driver caused the need of refactoring
the VF driver mechanism to check packet fields.
The function to check errors in descriptor has been removed and from
now only previously set struct fields are being checked. The field DD
(descriptor done) needs to be checked at
Structs idpf_rx_csum_decoded and idpf_rx_extracted are used both in
idpf and iavf Intel drivers. Change the prefix from idpf_* to libeth_*
and move mentioned structs to libeth's rx.h header file.
Adjust usage in idpf driver.
Suggested-by: Alexander Lobakin
Tested-by: Rafal Romanowski
Signed-off
From: Jacob Keller
Add support for allowing a VF to enable PTP feature - Rx timestamps
The new capability is gated by VIRTCHNL_VF_CAP_PTP, which must be
set by the VF to request access to the new operations. In addition, the
VIRTCHNL_OP_1588_PTP_CAPS command is used to determine the specific
cap
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue.git 200GbE
branch HEAD: 26a2bebd2c0cb55582501678a182d0ae1a730f2d Merge branch '100GbE' of
git://git.kernel.org/pub/scm/linux/kernel/git/tnguy/net-queue
elapsed time: 1457m
configs tested: 213
configs skipped: 9
The f
On Wed, Nov 06, 2024 at 02:07:55AM +0100, Arkadiusz Kubalewski wrote:
> Currently HW support of ptp/timesync solutions in network PHY chips can be
> implemented with two different approaches, the timestamp maybe latched
> either at the beginning or after the Start of Frame Delimiter (SFD) [1].
>
>
Move ktime_get_snapshot() into the loop. If a retry does occur, a more
recent snapshot will result in a more accurate cross-timestamp.
Fixes: a90ec8483732 ("igc: Add support for PTP getcrosststamp()")
Reviewed-by: Michal Swiatkowski
Tested-by: Mor Bar-Gabay
Tested-by: Avigail Dahan
Signed-off-b
Make sure that the PTP module is cleaned up if the igc_probe() fails by
calling igc_ptp_stop() on exit.
Fixes: d89f88419f99 ("igc: Add skeletal frame for Intel(R) 2.5G Ethernet
Controller support")
Signed-off-by: Christopher S M Hall
---
drivers/net/ethernet/intel/igc/igc_main.c | 1 +
1 file c
There have been sporadic reports of PTM timeouts using i225/i226 devices
These timeouts have been root caused to:
1) Manipulating the PTM status register while PTM is enabled and triggered
2) The hardware retrying too quickly when an inappropriate response is
received from the upstream device
All functions in igc_ptp.c called from igc_main.c should check the
IGC_PTP_ENABLED flag. Adding check for this flag to stop and reset
functions.
Fixes: 5f2958052c58 ("igc: Add basic skeleton for PTP")
Signed-off-by: Christopher S M Hall
---
drivers/net/ethernet/intel/igc/igc_ptp.c | 7 +++
1
Writing to clear the PTM status 'valid' bit while the PTM cycle is
triggered results in unreliable PTM operation. To fix this, clear the
PTM 'trigger' and status after each PTM transaction.
The issue can be reproduced with the following:
$ sudo phc2sys -R 1000 -O 0 -i tsn0 -m
Note: 1000 Hz (-R 1
Add a mutex around the PTM transaction to prevent multiple transactors
Multiple processes try to initiate a PTM transaction, one or all may
fail. This can be reproduced by running two instances of the
following:
$ sudo phc2sys -O 0 -i tsn0 -m
PHC2SYS exits with:
"ioctl PTP_OFFSET_PRECISE: Conne
Lengthen the hardware retry timer to four microseconds.
The i225/i226 hardware retries if it receives an inappropriate response
from the upstream device. If the device retries too quickly, the root
port does not respond.
The issue can be reproduced with the following:
$ sudo phc2sys -R 1000 -O 0
[Cc: +Sasha]
Dear Christopher,
Am 07.11.24 um 00:53 schrieb Hall, Christopher S:
From: Paul Menzel
Sent: Wednesday, November 06, 2024 3:14 PM
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 2/6] igc: Lengthen the
hardware retry time to prevent timeouts
I’d use the more specific summar
[Cc: -Sasha, 550 #5.1.0 Address rejected.]
Am 07.11.24 um 06:48 schrieb Paul Menzel:
[Cc: +Sasha]
Dear Christopher,
Am 07.11.24 um 00:53 schrieb Hall, Christopher S:
From: Paul Menzel
Sent: Wednesday, November 06, 2024 3:14 PM
Subject: Re: [Intel-wired-lan] [PATCH iwl-net v3 2/6] igc: L
Dear Intel Wired Ethernet Linux Kernel driver folks,
It looks like some developers are not working for Intel anymore – like
Sasha Neftin. I assume this is a result of layoffs from the news [1]. Is
this true, or was the team *not* affected by the layoffs, and developers
just moved on by themse
This reverts commit 338c4d3902feb5be49bfda530a72c7ab860e2c9f.
Sebastian noticed the ISR indirectly acquires spin_locks, which are
sleeping locks under PREEMPT_RT, which leads to kernel splats.
Fixes: 338c4d3902feb ("igb: Disable threaded IRQ for igb_msix_other")
Reported-by: Sebastian Andrzej Sie
41 matches
Mail list logo
