>
> E825 products have incorrect initialization procedure, which may lead to
> initialization failures and register values.
>
> Fix E825 products initialization by adding correct sync delay, checking the
> PHY
> revision only for current PHY and adding proper destination device when
> reading
> p
On Mon, Oct 07, 2024 at 11:14:51AM +0200, Kurt Kanzenbach wrote:
> Hi Joe,
>
> On Thu Oct 03 2024, Joe Damato wrote:
> > Link queues to NAPI instances via netdev-genl API so that users can
> > query this information with netlink:
> >
> > $ ./tools/net/ynl/cli.py --spec Documentation/netlink/specs/
Unloading the ice driver while switchdev port representors are added to
a bridge can lead to kernel panic. Reproducer:
modprobe ice
devlink dev eswitch set $PF1_PCI mode switchdev
ip link add $BR type bridge
ip link set $BR up
echo 2 > /sys/class/net/$PF1/device/sriov_numvfs
sleep 2
On Mon, Oct 07, 2024 at 04:03:00PM -0700, Vinicius Costa Gomes wrote:
> Joe Damato writes:
>
> > Greetings:
> >
> > This is an RFC to get feedback before submitting an actual series and
> > because I have a question for igc maintainers, see below.
> >
> > This series addss support for netdev-genl
clang-20
i386 allmodconfiggcc-12
i386 allnoconfiggcc-12
i386 allyesconfiggcc-12
i386buildonly-randconfig-001-20241009clang-18
i386buildonly-randconfig-002-20241009gcc-12
i386
allmodconfigclang-20
arc allnoconfiggcc-14.1.0
arc allyesconfigclang-20
arc defconfiggcc-14.1.0
arc randconfig-001-20241009gcc-14.1.0
arc randconfig-002-20241009
Quad registers are read/written incorrectly. E825 devices always use
quad 0 address and differentiate between the PHYs by changing SBQ
destination device (phy_0 or phy_0_peer).
Add helpers for reading/writing PTP registers shared per quad and use
correct quad address and SBQ destination device bas
Driver always naively assumes, that for PTP purposes, PHY lane to
configure is corresponding to PF ID.
This is not true for some port configurations, e.g.:
- 2x50G per quad, where lanes used are 0 and 2 on each quad, but PF IDs
are 0 and 1
- 100G per quad on 2 quads, where lanes used are 0 and 4
E825 products have incorrect initialization procedure, which may lead to
initialization failures and register values.
Fix E825 products initialization by adding correct sync delay, checking the
PHY
revision only for current PHY and adding proper destination device when
reading
port/quad.
In addit
Current implementation checks revision of all PHYs on all PFs, which is
incorrect and may result in initialization failure. Check only the
revision of the current PHY.
Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products")
Reviewed-by: Arkadiusz Kubalewski
Signed-off-by: Karol
Fix ETH56G FC-FEC incorrect Rx offset value by changing it from -255.96
to -469.26 ns.
Those values are derived from HW spec and reflect internal delays.
Hex value is a fixed point representation in Q23.9 format.
Fixes: 7cab44f1c35f ("ice: Introduce ETH56G PHY model for E825C products")
Reviewed-
On 09.10.2024 15:12, Paul Menzel wrote:
> Dear Marcin,
>
>
> Thank you for the patch, and the reproducer and detailed commit message.
>
> Am 09.10.24 um 14:49 schrieb Marcin Szycik:
>> Unloading the ice driver while switchdev port representors are added to
>> a bridge can lead to kernel panic
hexagon defconfiggcc-14.1.0
i386 allmodconfigclang-18
i386 allnoconfigclang-18
i386 allyesconfigclang-18
i386buildonly-randconfig-001-20241009clang-18
i386
defconfiggcc-14.1.0
i386 allmodconfigclang-18
i386 allnoconfigclang-18
i386 allyesconfigclang-18
i386buildonly-randconfig-001-20241009clang-18
i386
From: Intel-wired-lan on behalf of Przemek
Kitszel
Sent: Monday, September 23, 2024 11:07 AM
To: Wander Lairson Costa
Cc: Yuying Ma ; moderated list:INTEL ETHERNET DRIVERS
; open list ;
Eric Dumazet ; Nguyen, Anthony L
; open list:NETWORKING DRIVERS
; Jakub Kicinski ; Paolo Abeni
; David S
On Thu, Oct 3, 2024 at 11:26 AM Arkadiusz Kubalewski
wrote:
>
> The E810 Lan On Motherboard (LOM) design is vendor specific. Intel
> provides the reference design, but it is up to vendor on the final
> product design. For some cases, like Linux DPLL support, the static
> values defined in the driv
Unloading the ice driver while switchdev port representors are added to
a bridge can lead to kernel panic. Reproducer:
modprobe ice
devlink dev eswitch set $PF1_PCI mode switchdev
ip link add $BR type bridge
ip link set $BR up
echo 2 > /sys/class/net/$PF1/device/sriov_numvfs
sleep 2
Both NL operations directly map on the homonymous device shaper
callbacks, update accordingly the shapers cache and are serialized
via a per device lock.
Implement the cache modification helpers to additionally deal with
NODE scope shaper. That will be needed by the group() operation
implemented in
Introduce the basic infrastructure to implement the net-shaper
core functionality. Each network devices carries a net-shaper cache,
the NL get() operation fetches the data from such cache.
The cache is initially empty, will be fill by the set()/group()
operation implemented later and is destroyed
Allow grouping multiple leaves shaper under the given root.
The node and the leaves shapers are created, if needed, otherwise
the existing shapers are re-linked as requested.
Try hard to pre-allocated the needed resources, to avoid non
trivial H/W configuration rollbacks in case of any failure.
R
Define the user-space visible interface to query, configure and delete
network shapers via yaml definition.
Add dummy implementations for the relevant NL callbacks.
set() and delete() operations touch a single shaper creating/updating or
deleting it.
The group() operation creates a shaper's group
We have a plurality of shaping-related drivers API, but none flexible
enough to meet existing demand from vendors[1].
This series introduces new device APIs to configure in a flexible way
TX H/W shaping. The new functionalities are exposed via a newly
defined generic netlink interface and include
This allows a more uniform implementation of non-dump and dump
operations, and will be used later in the series to avoid some
per-operation allocation.
Additionally rename the NL_ASSERT_DUMP_CTX_FITS macro, to
fit a more extended usage.
Suggested-by: Jakub Kicinski
Reviewed-by: Jakub Kicinski
R
The netlink op is a simple wrapper around the device callback.
Extend the existing fetch_dev() helper adding an attribute argument
for the requested device. Reuse such helper in the newly implemented
operation.
Reviewed-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
Signed-off-by: Paolo Abeni
---
Leverage a basic/dummy netdevsim implementation to do functional
coverage for NL interface.
Reviewed-by: Jiri Pirko
Signed-off-by: Paolo Abeni
---
v7 -> v8:
- fix nested node probing
- reset the configuration after the queue_update test-case
v5 -> v6:
- additional test-cases for delegatio
From: Wenjun Wu
Add support to configure VF queue rate limit and quanta size.
For quanta size configuration, the quanta profiles are divided evenly
by PF numbers. For each port, the first quanta profile is reserved for
default. When VF is asked to set queue quanta size, PF will search for
an ava
From: Sudheer Mogilappagari
Implement net_shaper_ops support for IAVF. This enables configuration
of rate limiting on per queue basis. Customer intends to enforce
bandwidth limit on Tx traffic steered to the queue by configuring
rate limits on the queue.
To set rate limiting for a queue, update
From: Sudheer Mogilappagari
During driver initialization VF determines QOS capability is allowed
by PF and receives QOS parameters. After which quanta size for queues
is configured which is not configurable and is set to 1KB currently.
Reviewed-by: Jiri Pirko
Signed-off-by: Sudheer Mogilappagar
Leverage the previously introduced group operation to implement
the removal of NODE scope shaper, re-linking its leaves under the
the parent node before actually deleting the specified NODE scope
shaper.
Reviewed-by: Jiri Pirko
Signed-off-by: Paolo Abeni
---
v4 -> v5:
- replace net_device* with
Allow the user-space to fine-grain query the shaping features
supported by the NIC on each domain.
Reviewed-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
Signed-off-by: Paolo Abeni
---
v5 -> v6:
- shorter cap-related names
v4 -> v5:
- added pre/post helpers for dump op
---
Documentation/netlin
Use the device capabilities to reject invalid attribute values before
pushing them to the H/W.
Note that validating the metric explicitly avoids NL_SET_BAD_ATTR()
usage, to provide unambiguous error messages to the user.
Validating the nesting requires the knowledge of the new parent for
the give
From: Wenjun Wu
This patch adds new virtchnl opcodes and structures for rate limit
and quanta size configuration, which include:
1. VIRTCHNL_OP_CONFIG_QUEUE_BW, to configure max bandwidth for each
VF per queue.
2. VIRTCHNL_OP_CONFIG_QUANTA, to configure quanta size per queue.
3. VIRTCHNL_OP_GET_Q
hook into netif_set_real_num_tx_queues() to cleanup any shaper
configured on top of the to-be-destroyed TX queues.
Reviewed-by: Jiri Pirko
Reviewed-by: Jakub Kicinski
Signed-off-by: Paolo Abeni
---
v6 -> v7:
- don't touch the H/W for the queue shaper, the driver
is supposed to reset clean i
Dear Marcin,
Thank you for the patch, and the reproducer and detailed commit message.
Am 09.10.24 um 14:49 schrieb Marcin Szycik:
Unloading the ice driver while switchdev port representors are added to
a bridge can lead to kernel panic. Reproducer:
modprobe ice
devlink dev eswitch set
>From: Michal Schmidt
>Sent: Wednesday, October 9, 2024 12:21 PM
>
>On Thu, Oct 3, 2024 at 11:26 AM Arkadiusz Kubalewski
> wrote:
>>
>> The E810 Lan On Motherboard (LOM) design is vendor specific. Intel
>> provides the reference design, but it is up to vendor on the final
>> product design. For so
On 08 October 2024 13:46, Paul Menzel wrote:
> Am 08.10.24 um 13:05 schrieb Karol Kolacinski:
>> HW can have different input/output delays for each of the pins.
>> Add a field in ice_ptp_pin_desc structure to reflect that.
>
> What is the current status, that means before your patch?
Only E82X ada
tree/branch:
https://git.kernel.org/pub/scm/linux/kernel/git/tnguy/next-queue.git 100GbE
branch HEAD: 8f7ff18a5ec7d8ce47ff84a9d1b024bfb6039dd8 e1000: Link NAPI
instances to queues and IRQs
elapsed time: 1769m
configs tested: 116
configs skipped: 2
The following configs have been built success
37 matches
Mail list logo
