Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-27 Thread Yunsheng Lin
adding Sumit & Christian & dma-buf maillist On 2024/9/27 13:54, Mina Almasry wrote: > On Thu, Sep 26, 2024 at 8:58 PM Yunsheng Lin wrote: >> >> On 2024/9/27 2:15, Mina Almasry wrote: >>> In order not to do the dma unmmapping after driver has already unbound and stall the unloading of th

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-27 Thread Yunsheng Lin
On 2024/9/27 17:58, Ilias Apalodimas wrote: ... >> >>> importantly, though, why does struct page need to know about this? >>> Can't we have the same information in page pool? >>> When the driver allocates pages it does via page_pool_dev_alloc_X >>> or something similar. Cant we do what you su

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-27 Thread Ilias Apalodimas
Hi Yunsheng On Fri, 27 Sept 2024 at 06:58, Yunsheng Lin wrote: > > On 2024/9/27 2:15, Mina Almasry wrote: > > > >> In order not to do the dma unmmapping after driver has already > >> unbound and stall the unloading of the networking driver, add > >> the pool->items array to record all the pages i

Re: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: consistently use q_idx in ice_vc_cfg_qs_msg()

2024-09-27 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Tuesday, September 10, 2024 1:08 AM > To: Intel Wired LAN ; Nguyen, Anthony L > > Cc: Keller, Jacob E ; Kitszel, Przemyslaw > > Subject: [Intel-wired-lan] [PATCH iwl-next 1/2] ice: consistently use q_idx in

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-27 Thread Ilias Apalodimas
On Fri, 27 Sept 2024 at 12:50, Yunsheng Lin wrote: > > On 2024/9/27 17:21, Ilias Apalodimas wrote: > > Hi Yunsheng > > > > On Fri, 27 Sept 2024 at 06:58, Yunsheng Lin wrote: > >> > >> On 2024/9/27 2:15, Mina Almasry wrote: > >>> > In order not to do the dma unmmapping after driver has alread

Re: [Intel-wired-lan] [PATCH net v2 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-27 Thread Yunsheng Lin
On 2024/9/27 17:21, Ilias Apalodimas wrote: > Hi Yunsheng > > On Fri, 27 Sept 2024 at 06:58, Yunsheng Lin wrote: >> >> On 2024/9/27 2:15, Mina Almasry wrote: >>> In order not to do the dma unmmapping after driver has already unbound and stall the unloading of the networking driver, add

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-27 Thread Toke Høiland-Jørgensen
"Arthur Fabre" writes: >> >> The nice thing about an API like this, though, is that it's extensible, >> >> and the kernel itself can be just another consumer of it for the >> >> metadata fields Lorenzo is adding in this series. I.e., we could just >> >> pre-define some IDs for metadata vlan, time

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-27 Thread Arthur Fabre
On Fri Sep 27, 2024 at 12:24 PM CEST, Toke Høiland-Jørgensen wrote: > "Arthur Fabre" writes: > > >> >> The nice thing about an API like this, though, is that it's extensible, > >> >> and the kernel itself can be just another consumer of it for the > >> >> metadata fields Lorenzo is adding in this

Re: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: store max_frame and rx_buf_len only in ice_rx_ring

2024-09-27 Thread Romanowski, Rafal
> -Original Message- > From: Intel-wired-lan On Behalf Of Jacob > Keller > Sent: Tuesday, September 10, 2024 1:08 AM > To: Intel Wired LAN ; Nguyen, Anthony L > > Cc: Keller, Jacob E ; Kitszel, Przemyslaw > > Subject: [Intel-wired-lan] [PATCH iwl-next 2/2] ice: store max_frame and > rx_b

Re: [Intel-wired-lan] [RFC bpf-next 0/4] Add XDP rx hw hints support performing XDP_REDIRECT

2024-09-27 Thread Lorenzo Bianconi
On Sep 27, Arthur Fabre wrote: > On Fri Sep 27, 2024 at 12:24 PM CEST, Toke Høiland-Jørgensen wrote: > > "Arthur Fabre" writes: > > > > >> >> The nice thing about an API like this, though, is that it's > > >> >> extensible, > > >> >> and the kernel itself can be just another consumer of it for th

[Intel-wired-lan] [PATCH iwl-net] ice: Fix increasing MSI-X on VF

2024-09-27 Thread Marcin Szycik
Increasing MSI-X value on a VF leads to invalid memory operations. This is caused by not reallocating some arrays. Reproducer: modprobe ice echo 0 > /sys/bus/pci/devices/$PF_PCI/sriov_drivers_autoprobe echo 1 > /sys/bus/pci/devices/$PF_PCI/sriov_numvfs echo 17 > /sys/bus/pci/devices/$VF0_P

[Intel-wired-lan] [PATCH iwl-net v2] ice: Flush FDB entries before reset

2024-09-27 Thread Wojciech Drewek
Triggering the reset while in switchdev mode causes errors[1]. Rules are already removed by this time because switch content is flushed in case of the reset. This means that rules were deleted from HW but SW still thinks they exist so when we get SWITCHDEV_FDB_DEL_TO_DEVICE notification we try to d