Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] ice: Fix entering Safe Mode

2024-09-23 Thread Marcin Szycik
On 20.09.2024 19:14, Brett Creeley wrote: > > > On 9/20/2024 9:59 AM, Marcin Szycik wrote: >> Caution: This message originated from an External Source. Use proper caution >> when opening attachments, clicking links, or responding. >> >> >> If DDP package is missing or corrupted, the driver sh

[Intel-wired-lan] [PATCH iwl-net v1] i40e: Fix macvlan leak by synchronizing access to mac_filter_hash

2024-09-23 Thread Aleksandr Loktionov
This patch addresses a macvlan leak issue in the i40e driver caused by concurrent access to vsi->mac_filter_hash. The leak occurs when multiple threads attempt to modify the mac_filter_hash simultaneously, leading to inconsistent state and potential memory leaks. To fix this, we now wrap the calls

Re: [Intel-wired-lan] [PATCH] ice: Unbind the workqueue

2024-09-23 Thread Przemek Kitszel
On 9/23/24 00:24, Frederic Weisbecker wrote: The ice workqueue doesn't seem to rely on any CPU locality and should therefore be able to run on any CPU. In practice this is already happening through the unbound ice_service_timer that may fire anywhere and queue the workqueue accordingly to any CPU

Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

2024-09-23 Thread Przemek Kitszel
On 9/21/24 14:52, Paul Menzel wrote: Dear Wander, Thank you for your patch. Am 20.09.24 um 20:59 schrieb Wander Lairson Costa: tx_queue_lock and stats_lock are declared and initialized, but never used. Remove them. Signed-off-by: Wander Lairson Costa It’d be great if you added a Fixes: ta

Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

2024-09-23 Thread Wander Lairson Costa
On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel wrote: > > On 9/21/24 14:52, Paul Menzel wrote: > > Dear Wander, > > > > > > Thank you for your patch. > > > > Am 20.09.24 um 20:59 schrieb Wander Lairson Costa: > >> tx_queue_lock and stats_lock are declared and initialized, but never > >> used. Rem

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-23 Thread Jason Gunthorpe
On Fri, Sep 20, 2024 at 02:14:02PM +0800, Yunsheng Lin wrote: > I am not sure what dose the API that allows netdev to "give" struct device > to page_pool look like or how to implement the API yet, but the obvious way > to stall the calling of device_del() is to wait for the inflight > page to It

Re: [Intel-wired-lan] ice: Use common error handling code in two functions

2024-09-23 Thread Tony Nguyen
On 9/20/2024 12:05 AM, Markus Elfring wrote: Add jump targets so that a bit of exception handling can be better reused at the end of two function implementations. Thank you for contribution, the change is fine, Thanks for this positive feedback.

Re: [Intel-wired-lan] [PATCH] ice: Unbind the workqueue

2024-09-23 Thread Tony Nguyen
On 9/23/2024 1:57 AM, Przemek Kitszel wrote: On 9/23/24 00:24, Frederic Weisbecker wrote: The ice workqueue doesn't seem to rely on any CPU locality and should therefore be able to run on any CPU. In practice this is already happening through the unbound ice_service_timer that may fire anywhe

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-23 Thread Yunsheng Lin
On 2024/9/19 18:54, Yunsheng Lin wrote: > On 2024/9/19 1:06, Ilias Apalodimas wrote: >> Hi Yunsheng, >> >> Thanks for looking into this! >> >> On Wed, 18 Sept 2024 at 14:24, Yunsheng Lin wrote: >>> >>> Networking driver with page_pool support may hand over page >>> still with dma mapping to networ

Re: [Intel-wired-lan] [PATCH 1/2] igb: Disable threaded IRQ for igb_msix_other

2024-09-23 Thread Przemek Kitszel
On 9/20/24 20:59, Wander Lairson Costa wrote: During testing of SR-IOV, Red Hat QE encountered an issue where the ip link up command intermittently fails for the igbvf interfaces when using the PREEMPT_RT variant. Investigation revealed that e1000_write_posted_mbx returns an error due to the lack

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-23 Thread Jacob Keller
On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: > Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") > changed igb_io_error_detected() to ignore non-fatal pcie errors in order > to avoid hung task that can happen when igb_down() is called multiple > times. This caused an issue whe

Re: [Intel-wired-lan] [PATCH] igb: Do not bring the device up after non-fatal error

2024-09-23 Thread Jacob Keller
On 9/23/2024 4:11 PM, Jacob Keller wrote: > > > On 9/23/2024 2:22 PM, Mohamed Khalfella wrote: >> Commit 004d25060c78 ("igb: Fix igb_down hung on surprise removal") >> changed igb_io_error_detected() to ignore non-fatal pcie errors in order >> to avoid hung task that can happen when igb_down()

Re: [Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

2024-09-23 Thread Tony Nguyen
On 9/23/2024 9:46 AM, Wander Lairson Costa wrote: On Mon, Sep 23, 2024 at 6:04 AM Przemek Kitszel wrote: On 9/21/24 14:52, Paul Menzel wrote: Dear Wander, Thank you for your patch. Am 20.09.24 um 20:59 schrieb Wander Lairson Costa: tx_queue_lock and stats_lock are declared and initiali

Re: [Intel-wired-lan] [PATCH iwl-net v1] i40e: Fix macvlan leak by synchronizing access to mac_filter_hash

2024-09-23 Thread Simon Horman
On Mon, Sep 23, 2024 at 11:12:19AM +0200, Aleksandr Loktionov wrote: > This patch addresses a macvlan leak issue in the i40e driver caused by > concurrent access to vsi->mac_filter_hash. The leak occurs when multiple > threads attempt to modify the mac_filter_hash simultaneously, leading to > incon

Re: [Intel-wired-lan] [PATCH net 2/2] page_pool: fix IOMMU crash when driver has already unbound

2024-09-23 Thread Ilias Apalodimas
Hi Jason, On Mon, 23 Sept 2024 at 20:52, Jason Gunthorpe wrote: > > On Fri, Sep 20, 2024 at 02:14:02PM +0800, Yunsheng Lin wrote: > > > I am not sure what dose the API that allows netdev to "give" struct device > > to page_pool look like or how to implement the API yet, but the obvious way > > to