Re: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Marcin Szycik
On 20.09.2024 14:03, Maciej Fijalkowski wrote: > On Fri, Sep 20, 2024 at 01:55:09PM +0200, Marcin Szycik wrote: >> If DDP package is missing or corrupted, the driver should enter Safe Mode. >> Instead, an error is returned and probe fails. >> >> Don't check return value of ice_init_ddp_config()

Re: [Intel-wired-lan] ice: Use common error handling code in two functions

2024-09-20 Thread Markus Elfring
>> Add jump targets so that a bit of exception handling can be better reused >> at the end of two function implementations. > > Thank you for contribution, the change is fine, Thanks for this positive feedback. > but not as a bugfix. Would you lik

[Intel-wired-lan] [PATCH iwl-net 2/2] ice: Fix netif_is_ice() in Safe Mode

2024-09-20 Thread Marcin Szycik
netif_is_ice() works by checking the pointer to netdev ops. However, it only checks for the default ice_netdev_ops, not ice_netdev_safe_mode_ops, so in Safe Mode it always returns false, which is unintuitive. While it doesn't look like netif_is_ice() is currently being called anywhere in Safe Mode,

[Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Marcin Szycik
If DDP package is missing or corrupted, the driver should enter Safe Mode. Instead, an error is returned and probe fails. Don't check return value of ice_init_ddp_config() to fix this. Repro: * Remove or rename DDP package (/lib/firmware/intel/ice/ddp/ice.pkg) * Load ice Fixes: cc5776fe1832 ("ic

Re: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Maciej Fijalkowski
On Fri, Sep 20, 2024 at 01:55:09PM +0200, Marcin Szycik wrote: > If DDP package is missing or corrupted, the driver should enter Safe Mode. > Instead, an error is returned and probe fails. > > Don't check return value of ice_init_ddp_config() to fix this. no one else checks the retval after your

[Intel-wired-lan] [PATCH iwl-net v2 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Marcin Szycik
If DDP package is missing or corrupted, the driver should enter Safe Mode. Instead, an error is returned and probe fails. Don't check return value of ice_init_ddp_config() to fix this. Change ice_init_ddp_config() type to void, as now its return is never checked. Repro: * Remove or rename DDP pa

[Intel-wired-lan] [PATCH iwl-net v2 2/2] ice: Fix netif_is_ice() in Safe Mode

2024-09-20 Thread Marcin Szycik
netif_is_ice() works by checking the pointer to netdev ops. However, it only checks for the default ice_netdev_ops, not ice_netdev_safe_mode_ops, so in Safe Mode it always returns false, which is unintuitive. While it doesn't look like netif_is_ice() is currently being called anywhere in Safe Mode,

Re: [Intel-wired-lan] [PATCH iwl-net 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Brett Creeley
On 9/20/2024 5:03 AM, Maciej Fijalkowski wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. On Fri, Sep 20, 2024 at 01:55:09PM +0200, Marcin Szycik wrote: If DDP package is missing or corrupted, the d

Re: [Intel-wired-lan] [PATCH iwl-net v2 1/2] ice: Fix entering Safe Mode

2024-09-20 Thread Brett Creeley
On 9/20/2024 9:59 AM, Marcin Szycik wrote: Caution: This message originated from an External Source. Use proper caution when opening attachments, clicking links, or responding. If DDP package is missing or corrupted, the driver should enter Safe Mode. Instead, an error is returned and probe

[Intel-wired-lan] [PATCH 0/2] Fixes in igbvf driver

2024-09-20 Thread Wander Lairson Costa
The first patch fixes a bug manifested manifested in the igbvf driver when interrupting handling for the igb driver delays. The second is just a cleanup for igbvf. Wander Lairson Costa (2): igb: Disable threaded IRQ for igb_msix_other igbvf: remove unused spinlock drivers/net/ethernet/intel

[Intel-wired-lan] [PATCH 2/2] igbvf: remove unused spinlock

2024-09-20 Thread Wander Lairson Costa
tx_queue_lock and stats_lock are declared and initialized, but never used. Remove them. Signed-off-by: Wander Lairson Costa --- drivers/net/ethernet/intel/igbvf/igbvf.h | 3 --- drivers/net/ethernet/intel/igbvf/netdev.c | 3 --- 2 files changed, 6 deletions(-) diff --git a/drivers/net/ethernet

[Intel-wired-lan] [PATCH 1/2] igb: Disable threaded IRQ for igb_msix_other

2024-09-20 Thread Wander Lairson Costa
During testing of SR-IOV, Red Hat QE encountered an issue where the ip link up command intermittently fails for the igbvf interfaces when using the PREEMPT_RT variant. Investigation revealed that e1000_write_posted_mbx returns an error due to the lack of an ACK from e1000_poll_for_ack. The underly