Re: [Intel-wired-lan] [PATCH net-next] idpf: Slightly simplify memory management in idpf_add_del_mac_filters()

2024-08-26 Thread Przemek Kitszel
On 8/23/24 11:10, Dan Carpenter wrote: On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote: In idpf_add_del_mac_filters(), filters are chunked up into multiple messages to avoid sending a control queue message buffer that is too large. Each chunk has up to IDPF_NUM_FILTERS_PER_MS

Re: [Intel-wired-lan] [iwl-next v1 1/1] igc: Move the MULTI GBT AN Control Register to _regs file

2024-08-26 Thread Dahan, AvigailX
On 8/18/2024 11:32 AM, Sasha Neftin wrote: MULTI GBT AN Control Register is IEEE Standard Register 7.32 (not a mask). The right place should be in igc_reg.h file. In accordance with the registers naming convention added IGC_' prefix. Signed-off-by: Sasha Neftin Reviewed-by: Paul Menzel --- d

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct >allocated. So before accessing pf->lag a NULL pointer check is needed. > >Signed-off-by: Thomas Bogendoerfer You need to add a "fixes" tag blaming the commit tha

Re: [Intel-wired-lan] [PATCH iwl-next v10 04/14] iavf: add support for negotiating flexible RXDID format

2024-08-26 Thread Wojciech Drewek
On 21.08.2024 15:52, Alexander Lobakin wrote: > From: Wojciech Drewek > Date: Wed, 21 Aug 2024 14:15:29 +0200 > >> From: Jacob Keller >> >> Enable support for VIRTCHNL_VF_OFFLOAD_RX_FLEX_DESC, to enable the VF >> driver the ability to determine what Rx descriptor formats are >> available. Thi

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Jiri Pirko
Mon, Aug 26, 2024 at 12:17:10PM CEST, tbogendoer...@suse.de wrote: >On Mon, 26 Aug 2024 11:41:19 +0200 >Jiri Pirko wrote: > >> Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: >> >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct >> >allocated. So before accessin

Re: [Intel-wired-lan] [PATCH iwl-next v10 05/14] iavf: negotiate PTP capabilities

2024-08-26 Thread Wojciech Drewek
On 21.08.2024 16:06, Alexander Lobakin wrote: > From: Wojciech Drewek > Date: Wed, 21 Aug 2024 14:15:30 +0200 > >> From: Jacob Keller >> >> Add a new extended capabilities negotiation to exchange information from >> the PF about what PTP capabilities are supported by this VF. This >> requires

[Intel-wired-lan] [bug report]iavf: deadlock on detach/attach vf to VM with net_failover

2024-08-26 Thread Faicker Mo
Hello, we met a problem with iavf driver, the ubuntu22.04 kernel 5.15.0-119 and 6.11rc4 both have the same problem. When the X710 VF is detached and attached to the VM with net_failover, the kworker thread in VM hang. The backtrace is, [<0>] iavf_open+0x48/0x230 [iavf] [<0>] __dev_open+0xe5/0x1c

[Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Thomas Bogendoerfer
For PFs, which don't support SRIOV_LAG, there is no pf->lag struct allocated. So before accessing pf->lag a NULL pointer check is needed. Signed-off-by: Thomas Bogendoerfer --- drivers/net/ethernet/intel/ice/ice_lag.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/ne

Re: [Intel-wired-lan] [PATCH net] ice: Fix NULL pointer access, if PF doesn't support SRIOV_LAG

2024-08-26 Thread Thomas Bogendoerfer
On Mon, 26 Aug 2024 11:41:19 +0200 Jiri Pirko wrote: > Mon, Aug 26, 2024 at 10:58:30AM CEST, tbogendoer...@suse.de wrote: > >For PFs, which don't support SRIOV_LAG, there is no pf->lag struct > >allocated. So before accessing pf->lag a NULL pointer check is needed. > > > >Signed-off-by: Thomas Bo

Re: [Intel-wired-lan] [PATCH net-next] idpf: Slightly simplify memory management in idpf_add_del_mac_filters()

2024-08-26 Thread Christophe JAILLET
Le 26/08/2024 à 11:15, Przemek Kitszel a écrit : On 8/23/24 11:10, Dan Carpenter wrote: On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote: In idpf_add_del_mac_filters(), filters are chunked up into multiple messages to avoid sending a control queue message buffer that is too l

Re: [Intel-wired-lan] [PATCH iwl-net v5] ice: Add netif_device_attach/detach into PF reset flow

2024-08-26 Thread Michal Schmidt
On Wed, Aug 21, 2024 at 6:07 PM Dawid Osuchowski wrote: > > Ethtool callbacks can be executed while reset is in progress and try to > access deleted resources, e.g. getting coalesce settings can result in a > NULL pointer dereference seen below. > > Reproduction steps: > Once the driver is fully i

[Intel-wired-lan] [PATCH iwl-next v1] ice: Add E830 checksum support

2024-08-26 Thread Paul Greenwalt
E830 supports generic receive and HW_CSUM transmit checksumming. Generic receive checksum support is provided by hardware calculating the checksum over the whole packet and providing it to the driver in the Rx flex descriptor. Then the driver assigns the checksum to skb-->csum and sets skb->ip_sum

[Intel-wired-lan] [[PATCH v2 iwl-next] v2 1/4] idpf: address an rtnl lock splat in tx timeout recovery path

2024-08-26 Thread Manoj Vishwanathan
From: David Decotigny Adopt the same pattern as in other places in the code to take the rtnl lock during hard resets. Tested the patch by injecting tx timeout in IDPF , observe that idpf recovers and IDPF comes back reachable Without this patch causes there is a splat: [ 270.145214] WARNING: CP

[Intel-wired-lan] [[PATCH v2 iwl-next] v2 0/4]

2024-08-26 Thread Manoj Vishwanathan
IDPF Virtchnl: Enhance error reporting & fix locking/workqueue issues This patch series addresses several IDPF virtchnl issues: * Improved error reporting for better diagnostics. * Fixed locking sequence in virtchnl message handling to avoid potential race conditions. * Converted idpf workqueues

[Intel-wired-lan] [[PATCH v2 iwl-next] v2 4/4] idpf: add more info during virtchnl transaction time out

2024-08-26 Thread Manoj Vishwanathan
Add more information related to the transaction like cookie, vc_op, salt when transaction times out and include similar information when transaction salt does not match. Info output for transaction timeout: --- (op:5015 cookie:45fe vc_op:5015 salt:45 timeout:6ms) --

[Intel-wired-lan] [[PATCH v2 iwl-next] v2 3/4] idpf: convert workqueues to unbound

2024-08-26 Thread Manoj Vishwanathan
From: Marco Leogrande When a workqueue is created with `WQ_UNBOUND`, its work items are served by special worker-pools, whose host workers are not bound to any specific CPU. In the default configuration (i.e. when `queue_delayed_work` and friends do not specify which CPU to run the work item on),

[Intel-wired-lan] [[PATCH v2 iwl-next] v2 2/4] idpf: Acquire the lock before accessing the xn->salt

2024-08-26 Thread Manoj Vishwanathan
The transaction salt was being accessed before acquiring the idpf_vc_xn_lock when idpf has to forward the virtchnl reply. Fixes: 34c21fa894a1a (“idpf: implement virtchnl transaction manager”) Signed-off-by: Manoj Vishwanathan --- drivers/net/ethernet/intel/idpf/idpf_virtchnl.c | 3 ++- 1 file ch

Re: [Intel-wired-lan] [PATCH net-next v3 0/2] Add Embedded SYNC feature for a dpll's pin

2024-08-26 Thread patchwork-bot+netdevbpf
Hello: This series was applied to netdev/net-next.git (main) by Jakub Kicinski : On Fri, 23 Aug 2024 00:25:11 +0200 you wrote: > Introduce and allow DPLL subsystem users to get/set capabilities of > Embedded SYNC on a dpll's pin. > > Signed-off-by: Arkadiusz Kubalewski > > Arkadiusz Kubalewski

Re: [Intel-wired-lan] [PATCH net-next] idpf: Slightly simplify memory management in idpf_add_del_mac_filters()

2024-08-26 Thread Przemek Kitszel
On 8/26/24 19:14, Christophe JAILLET wrote: Le 26/08/2024 à 11:15, Przemek Kitszel a écrit : On 8/23/24 11:10, Dan Carpenter wrote: On Fri, Aug 23, 2024 at 08:23:29AM +0200, Christophe JAILLET wrote: It would be even nicer to move the ma_list allocation outside the loop: buf_size =